Re: [Buildroot] [PATCH 1/1] package/network-manager: bump to version 1.32.12

[James Hilliard <james.hilliard1@gmail.com>]

On Sat, Dec 4, 2021 at 1:33 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello James,
>
> On Wed,  1 Dec 2021 02:37:27 -0700
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> > Migrate autotools build system to meson.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>
> Why is the migration to meson tied to the version bump? The current
> version of network-manager packaged in Buildroot, 1.32.2, already has
> the meson build infrastructure. So really the bump to 1.32.12 has
> nothing to do with the meson migration it seems.

I had just tested them at the same time, I can do a separate bump first.

>
>
> >  NETWORK_MANAGER_VERSION_MAJOR = 1.32
> > -NETWORK_MANAGER_VERSION = $(NETWORK_MANAGER_VERSION_MAJOR).2
> > +NETWORK_MANAGER_VERSION = $(NETWORK_MANAGER_VERSION_MAJOR).12
> >  NETWORK_MANAGER_SOURCE = NetworkManager-$(NETWORK_MANAGER_VERSION).tar.xz
> >  NETWORK_MANAGER_SITE = https://download.gnome.org/sources/NetworkManager/$(NETWORK_MANAGER_VERSION_MAJOR)
> >  NETWORK_MANAGER_INSTALL_STAGING = YES
> > -NETWORK_MANAGER_DEPENDENCIES = host-pkgconf udev gnutls libglib2 \
> > +NETWORK_MANAGER_DEPENDENCIES = host-pkgconf udev dbus gnutls libglib2 \
>
> Why is dbus now a build-time dependency?

Due to the meson build system requiring the dbus pkg-config files.

>
> >  NETWORK_MANAGER_CONF_OPTS = \
> > -     --disable-introspection \
> > -     --disable-tests \
> > -     --disable-qt \
> > -     --disable-more-warnings \
> > -     --with-crypto=gnutls \
> > -     --with-iptables=/usr/sbin/iptables \
> > -     --disable-ifupdown \
> > -     --without-nm-cloud-setup
> > +     -Ddocs=false \
> > +     -Dtests=no \
>
> Sometimes "false", sometimes "no", is this logical?

Probably not...but that's what upstream requires here...

>
> > +ifeq ($(BR2_PACKAGE_IWD),y)
> > +NETWORK_MANAGER_DEPENDENCIES += iwd
> > +NETWORK_MANAGER_CONF_OPTS += -Diwd=true
> > +else
> > +NETWORK_MANAGER_CONF_OPTS += -Diwd=false
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_AUDIT),y)
> > +NETWORK_MANAGER_DEPENDENCIES += audit
> > +NETWORK_MANAGER_CONF_OPTS += -Dlibaudit=yes
> > +else
> > +NETWORK_MANAGER_CONF_OPTS += -Dlibaudit=no
>
> Ditto. Is there a reason why it's sometimes yes/no and sometimes
> true/false?

Upstream is rather inconsistent with the option names.

>
>
> > +ifeq ($(BR2_PACKAGE_POLKIT),y)
> > +NETWORK_MANAGER_DEPENDENCIES += polkit
> > +NETWORK_MANAGER_CONF_OPTS += -Dpolkit=true
> > +else
> > +NETWORK_MANAGER_CONF_OPTS += -Dpolkit=false
> > +endif
>
> Is the polkit optional dependency new in 1.32.12 ? If not, it should be
> a separate commit.

I don't think it's new but setting this was required due to meson
being stricter.

>
> > +ifeq ($(BR2_PACKAGE_SYSTEMD),y)
> > +NETWORK_MANAGER_DEPENDENCIES += systemd
> > +NETWORK_MANAGER_CONF_OPTS += \
> > +     -Dsystemd_journal=true \
> > +     -Dconfig_logging_backend_default=journal \
> > +     -Dsession_tracking=systemd \
> > +     -Dsuspend_resume=systemd
> >  else
> > -NETWORK_MANAGER_CONF_OPTS += --without-modem-manager-1
> > +NETWORK_MANAGER_CONF_OPTS += \
> > +     -Dsystemd_journal=false \
> > +     -Dconfig_logging_backend_default=syslog \
> > +     -Dsession_tracking=no \
> > +     -Dsuspend_resume=upower
>
> This whole systemd logic also seems new, is it related to the version
> bump?

Related to the meson migration.

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot