Re: [Buildroot] [PATCH v7 4/5] package/python-tomli: bump to version 2.0.1

[James Hilliard <james.hilliard1@gmail.com>]

On Wed, Apr 27, 2022 at 1:15 AM James Hilliard
<james.hilliard1@gmail.com> wrote:
>
> On Wed, Apr 27, 2022 at 1:07 AM Arnout Vandecappelle <arnout@mind.be> wrote:
> >
> >
> >
> > On 26/04/2022 03:35, James Hilliard wrote:
> > > On Mon, Apr 25, 2022 at 4:37 PM Arnout Vandecappelle <arnout@mind.be> wrote:
> > >>
> > >>
> > >>
> > >> On 24/04/2022 23:39, James Hilliard wrote:
> > >>> This package now requires flit and must use the flit-bootstrap setup
> > >>> type for the host build since it is a dependency of
> > >>> host-python-pypa-build.
> > >>>
> > >>> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > >>
> > >>
> > >>    Applied to master, thanks.
> > >>
> > >>    While testing this series, I noticed that the following gives an error (this
> > >> was already the case in the original series; I haven't checked how it was before
> > >> your series was applied - for tomli, it certainly wouldn't happen because it
> > >> would still be using setuptools, but maybe for other flit packages, I don't know).
> > >>
> > >> make python-tomli
> > >> make python-tomli-dirclean
> > >> make python-tomli
> > >> ...
> > >> FileExistsError: File already exists:
> > >> /home/arnout/src/buildroot/output/target/usr/lib/python3.10/site-packages/tomli/__init__.py
> > >
> > > I think it happens only when building across version bumps, probably a bug
> > > with installer(https://github.com/pypa/installer) upstream.
> >
> >   No, it's exactly the sequence of commands that I wrote above that triggers it.
>
> Oh, yeah, I see what's happening, I was testing with per-package directories
> which prevents one from hitting that issue in most cases since it clears out
> the conflicting/old artifacts with dirclean.
>
> >
> >   I haven't checked if this is the case for flit/pep517 packages in general, or
> > just for flit-bootstrap.
>
> Likely affects all flit/flit-bootstrap and pep517 packages if I had to
> guess, seems
> due to stale build artifacts lying around combined with installer not wanting to
> overwrite artifacts in general, might need to upstream some way to enable
> artifact overwrites, I'll look into that.

Issue opened upstream:
https://github.com/pypa/installer/issues/121

>
> >
> >   Regards,
> >   Arnout
> >
> > >
> > >>
> > >>    Would be nice to get that fixed...
> > >
> > > Yeah, I'll see if I can track that issue down.
> > >
> > >>
> > >>    Regards,
> > >>    Arnout
> > >>
> > >>> ---
> > >>> Changes v6 -> v7:
> > >>>     - only use flit-boostrap for host-python-tomli
> > >>> ---
> > >>>    package/python-tomli/python-tomli.hash | 4 ++--
> > >>>    package/python-tomli/python-tomli.mk   | 7 ++++---
> > >>>    2 files changed, 6 insertions(+), 5 deletions(-)
> > >>>
> > >>> diff --git a/package/python-tomli/python-tomli.hash b/package/python-tomli/python-tomli.hash
> > >>> index 1a274c8a40..8368f9ee13 100644
> > >>> --- a/package/python-tomli/python-tomli.hash
> > >>> +++ b/package/python-tomli/python-tomli.hash
> > >>> @@ -1,5 +1,5 @@
> > >>>    # md5, sha256 from https://pypi.org/pypi/tomli/json
> > >>> -md5  2ecbc7a23b8c8dc2fe96f588f88463d9  tomli-1.2.0.tar.gz
> > >>> -sha256  d60e681734099207a6add7a10326bc2ddd1fdc36c1b0f547d00ef73ac63739c2  tomli-1.2.0.tar.gz
> > >>> +md5  d4341621d423a7ca6822e23d6d52bb9a  tomli-2.0.1.tar.gz
> > >>> +sha256  de526c12914f0c550d15924c62d72abc48d6fe7364aa87328337a31007fe8a4f  tomli-2.0.1.tar.gz
> > >>>    # Locally computed sha256 checksums
> > >>>    sha256  b80816b0d530b8accb4c2211783790984a6e3b61922c2b5ee92f3372ab2742fe  LICENSE
> > >>> diff --git a/package/python-tomli/python-tomli.mk b/package/python-tomli/python-tomli.mk
> > >>> index b8c20ca736..b803d67466 100644
> > >>> --- a/package/python-tomli/python-tomli.mk
> > >>> +++ b/package/python-tomli/python-tomli.mk
> > >>> @@ -4,12 +4,13 @@
> > >>>    #
> > >>>    ################################################################################
> > >>>
> > >>> -PYTHON_TOMLI_VERSION = 1.2.0
> > >>> +PYTHON_TOMLI_VERSION = 2.0.1
> > >>>    PYTHON_TOMLI_SOURCE = tomli-$(PYTHON_TOMLI_VERSION).tar.gz
> > >>> -PYTHON_TOMLI_SITE = https://files.pythonhosted.org/packages/ec/38/8eccdc662c61aed187d5f5b168c18b1d2de3827976c3691e4da8be7375aa
> > >>> -PYTHON_TOMLI_SETUP_TYPE = distutils
> > >>> +PYTHON_TOMLI_SITE = https://files.pythonhosted.org/packages/c0/3f/d7af728f075fb08564c5949a9c95e44352e23dee646869fa104a3b2060a3
> > >>>    PYTHON_TOMLI_LICENSE = MIT
> > >>>    PYTHON_TOMLI_LICENSE_FILES = LICENSE
> > >>> +PYTHON_TOMLI_SETUP_TYPE = flit
> > >>> +HOST_PYTHON_TOMLI_SETUP_TYPE = flit-bootstrap
> > >>>
> > >>>    $(eval $(python-package))
> > >>>    $(eval $(host-python-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot