From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50414C433F5 for ; Tue, 21 Sep 2021 07:02:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3342D6115B for ; Tue, 21 Sep 2021 07:02:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230031AbhIUHDg (ORCPT ); Tue, 21 Sep 2021 03:03:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230027AbhIUHDe (ORCPT ); Tue, 21 Sep 2021 03:03:34 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E0E8C061574 for ; Tue, 21 Sep 2021 00:02:05 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id d21so36079528wra.12 for ; Tue, 21 Sep 2021 00:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HfIARBfVCCT7vPYMtN3+SPdDH+ThIQoGLpcaGKSdVGk=; b=Zb0d2wP/g3UAFvd0gS+m37e/oOVwbP75x9esu0xGEAip7KPW3+UYmPJDaLBxNrtKx1 P38XhXNCMA2Us8TcDAcMXfGUNWfzCAn6/Xm3PDu/G7IOqNAlJh484WdSkBMdi+UpoxQq 9BaUqzw2MhweiGIx2a58sy3hN88u8H7VQXDZe3epIajSLRfJNiTS2CK3CqTNZQRt009O RTaZwHW4BSwvdp/XCdMRxubZjSrh+3rsSBhhvzfAZ+A9aexIj2jSFq2VQsSbwQFx+php y9hfRnrIkQL7yAw+rRCwiHyuJeGFjzOUjXSa40WZzDfUBXMMuCrdKaUTwnCOHbOkyAgt J7AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HfIARBfVCCT7vPYMtN3+SPdDH+ThIQoGLpcaGKSdVGk=; b=icGX8KaLZv97cUDjBaToZiRzsmZ6LxoeZdb32YugS1uSsz92O3jpGCBLz4kb7xo4bo dm9bE44JDNLfCssIlPy0a9BcNyocUvLTtToQRDNMHmoidW9olLDgawhYEN1xOymmhXbP RmkQsh8SsRnWnxh/nVZuBHQsUfvIlRX09ezw4NRjQo/uMMa7xe3zcJQaK5PUMOrvhnR4 BV0N4UwNJ8GTo+QqY1QSLKl0g8LmwQr4ewfHmWolqEhH193RP/gKHLC/SHmHiEmTxQdS YcUSnWkNu15jh6FdD9iJdkyd6n9a3s/mp+adwx/gRGkuaHOWCexjTNa+9EKeYqz8zRXE EyKQ== X-Gm-Message-State: AOAM532TLogEybCDSYKNDd4o/+FbBzxZAGSJPUAWFcrsizV2q0coB9k2 Ciz7edsZJ7rfmDl5QHXeanEis4JSp9NZImXuksvfm9it+yNmHw== X-Google-Smtp-Source: ABdhPJxAPCkhTzDAZ336WwmL8b7wBL8zKg+mjYsC/mtlam85cyLYzQ5iKF95uQewNeFpWVrRQe2CbP1VGkmnheKe8N0= X-Received: by 2002:a05:6000:104e:: with SMTP id c14mr32732165wrx.130.1632207723041; Tue, 21 Sep 2021 00:02:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Xin Long Date: Tue, 21 Sep 2021 15:01:52 +0800 Message-ID: Subject: Re: [PATCH net 2/2] net: sched: also drop dst for the packets toward ingress in act_mirred To: Cong Wang Cc: network dev , David Miller , Jakub Kicinski , Marcelo Ricardo Leitner , Davide Caratti , Hangbin Liu , Jamal Hadi Salim , Jiri Pirko Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Sep 21, 2021 at 2:34 AM Cong Wang wrote: > > On Mon, Sep 20, 2021 at 7:12 AM Xin Long wrote: > > > > Without dropping dst, the packets sent from local mirred/redirected > > to ingress will may still use the old dst. ip_rcv() will drop it as > > the old dst is for output and its .input is dst_discard. > > > > This patch is to fix by also dropping dst for those packets that are > > mirred or redirected to ingress in act_mirred. > > Similar question: what about redirecting from ingress to egress? We can do it IF there's any user case needing it. But for now, The problem I've met occurred in ip_rcv() for the user case. > > BTW, please CC TC maintainers for TC patches. added Jamal and Jiri. Thanks. > > Thanks.