All of lore.kernel.org
 help / color / mirror / Atom feed
From: Menglong Dong <menglong8.dong@gmail.com>
To: David Ahern <dsahern@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	mingo@redhat.com, David Miller <davem@davemloft.net>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>,
	pablo@netfilter.org, kadlec@netfilter.org,
	Florian Westphal <fw@strlen.de>,
	Menglong Dong <imagedong@tencent.com>,
	Eric Dumazet <edumazet@google.com>,
	alobakin@pm.me, paulb@nvidia.com, Paolo Abeni <pabeni@redhat.com>,
	talalahmad@google.com, haokexin@gmail.com,
	Kees Cook <keescook@chromium.org>,
	memxor@gmail.com, LKML <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	Cong Wang <cong.wang@bytedance.com>
Subject: Re: [PATCH net-next 3/6] net: ipv4: use kfree_skb_reason() in ip_rcv_finish_core()
Date: Wed, 26 Jan 2022 11:13:35 +0800	[thread overview]
Message-ID: <CADxym3Y5Ld-BcM4-Y=vJZiwsCEfRZpBqd1oj6ct+Xeu8F=wXew@mail.gmail.com> (raw)
In-Reply-To: <926e3d3d-1af0-7155-e0ac-aee7d804a645@gmail.com>

On Wed, Jan 26, 2022 at 10:57 AM David Ahern <dsahern@gmail.com> wrote:
>
> On 1/25/22 7:36 PM, Menglong Dong wrote:
> > Is't it meaningful? I name it from the meaning of 'ip route lookup or validate
> > failed in input path', can't it express this information?
>
>
> ip_route_input_noref has many failures and not all of them are FIB
> lookups. ip_route_input_slow has a bunch of EINVAL cases for example.
>
> Returning a 'reason' as the code function name has no meaning to a user
> and could actually be misleading in some cases. I would skip this one
> for now.

Yeah, the real reason can be complex. I'll skip this case for now.

  reply	other threads:[~2022-01-26  3:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 13:15 [PATCH net-next 0/6] net: use kfree_skb_reason() for ip/udp packet receive menglong8.dong
2022-01-24 13:15 ` [PATCH net-next 1/6] net: netfilter: use kfree_drop_reason() for NF_DROP menglong8.dong
2022-01-25 23:32   ` Jakub Kicinski
2022-01-26  0:51     ` Pablo Neira Ayuso
2022-01-24 13:15 ` [PATCH net-next 2/6] net: ipv4: use kfree_skb_reason() in ip_rcv_core() menglong8.dong
2022-01-26  2:10   ` David Ahern
2022-01-26  2:26     ` Menglong Dong
2022-01-24 13:15 ` [PATCH net-next 3/6] net: ipv4: use kfree_skb_reason() in ip_rcv_finish_core() menglong8.dong
2022-01-26  2:18   ` David Ahern
2022-01-26  2:36     ` Menglong Dong
2022-01-26  2:57       ` David Ahern
2022-01-26  3:13         ` Menglong Dong [this message]
2022-01-24 13:15 ` [PATCH net-next 4/6] net: ipv4: use kfree_skb_reason() in ip_protocol_deliver_rcu() menglong8.dong
2022-01-26  2:21   ` David Ahern
2022-01-26  2:39     ` Menglong Dong
2022-01-24 13:15 ` [PATCH net-next 5/6] net: udp: use kfree_skb_reason() in udp_queue_rcv_one_skb() menglong8.dong
2022-01-26  2:25   ` David Ahern
2022-01-26  2:43     ` Menglong Dong
2022-01-26  3:04       ` David Ahern
2022-01-26  3:25         ` Jakub Kicinski
2022-01-26 15:28           ` David Ahern
2022-01-24 13:15 ` [PATCH net-next 6/6] net: udp: use kfree_skb_reason() in __udp_queue_rcv_skb() menglong8.dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADxym3Y5Ld-BcM4-Y=vJZiwsCEfRZpBqd1oj6ct+Xeu8F=wXew@mail.gmail.com' \
    --to=menglong8.dong@gmail.com \
    --cc=alobakin@pm.me \
    --cc=cong.wang@bytedance.com \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=haokexin@gmail.com \
    --cc=imagedong@tencent.com \
    --cc=kadlec@netfilter.org \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=memxor@gmail.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=paulb@nvidia.com \
    --cc=rostedt@goodmis.org \
    --cc=talalahmad@google.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.