From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH v20 00/17] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Date: Thu, 19 Jan 2017 19:06:10 +0800 Message-ID: References: <20170118132541.8989-1-fu.wei@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Hanjun Guo Cc: Mark Rutland , Linaro ACPI Mailman List , Catalin Marinas , Will Deacon , rruigrok@codeaurora.org, Wim Van Sebroeck , Wei Huang , Lorenzo Pieralisi , Al Stone , Tomasz Nowicki , Timur Tabi , Daniel Lezcano , ACPI Devel Maling List , Guenter Roeck , Len Brown , "Abdulhamid, Harb" , Julien Grall , linux-watchdog@vger.kernel.org, Arnd Bergmann , Marc Zyngier , Jon Masters , Christopher Covington , Thomas Gleixner , linux-arm-kernel@lists List-Id: linux-acpi@vger.kernel.org Hi Hanjun, On 19 January 2017 at 17:20, Hanjun Guo wrote: > Hi Fuwei, > > > On 2017/1/18 21:25, fu.wei@linaro.org wrote: >> >> From: Fu Wei >> >> This patchset: >> (1)Preparation for adding GTDT support in arm_arch_timer: >> 1. Clean up printk() usage >> 2. Rename the type macros >> 3. Rename the PPI enum & enum values >> 4. Move the type macro and PPI enum into the header file >> 5. Add new enum for SPIs >> 6. Rework PPI determination; >> 7. Rework counter frequency detection; >> 8. Refactor arch_timer_needs_probing, move it into DT init call >> 9. Introduce some new structs and refactor the MMIO timer init >> code >> for reusing some common code. >> >> (2)Introduce ACPI GTDT parser: drivers/acpi/arm64/acpi_gtdt.c >> Parse all kinds of timer in GTDT table of ACPI:arch timer, >> memory-mapped timer and SBSA Generic Watchdog timer. >> This driver can help to simplify all the relevant timer drivers, >> and separate all the ACPI GTDT knowledge from them. >> >> (3)Simplify ACPI code for arm_arch_timer >> >> (4)Add GTDT support for ARM memory-mapped timer. >> >> This patchset has been tested on the following platforms with ACPI >> enabled: >> (1)ARM Foundation v8 model >> >> Changelog: >> v20: https://lkml.org/lkml/2017/1/18/ >> Reorder the first 4 patches and split the 4th patches. >> Leave CNTHCTL_* as they originally were. >> Fix the bug in arch_timer_select_ppi. >> Split "Rework counter frequency detection" patch. >> Rework the arch_timer_detect_rate function. >> Improve the commit message of "Refactor MMIO timer probing". >> Rebase to 4.10.0-rc4 > > > Other than some minor comments I raised, the patch set > looks fine to me, and I tested this patch set on D03, > the percpu arch timer works fine as before. > > With the comments fixed, > Reviewed-by: Hanjun Guo > Tested-by: Hanjun Guo Great thanks for your testing. :-) will apply Reviewed-by: Hanjun Guo on all patches, and Tested-by: Hanjun Guo on arch_timer patches. > > Thanks > Hanjun -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbdASLM5 (ORCPT ); Thu, 19 Jan 2017 06:12:57 -0500 Received: from mail-it0-f52.google.com ([209.85.214.52]:35149 "EHLO mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752052AbdASLM4 (ORCPT ); Thu, 19 Jan 2017 06:12:56 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170118132541.8989-1-fu.wei@linaro.org> From: Fu Wei Date: Thu, 19 Jan 2017 19:06:10 +0800 Message-ID: Subject: Re: [PATCH v20 00/17] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer To: Hanjun Guo Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , Wei Huang , Arnd Bergmann , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , Leo Duran , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Tomasz Nowicki , Christoffer Dall , Julien Grall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hanjun, On 19 January 2017 at 17:20, Hanjun Guo wrote: > Hi Fuwei, > > > On 2017/1/18 21:25, fu.wei@linaro.org wrote: >> >> From: Fu Wei >> >> This patchset: >> (1)Preparation for adding GTDT support in arm_arch_timer: >> 1. Clean up printk() usage >> 2. Rename the type macros >> 3. Rename the PPI enum & enum values >> 4. Move the type macro and PPI enum into the header file >> 5. Add new enum for SPIs >> 6. Rework PPI determination; >> 7. Rework counter frequency detection; >> 8. Refactor arch_timer_needs_probing, move it into DT init call >> 9. Introduce some new structs and refactor the MMIO timer init >> code >> for reusing some common code. >> >> (2)Introduce ACPI GTDT parser: drivers/acpi/arm64/acpi_gtdt.c >> Parse all kinds of timer in GTDT table of ACPI:arch timer, >> memory-mapped timer and SBSA Generic Watchdog timer. >> This driver can help to simplify all the relevant timer drivers, >> and separate all the ACPI GTDT knowledge from them. >> >> (3)Simplify ACPI code for arm_arch_timer >> >> (4)Add GTDT support for ARM memory-mapped timer. >> >> This patchset has been tested on the following platforms with ACPI >> enabled: >> (1)ARM Foundation v8 model >> >> Changelog: >> v20: https://lkml.org/lkml/2017/1/18/ >> Reorder the first 4 patches and split the 4th patches. >> Leave CNTHCTL_* as they originally were. >> Fix the bug in arch_timer_select_ppi. >> Split "Rework counter frequency detection" patch. >> Rework the arch_timer_detect_rate function. >> Improve the commit message of "Refactor MMIO timer probing". >> Rebase to 4.10.0-rc4 > > > Other than some minor comments I raised, the patch set > looks fine to me, and I tested this patch set on D03, > the percpu arch timer works fine as before. > > With the comments fixed, > Reviewed-by: Hanjun Guo > Tested-by: Hanjun Guo Great thanks for your testing. :-) will apply Reviewed-by: Hanjun Guo on all patches, and Tested-by: Hanjun Guo on arch_timer patches. > > Thanks > Hanjun -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 From: fu.wei@linaro.org (Fu Wei) Date: Thu, 19 Jan 2017 19:06:10 +0800 Subject: [PATCH v20 00/17] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer In-Reply-To: References: <20170118132541.8989-1-fu.wei@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Hanjun, On 19 January 2017 at 17:20, Hanjun Guo wrote: > Hi Fuwei, > > > On 2017/1/18 21:25, fu.wei at linaro.org wrote: >> >> From: Fu Wei >> >> This patchset: >> (1)Preparation for adding GTDT support in arm_arch_timer: >> 1. Clean up printk() usage >> 2. Rename the type macros >> 3. Rename the PPI enum & enum values >> 4. Move the type macro and PPI enum into the header file >> 5. Add new enum for SPIs >> 6. Rework PPI determination; >> 7. Rework counter frequency detection; >> 8. Refactor arch_timer_needs_probing, move it into DT init call >> 9. Introduce some new structs and refactor the MMIO timer init >> code >> for reusing some common code. >> >> (2)Introduce ACPI GTDT parser: drivers/acpi/arm64/acpi_gtdt.c >> Parse all kinds of timer in GTDT table of ACPI:arch timer, >> memory-mapped timer and SBSA Generic Watchdog timer. >> This driver can help to simplify all the relevant timer drivers, >> and separate all the ACPI GTDT knowledge from them. >> >> (3)Simplify ACPI code for arm_arch_timer >> >> (4)Add GTDT support for ARM memory-mapped timer. >> >> This patchset has been tested on the following platforms with ACPI >> enabled: >> (1)ARM Foundation v8 model >> >> Changelog: >> v20: https://lkml.org/lkml/2017/1/18/ >> Reorder the first 4 patches and split the 4th patches. >> Leave CNTHCTL_* as they originally were. >> Fix the bug in arch_timer_select_ppi. >> Split "Rework counter frequency detection" patch. >> Rework the arch_timer_detect_rate function. >> Improve the commit message of "Refactor MMIO timer probing". >> Rebase to 4.10.0-rc4 > > > Other than some minor comments I raised, the patch set > looks fine to me, and I tested this patch set on D03, > the percpu arch timer works fine as before. > > With the comments fixed, > Reviewed-by: Hanjun Guo > Tested-by: Hanjun Guo Great thanks for your testing. :-) will apply Reviewed-by: Hanjun Guo on all patches, and Tested-by: Hanjun Guo on arch_timer patches. > > Thanks > Hanjun -- Best regards, Fu Wei Software Engineer Red Hat