From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH v21 03/13] clocksource: arm_arch_timer: remove arch_timer_detect_rate Date: Mon, 20 Mar 2017 14:59:35 +0800 Message-ID: References: <20170206185015.12296-1-fu.wei@linaro.org> <20170206185015.12296-4-fu.wei@linaro.org> <20170317180725.GC15909@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170317180725.GC15909@leverpostej> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mark Rutland Cc: Linaro ACPI Mailman List , Catalin Marinas , Will Deacon , rruigrok@codeaurora.org, Wim Van Sebroeck , Wei Huang , Lorenzo Pieralisi , Al Stone , Tomasz Nowicki , Timur Tabi , Daniel Lezcano , ACPI Devel Maling List , Guenter Roeck , Len Brown , "Abdulhamid, Harb" , Julien Grall , linux-watchdog@vger.kernel.org, Arnd Bergmann , Marc Zyngier , Jon Masters , Christopher Covington , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, G Gregory List-Id: linux-acpi@vger.kernel.org Hi Mark, On 18 March 2017 at 02:07, Mark Rutland wrote: > On Tue, Feb 07, 2017 at 02:50:05AM +0800, fu.wei@linaro.org wrote: >> From: Fu Wei >> >> The original counter frequency detection call(arch_timer_detect_rate) >> include getting the frequency from the per-cpu arch-timer and the >> memory-mapped (MMIO) timer interfaces. But they will be needed only when >> the system initializes the relevant timer. >> >> This patch remove arch_timer_detect_rate founction, and use the >> arch_timer_get_sysreg_freq and arch_timer_get_mmio_freq directly. >> >> Signed-off-by: Fu Wei > > Could you please fold this with the prior patch? Sure, will do > >> @@ -1087,7 +1072,12 @@ static int __init arch_timer_mem_init(struct device_node *np) >> */ >> if (!arch_timer_rate && >> of_property_read_u32(np, "clock-frequency", &arch_timer_rate)) >> - arch_timer_detect_rate(base); >> + arch_timer_rate = arch_timer_get_mmio_freq(base); >> + if (!arch_timer_rate) { >> + pr_err(FW_BUG "frequency not available for MMIO timer.\n"); > > It would be better to say "MMIO frequency not available.\n" here. thanks , will do > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753173AbdCTHHc (ORCPT ); Mon, 20 Mar 2017 03:07:32 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:36713 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753124AbdCTHH2 (ORCPT ); Mon, 20 Mar 2017 03:07:28 -0400 MIME-Version: 1.0 In-Reply-To: <20170317180725.GC15909@leverpostej> References: <20170206185015.12296-1-fu.wei@linaro.org> <20170206185015.12296-4-fu.wei@linaro.org> <20170317180725.GC15909@leverpostej> From: Fu Wei Date: Mon, 20 Mar 2017 14:59:35 +0800 Message-ID: Subject: Re: [PATCH v21 03/13] clocksource: arm_arch_timer: remove arch_timer_detect_rate To: Mark Rutland Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Lorenzo Pieralisi , Sudeep Holla , Hanjun Guo , linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , Wei Huang , Arnd Bergmann , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , Leo Duran , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Tomasz Nowicki , Christoffer Dall , Julien Grall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 18 March 2017 at 02:07, Mark Rutland wrote: > On Tue, Feb 07, 2017 at 02:50:05AM +0800, fu.wei@linaro.org wrote: >> From: Fu Wei >> >> The original counter frequency detection call(arch_timer_detect_rate) >> include getting the frequency from the per-cpu arch-timer and the >> memory-mapped (MMIO) timer interfaces. But they will be needed only when >> the system initializes the relevant timer. >> >> This patch remove arch_timer_detect_rate founction, and use the >> arch_timer_get_sysreg_freq and arch_timer_get_mmio_freq directly. >> >> Signed-off-by: Fu Wei > > Could you please fold this with the prior patch? Sure, will do > >> @@ -1087,7 +1072,12 @@ static int __init arch_timer_mem_init(struct device_node *np) >> */ >> if (!arch_timer_rate && >> of_property_read_u32(np, "clock-frequency", &arch_timer_rate)) >> - arch_timer_detect_rate(base); >> + arch_timer_rate = arch_timer_get_mmio_freq(base); >> + if (!arch_timer_rate) { >> + pr_err(FW_BUG "frequency not available for MMIO timer.\n"); > > It would be better to say "MMIO frequency not available.\n" here. thanks , will do > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 From: fu.wei@linaro.org (Fu Wei) Date: Mon, 20 Mar 2017 14:59:35 +0800 Subject: [PATCH v21 03/13] clocksource: arm_arch_timer: remove arch_timer_detect_rate In-Reply-To: <20170317180725.GC15909@leverpostej> References: <20170206185015.12296-1-fu.wei@linaro.org> <20170206185015.12296-4-fu.wei@linaro.org> <20170317180725.GC15909@leverpostej> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, On 18 March 2017 at 02:07, Mark Rutland wrote: > On Tue, Feb 07, 2017 at 02:50:05AM +0800, fu.wei at linaro.org wrote: >> From: Fu Wei >> >> The original counter frequency detection call(arch_timer_detect_rate) >> include getting the frequency from the per-cpu arch-timer and the >> memory-mapped (MMIO) timer interfaces. But they will be needed only when >> the system initializes the relevant timer. >> >> This patch remove arch_timer_detect_rate founction, and use the >> arch_timer_get_sysreg_freq and arch_timer_get_mmio_freq directly. >> >> Signed-off-by: Fu Wei > > Could you please fold this with the prior patch? Sure, will do > >> @@ -1087,7 +1072,12 @@ static int __init arch_timer_mem_init(struct device_node *np) >> */ >> if (!arch_timer_rate && >> of_property_read_u32(np, "clock-frequency", &arch_timer_rate)) >> - arch_timer_detect_rate(base); >> + arch_timer_rate = arch_timer_get_mmio_freq(base); >> + if (!arch_timer_rate) { >> + pr_err(FW_BUG "frequency not available for MMIO timer.\n"); > > It would be better to say "MMIO frequency not available.\n" here. thanks , will do > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat