Re: [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64

From: Fu Wei <fu.wei@linaro.org>
To: Julien Grall <julien.grall@linaro.org>
Cc: The development of GNU GRUB <grub-devel@gnu.org>,
	Ian Campbell <ian.campbell@citrix.com>,
	Steve Capper <steve.capper@arm.com>,
	Vladimir Serbinenko <phcoder@gmail.com>,
	xen-devel <xen-devel@lists.xen.org>,
	stefano.stabellini@citrix.com
Subject: Re: [PATCH] arm64: xen_boot: Fix xen boot using Grub on AARCH64
Date: Thu, 31 Mar 2016 01:10:02 +0800	[thread overview]
Message-ID: <CADyBb7spetxVXVKCqndZQCc=rCOusNsfCssMN9aC0xcco_W_kw__4655.18404166705$1459357872$gmane$org@mail.gmail.com> (raw)
In-Reply-To: <56FBF64A.5050105@linaro.org>

Hi Julien,

I have posted the v3 , please check
http://lists.xen.org/archives/html/xen-devel/2016-03/msg03564.html

And I hope GRUB patch can be merged :-)

On 30 March 2016 at 23:52, Julien Grall <julien.grall@linaro.org> wrote:
> Hello,
>
> Ping?
>
> Regards,
>
>
> On 19/02/16 16:28, Julien Grall wrote:
>>
>> Xen is currently crashing because of malformed compatible property for
>> the boot module. This is because the property string is not
>> null-terminated as requested by the ePAR spec.
>> ---
>>   grub-core/loader/arm64/xen_boot.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/grub-core/loader/arm64/xen_boot.c
>> b/grub-core/loader/arm64/xen_boot.c
>> index a914eb8..8ae43d7 100644
>> --- a/grub-core/loader/arm64/xen_boot.c
>> +++ b/grub-core/loader/arm64/xen_boot.c
>> @@ -156,7 +156,7 @@ prepare_xen_module_params (struct xen_boot_binary
>> *module, void *xen_boot_fdt)
>>         grub_fdt_add_subnode (xen_boot_fdt, chosen_node, module_name);
>>
>>     retval = grub_fdt_set_prop (xen_boot_fdt, module_node, "compatible",
>> -                             MODULE_CUSTOM_COMPATIBLE,
>> sizeof(MODULE_CUSTOM_COMPATIBLE) - 1);
>> +                             MODULE_CUSTOM_COMPATIBLE,
>> sizeof(MODULE_CUSTOM_COMPATIBLE));
>>     if (retval)
>>       return grub_error (GRUB_ERR_IO, "failed to update FDT");
>>
>>
>
> --
> Julien Grall

-- 
Best regards,

Fu Wei
Software Engineer
Red Hat Software (Beijing) Co.,Ltd.Shanghai Branch
Ph: +86 21 61221326(direct)
Ph: +86 186 2020 4684 (mobile)
Room 1512, Regus One Corporate Avenue,Level 15,
One Corporate Avenue,222 Hubin Road,Huangpu District,
Shanghai,China 200021

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel