From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code Date: Wed, 26 Oct 2016 16:28:43 +0800 Message-ID: References: <1475086637-1914-1-git-send-email-fu.wei@linaro.org> <1475086637-1914-4-git-send-email-fu.wei@linaro.org> <20161020153244.GB27598@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-oi0-f53.google.com ([209.85.218.53]:35565 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751592AbcJZI2p (ORCPT ); Wed, 26 Oct 2016 04:28:45 -0400 Received: by mail-oi0-f53.google.com with SMTP id i127so83422020oia.2 for ; Wed, 26 Oct 2016 01:28:44 -0700 (PDT) In-Reply-To: <20161020153244.GB27598@leverpostej> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Mark Rutland Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Lorenzo Pieralisi , Sudeep Holla , Hanjun Guo , linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters Hi Mark, On 20 October 2016 at 23:32, Mark Rutland wrote: > On Thu, Sep 29, 2016 at 02:17:11AM +0800, fu.wei@linaro.org wrote: >> static void arch_timer_banner(unsigned type) >> { >> - pr_info("Architected %s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n", >> - type & ARCH_CP15_TIMER ? "cp15" : "", >> - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "", >> - type & ARCH_MEM_TIMER ? "mmio" : "", >> - (unsigned long)arch_timer_rate / 1000000, >> - (unsigned long)(arch_timer_rate / 10000) % 100, >> - type & ARCH_CP15_TIMER ? >> - (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" : >> - "", >> - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "", >> - type & ARCH_MEM_TIMER ? >> - arch_timer_mem_use_virtual ? "virt" : "phys" : >> - ""); >> + pr_info("%s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n", >> + type & ARCH_CP15_TIMER ? "cp15" : "", >> + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "", >> + type & ARCH_MEM_TIMER ? "mmio" : "", >> + (unsigned long)arch_timer_rate / 1000000, >> + (unsigned long)(arch_timer_rate / 10000) % 100, >> + type & ARCH_CP15_TIMER ? >> + (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" : >> + "", > Please restore the additional indent on this line... > >> + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "", >> + type & ARCH_MEM_TIMER ? >> + arch_timer_mem_use_virtual ? "virt" : "phys" : >> + ""); > > ... and these two. > > No matter what checkpatch says, I prefer the code that way so as to keep > the ternary clear. yes, NP, I have fixed it :-) > > [...] > >> @@ -768,7 +769,7 @@ static int __init arch_timer_init(void) >> return ret; >> >> arch_timer_kvm_info.virtual_irq = arch_timer_ppi[VIRT_PPI]; >> - >> + > > Please mention the whitespace fixup in the commit message. It's > surprising otherwise. OK, added this message. > > With all that: > > Acked-by: Mark Rutland Great thanks :-) > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754026AbcJZI2r (ORCPT ); Wed, 26 Oct 2016 04:28:47 -0400 Received: from mail-oi0-f47.google.com ([209.85.218.47]:36434 "EHLO mail-oi0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbcJZI2p (ORCPT ); Wed, 26 Oct 2016 04:28:45 -0400 MIME-Version: 1.0 In-Reply-To: <20161020153244.GB27598@leverpostej> References: <1475086637-1914-1-git-send-email-fu.wei@linaro.org> <1475086637-1914-4-git-send-email-fu.wei@linaro.org> <20161020153244.GB27598@leverpostej> From: Fu Wei Date: Wed, 26 Oct 2016 16:28:43 +0800 Message-ID: Subject: Re: [PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code To: Mark Rutland Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Lorenzo Pieralisi , Sudeep Holla , Hanjun Guo , linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , Wei Huang , Arnd Bergmann , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , Leo Duran , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Tomasz Nowicki , Christoffer Dall , Julien Grall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 20 October 2016 at 23:32, Mark Rutland wrote: > On Thu, Sep 29, 2016 at 02:17:11AM +0800, fu.wei@linaro.org wrote: >> static void arch_timer_banner(unsigned type) >> { >> - pr_info("Architected %s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n", >> - type & ARCH_CP15_TIMER ? "cp15" : "", >> - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "", >> - type & ARCH_MEM_TIMER ? "mmio" : "", >> - (unsigned long)arch_timer_rate / 1000000, >> - (unsigned long)(arch_timer_rate / 10000) % 100, >> - type & ARCH_CP15_TIMER ? >> - (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" : >> - "", >> - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "", >> - type & ARCH_MEM_TIMER ? >> - arch_timer_mem_use_virtual ? "virt" : "phys" : >> - ""); >> + pr_info("%s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n", >> + type & ARCH_CP15_TIMER ? "cp15" : "", >> + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "", >> + type & ARCH_MEM_TIMER ? "mmio" : "", >> + (unsigned long)arch_timer_rate / 1000000, >> + (unsigned long)(arch_timer_rate / 10000) % 100, >> + type & ARCH_CP15_TIMER ? >> + (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" : >> + "", > Please restore the additional indent on this line... > >> + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "", >> + type & ARCH_MEM_TIMER ? >> + arch_timer_mem_use_virtual ? "virt" : "phys" : >> + ""); > > ... and these two. > > No matter what checkpatch says, I prefer the code that way so as to keep > the ternary clear. yes, NP, I have fixed it :-) > > [...] > >> @@ -768,7 +769,7 @@ static int __init arch_timer_init(void) >> return ret; >> >> arch_timer_kvm_info.virtual_irq = arch_timer_ppi[VIRT_PPI]; >> - >> + > > Please mention the whitespace fixup in the commit message. It's > surprising otherwise. OK, added this message. > > With all that: > > Acked-by: Mark Rutland Great thanks :-) > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 From: fu.wei@linaro.org (Fu Wei) Date: Wed, 26 Oct 2016 16:28:43 +0800 Subject: [PATCH v14 3/9] clocksource/drivers/arm_arch_timer: Improve printk relevant code In-Reply-To: <20161020153244.GB27598@leverpostej> References: <1475086637-1914-1-git-send-email-fu.wei@linaro.org> <1475086637-1914-4-git-send-email-fu.wei@linaro.org> <20161020153244.GB27598@leverpostej> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, On 20 October 2016 at 23:32, Mark Rutland wrote: > On Thu, Sep 29, 2016 at 02:17:11AM +0800, fu.wei at linaro.org wrote: >> static void arch_timer_banner(unsigned type) >> { >> - pr_info("Architected %s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n", >> - type & ARCH_CP15_TIMER ? "cp15" : "", >> - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "", >> - type & ARCH_MEM_TIMER ? "mmio" : "", >> - (unsigned long)arch_timer_rate / 1000000, >> - (unsigned long)(arch_timer_rate / 10000) % 100, >> - type & ARCH_CP15_TIMER ? >> - (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" : >> - "", >> - type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "", >> - type & ARCH_MEM_TIMER ? >> - arch_timer_mem_use_virtual ? "virt" : "phys" : >> - ""); >> + pr_info("%s%s%s timer(s) running at %lu.%02luMHz (%s%s%s).\n", >> + type & ARCH_CP15_TIMER ? "cp15" : "", >> + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? " and " : "", >> + type & ARCH_MEM_TIMER ? "mmio" : "", >> + (unsigned long)arch_timer_rate / 1000000, >> + (unsigned long)(arch_timer_rate / 10000) % 100, >> + type & ARCH_CP15_TIMER ? >> + (arch_timer_uses_ppi == VIRT_PPI) ? "virt" : "phys" : >> + "", > Please restore the additional indent on this line... > >> + type == (ARCH_CP15_TIMER | ARCH_MEM_TIMER) ? "/" : "", >> + type & ARCH_MEM_TIMER ? >> + arch_timer_mem_use_virtual ? "virt" : "phys" : >> + ""); > > ... and these two. > > No matter what checkpatch says, I prefer the code that way so as to keep > the ternary clear. yes, NP, I have fixed it :-) > > [...] > >> @@ -768,7 +769,7 @@ static int __init arch_timer_init(void) >> return ret; >> >> arch_timer_kvm_info.virtual_irq = arch_timer_ppi[VIRT_PPI]; >> - >> + > > Please mention the whitespace fixup in the commit message. It's > surprising otherwise. OK, added this message. > > With all that: > > Acked-by: Mark Rutland Great thanks :-) > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat