From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH v19 10/15] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT Date: Tue, 17 Jan 2017 21:22:17 +0800 Message-ID: References: <20161221064603.11830-1-fu.wei@linaro.org> <20161221064603.11830-11-fu.wei@linaro.org> <20170116183032.GL5908@leverpostej> <20170117122921.GE11939@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170117122921.GE11939@leverpostej> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mark Rutland Cc: Linaro ACPI Mailman List , Catalin Marinas , Will Deacon , rruigrok@codeaurora.org, Wim Van Sebroeck , Wei Huang , Lorenzo Pieralisi , Al Stone , Tomasz Nowicki , Timur Tabi , Daniel Lezcano , ACPI Devel Maling List , Guenter Roeck , Len Brown , "Abdulhamid, Harb" , Julien Grall , linux-watchdog@vger.kernel.org, Arnd Bergmann , Marc Zyngier , Jon Masters , Christopher Covington , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, G Gregory List-Id: linux-acpi@vger.kernel.org Hi Mark, On 17 January 2017 at 20:29, Mark Rutland wrote: > On Tue, Jan 17, 2017 at 06:18:12AM -0600, Timur Tabi wrote: >> Fu Wei wrote: >> >if (i >= ARCH_TIMER_MEM_MAX_FRAMES) { >> > pr_err(FW_BUG "too many frames, ARMv8 spec only allows 8.\n"); >> >> pr_err(FW_BUG "too many frames, ARMv8 spec only allows %u.\n", >> ARCH_TIMER_MEM_MAX_FRAMES); > > While I don't see ARCH_TIMER_MEM_MAX_FRAMES changing, this would be > nicer to ensure the result obviously matches. > > As for wording, I'd perfer: > > pr_err(FW_BUG "too many frames, only %u are permitted.\n", > ARCH_TIMER_MEM_MAX_FRAMES); OK, will do so. Thanks! > > ... so as to avoid any confusion between spec versions and so on. We can > reconsider the message if/when that changes. > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751160AbdAQNXN (ORCPT ); Tue, 17 Jan 2017 08:23:13 -0500 Received: from mail-io0-f170.google.com ([209.85.223.170]:34493 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbdAQNXK (ORCPT ); Tue, 17 Jan 2017 08:23:10 -0500 MIME-Version: 1.0 In-Reply-To: <20170117122921.GE11939@leverpostej> References: <20161221064603.11830-1-fu.wei@linaro.org> <20161221064603.11830-11-fu.wei@linaro.org> <20170116183032.GL5908@leverpostej> <20170117122921.GE11939@leverpostej> From: Fu Wei Date: Tue, 17 Jan 2017 21:22:17 +0800 Message-ID: Subject: Re: [PATCH v19 10/15] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT To: Mark Rutland Cc: Timur Tabi , "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Lorenzo Pieralisi , Sudeep Holla , Hanjun Guo , linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , G Gregory , Al Stone , Jon Masters , Wei Huang , Arnd Bergmann , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , Leo Duran , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Tomasz Nowicki , Christoffer Dall , Julien Grall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 17 January 2017 at 20:29, Mark Rutland wrote: > On Tue, Jan 17, 2017 at 06:18:12AM -0600, Timur Tabi wrote: >> Fu Wei wrote: >> >if (i >= ARCH_TIMER_MEM_MAX_FRAMES) { >> > pr_err(FW_BUG "too many frames, ARMv8 spec only allows 8.\n"); >> >> pr_err(FW_BUG "too many frames, ARMv8 spec only allows %u.\n", >> ARCH_TIMER_MEM_MAX_FRAMES); > > While I don't see ARCH_TIMER_MEM_MAX_FRAMES changing, this would be > nicer to ensure the result obviously matches. > > As for wording, I'd perfer: > > pr_err(FW_BUG "too many frames, only %u are permitted.\n", > ARCH_TIMER_MEM_MAX_FRAMES); OK, will do so. Thanks! > > ... so as to avoid any confusion between spec versions and so on. We can > reconsider the message if/when that changes. > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 From: fu.wei@linaro.org (Fu Wei) Date: Tue, 17 Jan 2017 21:22:17 +0800 Subject: [PATCH v19 10/15] clocksource/drivers/arm_arch_timer: Refactor the timer init code to prepare for GTDT In-Reply-To: <20170117122921.GE11939@leverpostej> References: <20161221064603.11830-1-fu.wei@linaro.org> <20161221064603.11830-11-fu.wei@linaro.org> <20170116183032.GL5908@leverpostej> <20170117122921.GE11939@leverpostej> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, On 17 January 2017 at 20:29, Mark Rutland wrote: > On Tue, Jan 17, 2017 at 06:18:12AM -0600, Timur Tabi wrote: >> Fu Wei wrote: >> >if (i >= ARCH_TIMER_MEM_MAX_FRAMES) { >> > pr_err(FW_BUG "too many frames, ARMv8 spec only allows 8.\n"); >> >> pr_err(FW_BUG "too many frames, ARMv8 spec only allows %u.\n", >> ARCH_TIMER_MEM_MAX_FRAMES); > > While I don't see ARCH_TIMER_MEM_MAX_FRAMES changing, this would be > nicer to ensure the result obviously matches. > > As for wording, I'd perfer: > > pr_err(FW_BUG "too many frames, only %u are permitted.\n", > ARCH_TIMER_MEM_MAX_FRAMES); OK, will do so. Thanks! > > ... so as to avoid any confusion between spec versions and so on. We can > reconsider the message if/when that changes. > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat