From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH v20 11/17] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT Date: Thu, 19 Jan 2017 17:47:14 +0800 Message-ID: References: <20170118132541.8989-1-fu.wei@linaro.org> <20170118132541.8989-12-fu.wei@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Hanjun Guo Cc: Mark Rutland , Linaro ACPI Mailman List , Catalin Marinas , Will Deacon , rruigrok@codeaurora.org, Wim Van Sebroeck , Wei Huang , Lorenzo Pieralisi , Al Stone , Tomasz Nowicki , Timur Tabi , Daniel Lezcano , ACPI Devel Maling List , Guenter Roeck , Len Brown , "Abdulhamid, Harb" , Julien Grall , linux-watchdog@vger.kernel.org, Arnd Bergmann , Marc Zyngier , Jon Masters , Christopher Covington , Thomas Gleixner , linux-arm-kernel@lists List-Id: linux-acpi@vger.kernel.org Hi Hanjun, On 19 January 2017 at 16:28, Hanjun Guo wrote: > On 2017/1/18 21:25, fu.wei@linaro.org wrote: >> >> From: Fu Wei >> >> The patch introduce two new structs: arch_timer_mem, arch_timer_mem_frame. >> And also introduce a new define: ARCH_TIMER_MEM_MAX_FRAMES >> >> These will be used for refactoring the memory-mapped timer init code to >> prepare for GTDT >> >> Signed-off-by: Fu Wei >> --- >> include/clocksource/arm_arch_timer.h | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/include/clocksource/arm_arch_timer.h >> b/include/clocksource/arm_arch_timer.h >> index 4a98c06..b7dd185 100644 >> --- a/include/clocksource/arm_arch_timer.h >> +++ b/include/clocksource/arm_arch_timer.h >> @@ -57,6 +57,8 @@ enum arch_timer_spi_nr { >> #define ARCH_TIMER_MEM_PHYS_ACCESS 2 >> #define ARCH_TIMER_MEM_VIRT_ACCESS 3 >> >> +#define ARCH_TIMER_MEM_MAX_FRAMES 8 >> + >> #define ARCH_TIMER_USR_PCT_ACCESS_EN (1 << 0) /* physical counter */ >> #define ARCH_TIMER_USR_VCT_ACCESS_EN (1 << 1) /* virtual counter */ >> #define ARCH_TIMER_VIRT_EVT_EN (1 << 2) >> @@ -72,6 +74,21 @@ struct arch_timer_kvm_info { >> int virtual_irq; >> }; >> >> +struct arch_timer_mem_frame { >> + int frame_nr; >> + phys_addr_t cntbase; >> + size_t size; >> + int phys_irq; >> + int virt_irq; >> +}; >> + >> +struct arch_timer_mem { >> + phys_addr_t cntctlbase; >> + size_t size; >> + int num_frames; >> + struct arch_timer_mem_frame frame[ARCH_TIMER_MEM_MAX_FRAMES]; >> +}; > > > Since struct is introduced but not used in this patch, how about > squash it with patch 12/17? In the previous patchset, I have been suggested that I should split it out. > > Thanks > Hanjun -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751876AbdASJzo (ORCPT ); Thu, 19 Jan 2017 04:55:44 -0500 Received: from mail-io0-f172.google.com ([209.85.223.172]:33847 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbdASJyh (ORCPT ); Thu, 19 Jan 2017 04:54:37 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170118132541.8989-1-fu.wei@linaro.org> <20170118132541.8989-12-fu.wei@linaro.org> From: Fu Wei Date: Thu, 19 Jan 2017 17:47:14 +0800 Message-ID: Subject: Re: [PATCH v20 11/17] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT To: Hanjun Guo Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , Wei Huang , Arnd Bergmann , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , Leo Duran , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Tomasz Nowicki , Christoffer Dall , Julien Grall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hanjun, On 19 January 2017 at 16:28, Hanjun Guo wrote: > On 2017/1/18 21:25, fu.wei@linaro.org wrote: >> >> From: Fu Wei >> >> The patch introduce two new structs: arch_timer_mem, arch_timer_mem_frame. >> And also introduce a new define: ARCH_TIMER_MEM_MAX_FRAMES >> >> These will be used for refactoring the memory-mapped timer init code to >> prepare for GTDT >> >> Signed-off-by: Fu Wei >> --- >> include/clocksource/arm_arch_timer.h | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/include/clocksource/arm_arch_timer.h >> b/include/clocksource/arm_arch_timer.h >> index 4a98c06..b7dd185 100644 >> --- a/include/clocksource/arm_arch_timer.h >> +++ b/include/clocksource/arm_arch_timer.h >> @@ -57,6 +57,8 @@ enum arch_timer_spi_nr { >> #define ARCH_TIMER_MEM_PHYS_ACCESS 2 >> #define ARCH_TIMER_MEM_VIRT_ACCESS 3 >> >> +#define ARCH_TIMER_MEM_MAX_FRAMES 8 >> + >> #define ARCH_TIMER_USR_PCT_ACCESS_EN (1 << 0) /* physical counter */ >> #define ARCH_TIMER_USR_VCT_ACCESS_EN (1 << 1) /* virtual counter */ >> #define ARCH_TIMER_VIRT_EVT_EN (1 << 2) >> @@ -72,6 +74,21 @@ struct arch_timer_kvm_info { >> int virtual_irq; >> }; >> >> +struct arch_timer_mem_frame { >> + int frame_nr; >> + phys_addr_t cntbase; >> + size_t size; >> + int phys_irq; >> + int virt_irq; >> +}; >> + >> +struct arch_timer_mem { >> + phys_addr_t cntctlbase; >> + size_t size; >> + int num_frames; >> + struct arch_timer_mem_frame frame[ARCH_TIMER_MEM_MAX_FRAMES]; >> +}; > > > Since struct is introduced but not used in this patch, how about > squash it with patch 12/17? In the previous patchset, I have been suggested that I should split it out. > > Thanks > Hanjun -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 From: fu.wei@linaro.org (Fu Wei) Date: Thu, 19 Jan 2017 17:47:14 +0800 Subject: [PATCH v20 11/17] clocksource/drivers/arm_arch_timer: Introduce some new structs to prepare for GTDT In-Reply-To: References: <20170118132541.8989-1-fu.wei@linaro.org> <20170118132541.8989-12-fu.wei@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Hanjun, On 19 January 2017 at 16:28, Hanjun Guo wrote: > On 2017/1/18 21:25, fu.wei at linaro.org wrote: >> >> From: Fu Wei >> >> The patch introduce two new structs: arch_timer_mem, arch_timer_mem_frame. >> And also introduce a new define: ARCH_TIMER_MEM_MAX_FRAMES >> >> These will be used for refactoring the memory-mapped timer init code to >> prepare for GTDT >> >> Signed-off-by: Fu Wei >> --- >> include/clocksource/arm_arch_timer.h | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/include/clocksource/arm_arch_timer.h >> b/include/clocksource/arm_arch_timer.h >> index 4a98c06..b7dd185 100644 >> --- a/include/clocksource/arm_arch_timer.h >> +++ b/include/clocksource/arm_arch_timer.h >> @@ -57,6 +57,8 @@ enum arch_timer_spi_nr { >> #define ARCH_TIMER_MEM_PHYS_ACCESS 2 >> #define ARCH_TIMER_MEM_VIRT_ACCESS 3 >> >> +#define ARCH_TIMER_MEM_MAX_FRAMES 8 >> + >> #define ARCH_TIMER_USR_PCT_ACCESS_EN (1 << 0) /* physical counter */ >> #define ARCH_TIMER_USR_VCT_ACCESS_EN (1 << 1) /* virtual counter */ >> #define ARCH_TIMER_VIRT_EVT_EN (1 << 2) >> @@ -72,6 +74,21 @@ struct arch_timer_kvm_info { >> int virtual_irq; >> }; >> >> +struct arch_timer_mem_frame { >> + int frame_nr; >> + phys_addr_t cntbase; >> + size_t size; >> + int phys_irq; >> + int virt_irq; >> +}; >> + >> +struct arch_timer_mem { >> + phys_addr_t cntctlbase; >> + size_t size; >> + int num_frames; >> + struct arch_timer_mem_frame frame[ARCH_TIMER_MEM_MAX_FRAMES]; >> +}; > > > Since struct is introduced but not used in this patch, how about > squash it with patch 12/17? In the previous patchset, I have been suggested that I should split it out. > > Thanks > Hanjun -- Best regards, Fu Wei Software Engineer Red Hat