From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH v19 00/15] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Date: Tue, 17 Jan 2017 17:14:31 +0800 Message-ID: References: <20161221064603.11830-1-fu.wei@linaro.org> <20170116170010.GH5908@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170116170010.GH5908@leverpostej> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mark Rutland Cc: Linaro ACPI Mailman List , Catalin Marinas , Will Deacon , rruigrok@codeaurora.org, Wim Van Sebroeck , Wei Huang , Lorenzo Pieralisi , Al Stone , Tomasz Nowicki , Timur Tabi , Daniel Lezcano , ACPI Devel Maling List , Guenter Roeck , Len Brown , "Abdulhamid, Harb" , Julien Grall , linux-watchdog@vger.kernel.org, Arnd Bergmann , Marc Zyngier , Jon Masters , Christopher Covington , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, G Gregory List-Id: linux-acpi@vger.kernel.org Hi Mark, On 17 January 2017 at 01:00, Mark Rutland wrote: > Hi, > > On Wed, Dec 21, 2016 at 02:45:48PM +0800, fu.wei@linaro.org wrote: >> From: Fu Wei >> >> This patchset: >> (1)Preparation for adding GTDT support in arm_arch_timer: >> 1. Move some enums and marcos to header file; >> 2. Add a new enum for spi type; >> 3. Improve printk relevant code; >> 4. Rename some enums and defines; > > Can we please rework these first few patches into a series: > > 1. Clean up printk() usage > 2. Rename the type macros > 3. Rename the PPI enum & enum values > 4. Move the type macro and PPI enum into a header > 5. Add new enum for SPIs > > Please leave CNTHCL_* as they originally were. It's not part of the > interface of the driver, and leaving them as they are will save us an > interdependency with KVM. > > I'm happy to queue that immediately, as it's purely structural and > shouldn't have a functional impact anywhere. That will also shrink the > series a bit, and we can rebase the following patches atop of that. Thanks for your suggestion, I have finished this improvement. It will be in v20. https://git.linaro.org/people/fu.wei/linux.git/log/?h=topic-gtdt-wakeup-timer_upstream_v20_devel > >> 5. Rework PPI determination; >> 6. Rework counter frequency detection; >> 7. Refactor arch_timer_needs_probing, move it into DT init call >> 8. Introduce some new structs and refactor the MMIO timer init code >> for reusing some common code. > > I'll review these in separate replies. > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751155AbdAQJWF (ORCPT ); Tue, 17 Jan 2017 04:22:05 -0500 Received: from mail-it0-f48.google.com ([209.85.214.48]:33633 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbdAQJVv (ORCPT ); Tue, 17 Jan 2017 04:21:51 -0500 MIME-Version: 1.0 In-Reply-To: <20170116170010.GH5908@leverpostej> References: <20161221064603.11830-1-fu.wei@linaro.org> <20170116170010.GH5908@leverpostej> From: Fu Wei Date: Tue, 17 Jan 2017 17:14:31 +0800 Message-ID: Subject: Re: [PATCH v19 00/15] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer To: Mark Rutland Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Lorenzo Pieralisi , Sudeep Holla , Hanjun Guo , linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , Wei Huang , Arnd Bergmann , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , Leo Duran , Wim Van Sebroeck , Guenter Roeck , linux-watchdog@vger.kernel.org, Tomasz Nowicki , Christoffer Dall , Julien Grall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 17 January 2017 at 01:00, Mark Rutland wrote: > Hi, > > On Wed, Dec 21, 2016 at 02:45:48PM +0800, fu.wei@linaro.org wrote: >> From: Fu Wei >> >> This patchset: >> (1)Preparation for adding GTDT support in arm_arch_timer: >> 1. Move some enums and marcos to header file; >> 2. Add a new enum for spi type; >> 3. Improve printk relevant code; >> 4. Rename some enums and defines; > > Can we please rework these first few patches into a series: > > 1. Clean up printk() usage > 2. Rename the type macros > 3. Rename the PPI enum & enum values > 4. Move the type macro and PPI enum into a header > 5. Add new enum for SPIs > > Please leave CNTHCL_* as they originally were. It's not part of the > interface of the driver, and leaving them as they are will save us an > interdependency with KVM. > > I'm happy to queue that immediately, as it's purely structural and > shouldn't have a functional impact anywhere. That will also shrink the > series a bit, and we can rebase the following patches atop of that. Thanks for your suggestion, I have finished this improvement. It will be in v20. https://git.linaro.org/people/fu.wei/linux.git/log/?h=topic-gtdt-wakeup-timer_upstream_v20_devel > >> 5. Rework PPI determination; >> 6. Rework counter frequency detection; >> 7. Refactor arch_timer_needs_probing, move it into DT init call >> 8. Introduce some new structs and refactor the MMIO timer init code >> for reusing some common code. > > I'll review these in separate replies. > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 From: fu.wei@linaro.org (Fu Wei) Date: Tue, 17 Jan 2017 17:14:31 +0800 Subject: [PATCH v19 00/15] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer In-Reply-To: <20170116170010.GH5908@leverpostej> References: <20161221064603.11830-1-fu.wei@linaro.org> <20170116170010.GH5908@leverpostej> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, On 17 January 2017 at 01:00, Mark Rutland wrote: > Hi, > > On Wed, Dec 21, 2016 at 02:45:48PM +0800, fu.wei at linaro.org wrote: >> From: Fu Wei >> >> This patchset: >> (1)Preparation for adding GTDT support in arm_arch_timer: >> 1. Move some enums and marcos to header file; >> 2. Add a new enum for spi type; >> 3. Improve printk relevant code; >> 4. Rename some enums and defines; > > Can we please rework these first few patches into a series: > > 1. Clean up printk() usage > 2. Rename the type macros > 3. Rename the PPI enum & enum values > 4. Move the type macro and PPI enum into a header > 5. Add new enum for SPIs > > Please leave CNTHCL_* as they originally were. It's not part of the > interface of the driver, and leaving them as they are will save us an > interdependency with KVM. > > I'm happy to queue that immediately, as it's purely structural and > shouldn't have a functional impact anywhere. That will also shrink the > series a bit, and we can rebase the following patches atop of that. Thanks for your suggestion, I have finished this improvement. It will be in v20. https://git.linaro.org/people/fu.wei/linux.git/log/?h=topic-gtdt-wakeup-timer_upstream_v20_devel > >> 5. Rework PPI determination; >> 6. Rework counter frequency detection; >> 7. Refactor arch_timer_needs_probing, move it into DT init call >> 8. Introduce some new structs and refactor the MMIO timer init code >> for reusing some common code. > > I'll review these in separate replies. > > Thanks, > Mark. -- Best regards, Fu Wei Software Engineer Red Hat