From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI support code. Date: Tue, 13 Sep 2016 17:22:42 +0800 Message-ID: References: <1473168352-5156-1-git-send-email-fu.wei@linaro.org> <1473168352-5156-6-git-send-email-fu.wei@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-oi0-f50.google.com ([209.85.218.50]:35246 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756709AbcIMJWn (ORCPT ); Tue, 13 Sep 2016 05:22:43 -0400 Received: by mail-oi0-f50.google.com with SMTP id w11so1019542oia.2 for ; Tue, 13 Sep 2016 02:22:43 -0700 (PDT) In-Reply-To: Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Thomas Gleixner , Daniel Lezcano Cc: "Rafael J. Wysocki" , Len Brown , Marc Zyngier , Lorenzo Pieralisi , Sudeep Holla , Hanjun Guo , linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , Wei Huang , Arnd Bergmann , Wim Van Sebroeck Hi Thomas, Daniel, For these arm_arch_timer patches, do you have any other suggestion or comm= ent? I have deleted "skipping" in the error message. I have prepared v12 (rebase to rc6 and on the top of IORT v11), should I send it now (if you are OK with my arm_arch_timer patches ), or anything I can do to improve this patchset ? Thanks. On 7 September 2016 at 17:23, Fu Wei wrote: > Hi Thomas > > On 6 September 2016 at 22:36, Thomas Gleixner wrote: >> On Tue, 6 Sep 2016, fu.wei@linaro.org wrote: >>> + if (timer_count < 0) >>> + pr_err("Failed to get platform timer info, skipping.\n"); >> >> So this prints something about skipping. But then it continues as if >> nothing went wrong. That's either wrong or confusing or both. > > yes, you are right, this info is confusing. > maybe we just delete the "skipping" ? > > =E2=80=9Ctimer_count < 0=E2=80=9D is caused by some firmware bug, in gtdt= .c: > ---- > int __init acpi_gtdt_init(struct acpi_table_header *table) > { > ...... > if (start < (void *)table + sizeof(struct acpi_table_gtdt)) { > pr_err(FW_BUG "Failed to retrieve timer info from firmware: > invalid data.\n"); > return -EINVAL; > ...... > } > ---- > > But in this situation( without platform timers ), system still can work. > So I thing we just need to print a error. > >> >>> - arch_timer_init(); >>> - return 0; >>> + return arch_timer_init(); >> >> Thanks, >> >> tglx > > > > -- > Best regards, > > Fu Wei > Software Engineer > Red Hat --=20 Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757525AbcIMJWq (ORCPT ); Tue, 13 Sep 2016 05:22:46 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:33557 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756361AbcIMJWn (ORCPT ); Tue, 13 Sep 2016 05:22:43 -0400 MIME-Version: 1.0 In-Reply-To: References: <1473168352-5156-1-git-send-email-fu.wei@linaro.org> <1473168352-5156-6-git-send-email-fu.wei@linaro.org> From: Fu Wei Date: Tue, 13 Sep 2016 17:22:42 +0800 Message-ID: Subject: Re: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI support code. To: Thomas Gleixner , Daniel Lezcano Cc: "Rafael J. Wysocki" , Len Brown , Marc Zyngier , Lorenzo Pieralisi , Sudeep Holla , Hanjun Guo , linux-arm-kernel@lists.infradead.org, Linaro ACPI Mailman List , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, "Abdulhamid, Harb" , Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , Wei Huang , Arnd Bergmann , Wim Van Sebroeck , Catalin Marinas , Will Deacon , Suravee Suthikulpanit , Leo Duran , Guenter Roeck , linux-watchdog@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8D9NCvS021650 Hi Thomas, Daniel, For these arm_arch_timer patches, do you have any other suggestion or comment? I have deleted "skipping" in the error message. I have prepared v12 (rebase to rc6 and on the top of IORT v11), should I send it now (if you are OK with my arm_arch_timer patches ), or anything I can do to improve this patchset ? Thanks. On 7 September 2016 at 17:23, Fu Wei wrote: > Hi Thomas > > On 6 September 2016 at 22:36, Thomas Gleixner wrote: >> On Tue, 6 Sep 2016, fu.wei@linaro.org wrote: >>> + if (timer_count < 0) >>> + pr_err("Failed to get platform timer info, skipping.\n"); >> >> So this prints something about skipping. But then it continues as if >> nothing went wrong. That's either wrong or confusing or both. > > yes, you are right, this info is confusing. > maybe we just delete the "skipping" ? > > “timer_count < 0” is caused by some firmware bug, in gtdt.c: > ---- > int __init acpi_gtdt_init(struct acpi_table_header *table) > { > ...... > if (start < (void *)table + sizeof(struct acpi_table_gtdt)) { > pr_err(FW_BUG "Failed to retrieve timer info from firmware: > invalid data.\n"); > return -EINVAL; > ...... > } > ---- > > But in this situation( without platform timers ), system still can work. > So I thing we just need to print a error. > >> >>> - arch_timer_init(); >>> - return 0; >>> + return arch_timer_init(); >> >> Thanks, >> >> tglx > > > > -- > Best regards, > > Fu Wei > Software Engineer > Red Hat -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 From: fu.wei@linaro.org (Fu Wei) Date: Tue, 13 Sep 2016 17:22:42 +0800 Subject: [PATCH v11 5/8] clocksource/drivers/arm_arch_timer: Simplify ACPI support code. In-Reply-To: References: <1473168352-5156-1-git-send-email-fu.wei@linaro.org> <1473168352-5156-6-git-send-email-fu.wei@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Thomas, Daniel, For these arm_arch_timer patches, do you have any other suggestion or comment? I have deleted "skipping" in the error message. I have prepared v12 (rebase to rc6 and on the top of IORT v11), should I send it now (if you are OK with my arm_arch_timer patches ), or anything I can do to improve this patchset ? Thanks. On 7 September 2016 at 17:23, Fu Wei wrote: > Hi Thomas > > On 6 September 2016 at 22:36, Thomas Gleixner wrote: >> On Tue, 6 Sep 2016, fu.wei at linaro.org wrote: >>> + if (timer_count < 0) >>> + pr_err("Failed to get platform timer info, skipping.\n"); >> >> So this prints something about skipping. But then it continues as if >> nothing went wrong. That's either wrong or confusing or both. > > yes, you are right, this info is confusing. > maybe we just delete the "skipping" ? > > ?timer_count < 0? is caused by some firmware bug, in gtdt.c: > ---- > int __init acpi_gtdt_init(struct acpi_table_header *table) > { > ...... > if (start < (void *)table + sizeof(struct acpi_table_gtdt)) { > pr_err(FW_BUG "Failed to retrieve timer info from firmware: > invalid data.\n"); > return -EINVAL; > ...... > } > ---- > > But in this situation( without platform timers ), system still can work. > So I thing we just need to print a error. > >> >>> - arch_timer_init(); >>> - return 0; >>> + return arch_timer_init(); >> >> Thanks, >> >> tglx > > > > -- > Best regards, > > Fu Wei > Software Engineer > Red Hat -- Best regards, Fu Wei Software Engineer Red Hat