From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fu Wei Subject: Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer Date: Thu, 30 Jun 2016 09:29:59 +0800 Message-ID: References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Hanjun Guo , "linux-arm-kernel@lists.infradead.org" , "linaro-acpi@lists.linaro.org" , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, harba@codeaurora.org, Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , wei@redhat.com, Arnd Bergmann , Wim Van Sebroeck , Catalin Marinas , Will Deacon , Suravee List-Id: linux-acpi@vger.kernel.org Hi Rafael, On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: > On Wed, Jun 29, 2016 at 8:15 PM, wrote: >> From: Fu Wei >> >> This patchset: >> (1)Preparation for adding GTDT support in arm_arch_timer >> 1. Move some enums and marcos to header file >> 2. Add a new enum for spi type. >> 3. Improve printk relevant code >> >> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c >> Parse all kinds of timer in GTDT table of ACPI:arch timer, >> memory-mapped timer and SBSA Generic Watchdog timer. >> This driver can help to simplify all the relevant timer drivers, >> and separate all the ACPI GTDT knowledge from them. >> >> (3)Simplify ACPI code for arm_arch_timer >> >> (4)Add GTDT support for ARM memory-mapped timer > > GTDT is ARM-specific AFAICS. yes, you are right, it is. > > If so, why do we need that code to reside in drivers/acpi/ ? Although the GTDT is just for ARM64, but this driver is parsing one of ACPI table, I think that could be treated as ACPI driver. Do I miss something? :-) > > Thanks, > Rafael -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752299AbcF3BaG (ORCPT ); Wed, 29 Jun 2016 21:30:06 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:33019 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbcF3BaB (ORCPT ); Wed, 29 Jun 2016 21:30:01 -0400 MIME-Version: 1.0 In-Reply-To: References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> From: Fu Wei Date: Thu, 30 Jun 2016 09:29:59 +0800 Message-ID: Subject: Re: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer To: "Rafael J. Wysocki" Cc: "Rafael J. Wysocki" , Len Brown , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Hanjun Guo , "linux-arm-kernel@lists.infradead.org" , "linaro-acpi@lists.linaro.org" , Linux Kernel Mailing List , ACPI Devel Maling List , rruigrok@codeaurora.org, harba@codeaurora.org, Christopher Covington , Timur Tabi , G Gregory , Al Stone , Jon Masters , wei@redhat.com, Arnd Bergmann , Wim Van Sebroeck , Catalin Marinas , Will Deacon , Suravee Suthikulanit , Leo Duran Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rafael, On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: > On Wed, Jun 29, 2016 at 8:15 PM, wrote: >> From: Fu Wei >> >> This patchset: >> (1)Preparation for adding GTDT support in arm_arch_timer >> 1. Move some enums and marcos to header file >> 2. Add a new enum for spi type. >> 3. Improve printk relevant code >> >> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c >> Parse all kinds of timer in GTDT table of ACPI:arch timer, >> memory-mapped timer and SBSA Generic Watchdog timer. >> This driver can help to simplify all the relevant timer drivers, >> and separate all the ACPI GTDT knowledge from them. >> >> (3)Simplify ACPI code for arm_arch_timer >> >> (4)Add GTDT support for ARM memory-mapped timer > > GTDT is ARM-specific AFAICS. yes, you are right, it is. > > If so, why do we need that code to reside in drivers/acpi/ ? Although the GTDT is just for ARM64, but this driver is parsing one of ACPI table, I think that could be treated as ACPI driver. Do I miss something? :-) > > Thanks, > Rafael -- Best regards, Fu Wei Software Engineer Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 From: fu.wei@linaro.org (Fu Wei) Date: Thu, 30 Jun 2016 09:29:59 +0800 Subject: [PATCH v6 00/10] acpi, clocksource: add GTDT driver and GTDT support in arm_arch_timer In-Reply-To: References: <1467224153-22873-1-git-send-email-fu.wei@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rafael, On 30 June 2016 at 05:32, Rafael J. Wysocki wrote: > On Wed, Jun 29, 2016 at 8:15 PM, wrote: >> From: Fu Wei >> >> This patchset: >> (1)Preparation for adding GTDT support in arm_arch_timer >> 1. Move some enums and marcos to header file >> 2. Add a new enum for spi type. >> 3. Improve printk relevant code >> >> (2)Introduce ACPI GTDT parser: drivers/acpi/gtdt.c >> Parse all kinds of timer in GTDT table of ACPI:arch timer, >> memory-mapped timer and SBSA Generic Watchdog timer. >> This driver can help to simplify all the relevant timer drivers, >> and separate all the ACPI GTDT knowledge from them. >> >> (3)Simplify ACPI code for arm_arch_timer >> >> (4)Add GTDT support for ARM memory-mapped timer > > GTDT is ARM-specific AFAICS. yes, you are right, it is. > > If so, why do we need that code to reside in drivers/acpi/ ? Although the GTDT is just for ARM64, but this driver is parsing one of ACPI table, I think that could be treated as ACPI driver. Do I miss something? :-) > > Thanks, > Rafael -- Best regards, Fu Wei Software Engineer Red Hat