From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f170.google.com ([209.85.208.170]:32911 "EHLO mail-lj1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726359AbeLNDfN (ORCPT ); Thu, 13 Dec 2018 22:35:13 -0500 Received: by mail-lj1-f170.google.com with SMTP id v1-v6so3707119ljd.0 for ; Thu, 13 Dec 2018 19:35:12 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20181213213921.GG6311@dastard> References: <20181210165020.GT24487@magnolia> <20181210174627.GD8356@bfoster> <20181210214115.GC6311@dastard> <20181211122701.GA2819@bfoster> <20181213035352.GF6311@dastard> <20181213213921.GG6311@dastard> From: Nick Bowler Date: Thu, 13 Dec 2018 22:35:09 -0500 Message-ID: Subject: Re: Enlarging w/ xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Inappropriate ioctl for device Content-Type: text/plain; charset="UTF-8" Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dave Chinner Cc: Brian Foster , "Darrick J. Wong" , linux-xfs@vger.kernel.org On 12/13/18, Dave Chinner wrote: > That test automates the generation of the test code and output, > and if it changes from the golden output, then the test fails. > I'd suggest that a similar thing is done here for /all/ the > structures we expose in ioctls. > > FWIW, pahole can make this easy. e.g you can harvest every ioctl > structure from xfs_fs.h, OK, I did just that, by snarfing up the preprocessor output from #including "xfs/xfs_fs.h" and searching for 'struct'. The pahole tool was previously unknown to me. I like it. One thing I'll note is that it does not appear to be possible to use pahole to get information about structs that don't have a tag. The xfs_fsid_t typedef is such a type. Fortunately that one does not look like a problem! Cheers, Nick