Re: [dpdk-dev] [PATCH] net/bnxt: fix initialization of filter struct

From: Lance Richardson <lance.richardson@broadcom.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dev@dpdk.org, dpdk stable <stable@dpdk.org>,
	 Kalesh Anakkur Purayil <kalesh-anakkur.purayil@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix initialization of filter struct
Date: Thu, 29 Apr 2021 09:59:00 -0400	[thread overview]
Message-ID: <CADyeNECxSjrrM5kK4UAve3+Gu_stHadZNwpvmeo5tkf9nC4C6w@mail.gmail.com> (raw)
In-Reply-To: <CADyeNEA+FeASZoMXVOpCnZ4KpwHksjUc1ypTZ-ZV-gBgKmLBTg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]

On Thu, Apr 29, 2021 at 9:43 AM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> On Wed, Apr 28, 2021 at 6:04 PM Lance Richardson
> <lance.richardson@broadcom.com> wrote:
> >
> > Initialize filter structure to all zeroes on allocation.
> >
> > Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
> > Cc: stable@dpdk.org
> > Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> > Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> > ---
> >  drivers/net/bnxt/bnxt_filter.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/bnxt/bnxt_filter.c b/drivers/net/bnxt/bnxt_filter.c
> > index 1d08e03b2f..6aadfa9526 100644
> > --- a/drivers/net/bnxt/bnxt_filter.c
> > +++ b/drivers/net/bnxt/bnxt_filter.c
> > @@ -188,6 +188,7 @@ struct bnxt_filter_info *bnxt_get_unused_filter(struct bnxt *bp)
> >                 return NULL;
> >         }
> >         STAILQ_REMOVE_HEAD(&bp->free_filter_list, next);
> > +       memset(filter, 0, sizeof(*filter));
> >
> >         return filter;
> >  }
> > --
> > 2.25.1
> >
> Self-NAK, will send a v2 shortly.

Let's drop this patch, this is already fixed in upstream via
commit 7105de7085b0 ("net/bnxt: reset filter indices on free"),
but that commit should be applied to -stable branches.