From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DFCEC6379F for ; Tue, 17 Nov 2020 09:55:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5725F2168B for ; Tue, 17 Nov 2020 09:55:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CzawzkGY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727729AbgKQJzL (ORCPT ); Tue, 17 Nov 2020 04:55:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727724AbgKQJzK (ORCPT ); Tue, 17 Nov 2020 04:55:10 -0500 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B29DCC0613CF; Tue, 17 Nov 2020 01:55:10 -0800 (PST) Received: by mail-oi1-x241.google.com with SMTP id t16so21923434oie.11; Tue, 17 Nov 2020 01:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=g6cFr1GWe/3eh4NUqXWAinlK5cgfPVLY2u3q3tSx53o=; b=CzawzkGYSM3k6pL0T1hbwyHjk6lf4OIJYruDp2QL9npIt9xSBOSoriYK+lZN9iL+1X Rcg9c8kQYukPpCN7TI/x193Dnvx9ojNTqpQD9pRj/8HF9pLMqS+OHXMcCkLl9uqVDXOg +dpwSRi5RPt+5kwajoY5fEgEg6mIUXRavCobmMSmukmp+kmUagl1I+8xeqZCMAm2dOKj 5GapsgPY+wOutrJEWvwAD9zyseIihpDzWEpMAAonb1aiZ8MVdJRJOZdKhxs/Q7I5VokN eAVT1dU8mjcSJsiklHSwc26Qpa+BWC/Hdg3gS1B8COd1jgrAbqvhKWTj+NzoaSwfKFSJ /C8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=g6cFr1GWe/3eh4NUqXWAinlK5cgfPVLY2u3q3tSx53o=; b=AbUlJZPlCQqjuwh8j+YjzFrFuivBjD5/uGpOQI4OPWbflbQ9ZGAMxkreyys97ulHqM KDhWOaBPNv15HeIzJmqqS8Ikk44TBB3c9O62m6FzG7NqnrGam+rwNlJvQSD3fIJtoheK 1d+eIOsJmN+sNjLZv86mhWbt7Lg2cfjhvgSeBd8ZHVzdLAyacrugIQ1w1wsF/4MTworJ bLQxw8lYZy+2HDdrWVrZ+tsgT9NPgkzTlvw9LieRorJqOpE57PrFeg+rXTfxSdKGO8A8 d0gQpGMxoM0EtdqPRrpN3P7YA4mHoUJNpDA6JyhwuAtXDuOgWLfGEg2UzvsAe/+/9EuT zmtw== X-Gm-Message-State: AOAM5325/E6iPrcgvN/cRJnmaDYApXHuUIKR71Ie25A0ubtq+i37xRN/ z5sb+tmD1SggmlEIN+rfZINsvMSS0rJ4GCLnOOs= X-Google-Smtp-Source: ABdhPJya8F6HqaXOxv32vLbvDlmGZZUV8Q00KUBZXfRPq3qbh5S+PA3y0CdQ8g7uWdODqTVA4V0Epe3FABZHNroWpjk= X-Received: by 2002:aca:4783:: with SMTP id u125mr1917664oia.23.1605606909920; Tue, 17 Nov 2020 01:55:09 -0800 (PST) MIME-Version: 1.0 References: <1602034966-3524-1-git-send-email-gene.chen.richtek@gmail.com> <1602034966-3524-3-git-send-email-gene.chen.richtek@gmail.com> <5a9b31c4-739c-06fc-2015-ed474993ad22@gmail.com> <8925db23-5cc4-3c5f-932a-461fe6450dad@gmail.com> <1bb76c54-14af-6c78-4623-77c6678b262e@gmail.com> In-Reply-To: From: Gene Chen Date: Tue, 17 Nov 2020 17:54:58 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360 To: Jacek Anaszewski Cc: Pavel Machek , Rob Herring , Matthias Brugger , Dan Murphy , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Gene Chen , Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Jacek Anaszewski =E6=96=BC 2020=E5=B9=B411=E6= =9C=8817=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8A=E5=8D=882:25=E5=AF=AB=E9=81= =93=EF=BC=9A > > On 11/16/20 11:01 AM, Gene Chen wrote: > > Jacek Anaszewski =E6=96=BC 2020=E5=B9=B410= =E6=9C=8831=E6=97=A5 =E9=80=B1=E5=85=AD =E4=B8=8A=E5=8D=886:34=E5=AF=AB=E9= =81=93=EF=BC=9A > >> > >> On 10/30/20 9:51 AM, Gene Chen wrote: > >>> Jacek Anaszewski =E6=96=BC 2020=E5=B9=B4= 10=E6=9C=8828=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=881:28=E5=AF=AB= =E9=81=93=EF=BC=9A > >>>> > >>>> On 10/27/20 10:28 AM, Gene Chen wrote: > >>>>> Jacek Anaszewski =E6=96=BC 2020=E5=B9= =B410=E6=9C=8821=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=885:47=E5=AF= =AB=E9=81=93=EF=BC=9A > >>>>>> > >>>>>> On 10/20/20 8:44 AM, Gene Chen wrote: > >>>>>>> Jacek Anaszewski =E6=96=BC 2020=E5= =B9=B410=E6=9C=889=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8A=E5=8D=885:51=E5=AF= =AB=E9=81=93=EF=BC=9A > >>>>>>>> > >>>>>>>> Hi Gene, > >>>>>>>> > >>>>>>>> On 10/7/20 3:42 AM, Gene Chen wrote: > >>>>>>>>> From: Gene Chen > >>>>>>>>> > >>>>>>>>> Add MT6360 LED driver include 2-channel Flash LED with torch/st= robe mode, > >>>>>>>>> 3-channel RGB LED support Register/Flash/Breath Mode, and 1-cha= nnel for > >>>>>>>>> moonlight LED. > >>>>>>>>> > >>>>>>>>> Signed-off-by: Gene Chen > >>>>>>>>> --- > >>>>>>>>> drivers/leds/Kconfig | 12 + > >>>>>>>>> drivers/leds/Makefile | 1 + > >>>>>>>>> drivers/leds/leds-mt6360.c | 783 ++++++++++++++++++++++++= +++++++++++++++++++++ > >>>>>>>>> 3 files changed, 796 insertions(+) > >>>>>>>>> create mode 100644 drivers/leds/leds-mt6360.c > >>>>>>>>> > >>>>>>>>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > >>>>>>>>> index 1c181df..c7192dd 100644 > >>>>>>>>> --- a/drivers/leds/Kconfig > >>>>>>>>> +++ b/drivers/leds/Kconfig > >>>>>>>>> @@ -271,6 +271,18 @@ config LEDS_MT6323 > >>>>>>>>> This option enables support for on-chip LED drivers= found on > >>>>>>>>> Mediatek MT6323 PMIC. > >>>>>>>>> > >>>>>>>>> +config LEDS_MT6360 > >>>>>>>>> + tristate "LED Support for Mediatek MT6360 PMIC" > >>>>>>>>> + depends on LEDS_CLASS_FLASH && OF > >>>>>>>>> + depends on LEDS_CLASS_MULTICOLOR > >>>>>>>> > >>>>>>>> Since CONFIG_LED_CLASS_MULTICOLOR can be turned off you need to = have > >>>>>>>> below instead: > >>>>>>>> > >>>>>>>> depends on LEDS_CLASS_MULTICOLOR || !!LEDS_CLASS_MULTICOLOR > >>>> > >>>> My typo here, should be one "!": > >>>> > >>>> depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR > >>>> > >>>> And you should also have > >>>> > >>>> depends on LEDS_CLASS_FLASH || !LEDS_CLASS_FLASH > >>>> > >>>> But to make it work correctly you would have to add registration > >>>> stubs to include/linux/led-class-flash.h similarly to LED mc stubs > >>>> in include/linux/led-class-multicolor.h. > >>>> > >>>>>>>> > >>>>>>>> Unless you want to prevent enabling the driver without RGB LED, > >>>>>>>> but that does not seem to be reasonable at first glance. > >>>>>>>> > >>>>>>> > >>>>>>> May I change to "select LEDS_CLASS_MULTICOLOR"? > >>>>>>> I suppose RGB always use multicolor mode. > >>>>>> > >>>>>> You will also have moonlight LED that will not need multicolor > >>>>>> framework. Is it somehow troublesome to keep "depends on"? > >>>>>> > >>>>> > >>>>> If only use ML LED and FLED, DTSI will only define ML LED and FLED= . > >>>>> Therefore, the drivers probe will not register rgb multicolor devic= e. > >>>> > >>>> Please test your use case again with my fixed "depends on". > >>>> > >>>> In case when there is only ML LED and FLED in the DT it should > >>>> register both devices if LEDS_CLASS_FLASH is turned on. > >>>> Multicolor framework has nothing to do in this case. > >>>> > >>>> But if you additionally had MC LED node, then it should > >>>> be registered only if LEDS_CLASS_MULTICOLOR is enabled. > >>>> > >>>> Similarly, when FLED node is present, but LEDS_CLASS_FLASH > >>>> is off, and LEDS_CLASS_MULTICOLOR is on, the driver should still > >>>> compile, but register only LED MC device (if its node is present). > >>>> > >>> > >>> I think this case only register LED device, not LED "MC" device. > >>> Because our FLASH is not a multicolor device. > >> > >> No, here I was describing following setup: > >> > >> - DT FLED node is present, CONFIG_LEDS_CLASS_FLASH is off > >> - DT MC node is present, CONFIG_LEDS_CLASS_MULTICOLOR is on > >> > >> ML LED presence in DT is irrelevant in this case. > >> It should be always registered if there is corresponding DT node > >> and LEDS_CLASS is on. > >> > > > > As a long time discussion, we conclude some rules about MT6360 LED driv= er. > > FLED is necessary, so Kconfig depends on LED_CLASS_FLASH > > Maybe it is necessary in your use case, but probably it is possible to > use the device without FLED. If so, then you should allow users > disabling it. Therefore you should have: > > depends on LEDS_CLASS_FLASH || !LEDS_CLASS_FLASH > ACK > > ML LED is optional, which is registered as led class device. > > RGB LED can be either simple led class device or multicolor device, > > which is decided in DT node > > If Multicolor LED DT node is exist, it should be register multicolor > > device success. > > But only if CONFIG_LEDS_CLASS_MULTICOLOR is enabled. > > > Maybe it is more specific to send a new patch? > > > > Sample DT as below > > LED "red" is simple led class device, LED "green&blue" is multicolor de= vices. > > led@0 { > > reg =3D <0>; > > function =3D LED_FUNCTION_INDICATOR; > > color =3D ; > > led-max-microamp =3D <24000>; > > }; > > led@6 { > > reg =3D <6>; > > function =3D LED_FUNCTION_INDICATOR; > > color =3D ; > > > > led@1 { > > reg =3D <1>; > > function =3D LED_FUNCTION_INDICATOR; > > color =3D ; > > led-max-microamp =3D <24000>; > > }; > > led@2 { > > reg =3D <2>; > > function =3D LED_FUNCTION_INDICATOR; > > color =3D ; > > led-max-microamp =3D <24000>; > > }; > > }; > > It looks OK. > > >>>> Possible should be also the case when both LEDS_CLASS_FLASH > >>>> and LEDS_CLASS_MULTICOLOR are off. Then only LED class device > >>>> for ML LED will be registered (provided there is ML DT node). > >>>> But to make it possible you should have also "depends on LEDS_CLASS" > >>>> in the Kconfig entry. > >>>> > >>> > >>> According to your suggestion, > >>> depends on LED_CLASS && LEDS_CLASS_FLASH && OF > >> > >> s/LED_CLASS/LEDS_CLASS/ > >> > >> And you have to remove LEDS_CLASS_FLASH from above line. > >> > >>> depends on LEDS_CLASS_MULTICOLOR || !!LEDS_CLASS_MULTICOLOR > >> > >> s/!!LEDS_CLASS_MULTICOLOR/!LEDS_CLASS_MULTICOLOR/ > >> > >>> depends on LEDS_CLASS_FLASH || !LEDS_CLASS_FLASH > >>> depends on MFD_MT6360 > >> > >> You will need V4L2_FLASH_LED_CLASS dependency as well, to avoid > >> build break, when it is set to 'm'. > >> > >> To recap, following block of dependencies is required: > >> > >> depends on LEDS_CLASS && OF > >> depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR > >> depends on LEDS_CLASS_FLASH || !LEDS_CLASS_FLASH > >> depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS > >> depends on MFD_MT6360 > >> > > > > LEDS_MT6360 depends on LEDS_CLASS_FLASH, and LEDS_CLASS_FLASH depends > > on LEDS_CLASS > > Is "depends on LEDS_CLASS" still needed? > > Yes, because you should allow disabling CONFIG_LEDS_CLASS_FLASH. > In such a case driver should still compile and register ML LED class > device when it has corresponding DT node. > ACK > >>> and source code add constraint > >>> > >>> #if IS_ENABLED(CONFIG_LEDS_CLASS_MULTICOLOR) > >>> ret =3D devm_led_classdev_multicolor_register_ext(parent, &led-= >rgb, > >>> init_data); > >>> #endif > >>> > >>> #if IS_ENABLED(CONFIG_LEDS_CLASS_FLASH) > >>> ret =3D devm_led_classdev_flash_register_ext(parent, &led->flas= h, init_data); > >>> #endif > >> > >> No, the guards should be in headers. That's why I recommended adding > >> no ops for LED flash class registration functions in previous email. > >> > >> Please compare include/linux/led-class-multicolor.h and do similar > >> changes in include/linux/led-class-flash.h. > >> > > > > ACK, I will submit a fixed patch about leds-class-flash.h. > > > > By the way, if CONFIG_LED_CLASS_MULTICOLOR is not enabled and we don't > > use #if IS_ENABLED, > > according to led-class-multicolor.h return -EINVAL, > > we will register multicolor device fail and cause probe fail. > > Good point. So led-class-multicolor.h no-ops need to be fixed to return > 0 instead of -EINVAL. > > And no-ops in include/linux/led-class-flash.h should also return 0. DT node is first priority to decide how leds work. If RGB LED use multicolor form in DT, CONFIG_LEDS_CLASS_FLASH should be def= ined. Otherwise It is right action to probe fail. > > -- > Best regards, > Jacek Anaszewski From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D730AC2D0E4 for ; Tue, 17 Nov 2020 09:55:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4155B2464E for ; Tue, 17 Nov 2020 09:55:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YcHc2BR3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CzawzkGY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4155B2464E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u4lvEha/TIkyrJwfeAwu6C9s9m04P2Goi8eAE7CbToQ=; b=YcHc2BR3iG6j16BNzIa0UPJoa riGujXwZZNcfQUNtVefLh7l+wBNRQPGygkSn8zGadWeynv4tDuq9htk+oPQxRTlNME8H5gVk443/i J96WCmPQzSTEW/Ydx3Sb4PKez9foj0LhU/d37uU/LfWWemoEnE2paiAjGErvQ8X2bxOPbkpmP5z2Y zMTKY5N7c6JOl1ymJEwp2wkaPoREOm+SnGiyFmKnNposg61QbTz5YU4qO/IDvllQaMKr1y3Vek3qy NIR4rB8GiDMdgd8L6Lza9ddxAyuISiZ4r/Dc/EdFXi43GQYwNWUKvl/i4zwDBU24eoLl7mMqsJ0vv 3mf/B/ltA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kexhn-0003QK-JS; Tue, 17 Nov 2020 09:55:19 +0000 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kexhj-0003Ok-03; Tue, 17 Nov 2020 09:55:16 +0000 Received: by mail-oi1-x242.google.com with SMTP id l206so886357oif.12; Tue, 17 Nov 2020 01:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=g6cFr1GWe/3eh4NUqXWAinlK5cgfPVLY2u3q3tSx53o=; b=CzawzkGYSM3k6pL0T1hbwyHjk6lf4OIJYruDp2QL9npIt9xSBOSoriYK+lZN9iL+1X Rcg9c8kQYukPpCN7TI/x193Dnvx9ojNTqpQD9pRj/8HF9pLMqS+OHXMcCkLl9uqVDXOg +dpwSRi5RPt+5kwajoY5fEgEg6mIUXRavCobmMSmukmp+kmUagl1I+8xeqZCMAm2dOKj 5GapsgPY+wOutrJEWvwAD9zyseIihpDzWEpMAAonb1aiZ8MVdJRJOZdKhxs/Q7I5VokN eAVT1dU8mjcSJsiklHSwc26Qpa+BWC/Hdg3gS1B8COd1jgrAbqvhKWTj+NzoaSwfKFSJ /C8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=g6cFr1GWe/3eh4NUqXWAinlK5cgfPVLY2u3q3tSx53o=; b=kjVpQitzUMu5QrGo0pPeizi67bzGt9SxC8Wbf1Kb9VJBeVtF8wwB/EeqHimXVU3TJ7 iJz35hoAINQ9gL6UiHQ1S8Nrqs/f6m/R2c1rNPXRtvBA58v8TY8tldE0eY5cV+wbFmi6 ZIYwp/kaCZlHz53iAnn6z+vpDukfpYybxKbptJFb3+qdL0dzi7pr3fTm7loeNWOwTtGQ VK1OfAhKUbAKrTMuP9BPTK3/KLhwQ9JCbVFxa9lsFYjkc214X/VW7uunKSfHEj0SCa+P 5GdbeUVyvYMxVpcYGeNaI7z74MtW3wqlJE81/M15X9UArYYqS1O5oBZe2jfQQT86OeeA wxFQ== X-Gm-Message-State: AOAM532s6dIWK5AQLVorZnHweol1KGZTxHj/S4jQNEkipJSHdFlitoKz kIWrlGyu9fhZNEhpTZ1K/ruOTJAHRrsA3fe1wEU= X-Google-Smtp-Source: ABdhPJya8F6HqaXOxv32vLbvDlmGZZUV8Q00KUBZXfRPq3qbh5S+PA3y0CdQ8g7uWdODqTVA4V0Epe3FABZHNroWpjk= X-Received: by 2002:aca:4783:: with SMTP id u125mr1917664oia.23.1605606909920; Tue, 17 Nov 2020 01:55:09 -0800 (PST) MIME-Version: 1.0 References: <1602034966-3524-1-git-send-email-gene.chen.richtek@gmail.com> <1602034966-3524-3-git-send-email-gene.chen.richtek@gmail.com> <5a9b31c4-739c-06fc-2015-ed474993ad22@gmail.com> <8925db23-5cc4-3c5f-932a-461fe6450dad@gmail.com> <1bb76c54-14af-6c78-4623-77c6678b262e@gmail.com> In-Reply-To: From: Gene Chen Date: Tue, 17 Nov 2020 17:54:58 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360 To: Jacek Anaszewski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_045515_119218_F9C5F5F4 X-CRM114-Status: GOOD ( 45.16 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm Mailing List , devicetree , cy_huang@richtek.com, Linux Kernel Mailing List , Gene Chen , benjamin.chao@mediatek.com, Rob Herring , "moderated list:ARM/Mediatek SoC support" , Dan Murphy , Pavel Machek , Matthias Brugger , Wilma.Wu@mediatek.com, Linux LED Subsystem , shufan_lee@richtek.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SmFjZWsgQW5hc3pld3NraSA8amFjZWsuYW5hc3pld3NraUBnbWFpbC5jb20+IOaWvCAyMDIw5bm0 MTHmnIgxN+aXpSDpgLHkuowg5LiK5Y2IMjoyNeWvq+mBk++8mgo+Cj4gT24gMTEvMTYvMjAgMTE6 MDEgQU0sIEdlbmUgQ2hlbiB3cm90ZToKPiA+IEphY2VrIEFuYXN6ZXdza2kgPGphY2VrLmFuYXN6 ZXdza2lAZ21haWwuY29tPiDmlrwgMjAyMOW5tDEw5pyIMzHml6Ug6YCx5YWtIOS4iuWNiDY6MzTl r6vpgZPvvJoKPiA+Pgo+ID4+IE9uIDEwLzMwLzIwIDk6NTEgQU0sIEdlbmUgQ2hlbiB3cm90ZToK PiA+Pj4gSmFjZWsgQW5hc3pld3NraSA8amFjZWsuYW5hc3pld3NraUBnbWFpbC5jb20+IOaWvCAy MDIw5bm0MTDmnIgyOOaXpSDpgLHkuIkg5LiK5Y2IMToyOOWvq+mBk++8mgo+ID4+Pj4KPiA+Pj4+ IE9uIDEwLzI3LzIwIDEwOjI4IEFNLCBHZW5lIENoZW4gd3JvdGU6Cj4gPj4+Pj4gSmFjZWsgQW5h c3pld3NraSA8amFjZWsuYW5hc3pld3NraUBnbWFpbC5jb20+IOaWvCAyMDIw5bm0MTDmnIgyMeaX pSDpgLHkuIkg5LiK5Y2INTo0N+Wvq+mBk++8mgo+ID4+Pj4+Pgo+ID4+Pj4+PiBPbiAxMC8yMC8y MCA4OjQ0IEFNLCBHZW5lIENoZW4gd3JvdGU6Cj4gPj4+Pj4+PiBKYWNlayBBbmFzemV3c2tpIDxq YWNlay5hbmFzemV3c2tpQGdtYWlsLmNvbT4g5pa8IDIwMjDlubQxMOaciDnml6Ug6YCx5LqUIOS4 iuWNiDU6NTHlr6vpgZPvvJoKPiA+Pj4+Pj4+Pgo+ID4+Pj4+Pj4+IEhpIEdlbmUsCj4gPj4+Pj4+ Pj4KPiA+Pj4+Pj4+PiBPbiAxMC83LzIwIDM6NDIgQU0sIEdlbmUgQ2hlbiB3cm90ZToKPiA+Pj4+ Pj4+Pj4gRnJvbTogR2VuZSBDaGVuIDxnZW5lX2NoZW5AcmljaHRlay5jb20+Cj4gPj4+Pj4+Pj4+ Cj4gPj4+Pj4+Pj4+IEFkZCBNVDYzNjAgTEVEIGRyaXZlciBpbmNsdWRlIDItY2hhbm5lbCBGbGFz aCBMRUQgd2l0aCB0b3JjaC9zdHJvYmUgbW9kZSwKPiA+Pj4+Pj4+Pj4gMy1jaGFubmVsIFJHQiBM RUQgc3VwcG9ydCBSZWdpc3Rlci9GbGFzaC9CcmVhdGggTW9kZSwgYW5kIDEtY2hhbm5lbCBmb3IK PiA+Pj4+Pj4+Pj4gbW9vbmxpZ2h0IExFRC4KPiA+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+Pj4gU2lnbmVk LW9mZi1ieTogR2VuZSBDaGVuIDxnZW5lX2NoZW5AcmljaHRlay5jb20+Cj4gPj4+Pj4+Pj4+IC0t LQo+ID4+Pj4+Pj4+PiAgICAgICBkcml2ZXJzL2xlZHMvS2NvbmZpZyAgICAgICB8ICAxMiArCj4g Pj4+Pj4+Pj4+ICAgICAgIGRyaXZlcnMvbGVkcy9NYWtlZmlsZSAgICAgIHwgICAxICsKPiA+Pj4+ Pj4+Pj4gICAgICAgZHJpdmVycy9sZWRzL2xlZHMtbXQ2MzYwLmMgfCA3ODMgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPj4+Pj4+Pj4+ICAgICAgIDMgZmls ZXMgY2hhbmdlZCwgNzk2IGluc2VydGlvbnMoKykKPiA+Pj4+Pj4+Pj4gICAgICAgY3JlYXRlIG1v ZGUgMTAwNjQ0IGRyaXZlcnMvbGVkcy9sZWRzLW10NjM2MC5jCj4gPj4+Pj4+Pj4+Cj4gPj4+Pj4+ Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2xlZHMvS2NvbmZpZyBiL2RyaXZlcnMvbGVkcy9LY29u ZmlnCj4gPj4+Pj4+Pj4+IGluZGV4IDFjMTgxZGYuLmM3MTkyZGQgMTAwNjQ0Cj4gPj4+Pj4+Pj4+ IC0tLSBhL2RyaXZlcnMvbGVkcy9LY29uZmlnCj4gPj4+Pj4+Pj4+ICsrKyBiL2RyaXZlcnMvbGVk cy9LY29uZmlnCj4gPj4+Pj4+Pj4+IEBAIC0yNzEsNiArMjcxLDE4IEBAIGNvbmZpZyBMRURTX01U NjMyMwo+ID4+Pj4+Pj4+PiAgICAgICAgICAgICBUaGlzIG9wdGlvbiBlbmFibGVzIHN1cHBvcnQg Zm9yIG9uLWNoaXAgTEVEIGRyaXZlcnMgZm91bmQgb24KPiA+Pj4+Pj4+Pj4gICAgICAgICAgICAg TWVkaWF0ZWsgTVQ2MzIzIFBNSUMuCj4gPj4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4+ICtjb25maWcgTEVE U19NVDYzNjAKPiA+Pj4+Pj4+Pj4gKyAgICAgdHJpc3RhdGUgIkxFRCBTdXBwb3J0IGZvciBNZWRp YXRlayBNVDYzNjAgUE1JQyIKPiA+Pj4+Pj4+Pj4gKyAgICAgZGVwZW5kcyBvbiBMRURTX0NMQVNT X0ZMQVNIICYmIE9GCj4gPj4+Pj4+Pj4+ICsgICAgIGRlcGVuZHMgb24gTEVEU19DTEFTU19NVUxU SUNPTE9SCj4gPj4+Pj4+Pj4KPiA+Pj4+Pj4+PiBTaW5jZSBDT05GSUdfTEVEX0NMQVNTX01VTFRJ Q09MT1IgY2FuIGJlIHR1cm5lZCBvZmYgeW91IG5lZWQgdG8gaGF2ZQo+ID4+Pj4+Pj4+IGJlbG93 IGluc3RlYWQ6Cj4gPj4+Pj4+Pj4KPiA+Pj4+Pj4+PiBkZXBlbmRzIG9uIExFRFNfQ0xBU1NfTVVM VElDT0xPUiB8fCAhIUxFRFNfQ0xBU1NfTVVMVElDT0xPUgo+ID4+Pj4KPiA+Pj4+IE15IHR5cG8g aGVyZSwgc2hvdWxkIGJlIG9uZSAiISI6Cj4gPj4+Pgo+ID4+Pj4gZGVwZW5kcyBvbiBMRURTX0NM QVNTX01VTFRJQ09MT1IgfHwgIUxFRFNfQ0xBU1NfTVVMVElDT0xPUgo+ID4+Pj4KPiA+Pj4+IEFu ZCB5b3Ugc2hvdWxkIGFsc28gaGF2ZQo+ID4+Pj4KPiA+Pj4+IGRlcGVuZHMgb24gTEVEU19DTEFT U19GTEFTSCB8fCAhTEVEU19DTEFTU19GTEFTSAo+ID4+Pj4KPiA+Pj4+IEJ1dCB0byBtYWtlIGl0 IHdvcmsgY29ycmVjdGx5IHlvdSB3b3VsZCBoYXZlIHRvIGFkZCByZWdpc3RyYXRpb24KPiA+Pj4+ IHN0dWJzIHRvIGluY2x1ZGUvbGludXgvbGVkLWNsYXNzLWZsYXNoLmggc2ltaWxhcmx5IHRvIExF RCBtYyBzdHVicwo+ID4+Pj4gaW4gaW5jbHVkZS9saW51eC9sZWQtY2xhc3MtbXVsdGljb2xvci5o Lgo+ID4+Pj4KPiA+Pj4+Pj4+Pgo+ID4+Pj4+Pj4+IFVubGVzcyB5b3Ugd2FudCB0byBwcmV2ZW50 IGVuYWJsaW5nIHRoZSBkcml2ZXIgd2l0aG91dCBSR0IgTEVELAo+ID4+Pj4+Pj4+IGJ1dCB0aGF0 IGRvZXMgbm90IHNlZW0gdG8gYmUgcmVhc29uYWJsZSBhdCBmaXJzdCBnbGFuY2UuCj4gPj4+Pj4+ Pj4KPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBNYXkgSSBjaGFuZ2UgdG8gInNlbGVjdCBMRURTX0NMQVNT X01VTFRJQ09MT1IiPwo+ID4+Pj4+Pj4gSSBzdXBwb3NlIFJHQiBhbHdheXMgdXNlIG11bHRpY29s b3IgbW9kZS4KPiA+Pj4+Pj4KPiA+Pj4+Pj4gWW91IHdpbGwgYWxzbyBoYXZlIG1vb25saWdodCBM RUQgdGhhdCB3aWxsIG5vdCBuZWVkIG11bHRpY29sb3IKPiA+Pj4+Pj4gZnJhbWV3b3JrLiBJcyBp dCBzb21laG93IHRyb3VibGVzb21lIHRvIGtlZXAgImRlcGVuZHMgb24iPwo+ID4+Pj4+Pgo+ID4+ Pj4+Cj4gPj4+Pj4gSWYgb25seSB1c2UgTUwgTEVEIGFuZCBGTEVELCAgRFRTSSB3aWxsIG9ubHkg ZGVmaW5lIE1MIExFRCBhbmQgRkxFRC4KPiA+Pj4+PiBUaGVyZWZvcmUsIHRoZSBkcml2ZXJzIHBy b2JlIHdpbGwgbm90IHJlZ2lzdGVyIHJnYiBtdWx0aWNvbG9yIGRldmljZS4KPiA+Pj4+Cj4gPj4+ PiBQbGVhc2UgdGVzdCB5b3VyIHVzZSBjYXNlIGFnYWluIHdpdGggbXkgZml4ZWQgImRlcGVuZHMg b24iLgo+ID4+Pj4KPiA+Pj4+IEluIGNhc2Ugd2hlbiB0aGVyZSBpcyBvbmx5IE1MIExFRCBhbmQg RkxFRCBpbiB0aGUgRFQgaXQgc2hvdWxkCj4gPj4+PiByZWdpc3RlciBib3RoIGRldmljZXMgaWYg TEVEU19DTEFTU19GTEFTSCBpcyB0dXJuZWQgb24uCj4gPj4+PiBNdWx0aWNvbG9yIGZyYW1ld29y ayBoYXMgbm90aGluZyB0byBkbyBpbiB0aGlzIGNhc2UuCj4gPj4+Pgo+ID4+Pj4gQnV0IGlmIHlv dSBhZGRpdGlvbmFsbHkgaGFkIE1DIExFRCBub2RlLCB0aGVuIGl0IHNob3VsZAo+ID4+Pj4gYmUg cmVnaXN0ZXJlZCBvbmx5IGlmIExFRFNfQ0xBU1NfTVVMVElDT0xPUiBpcyBlbmFibGVkLgo+ID4+ Pj4KPiA+Pj4+IFNpbWlsYXJseSwgd2hlbiBGTEVEIG5vZGUgaXMgcHJlc2VudCwgYnV0IExFRFNf Q0xBU1NfRkxBU0gKPiA+Pj4+IGlzIG9mZiwgYW5kIExFRFNfQ0xBU1NfTVVMVElDT0xPUiBpcyBv biwgdGhlIGRyaXZlciBzaG91bGQgc3RpbGwKPiA+Pj4+IGNvbXBpbGUsIGJ1dCByZWdpc3RlciBv bmx5IExFRCBNQyBkZXZpY2UgKGlmIGl0cyBub2RlIGlzIHByZXNlbnQpLgo+ID4+Pj4KPiA+Pj4K PiA+Pj4gSSB0aGluayB0aGlzIGNhc2Ugb25seSByZWdpc3RlciBMRUQgZGV2aWNlLCBub3QgTEVE ICJNQyIgZGV2aWNlLgo+ID4+PiBCZWNhdXNlIG91ciBGTEFTSCBpcyBub3QgYSBtdWx0aWNvbG9y IGRldmljZS4KPiA+Pgo+ID4+IE5vLCBoZXJlIEkgd2FzIGRlc2NyaWJpbmcgZm9sbG93aW5nIHNl dHVwOgo+ID4+Cj4gPj4gLSBEVCBGTEVEIG5vZGUgaXMgcHJlc2VudCwgQ09ORklHX0xFRFNfQ0xB U1NfRkxBU0ggaXMgb2ZmCj4gPj4gLSBEVCBNQyBub2RlIGlzIHByZXNlbnQsIENPTkZJR19MRURT X0NMQVNTX01VTFRJQ09MT1IgaXMgb24KPiA+Pgo+ID4+IE1MIExFRCBwcmVzZW5jZSBpbiBEVCBp cyBpcnJlbGV2YW50IGluIHRoaXMgY2FzZS4KPiA+PiBJdCBzaG91bGQgYmUgYWx3YXlzIHJlZ2lz dGVyZWQgaWYgdGhlcmUgaXMgY29ycmVzcG9uZGluZyBEVCBub2RlCj4gPj4gYW5kIExFRFNfQ0xB U1MgaXMgb24uCj4gPj4KPiA+Cj4gPiBBcyBhIGxvbmcgdGltZSBkaXNjdXNzaW9uLCB3ZSBjb25j bHVkZSBzb21lIHJ1bGVzIGFib3V0IE1UNjM2MCBMRUQgZHJpdmVyLgo+ID4gRkxFRCBpcyBuZWNl c3NhcnksIHNvIEtjb25maWcgZGVwZW5kcyBvbiBMRURfQ0xBU1NfRkxBU0gKPgo+IE1heWJlIGl0 IGlzIG5lY2Vzc2FyeSBpbiB5b3VyIHVzZSBjYXNlLCBidXQgcHJvYmFibHkgaXQgaXMgcG9zc2li bGUgdG8KPiB1c2UgdGhlIGRldmljZSB3aXRob3V0IEZMRUQuIElmIHNvLCB0aGVuIHlvdSBzaG91 bGQgYWxsb3cgdXNlcnMKPiBkaXNhYmxpbmcgaXQuIFRoZXJlZm9yZSB5b3Ugc2hvdWxkIGhhdmU6 Cj4KPiBkZXBlbmRzIG9uIExFRFNfQ0xBU1NfRkxBU0ggfHwgIUxFRFNfQ0xBU1NfRkxBU0gKPgoK QUNLCgo+ID4gTUwgTEVEIGlzIG9wdGlvbmFsLCB3aGljaCBpcyByZWdpc3RlcmVkIGFzIGxlZCBj bGFzcyBkZXZpY2UuCj4gPiBSR0IgTEVEIGNhbiBiZSBlaXRoZXIgc2ltcGxlIGxlZCBjbGFzcyBk ZXZpY2Ugb3IgbXVsdGljb2xvciBkZXZpY2UsCj4gPiB3aGljaCBpcyBkZWNpZGVkIGluIERUIG5v ZGUKPiA+IElmIE11bHRpY29sb3IgTEVEIERUIG5vZGUgaXMgZXhpc3QsIGl0IHNob3VsZCBiZSBy ZWdpc3RlciBtdWx0aWNvbG9yCj4gPiBkZXZpY2Ugc3VjY2Vzcy4KPgo+IEJ1dCBvbmx5IGlmIENP TkZJR19MRURTX0NMQVNTX01VTFRJQ09MT1IgaXMgZW5hYmxlZC4KPgo+ID4gTWF5YmUgaXQgaXMg bW9yZSBzcGVjaWZpYyB0byBzZW5kIGEgbmV3IHBhdGNoPwo+ID4KPiA+IFNhbXBsZSBEVCBhcyBi ZWxvdwo+ID4gTEVEICJyZWQiIGlzIHNpbXBsZSBsZWQgY2xhc3MgZGV2aWNlLCBMRUQgImdyZWVu JmJsdWUiIGlzIG11bHRpY29sb3IgZGV2aWNlcy4KPiA+IGxlZEAwIHsKPiA+ICAgICAgICAgIHJl ZyA9IDwwPjsKPiA+ICAgICAgICAgIGZ1bmN0aW9uID0gTEVEX0ZVTkNUSU9OX0lORElDQVRPUjsK PiA+ICAgICAgICAgIGNvbG9yID0gPExFRF9DT0xPUl9JRF9SRUQ+Owo+ID4gICAgICAgICAgbGVk LW1heC1taWNyb2FtcCA9IDwyNDAwMD47Cj4gPiB9Owo+ID4gbGVkQDYgewo+ID4gICAgICAgICAg cmVnID0gPDY+Owo+ID4gICAgICAgICAgZnVuY3Rpb24gPSBMRURfRlVOQ1RJT05fSU5ESUNBVE9S Owo+ID4gICAgICAgICAgY29sb3IgPSA8TEVEX0NPTE9SX0lEX01VTFRJPjsKPiA+Cj4gPiAgICAg ICAgICBsZWRAMSB7Cj4gPiAgICAgICAgICAgICAgICAgIHJlZyA9IDwxPjsKPiA+ICAgICAgICAg ICAgICAgICAgZnVuY3Rpb24gPSBMRURfRlVOQ1RJT05fSU5ESUNBVE9SOwo+ID4gICAgICAgICAg ICAgICAgICBjb2xvciA9IDxMRURfQ09MT1JfSURfR1JFRU4+Owo+ID4gICAgICAgICAgICAgICAg ICBsZWQtbWF4LW1pY3JvYW1wID0gPDI0MDAwPjsKPiA+ICAgICAgICAgIH07Cj4gPiAgICAgICAg ICBsZWRAMiB7Cj4gPiAgICAgICAgICAgICAgICAgIHJlZyA9IDwyPjsKPiA+ICAgICAgICAgICAg ICAgICAgZnVuY3Rpb24gPSBMRURfRlVOQ1RJT05fSU5ESUNBVE9SOwo+ID4gICAgICAgICAgICAg ICAgICBjb2xvciA9IDxMRURfQ09MT1JfSURfQkxVRT47Cj4gPiAgICAgICAgICAgICAgICAgIGxl ZC1tYXgtbWljcm9hbXAgPSA8MjQwMDA+Owo+ID4gICAgICAgICAgfTsKPiA+IH07Cj4KPiBJdCBs b29rcyBPSy4KPgo+ID4+Pj4gUG9zc2libGUgc2hvdWxkIGJlIGFsc28gdGhlIGNhc2Ugd2hlbiBi b3RoIExFRFNfQ0xBU1NfRkxBU0gKPiA+Pj4+IGFuZCBMRURTX0NMQVNTX01VTFRJQ09MT1IgYXJl IG9mZi4gVGhlbiBvbmx5IExFRCBjbGFzcyBkZXZpY2UKPiA+Pj4+IGZvciBNTCBMRUQgd2lsbCBi ZSByZWdpc3RlcmVkIChwcm92aWRlZCB0aGVyZSBpcyBNTCBEVCBub2RlKS4KPiA+Pj4+IEJ1dCB0 byBtYWtlIGl0IHBvc3NpYmxlIHlvdSBzaG91bGQgaGF2ZSBhbHNvICJkZXBlbmRzIG9uIExFRFNf Q0xBU1MiCj4gPj4+PiBpbiB0aGUgS2NvbmZpZyBlbnRyeS4KPiA+Pj4+Cj4gPj4+Cj4gPj4+IEFj Y29yZGluZyB0byB5b3VyIHN1Z2dlc3Rpb24sCj4gPj4+IGRlcGVuZHMgb24gTEVEX0NMQVNTICYm IExFRFNfQ0xBU1NfRkxBU0ggJiYgT0YKPiA+Pgo+ID4+IHMvTEVEX0NMQVNTL0xFRFNfQ0xBU1Mv Cj4gPj4KPiA+PiBBbmQgeW91IGhhdmUgdG8gcmVtb3ZlIExFRFNfQ0xBU1NfRkxBU0ggZnJvbSBh Ym92ZSBsaW5lLgo+ID4+Cj4gPj4+IGRlcGVuZHMgb24gTEVEU19DTEFTU19NVUxUSUNPTE9SIHx8 ICEhTEVEU19DTEFTU19NVUxUSUNPTE9SCj4gPj4KPiA+PiBzLyEhTEVEU19DTEFTU19NVUxUSUNP TE9SLyFMRURTX0NMQVNTX01VTFRJQ09MT1IvCj4gPj4KPiA+Pj4gZGVwZW5kcyBvbiBMRURTX0NM QVNTX0ZMQVNIIHx8ICFMRURTX0NMQVNTX0ZMQVNICj4gPj4+IGRlcGVuZHMgb24gTUZEX01UNjM2 MAo+ID4+Cj4gPj4gWW91IHdpbGwgbmVlZCBWNEwyX0ZMQVNIX0xFRF9DTEFTUyBkZXBlbmRlbmN5 IGFzIHdlbGwsIHRvIGF2b2lkCj4gPj4gYnVpbGQgYnJlYWssIHdoZW4gaXQgaXMgc2V0IHRvICdt Jy4KPiA+Pgo+ID4+IFRvIHJlY2FwLCBmb2xsb3dpbmcgYmxvY2sgb2YgZGVwZW5kZW5jaWVzIGlz IHJlcXVpcmVkOgo+ID4+Cj4gPj4gZGVwZW5kcyBvbiBMRURTX0NMQVNTICYmIE9GCj4gPj4gZGVw ZW5kcyBvbiBMRURTX0NMQVNTX01VTFRJQ09MT1IgfHwgIUxFRFNfQ0xBU1NfTVVMVElDT0xPUgo+ ID4+IGRlcGVuZHMgb24gTEVEU19DTEFTU19GTEFTSCB8fCAhTEVEU19DTEFTU19GTEFTSAo+ID4+ IGRlcGVuZHMgb24gVjRMMl9GTEFTSF9MRURfQ0xBU1MgfHwgIVY0TDJfRkxBU0hfTEVEX0NMQVNT Cj4gPj4gZGVwZW5kcyBvbiBNRkRfTVQ2MzYwCj4gPj4KPiA+Cj4gPiBMRURTX01UNjM2MCBkZXBl bmRzIG9uIExFRFNfQ0xBU1NfRkxBU0gsIGFuZCBMRURTX0NMQVNTX0ZMQVNIIGRlcGVuZHMKPiA+ IG9uIExFRFNfQ0xBU1MKPiA+IElzICJkZXBlbmRzIG9uIExFRFNfQ0xBU1MiIHN0aWxsIG5lZWRl ZD8KPgo+IFllcywgYmVjYXVzZSB5b3Ugc2hvdWxkIGFsbG93IGRpc2FibGluZyBDT05GSUdfTEVE U19DTEFTU19GTEFTSC4KPiBJbiBzdWNoIGEgY2FzZSBkcml2ZXIgc2hvdWxkIHN0aWxsIGNvbXBp bGUgYW5kIHJlZ2lzdGVyIE1MIExFRCBjbGFzcwo+IGRldmljZSB3aGVuIGl0IGhhcyBjb3JyZXNw b25kaW5nIERUIG5vZGUuCj4KCkFDSwoKPiA+Pj4gYW5kIHNvdXJjZSBjb2RlIGFkZCBjb25zdHJh aW50Cj4gPj4+Cj4gPj4+ICNpZiBJU19FTkFCTEVEKENPTkZJR19MRURTX0NMQVNTX01VTFRJQ09M T1IpCj4gPj4+ICAgICAgIHJldCA9IGRldm1fbGVkX2NsYXNzZGV2X211bHRpY29sb3JfcmVnaXN0 ZXJfZXh0KHBhcmVudCwgJmxlZC0+cmdiLAo+ID4+PiBpbml0X2RhdGEpOwo+ID4+PiAjZW5kaWYK PiA+Pj4KPiA+Pj4gI2lmIElTX0VOQUJMRUQoQ09ORklHX0xFRFNfQ0xBU1NfRkxBU0gpCj4gPj4+ ICAgICAgIHJldCA9IGRldm1fbGVkX2NsYXNzZGV2X2ZsYXNoX3JlZ2lzdGVyX2V4dChwYXJlbnQs ICZsZWQtPmZsYXNoLCBpbml0X2RhdGEpOwo+ID4+PiAjZW5kaWYKPiA+Pgo+ID4+IE5vLCB0aGUg Z3VhcmRzIHNob3VsZCBiZSBpbiBoZWFkZXJzLiBUaGF0J3Mgd2h5IEkgcmVjb21tZW5kZWQgYWRk aW5nCj4gPj4gbm8gb3BzIGZvciBMRUQgZmxhc2ggY2xhc3MgcmVnaXN0cmF0aW9uIGZ1bmN0aW9u cyBpbiBwcmV2aW91cyBlbWFpbC4KPiA+Pgo+ID4+IFBsZWFzZSBjb21wYXJlIGluY2x1ZGUvbGlu dXgvbGVkLWNsYXNzLW11bHRpY29sb3IuaCBhbmQgZG8gc2ltaWxhcgo+ID4+IGNoYW5nZXMgaW4g aW5jbHVkZS9saW51eC9sZWQtY2xhc3MtZmxhc2guaC4KPiA+Pgo+ID4KPiA+IEFDSywgSSB3aWxs IHN1Ym1pdCBhIGZpeGVkIHBhdGNoIGFib3V0IGxlZHMtY2xhc3MtZmxhc2guaC4KPiA+Cj4gPiBC eSB0aGUgd2F5LCBpZiBDT05GSUdfTEVEX0NMQVNTX01VTFRJQ09MT1IgaXMgbm90IGVuYWJsZWQg YW5kIHdlIGRvbid0Cj4gPiB1c2UgI2lmIElTX0VOQUJMRUQsCj4gPiBhY2NvcmRpbmcgdG8gbGVk LWNsYXNzLW11bHRpY29sb3IuaCByZXR1cm4gLUVJTlZBTCwKPiA+IHdlIHdpbGwgcmVnaXN0ZXIg bXVsdGljb2xvciBkZXZpY2UgZmFpbCBhbmQgY2F1c2UgcHJvYmUgZmFpbC4KPgo+IEdvb2QgcG9p bnQuIFNvIGxlZC1jbGFzcy1tdWx0aWNvbG9yLmggbm8tb3BzIG5lZWQgdG8gYmUgZml4ZWQgdG8g cmV0dXJuCj4gMCBpbnN0ZWFkIG9mIC1FSU5WQUwuCj4KPiBBbmQgbm8tb3BzIGluIGluY2x1ZGUv bGludXgvbGVkLWNsYXNzLWZsYXNoLmggc2hvdWxkIGFsc28gcmV0dXJuIDAuCgpEVCBub2RlIGlz IGZpcnN0IHByaW9yaXR5IHRvIGRlY2lkZSBob3cgbGVkcyB3b3JrLgpJZiBSR0IgTEVEIHVzZSBt dWx0aWNvbG9yIGZvcm0gaW4gRFQsIENPTkZJR19MRURTX0NMQVNTX0ZMQVNIIHNob3VsZCBiZSBk ZWZpbmVkLgpPdGhlcndpc2UgSXQgaXMgcmlnaHQgYWN0aW9uIHRvIHByb2JlIGZhaWwuCgo+Cj4g LS0KPiBCZXN0IHJlZ2FyZHMsCj4gSmFjZWsgQW5hc3pld3NraQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtbWVkaWF0ZWsgbWFpbGluZyBsaXN0 CkxpbnV4LW1lZGlhdGVrQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVh ZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1tZWRpYXRlawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65609C5519F for ; Tue, 17 Nov 2020 09:56:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3808207BC for ; Tue, 17 Nov 2020 09:56:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qmwCyOkB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CzawzkGY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3808207BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1/xeOKYoFsWhMyH0PrMPNBhA1e0RawoF+owZTIgCX6k=; b=qmwCyOkBXy1F8MTZzY8jGGsD5 A1gFzGM9tjnFEkumZvbW1ysYRk8PkhWXYWD6gj62NtEQKJSlR8hB84mZ9a2UN1aGDlee2tDCpm5yn Uk78kV/MwKE0PhIxjiCmx21Aj3nUHk7Ep2aK5i0rKhV/9LgOZ8gjSqX2xyh3pwE/xUm2rZbW97ZyK Z1aqg2G3MDVhEzNXcQpKNMoLChikDbrYLBIoqb6KnBNr4McL5I05+7fPYQYucrpVR1FuFeFsZjCou o42nwzdrXoI5jCqZGa8uqT//2gdbWmuSaE/gPJZVbwF9dJXvjK/9LehoqCn9y5gm7Q3MVGxL+/I1/ 6ZussaCBw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kexhm-0003Q5-1O; Tue, 17 Nov 2020 09:55:18 +0000 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kexhj-0003Ok-03; Tue, 17 Nov 2020 09:55:16 +0000 Received: by mail-oi1-x242.google.com with SMTP id l206so886357oif.12; Tue, 17 Nov 2020 01:55:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=g6cFr1GWe/3eh4NUqXWAinlK5cgfPVLY2u3q3tSx53o=; b=CzawzkGYSM3k6pL0T1hbwyHjk6lf4OIJYruDp2QL9npIt9xSBOSoriYK+lZN9iL+1X Rcg9c8kQYukPpCN7TI/x193Dnvx9ojNTqpQD9pRj/8HF9pLMqS+OHXMcCkLl9uqVDXOg +dpwSRi5RPt+5kwajoY5fEgEg6mIUXRavCobmMSmukmp+kmUagl1I+8xeqZCMAm2dOKj 5GapsgPY+wOutrJEWvwAD9zyseIihpDzWEpMAAonb1aiZ8MVdJRJOZdKhxs/Q7I5VokN eAVT1dU8mjcSJsiklHSwc26Qpa+BWC/Hdg3gS1B8COd1jgrAbqvhKWTj+NzoaSwfKFSJ /C8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=g6cFr1GWe/3eh4NUqXWAinlK5cgfPVLY2u3q3tSx53o=; b=kjVpQitzUMu5QrGo0pPeizi67bzGt9SxC8Wbf1Kb9VJBeVtF8wwB/EeqHimXVU3TJ7 iJz35hoAINQ9gL6UiHQ1S8Nrqs/f6m/R2c1rNPXRtvBA58v8TY8tldE0eY5cV+wbFmi6 ZIYwp/kaCZlHz53iAnn6z+vpDukfpYybxKbptJFb3+qdL0dzi7pr3fTm7loeNWOwTtGQ VK1OfAhKUbAKrTMuP9BPTK3/KLhwQ9JCbVFxa9lsFYjkc214X/VW7uunKSfHEj0SCa+P 5GdbeUVyvYMxVpcYGeNaI7z74MtW3wqlJE81/M15X9UArYYqS1O5oBZe2jfQQT86OeeA wxFQ== X-Gm-Message-State: AOAM532s6dIWK5AQLVorZnHweol1KGZTxHj/S4jQNEkipJSHdFlitoKz kIWrlGyu9fhZNEhpTZ1K/ruOTJAHRrsA3fe1wEU= X-Google-Smtp-Source: ABdhPJya8F6HqaXOxv32vLbvDlmGZZUV8Q00KUBZXfRPq3qbh5S+PA3y0CdQ8g7uWdODqTVA4V0Epe3FABZHNroWpjk= X-Received: by 2002:aca:4783:: with SMTP id u125mr1917664oia.23.1605606909920; Tue, 17 Nov 2020 01:55:09 -0800 (PST) MIME-Version: 1.0 References: <1602034966-3524-1-git-send-email-gene.chen.richtek@gmail.com> <1602034966-3524-3-git-send-email-gene.chen.richtek@gmail.com> <5a9b31c4-739c-06fc-2015-ed474993ad22@gmail.com> <8925db23-5cc4-3c5f-932a-461fe6450dad@gmail.com> <1bb76c54-14af-6c78-4623-77c6678b262e@gmail.com> In-Reply-To: From: Gene Chen Date: Tue, 17 Nov 2020 17:54:58 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360 To: Jacek Anaszewski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_045515_119218_F9C5F5F4 X-CRM114-Status: GOOD ( 45.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm Mailing List , devicetree , cy_huang@richtek.com, Linux Kernel Mailing List , Gene Chen , benjamin.chao@mediatek.com, Rob Herring , "moderated list:ARM/Mediatek SoC support" , Dan Murphy , Pavel Machek , Matthias Brugger , Wilma.Wu@mediatek.com, Linux LED Subsystem , shufan_lee@richtek.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SmFjZWsgQW5hc3pld3NraSA8amFjZWsuYW5hc3pld3NraUBnbWFpbC5jb20+IOaWvCAyMDIw5bm0 MTHmnIgxN+aXpSDpgLHkuowg5LiK5Y2IMjoyNeWvq+mBk++8mgo+Cj4gT24gMTEvMTYvMjAgMTE6 MDEgQU0sIEdlbmUgQ2hlbiB3cm90ZToKPiA+IEphY2VrIEFuYXN6ZXdza2kgPGphY2VrLmFuYXN6 ZXdza2lAZ21haWwuY29tPiDmlrwgMjAyMOW5tDEw5pyIMzHml6Ug6YCx5YWtIOS4iuWNiDY6MzTl r6vpgZPvvJoKPiA+Pgo+ID4+IE9uIDEwLzMwLzIwIDk6NTEgQU0sIEdlbmUgQ2hlbiB3cm90ZToK PiA+Pj4gSmFjZWsgQW5hc3pld3NraSA8amFjZWsuYW5hc3pld3NraUBnbWFpbC5jb20+IOaWvCAy MDIw5bm0MTDmnIgyOOaXpSDpgLHkuIkg5LiK5Y2IMToyOOWvq+mBk++8mgo+ID4+Pj4KPiA+Pj4+ IE9uIDEwLzI3LzIwIDEwOjI4IEFNLCBHZW5lIENoZW4gd3JvdGU6Cj4gPj4+Pj4gSmFjZWsgQW5h c3pld3NraSA8amFjZWsuYW5hc3pld3NraUBnbWFpbC5jb20+IOaWvCAyMDIw5bm0MTDmnIgyMeaX pSDpgLHkuIkg5LiK5Y2INTo0N+Wvq+mBk++8mgo+ID4+Pj4+Pgo+ID4+Pj4+PiBPbiAxMC8yMC8y MCA4OjQ0IEFNLCBHZW5lIENoZW4gd3JvdGU6Cj4gPj4+Pj4+PiBKYWNlayBBbmFzemV3c2tpIDxq YWNlay5hbmFzemV3c2tpQGdtYWlsLmNvbT4g5pa8IDIwMjDlubQxMOaciDnml6Ug6YCx5LqUIOS4 iuWNiDU6NTHlr6vpgZPvvJoKPiA+Pj4+Pj4+Pgo+ID4+Pj4+Pj4+IEhpIEdlbmUsCj4gPj4+Pj4+ Pj4KPiA+Pj4+Pj4+PiBPbiAxMC83LzIwIDM6NDIgQU0sIEdlbmUgQ2hlbiB3cm90ZToKPiA+Pj4+ Pj4+Pj4gRnJvbTogR2VuZSBDaGVuIDxnZW5lX2NoZW5AcmljaHRlay5jb20+Cj4gPj4+Pj4+Pj4+ Cj4gPj4+Pj4+Pj4+IEFkZCBNVDYzNjAgTEVEIGRyaXZlciBpbmNsdWRlIDItY2hhbm5lbCBGbGFz aCBMRUQgd2l0aCB0b3JjaC9zdHJvYmUgbW9kZSwKPiA+Pj4+Pj4+Pj4gMy1jaGFubmVsIFJHQiBM RUQgc3VwcG9ydCBSZWdpc3Rlci9GbGFzaC9CcmVhdGggTW9kZSwgYW5kIDEtY2hhbm5lbCBmb3IK PiA+Pj4+Pj4+Pj4gbW9vbmxpZ2h0IExFRC4KPiA+Pj4+Pj4+Pj4KPiA+Pj4+Pj4+Pj4gU2lnbmVk LW9mZi1ieTogR2VuZSBDaGVuIDxnZW5lX2NoZW5AcmljaHRlay5jb20+Cj4gPj4+Pj4+Pj4+IC0t LQo+ID4+Pj4+Pj4+PiAgICAgICBkcml2ZXJzL2xlZHMvS2NvbmZpZyAgICAgICB8ICAxMiArCj4g Pj4+Pj4+Pj4+ICAgICAgIGRyaXZlcnMvbGVkcy9NYWtlZmlsZSAgICAgIHwgICAxICsKPiA+Pj4+ Pj4+Pj4gICAgICAgZHJpdmVycy9sZWRzL2xlZHMtbXQ2MzYwLmMgfCA3ODMgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPj4+Pj4+Pj4+ICAgICAgIDMgZmls ZXMgY2hhbmdlZCwgNzk2IGluc2VydGlvbnMoKykKPiA+Pj4+Pj4+Pj4gICAgICAgY3JlYXRlIG1v ZGUgMTAwNjQ0IGRyaXZlcnMvbGVkcy9sZWRzLW10NjM2MC5jCj4gPj4+Pj4+Pj4+Cj4gPj4+Pj4+ Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2xlZHMvS2NvbmZpZyBiL2RyaXZlcnMvbGVkcy9LY29u ZmlnCj4gPj4+Pj4+Pj4+IGluZGV4IDFjMTgxZGYuLmM3MTkyZGQgMTAwNjQ0Cj4gPj4+Pj4+Pj4+ IC0tLSBhL2RyaXZlcnMvbGVkcy9LY29uZmlnCj4gPj4+Pj4+Pj4+ICsrKyBiL2RyaXZlcnMvbGVk cy9LY29uZmlnCj4gPj4+Pj4+Pj4+IEBAIC0yNzEsNiArMjcxLDE4IEBAIGNvbmZpZyBMRURTX01U NjMyMwo+ID4+Pj4+Pj4+PiAgICAgICAgICAgICBUaGlzIG9wdGlvbiBlbmFibGVzIHN1cHBvcnQg Zm9yIG9uLWNoaXAgTEVEIGRyaXZlcnMgZm91bmQgb24KPiA+Pj4+Pj4+Pj4gICAgICAgICAgICAg TWVkaWF0ZWsgTVQ2MzIzIFBNSUMuCj4gPj4+Pj4+Pj4+Cj4gPj4+Pj4+Pj4+ICtjb25maWcgTEVE U19NVDYzNjAKPiA+Pj4+Pj4+Pj4gKyAgICAgdHJpc3RhdGUgIkxFRCBTdXBwb3J0IGZvciBNZWRp YXRlayBNVDYzNjAgUE1JQyIKPiA+Pj4+Pj4+Pj4gKyAgICAgZGVwZW5kcyBvbiBMRURTX0NMQVNT X0ZMQVNIICYmIE9GCj4gPj4+Pj4+Pj4+ICsgICAgIGRlcGVuZHMgb24gTEVEU19DTEFTU19NVUxU SUNPTE9SCj4gPj4+Pj4+Pj4KPiA+Pj4+Pj4+PiBTaW5jZSBDT05GSUdfTEVEX0NMQVNTX01VTFRJ Q09MT1IgY2FuIGJlIHR1cm5lZCBvZmYgeW91IG5lZWQgdG8gaGF2ZQo+ID4+Pj4+Pj4+IGJlbG93 IGluc3RlYWQ6Cj4gPj4+Pj4+Pj4KPiA+Pj4+Pj4+PiBkZXBlbmRzIG9uIExFRFNfQ0xBU1NfTVVM VElDT0xPUiB8fCAhIUxFRFNfQ0xBU1NfTVVMVElDT0xPUgo+ID4+Pj4KPiA+Pj4+IE15IHR5cG8g aGVyZSwgc2hvdWxkIGJlIG9uZSAiISI6Cj4gPj4+Pgo+ID4+Pj4gZGVwZW5kcyBvbiBMRURTX0NM QVNTX01VTFRJQ09MT1IgfHwgIUxFRFNfQ0xBU1NfTVVMVElDT0xPUgo+ID4+Pj4KPiA+Pj4+IEFu ZCB5b3Ugc2hvdWxkIGFsc28gaGF2ZQo+ID4+Pj4KPiA+Pj4+IGRlcGVuZHMgb24gTEVEU19DTEFT U19GTEFTSCB8fCAhTEVEU19DTEFTU19GTEFTSAo+ID4+Pj4KPiA+Pj4+IEJ1dCB0byBtYWtlIGl0 IHdvcmsgY29ycmVjdGx5IHlvdSB3b3VsZCBoYXZlIHRvIGFkZCByZWdpc3RyYXRpb24KPiA+Pj4+ IHN0dWJzIHRvIGluY2x1ZGUvbGludXgvbGVkLWNsYXNzLWZsYXNoLmggc2ltaWxhcmx5IHRvIExF RCBtYyBzdHVicwo+ID4+Pj4gaW4gaW5jbHVkZS9saW51eC9sZWQtY2xhc3MtbXVsdGljb2xvci5o Lgo+ID4+Pj4KPiA+Pj4+Pj4+Pgo+ID4+Pj4+Pj4+IFVubGVzcyB5b3Ugd2FudCB0byBwcmV2ZW50 IGVuYWJsaW5nIHRoZSBkcml2ZXIgd2l0aG91dCBSR0IgTEVELAo+ID4+Pj4+Pj4+IGJ1dCB0aGF0 IGRvZXMgbm90IHNlZW0gdG8gYmUgcmVhc29uYWJsZSBhdCBmaXJzdCBnbGFuY2UuCj4gPj4+Pj4+ Pj4KPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBNYXkgSSBjaGFuZ2UgdG8gInNlbGVjdCBMRURTX0NMQVNT X01VTFRJQ09MT1IiPwo+ID4+Pj4+Pj4gSSBzdXBwb3NlIFJHQiBhbHdheXMgdXNlIG11bHRpY29s b3IgbW9kZS4KPiA+Pj4+Pj4KPiA+Pj4+Pj4gWW91IHdpbGwgYWxzbyBoYXZlIG1vb25saWdodCBM RUQgdGhhdCB3aWxsIG5vdCBuZWVkIG11bHRpY29sb3IKPiA+Pj4+Pj4gZnJhbWV3b3JrLiBJcyBp dCBzb21laG93IHRyb3VibGVzb21lIHRvIGtlZXAgImRlcGVuZHMgb24iPwo+ID4+Pj4+Pgo+ID4+ Pj4+Cj4gPj4+Pj4gSWYgb25seSB1c2UgTUwgTEVEIGFuZCBGTEVELCAgRFRTSSB3aWxsIG9ubHkg ZGVmaW5lIE1MIExFRCBhbmQgRkxFRC4KPiA+Pj4+PiBUaGVyZWZvcmUsIHRoZSBkcml2ZXJzIHBy b2JlIHdpbGwgbm90IHJlZ2lzdGVyIHJnYiBtdWx0aWNvbG9yIGRldmljZS4KPiA+Pj4+Cj4gPj4+ PiBQbGVhc2UgdGVzdCB5b3VyIHVzZSBjYXNlIGFnYWluIHdpdGggbXkgZml4ZWQgImRlcGVuZHMg b24iLgo+ID4+Pj4KPiA+Pj4+IEluIGNhc2Ugd2hlbiB0aGVyZSBpcyBvbmx5IE1MIExFRCBhbmQg RkxFRCBpbiB0aGUgRFQgaXQgc2hvdWxkCj4gPj4+PiByZWdpc3RlciBib3RoIGRldmljZXMgaWYg TEVEU19DTEFTU19GTEFTSCBpcyB0dXJuZWQgb24uCj4gPj4+PiBNdWx0aWNvbG9yIGZyYW1ld29y ayBoYXMgbm90aGluZyB0byBkbyBpbiB0aGlzIGNhc2UuCj4gPj4+Pgo+ID4+Pj4gQnV0IGlmIHlv dSBhZGRpdGlvbmFsbHkgaGFkIE1DIExFRCBub2RlLCB0aGVuIGl0IHNob3VsZAo+ID4+Pj4gYmUg cmVnaXN0ZXJlZCBvbmx5IGlmIExFRFNfQ0xBU1NfTVVMVElDT0xPUiBpcyBlbmFibGVkLgo+ID4+ Pj4KPiA+Pj4+IFNpbWlsYXJseSwgd2hlbiBGTEVEIG5vZGUgaXMgcHJlc2VudCwgYnV0IExFRFNf Q0xBU1NfRkxBU0gKPiA+Pj4+IGlzIG9mZiwgYW5kIExFRFNfQ0xBU1NfTVVMVElDT0xPUiBpcyBv biwgdGhlIGRyaXZlciBzaG91bGQgc3RpbGwKPiA+Pj4+IGNvbXBpbGUsIGJ1dCByZWdpc3RlciBv bmx5IExFRCBNQyBkZXZpY2UgKGlmIGl0cyBub2RlIGlzIHByZXNlbnQpLgo+ID4+Pj4KPiA+Pj4K PiA+Pj4gSSB0aGluayB0aGlzIGNhc2Ugb25seSByZWdpc3RlciBMRUQgZGV2aWNlLCBub3QgTEVE ICJNQyIgZGV2aWNlLgo+ID4+PiBCZWNhdXNlIG91ciBGTEFTSCBpcyBub3QgYSBtdWx0aWNvbG9y IGRldmljZS4KPiA+Pgo+ID4+IE5vLCBoZXJlIEkgd2FzIGRlc2NyaWJpbmcgZm9sbG93aW5nIHNl dHVwOgo+ID4+Cj4gPj4gLSBEVCBGTEVEIG5vZGUgaXMgcHJlc2VudCwgQ09ORklHX0xFRFNfQ0xB U1NfRkxBU0ggaXMgb2ZmCj4gPj4gLSBEVCBNQyBub2RlIGlzIHByZXNlbnQsIENPTkZJR19MRURT X0NMQVNTX01VTFRJQ09MT1IgaXMgb24KPiA+Pgo+ID4+IE1MIExFRCBwcmVzZW5jZSBpbiBEVCBp cyBpcnJlbGV2YW50IGluIHRoaXMgY2FzZS4KPiA+PiBJdCBzaG91bGQgYmUgYWx3YXlzIHJlZ2lz dGVyZWQgaWYgdGhlcmUgaXMgY29ycmVzcG9uZGluZyBEVCBub2RlCj4gPj4gYW5kIExFRFNfQ0xB U1MgaXMgb24uCj4gPj4KPiA+Cj4gPiBBcyBhIGxvbmcgdGltZSBkaXNjdXNzaW9uLCB3ZSBjb25j bHVkZSBzb21lIHJ1bGVzIGFib3V0IE1UNjM2MCBMRUQgZHJpdmVyLgo+ID4gRkxFRCBpcyBuZWNl c3NhcnksIHNvIEtjb25maWcgZGVwZW5kcyBvbiBMRURfQ0xBU1NfRkxBU0gKPgo+IE1heWJlIGl0 IGlzIG5lY2Vzc2FyeSBpbiB5b3VyIHVzZSBjYXNlLCBidXQgcHJvYmFibHkgaXQgaXMgcG9zc2li bGUgdG8KPiB1c2UgdGhlIGRldmljZSB3aXRob3V0IEZMRUQuIElmIHNvLCB0aGVuIHlvdSBzaG91 bGQgYWxsb3cgdXNlcnMKPiBkaXNhYmxpbmcgaXQuIFRoZXJlZm9yZSB5b3Ugc2hvdWxkIGhhdmU6 Cj4KPiBkZXBlbmRzIG9uIExFRFNfQ0xBU1NfRkxBU0ggfHwgIUxFRFNfQ0xBU1NfRkxBU0gKPgoK QUNLCgo+ID4gTUwgTEVEIGlzIG9wdGlvbmFsLCB3aGljaCBpcyByZWdpc3RlcmVkIGFzIGxlZCBj bGFzcyBkZXZpY2UuCj4gPiBSR0IgTEVEIGNhbiBiZSBlaXRoZXIgc2ltcGxlIGxlZCBjbGFzcyBk ZXZpY2Ugb3IgbXVsdGljb2xvciBkZXZpY2UsCj4gPiB3aGljaCBpcyBkZWNpZGVkIGluIERUIG5v ZGUKPiA+IElmIE11bHRpY29sb3IgTEVEIERUIG5vZGUgaXMgZXhpc3QsIGl0IHNob3VsZCBiZSBy ZWdpc3RlciBtdWx0aWNvbG9yCj4gPiBkZXZpY2Ugc3VjY2Vzcy4KPgo+IEJ1dCBvbmx5IGlmIENP TkZJR19MRURTX0NMQVNTX01VTFRJQ09MT1IgaXMgZW5hYmxlZC4KPgo+ID4gTWF5YmUgaXQgaXMg bW9yZSBzcGVjaWZpYyB0byBzZW5kIGEgbmV3IHBhdGNoPwo+ID4KPiA+IFNhbXBsZSBEVCBhcyBi ZWxvdwo+ID4gTEVEICJyZWQiIGlzIHNpbXBsZSBsZWQgY2xhc3MgZGV2aWNlLCBMRUQgImdyZWVu JmJsdWUiIGlzIG11bHRpY29sb3IgZGV2aWNlcy4KPiA+IGxlZEAwIHsKPiA+ICAgICAgICAgIHJl ZyA9IDwwPjsKPiA+ICAgICAgICAgIGZ1bmN0aW9uID0gTEVEX0ZVTkNUSU9OX0lORElDQVRPUjsK PiA+ICAgICAgICAgIGNvbG9yID0gPExFRF9DT0xPUl9JRF9SRUQ+Owo+ID4gICAgICAgICAgbGVk LW1heC1taWNyb2FtcCA9IDwyNDAwMD47Cj4gPiB9Owo+ID4gbGVkQDYgewo+ID4gICAgICAgICAg cmVnID0gPDY+Owo+ID4gICAgICAgICAgZnVuY3Rpb24gPSBMRURfRlVOQ1RJT05fSU5ESUNBVE9S Owo+ID4gICAgICAgICAgY29sb3IgPSA8TEVEX0NPTE9SX0lEX01VTFRJPjsKPiA+Cj4gPiAgICAg ICAgICBsZWRAMSB7Cj4gPiAgICAgICAgICAgICAgICAgIHJlZyA9IDwxPjsKPiA+ICAgICAgICAg ICAgICAgICAgZnVuY3Rpb24gPSBMRURfRlVOQ1RJT05fSU5ESUNBVE9SOwo+ID4gICAgICAgICAg ICAgICAgICBjb2xvciA9IDxMRURfQ09MT1JfSURfR1JFRU4+Owo+ID4gICAgICAgICAgICAgICAg ICBsZWQtbWF4LW1pY3JvYW1wID0gPDI0MDAwPjsKPiA+ICAgICAgICAgIH07Cj4gPiAgICAgICAg ICBsZWRAMiB7Cj4gPiAgICAgICAgICAgICAgICAgIHJlZyA9IDwyPjsKPiA+ICAgICAgICAgICAg ICAgICAgZnVuY3Rpb24gPSBMRURfRlVOQ1RJT05fSU5ESUNBVE9SOwo+ID4gICAgICAgICAgICAg ICAgICBjb2xvciA9IDxMRURfQ09MT1JfSURfQkxVRT47Cj4gPiAgICAgICAgICAgICAgICAgIGxl ZC1tYXgtbWljcm9hbXAgPSA8MjQwMDA+Owo+ID4gICAgICAgICAgfTsKPiA+IH07Cj4KPiBJdCBs b29rcyBPSy4KPgo+ID4+Pj4gUG9zc2libGUgc2hvdWxkIGJlIGFsc28gdGhlIGNhc2Ugd2hlbiBi b3RoIExFRFNfQ0xBU1NfRkxBU0gKPiA+Pj4+IGFuZCBMRURTX0NMQVNTX01VTFRJQ09MT1IgYXJl IG9mZi4gVGhlbiBvbmx5IExFRCBjbGFzcyBkZXZpY2UKPiA+Pj4+IGZvciBNTCBMRUQgd2lsbCBi ZSByZWdpc3RlcmVkIChwcm92aWRlZCB0aGVyZSBpcyBNTCBEVCBub2RlKS4KPiA+Pj4+IEJ1dCB0 byBtYWtlIGl0IHBvc3NpYmxlIHlvdSBzaG91bGQgaGF2ZSBhbHNvICJkZXBlbmRzIG9uIExFRFNf Q0xBU1MiCj4gPj4+PiBpbiB0aGUgS2NvbmZpZyBlbnRyeS4KPiA+Pj4+Cj4gPj4+Cj4gPj4+IEFj Y29yZGluZyB0byB5b3VyIHN1Z2dlc3Rpb24sCj4gPj4+IGRlcGVuZHMgb24gTEVEX0NMQVNTICYm IExFRFNfQ0xBU1NfRkxBU0ggJiYgT0YKPiA+Pgo+ID4+IHMvTEVEX0NMQVNTL0xFRFNfQ0xBU1Mv Cj4gPj4KPiA+PiBBbmQgeW91IGhhdmUgdG8gcmVtb3ZlIExFRFNfQ0xBU1NfRkxBU0ggZnJvbSBh Ym92ZSBsaW5lLgo+ID4+Cj4gPj4+IGRlcGVuZHMgb24gTEVEU19DTEFTU19NVUxUSUNPTE9SIHx8 ICEhTEVEU19DTEFTU19NVUxUSUNPTE9SCj4gPj4KPiA+PiBzLyEhTEVEU19DTEFTU19NVUxUSUNP TE9SLyFMRURTX0NMQVNTX01VTFRJQ09MT1IvCj4gPj4KPiA+Pj4gZGVwZW5kcyBvbiBMRURTX0NM QVNTX0ZMQVNIIHx8ICFMRURTX0NMQVNTX0ZMQVNICj4gPj4+IGRlcGVuZHMgb24gTUZEX01UNjM2 MAo+ID4+Cj4gPj4gWW91IHdpbGwgbmVlZCBWNEwyX0ZMQVNIX0xFRF9DTEFTUyBkZXBlbmRlbmN5 IGFzIHdlbGwsIHRvIGF2b2lkCj4gPj4gYnVpbGQgYnJlYWssIHdoZW4gaXQgaXMgc2V0IHRvICdt Jy4KPiA+Pgo+ID4+IFRvIHJlY2FwLCBmb2xsb3dpbmcgYmxvY2sgb2YgZGVwZW5kZW5jaWVzIGlz IHJlcXVpcmVkOgo+ID4+Cj4gPj4gZGVwZW5kcyBvbiBMRURTX0NMQVNTICYmIE9GCj4gPj4gZGVw ZW5kcyBvbiBMRURTX0NMQVNTX01VTFRJQ09MT1IgfHwgIUxFRFNfQ0xBU1NfTVVMVElDT0xPUgo+ ID4+IGRlcGVuZHMgb24gTEVEU19DTEFTU19GTEFTSCB8fCAhTEVEU19DTEFTU19GTEFTSAo+ID4+ IGRlcGVuZHMgb24gVjRMMl9GTEFTSF9MRURfQ0xBU1MgfHwgIVY0TDJfRkxBU0hfTEVEX0NMQVNT Cj4gPj4gZGVwZW5kcyBvbiBNRkRfTVQ2MzYwCj4gPj4KPiA+Cj4gPiBMRURTX01UNjM2MCBkZXBl bmRzIG9uIExFRFNfQ0xBU1NfRkxBU0gsIGFuZCBMRURTX0NMQVNTX0ZMQVNIIGRlcGVuZHMKPiA+ IG9uIExFRFNfQ0xBU1MKPiA+IElzICJkZXBlbmRzIG9uIExFRFNfQ0xBU1MiIHN0aWxsIG5lZWRl ZD8KPgo+IFllcywgYmVjYXVzZSB5b3Ugc2hvdWxkIGFsbG93IGRpc2FibGluZyBDT05GSUdfTEVE U19DTEFTU19GTEFTSC4KPiBJbiBzdWNoIGEgY2FzZSBkcml2ZXIgc2hvdWxkIHN0aWxsIGNvbXBp bGUgYW5kIHJlZ2lzdGVyIE1MIExFRCBjbGFzcwo+IGRldmljZSB3aGVuIGl0IGhhcyBjb3JyZXNw b25kaW5nIERUIG5vZGUuCj4KCkFDSwoKPiA+Pj4gYW5kIHNvdXJjZSBjb2RlIGFkZCBjb25zdHJh aW50Cj4gPj4+Cj4gPj4+ICNpZiBJU19FTkFCTEVEKENPTkZJR19MRURTX0NMQVNTX01VTFRJQ09M T1IpCj4gPj4+ICAgICAgIHJldCA9IGRldm1fbGVkX2NsYXNzZGV2X211bHRpY29sb3JfcmVnaXN0 ZXJfZXh0KHBhcmVudCwgJmxlZC0+cmdiLAo+ID4+PiBpbml0X2RhdGEpOwo+ID4+PiAjZW5kaWYK PiA+Pj4KPiA+Pj4gI2lmIElTX0VOQUJMRUQoQ09ORklHX0xFRFNfQ0xBU1NfRkxBU0gpCj4gPj4+ ICAgICAgIHJldCA9IGRldm1fbGVkX2NsYXNzZGV2X2ZsYXNoX3JlZ2lzdGVyX2V4dChwYXJlbnQs ICZsZWQtPmZsYXNoLCBpbml0X2RhdGEpOwo+ID4+PiAjZW5kaWYKPiA+Pgo+ID4+IE5vLCB0aGUg Z3VhcmRzIHNob3VsZCBiZSBpbiBoZWFkZXJzLiBUaGF0J3Mgd2h5IEkgcmVjb21tZW5kZWQgYWRk aW5nCj4gPj4gbm8gb3BzIGZvciBMRUQgZmxhc2ggY2xhc3MgcmVnaXN0cmF0aW9uIGZ1bmN0aW9u cyBpbiBwcmV2aW91cyBlbWFpbC4KPiA+Pgo+ID4+IFBsZWFzZSBjb21wYXJlIGluY2x1ZGUvbGlu dXgvbGVkLWNsYXNzLW11bHRpY29sb3IuaCBhbmQgZG8gc2ltaWxhcgo+ID4+IGNoYW5nZXMgaW4g aW5jbHVkZS9saW51eC9sZWQtY2xhc3MtZmxhc2guaC4KPiA+Pgo+ID4KPiA+IEFDSywgSSB3aWxs IHN1Ym1pdCBhIGZpeGVkIHBhdGNoIGFib3V0IGxlZHMtY2xhc3MtZmxhc2guaC4KPiA+Cj4gPiBC eSB0aGUgd2F5LCBpZiBDT05GSUdfTEVEX0NMQVNTX01VTFRJQ09MT1IgaXMgbm90IGVuYWJsZWQg YW5kIHdlIGRvbid0Cj4gPiB1c2UgI2lmIElTX0VOQUJMRUQsCj4gPiBhY2NvcmRpbmcgdG8gbGVk LWNsYXNzLW11bHRpY29sb3IuaCByZXR1cm4gLUVJTlZBTCwKPiA+IHdlIHdpbGwgcmVnaXN0ZXIg bXVsdGljb2xvciBkZXZpY2UgZmFpbCBhbmQgY2F1c2UgcHJvYmUgZmFpbC4KPgo+IEdvb2QgcG9p bnQuIFNvIGxlZC1jbGFzcy1tdWx0aWNvbG9yLmggbm8tb3BzIG5lZWQgdG8gYmUgZml4ZWQgdG8g cmV0dXJuCj4gMCBpbnN0ZWFkIG9mIC1FSU5WQUwuCj4KPiBBbmQgbm8tb3BzIGluIGluY2x1ZGUv bGludXgvbGVkLWNsYXNzLWZsYXNoLmggc2hvdWxkIGFsc28gcmV0dXJuIDAuCgpEVCBub2RlIGlz IGZpcnN0IHByaW9yaXR5IHRvIGRlY2lkZSBob3cgbGVkcyB3b3JrLgpJZiBSR0IgTEVEIHVzZSBt dWx0aWNvbG9yIGZvcm0gaW4gRFQsIENPTkZJR19MRURTX0NMQVNTX0ZMQVNIIHNob3VsZCBiZSBk ZWZpbmVkLgpPdGhlcndpc2UgSXQgaXMgcmlnaHQgYWN0aW9uIHRvIHByb2JlIGZhaWwuCgo+Cj4g LS0KPiBCZXN0IHJlZ2FyZHMsCj4gSmFjZWsgQW5hc3pld3NraQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxp c3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=