From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66AC1C433F5 for ; Fri, 25 Mar 2022 19:51:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 828EB10E588; Fri, 25 Mar 2022 19:51:08 +0000 (UTC) Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F96010E518 for ; Fri, 25 Mar 2022 19:51:07 +0000 (UTC) Received: by mail-oi1-x236.google.com with SMTP id t21so4403122oie.11 for ; Fri, 25 Mar 2022 12:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=eUek1jmX1h1x8PcNcflTTCV7rdiqXP/FImxouF9eXrk=; b=MuYU2U53+0XditHV3+xMmufekP83Q86clHPRUFiYJI5c83MMgqsqZU6OE0iD7uqI1D bq5BpO0h+DDnBW2dzr+T0KLiCp0GgYfvXmXPzjeUTmIwglTcDMjx2JTa8I15roXjfJQr QDYKF7wfPMDa6WIjm4l4EenX4il5h6oLp4L78= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=eUek1jmX1h1x8PcNcflTTCV7rdiqXP/FImxouF9eXrk=; b=5EsfWP6fFW8WXQvadI165ITo3mDj2OWhGnGpFEUmA0z3TDZh6UoXN7O55IGXU/x9GR bTNtVMgDkKs7B+wpejdX8LLByQHo3DffO9Cq/WtbXv7bs45vv7gpME8gj7WK44tbM8QR cTKcNyZEOuHFV9uk5x51PQSr0UUfcEE7XQuKRLuW1ROqnSsLwED1gqydNiCS5+o4qc4I OdSP9YilNjgxCU/4BoinNEU88lb9/9Y1tbNd2CroV3KDRGj5ppTP/izj+BAIBfAd/5FJ lVdvPmH2A1iwF57OgOZAG3Vi972mR4k+m7gOParqn5ZM62RcwV5keP24teaMjux+9YLd WrrQ== X-Gm-Message-State: AOAM532T6Uy6e12ndKcAQguqJsLpzhZj5a7LwgsqXdprTSMLtWopKZlv hlywUIaqJWUz9RgA3inSsDp45dbMvOfQBTLQieD/cg== X-Google-Smtp-Source: ABdhPJxjJgDkwaOL+igFbYKoHRlPcGxtCqcdt2HqSpDefQv8NNUO1BG5eOIgAhxWNNRmCDuEqZtRbL5DhxFUglZ6hXs= X-Received: by 2002:aca:a9c8:0:b0:2da:45b6:b796 with SMTP id s191-20020acaa9c8000000b002da45b6b796mr5910648oie.193.1648237866373; Fri, 25 Mar 2022 12:51:06 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 25 Mar 2022 14:51:05 -0500 MIME-Version: 1.0 In-Reply-To: References: <1647452154-16361-1-git-send-email-quic_sbillaka@quicinc.com> <1647452154-16361-3-git-send-email-quic_sbillaka@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Fri, 25 Mar 2022 14:51:05 -0500 Message-ID: Subject: RE: [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD To: Sankeerth Billakanti , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_kalyant , "dianders@chromium.org" , quic_vproddut , "airlied@linux.ie" , "sam@ravnborg.org" , Abhinav Kumar , "robh+dt@kernel.org" , Kuogee Hsieh , "agross@kernel.org" , "seanpaul@chromium.org" , "dmitry.baryshkov@linaro.org" , "thierry.reding@gmail.com" , "krzk+dt@kernel.org" , "bjorn.andersson@linaro.org" , "sean@poorly.run" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Sankeerth Billakanti (QUIC) (2022-03-25 06:30:58) > > > > > + vdda-1p2-supply = <&vreg_l6b_1p2>; > > > + vdda-0p9-supply = <&vreg_l10c_0p8>; > > > + > > > + aux-bus { > > > > Can this move to sc7280.dtsi and get a phandle? > > > > Okay, I will move this to sc7280.dtsi like below. > Shall I define the required properties under &mdss_edp_panel node in the sc7280-crd3.dts? The below patch looks good. > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -3283,6 +3283,18 @@ > > status = "disabled"; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 052C5C433F5 for ; Fri, 25 Mar 2022 19:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231964AbiCYUBL (ORCPT ); Fri, 25 Mar 2022 16:01:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231829AbiCYUAy (ORCPT ); Fri, 25 Mar 2022 16:00:54 -0400 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1E1817F3F5 for ; Fri, 25 Mar 2022 12:51:07 -0700 (PDT) Received: by mail-oi1-x22a.google.com with SMTP id e4so9301024oif.2 for ; Fri, 25 Mar 2022 12:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=eUek1jmX1h1x8PcNcflTTCV7rdiqXP/FImxouF9eXrk=; b=MuYU2U53+0XditHV3+xMmufekP83Q86clHPRUFiYJI5c83MMgqsqZU6OE0iD7uqI1D bq5BpO0h+DDnBW2dzr+T0KLiCp0GgYfvXmXPzjeUTmIwglTcDMjx2JTa8I15roXjfJQr QDYKF7wfPMDa6WIjm4l4EenX4il5h6oLp4L78= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=eUek1jmX1h1x8PcNcflTTCV7rdiqXP/FImxouF9eXrk=; b=XOrLiAjxxIp2twLnrh7QdyFpWfWYjtZhNyKc8UyS01yng4q2cZmMQ8uPXjTcnFerVu kDflzdvjx3d0TxSaHGnUkCrv/UsTHwuaboop8ClIeTqTPc8YummZ+RrAbJWEqnzdtDju 20xJjnEeuzgAm6lBig99KO2Pa6ScuG0y4WsblFmtOf7VL8kZNfZj2x7KMe89NN1/1DV2 /wFcKXFjs5q+00k892088YzwbwdTlxI3QAd+jpOOeeQ2183uF6ExW/6Y7lRuNow54xWx 3ZLh2N6paIP9fmmoF621uYPks8mIr1fs3VCjI08hJS+I/1FiydfvcBoCxgcXtwO5+flO 2wOg== X-Gm-Message-State: AOAM531XP/gh/C26yCkFIyI6k9EnAfopXfYHzslp0inke6HueybZU/2/ PCn0M2D6K/Ynd4HG94OWxDEEkEg6FsxeF2cK/jGBNQ== X-Google-Smtp-Source: ABdhPJxjJgDkwaOL+igFbYKoHRlPcGxtCqcdt2HqSpDefQv8NNUO1BG5eOIgAhxWNNRmCDuEqZtRbL5DhxFUglZ6hXs= X-Received: by 2002:aca:a9c8:0:b0:2da:45b6:b796 with SMTP id s191-20020acaa9c8000000b002da45b6b796mr5910648oie.193.1648237866373; Fri, 25 Mar 2022 12:51:06 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 25 Mar 2022 14:51:05 -0500 MIME-Version: 1.0 In-Reply-To: References: <1647452154-16361-1-git-send-email-quic_sbillaka@quicinc.com> <1647452154-16361-3-git-send-email-quic_sbillaka@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Fri, 25 Mar 2022 14:51:05 -0500 Message-ID: Subject: RE: [PATCH v5 2/9] arm64: dts: qcom: sc7280: Add support for eDP panel on CRD To: Sankeerth Billakanti , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "robdclark@gmail.com" , "seanpaul@chromium.org" , quic_kalyant , Abhinav Kumar , "dianders@chromium.org" , Kuogee Hsieh , "agross@kernel.org" , "bjorn.andersson@linaro.org" , "robh+dt@kernel.org" , "krzk+dt@kernel.org" , "sean@poorly.run" , "airlied@linux.ie" , "daniel@ffwll.ch" , "thierry.reding@gmail.com" , "sam@ravnborg.org" , "dmitry.baryshkov@linaro.org" , quic_vproddut Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Sankeerth Billakanti (QUIC) (2022-03-25 06:30:58) > > > > > + vdda-1p2-supply = <&vreg_l6b_1p2>; > > > + vdda-0p9-supply = <&vreg_l10c_0p8>; > > > + > > > + aux-bus { > > > > Can this move to sc7280.dtsi and get a phandle? > > > > Okay, I will move this to sc7280.dtsi like below. > Shall I define the required properties under &mdss_edp_panel node in the sc7280-crd3.dts? The below patch looks good. > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -3283,6 +3283,18 @@ > > status = "disabled";