From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39B4BC433EF for ; Tue, 5 Oct 2021 23:35:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0906E6121F for ; Tue, 5 Oct 2021 23:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236820AbhJEXhZ (ORCPT ); Tue, 5 Oct 2021 19:37:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236799AbhJEXhY (ORCPT ); Tue, 5 Oct 2021 19:37:24 -0400 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DE84C06174E for ; Tue, 5 Oct 2021 16:35:33 -0700 (PDT) Received: by mail-oi1-x22a.google.com with SMTP id w190so1520855oif.5 for ; Tue, 05 Oct 2021 16:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=56IzYsCngcQCBJWMD0JhwTzUl1q8pi+qZeXw6ytKK8A=; b=eRRinxuy/37yDFfXp6IVii9vjLkGuva0q1QVDD23ceHuI1Ku2gowQTk8r+Mi+XdmxX U2Wsp25IqyOlImWDr9V+UWMcKRvFJHL99YIhUVDVBQRG8DuQ01Lpl0DLnXurNPz2/fDy 7wW6jiSD1tcTXxwfxdEqh52XidJdgW83YrpTA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=56IzYsCngcQCBJWMD0JhwTzUl1q8pi+qZeXw6ytKK8A=; b=3plpSxky8OeidQCV5jQfZxbvXI/iLk+Gcq2+MVeWD0aSYEhJByiNqhwcypW0iZGDSE JicC+hF+i5j3trto1eQAeyGvWjb6jJ3clvFW2lEARQctrJxtc/+AK+pz+HW+i7GYCkb2 dQ968tIsDxYB1uCExnYkWSNYKIV8MtBTsFDCRfroB9gZ91nMW96ahtH+01KCwMy5Y915 +UlVvYsEPzKlA3SaNQGTOuMdoCMxbuw85BBn1VVnQmjQv6cGx/uwKkCqI1K0LxB/xPlR po9NHuilMjYa4HLGZjGKVR2+GTSjSxLNGrlU/jt2EFA61VnGQXY5OmiN5dlM2BJkndrl Aaig== X-Gm-Message-State: AOAM533JUNPbJ/Lh4C2GMMEwTmPrusc101bt1/fj8B483lXKNEstM7TN 4cNH84128n3Hj60f+oe9fwxAhr6DLEQfnnykVT/KcA== X-Google-Smtp-Source: ABdhPJz8EZyQff1TxdzuJVG8JQE9jeLRASYoOxoi7ECsw4XqrqgsNEazNQpnBxnQIQovikbvFIHbcAQ/6pYFY/+7Tqw= X-Received: by 2002:a05:6808:f8f:: with SMTP id o15mr4789420oiw.164.1633476932903; Tue, 05 Oct 2021 16:35:32 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Oct 2021 16:35:32 -0700 MIME-Version: 1.0 In-Reply-To: References: <20211005023750.2037631-1-bjorn.andersson@linaro.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 5 Oct 2021 16:35:32 -0700 Message-ID: Subject: Re: [PATCH] drm/msm/dp: Shorten SETUP timeout To: khsieh@codeaurora.org Cc: Bjorn Andersson , Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Rob Clark , Sean Paul , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sankeerth Billakanti Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting khsieh@codeaurora.org (2021-10-05 16:04:40) > On 2021-10-05 15:36, Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-10-05 14:40:38) > >> On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote: > >> > >> > Quoting Bjorn Andersson (2021-10-04 19:37:50) > >> > > Found in the middle of a patch from Sankeerth was the reduction of the > >> > > INIT_SETUP timeout from 10s to 100ms. Upon INIT_SETUP timeout the host > >> > > is initalized and HPD interrupt start to be serviced, so in the case of > >> > > eDP this reduction improves the user experience dramatically - i.e. > >> > > removes 9.9s of bland screen time at boot. > >> > > > >> > > Suggested-by: Sankeerth Billakanti > >> > > Signed-off-by: Bjorn Andersson > >> > > --- > >> > > >> > Any Fixes tag? BTW, the delay design is pretty convoluted. I had to go > >> > re-read the code a couple times to understand that it's waiting 100ms > >> > times the 'delay' number. Whaaaaat? > >> > > >> > >> I assume you're happy with the current 10s delay on the current > >> devices, so I don't think we should push for this to be backported. > >> I have no need for it to be backported on my side at least. > >> > > > > Sure. Fixes tag != backported to stable trees but it is close. > > > >> > Reviewed-by: Stephen Boyd > >> > dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 1); <== to 100ms > > This patch will prevent usb3 from working due to dp driver initialize > phy earlier than usb3 which cause timeout error at power up usb3 phy > when both edp and dp are enabled. That sounds pretty bad. > I had prepared a patch (drm/msm/dp: do not initialize combo phy until > plugin interrupt) to fix this problem. Great! When were you planning to report this problem on the list? > Unfortunately, my patch is depend on Bjorn's patch (PATCH v3 3/5] > drm/msm/dp: Support up to 3 DP controllers). > I will submit my patch for review once Bjorn's patches merged in. > Therefore I would think this patch should go after both Bjorn's patches > and my patch. > Why can't you send it now? Point to the other patch series as a dependency.