From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F79C433EF for ; Fri, 17 Sep 2021 00:55:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6D6B61241 for ; Fri, 17 Sep 2021 00:55:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242021AbhIQA40 (ORCPT ); Thu, 16 Sep 2021 20:56:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241940AbhIQA40 (ORCPT ); Thu, 16 Sep 2021 20:56:26 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46882C061756 for ; Thu, 16 Sep 2021 17:55:05 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id 6so11608593oiy.8 for ; Thu, 16 Sep 2021 17:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=2yH0Zt0O7gBl56UZTi2Aqh4YymYqkgwf1TTMl7F/bXo=; b=H0lHLP20LFpppz68jylyF0kBm32s2ENHdXDuWHo/9BSJo6Ho2Vtfxl1ggpn/h7bH+k vSPnQipeBqdE5Hh+ZYlRSgoQ8m+RpFXy//acsVdWCX+fdhrjSIhU3IWPPTccx/AWdHI8 iKniZ6s07bSukhxBoUXbQPXUAFa+KHqd/MIGc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=2yH0Zt0O7gBl56UZTi2Aqh4YymYqkgwf1TTMl7F/bXo=; b=bAJrYLEUG1krjZRmw0oLicW0aRti1f4yG9eLxkp1xgnM6QaD/5VvpGMlkfv7kfX71W XKhmJ+wTPh423SOv/u/i1hj+W2SLaOix2WPJxjlR0ePMLfmCE9UcF6UQ97EPcsUlVJom R/bd7E6WzUVOGvHRqdkKNBDX8s0VxCWMAhe38nHBpsfO5QwiIW4zeMOXGTB4MYlRIpgY 3TQhu97tUN1ZlCGi39hsUXs0Jq6HqM1e7m9tPbu7aNgoRfSoLYvsmHWHVrgmOc+EebVq HnOnZyMiPnwUwuuenJCAorc4FR4hOQ8izccx7QvpZGWOSU1rbOUIIAVZGhesoWVFZFmw m5mw== X-Gm-Message-State: AOAM530gqceDRchzWn1KZUM7JN7Xrmg7nld7+LP6/gPbnuktZBN3hBXD o8TBLmjqN/36aND70bTOAi20r2YIxNk9XQjVliAoYg== X-Google-Smtp-Source: ABdhPJyILhYG1yeMRXTOEinJ2nWQ5k/Wdk5oKtI6BocyrPxqkMfj6StMQ/RoL3uGpsxH8+vdgbsJTpfVXCkhobcsh24= X-Received: by 2002:aca:2310:: with SMTP id e16mr2036358oie.64.1631840104499; Thu, 16 Sep 2021 17:55:04 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 16 Sep 2021 17:55:04 -0700 MIME-Version: 1.0 In-Reply-To: <1631811121-32662-1-git-send-email-pillair@codeaurora.org> References: <1631811121-32662-1-git-send-email-pillair@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 16 Sep 2021 17:55:04 -0700 Message-ID: Subject: Re: [PATCH v3] arm64: dts: qcom: sc7280: Add WPSS remoteproc node To: Rakesh Pillai , agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sibis@codeaurora.org, mpubbise@codeaurora.org, kuabhs@chromium.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Rakesh Pillai (2021-09-16 09:52:01) > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > index 64fc22a..2b8bbcd 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts > @@ -1423,6 +1433,59 @@ > #power-domain-cells = <1>; > }; > > + remoteproc_wpss: remoteproc@8a00000 { > + compatible = "qcom,sc7280-wpss-pil"; > + reg = <0 0x08a00000 0 0x10000>; > + > + interrupts-extended = <&intc GIC_SPI 587 IRQ_TYPE_EDGE_RISING>, > + <&wpss_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > + <&wpss_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, > + <&wpss_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, > + <&wpss_smp2p_in 3 IRQ_TYPE_EDGE_RISING>, > + <&wpss_smp2p_in 7 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "wdog", "fatal", "ready", "handover", > + "stop-ack", "shutdown-ack"; > + > + clocks = <&gcc GCC_WPSS_AHB_BDG_MST_CLK>, > + <&gcc GCC_WPSS_AHB_CLK>, > + <&gcc GCC_WPSS_RSCP_CLK>, > + <&rpmhcc RPMH_CXO_CLK>; > + clock-names = "gcc_wpss_ahb_bdg_mst_clk", > + "gcc_wpss_ahb_clk", > + "gcc_wpss_rscp_clk", > + "xo"; > + > + power-domains = <&rpmhpd SC7280_CX>, > + <&rpmhpd SC7280_MX>; > + power-domain-names = "cx", "mx"; > + > + memory-region = <&wpss_mem>; > + > + qcom,qmp = <&aoss_qmp>; > + > + qcom,smem-states = <&wpss_smp2p_out 0>; > + qcom,smem-state-names = "stop"; > + > + resets = <&aoss_reset AOSS_CC_WCSS_RESTART>, > + <&pdc_reset PDC_WPSS_SYNC_RESET>; > + reset-names = "restart", "pdc_sync"; > + > + qcom,halt-regs = <&tcsr_mutex_regs 0x37000>; Where is this node defined? I don't see it on the mailing list for sc7280. Can you indicate what patches this depends on, and use git format-patch --base= so we can try to find them ourselves.