From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECF89C4338F for ; Mon, 23 Aug 2021 20:12:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1D09613D0 for ; Mon, 23 Aug 2021 20:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232262AbhHWUMr (ORCPT ); Mon, 23 Aug 2021 16:12:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231716AbhHWUMr (ORCPT ); Mon, 23 Aug 2021 16:12:47 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E112C061575 for ; Mon, 23 Aug 2021 13:12:04 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id c19-20020a9d6153000000b0051829acbfc7so39574882otk.9 for ; Mon, 23 Aug 2021 13:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=POiwHJcH23QK5EMwQWZLBbZ3EMO9rr1bfufNeMb6Dtg=; b=Zwa/jYiq9ajQMhNpRT/4QSrtThvXd2nt92BHoxA5m6czWSb3MotJ8TSzKMo7lWmHjP iz8x0+Ty+Mf4E2VooQpEgfOkpzzMMIF0eQaC4RZ42FsjK3KkpXiGG1xFloZiayXa2/e2 YHegKFwlOEBOBi5eARqw1xAHWPN8FURvGpZno= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=POiwHJcH23QK5EMwQWZLBbZ3EMO9rr1bfufNeMb6Dtg=; b=kwRKO7EA42yzgzWolLG8Yco9N5cXZOQaZo/xKv/JqNtOINWFqoOdhli7q65lqpzDXN OCH4nupgmS7rFNoLw3R98I281S771FM8TWifoTRjRHfOQfvasMyShmjBvXP+/QyAnT6l PUuaQaHt6rrLzPSdmoGVfj0COJ93p9ytjk5+UsnxVDUky9IR0Ihf/kVPtwY1H/st7h6t Zk9/VmcQRsPnIDwJMkqB0NVIY1HP+K3cPwNG8Lf6cYPzBrg43AIPMSu0VvUVo0wqdVSZ Nup5aa+TJ58vVgJUV7KL/L1Csa1EeNNNaf39GkSBbL/exh4ia2s0pbhUBXQp2QS/uGSo 8s7A== X-Gm-Message-State: AOAM5324iENVM0s76q2oVBwnTDOzfwcEKfucDUkMiX7OFL+iQlllMx63 7gs8nPH4InzpT8sdsJcRw15Q7FgpAfF0uZaa8o+rLA== X-Google-Smtp-Source: ABdhPJwex7Sxwx8tVMxehFbfF/8WWkSlhNesrH+dQz9oiKkGffOPqfeYUCY9Hqs1Ac+eg4X+WB0Dtfd+ojZu+YfTLcM= X-Received: by 2002:a05:6808:181a:: with SMTP id bh26mr258227oib.166.1629749523660; Mon, 23 Aug 2021 13:12:03 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 23 Aug 2021 15:12:02 -0500 MIME-Version: 1.0 In-Reply-To: <1629344185-27368-11-git-send-email-sibis@codeaurora.org> References: <1629344185-27368-1-git-send-email-sibis@codeaurora.org> <1629344185-27368-11-git-send-email-sibis@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 23 Aug 2021 15:12:02 -0500 Message-ID: Subject: Re: [PATCH v3 10/10] arm64: dts: qcom: sc7280: Update Q6V5 MSS node To: Sibi Sankar , bjorn.andersson@linaro.org, mka@chromium.org, robh+dt@kernel.org, saiprakash.ranjan@codeaurora.org, will@kernel.org Cc: ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Quoting Sibi Sankar (2021-08-18 20:36:25) > Update MSS node to support MSA based modem boot on SC7280 SoCs. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd > > v3: > * Place remoteproc_mpss node in alphabetical order above pinctrl > section. [Stephen] > > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 7 +++++++ > arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 ++++++++++++++++--- > 2 files changed, 23 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 103d89c1e1c7..f1c8641b0c26 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -263,6 +263,13 @@ > status = "okay"; > }; > > +&remoteproc_mpss { > + status = "okay"; > + compatible = "qcom,sc7280-mss-pil"; > + iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>; > + memory-region = <&mba_mem &mpss_mem>; Nitpick: memory-region = <&mba_mem>, <&mpss_mem>; would be better as it indicates that &mpss_mem isn't being parsed when &mba_mem is being parsed, i.e. they're independent phandles. > +}; > + > &sdhc_1 { > status = "okay"; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E68DDC4338F for ; Mon, 23 Aug 2021 20:14:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7F01613CF for ; Mon, 23 Aug 2021 20:14:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B7F01613CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xJjSnRYO2HXef2P9Vap6j39RxEb85Zb/SwtAAm2fPxc=; b=U7djJCEmLJ2xrY vxEV2gNUg5nqaJXL+JOqrc4oonSxIqXLVXve7+yan3bkOSdzL45PMJogyPqkwhkyk23W8jFK+EoXS 1JSZc/xYL44CIOzvkucAgCQwKrTtWvpC4A0Y8WgFcJtxt5TJNyjr6PF7CXOVRuudVnQ5CFz5u1WTs jLcTcN6lYSq9CFSzvY1tHSNRQ/52rIEAcpiqBib6DFDJAYYxwNInKOzqgLfbrD5l7BHAf6ju/z59v ir6NwN6lvJFgkBImy6GDnzu9tBHCR+B1Q7WhrCvCfAQaFQIIEIqKqO7l2Sk6CZd7i3JlQWrnFluj1 bSoRGeJ1JcItxVpR7xnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIGIm-000W9H-Vn; Mon, 23 Aug 2021 20:12:13 +0000 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIGIg-000W7W-Bt for linux-arm-kernel@lists.infradead.org; Mon, 23 Aug 2021 20:12:10 +0000 Received: by mail-ot1-x332.google.com with SMTP id y14-20020a0568302a0e00b0051acbdb2869so32821904otu.2 for ; Mon, 23 Aug 2021 13:12:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=POiwHJcH23QK5EMwQWZLBbZ3EMO9rr1bfufNeMb6Dtg=; b=Zwa/jYiq9ajQMhNpRT/4QSrtThvXd2nt92BHoxA5m6czWSb3MotJ8TSzKMo7lWmHjP iz8x0+Ty+Mf4E2VooQpEgfOkpzzMMIF0eQaC4RZ42FsjK3KkpXiGG1xFloZiayXa2/e2 YHegKFwlOEBOBi5eARqw1xAHWPN8FURvGpZno= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=POiwHJcH23QK5EMwQWZLBbZ3EMO9rr1bfufNeMb6Dtg=; b=XydTy9v6ekOlGU1mWFOjnNyKDGvl7woxgIjhZrfw0u8Hh7R8R9jnrBRtptMaSGsL8n aETxpmUrb1eCbn2eun7KQQsUT8Zsv0HnfKXmBisUEO9mjO4lDb+qAwQ1ddhbYtBTF+Ra JF2gwzW6YX3oAjEVCuLJ5aiQtq4uBzwNlP99sn4IRsqsL9Iq+XlwVjrONLGqgz5c577f YDdkGcLyDeK/AaKwOnXeWHSyJ9p4IjJ9/ihgojaULP0SACqMSiwE138Pb11JEV2V5cQA DxwQ3SkDSA1oARbSW1vbCC6AFzlqAEswBbKbKDoyl3sUQwo4AnVI4Xa0eNO/f3a8cxXk 5f7A== X-Gm-Message-State: AOAM5302fA5zH302XabVIoCjehtntj6JyZYpTEGhpdDQDkiUsRAzLrRT l1PC5RzqWab+6Cmm4K8veHdf9dnvxkvrr3sjq39dVA== X-Google-Smtp-Source: ABdhPJwex7Sxwx8tVMxehFbfF/8WWkSlhNesrH+dQz9oiKkGffOPqfeYUCY9Hqs1Ac+eg4X+WB0Dtfd+ojZu+YfTLcM= X-Received: by 2002:a05:6808:181a:: with SMTP id bh26mr258227oib.166.1629749523660; Mon, 23 Aug 2021 13:12:03 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 23 Aug 2021 15:12:02 -0500 MIME-Version: 1.0 In-Reply-To: <1629344185-27368-11-git-send-email-sibis@codeaurora.org> References: <1629344185-27368-1-git-send-email-sibis@codeaurora.org> <1629344185-27368-11-git-send-email-sibis@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 23 Aug 2021 15:12:02 -0500 Message-ID: Subject: Re: [PATCH v3 10/10] arm64: dts: qcom: sc7280: Update Q6V5 MSS node To: Sibi Sankar , bjorn.andersson@linaro.org, mka@chromium.org, robh+dt@kernel.org, saiprakash.ranjan@codeaurora.org, will@kernel.org Cc: ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210823_131206_472524_EAF14442 X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Sibi Sankar (2021-08-18 20:36:25) > Update MSS node to support MSA based modem boot on SC7280 SoCs. > > Signed-off-by: Sibi Sankar > --- Reviewed-by: Stephen Boyd > > v3: > * Place remoteproc_mpss node in alphabetical order above pinctrl > section. [Stephen] > > arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 7 +++++++ > arch/arm64/boot/dts/qcom/sc7280.dtsi | 19 ++++++++++++++++--- > 2 files changed, 23 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 103d89c1e1c7..f1c8641b0c26 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -263,6 +263,13 @@ > status = "okay"; > }; > > +&remoteproc_mpss { > + status = "okay"; > + compatible = "qcom,sc7280-mss-pil"; > + iommus = <&apps_smmu 0x124 0x0>, <&apps_smmu 0x488 0x7>; > + memory-region = <&mba_mem &mpss_mem>; Nitpick: memory-region = <&mba_mem>, <&mpss_mem>; would be better as it indicates that &mpss_mem isn't being parsed when &mba_mem is being parsed, i.e. they're independent phandles. > +}; > + > &sdhc_1 { > status = "okay"; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel