All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] driver core: Make dev_info() messages dev_dbg()
@ 2021-06-03  6:48 Stephen Boyd
  2021-06-03 16:18 ` Saravana Kannan
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2021-06-03  6:48 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-kernel, Saravana Kannan

These seem to mostly print debug information about device link stuff at
boot. They don't seem very useful outside of debugging so move them to
dev_dbg().

Cc: Saravana Kannan <saravanak@google.com>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 drivers/base/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 628e33939aca..066880a843bc 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -865,7 +865,7 @@ static void __device_link_del(struct kref *kref)
 {
 	struct device_link *link = container_of(kref, struct device_link, kref);
 
-	dev_info(link->consumer, "Dropping the link to %s\n",
+	dev_dbg(link->consumer, "Dropping the link to %s\n",
 		 dev_name(link->supplier));
 
 	pm_runtime_drop_link(link);
@@ -1732,7 +1732,7 @@ static int fw_devlink_create_devlink(struct device *con,
 		 */
 		if (!device_link_add(con, sup_dev, flags) &&
 		    !(flags & DL_FLAG_SYNC_STATE_ONLY)) {
-			dev_info(con, "Fixing up cyclic dependency with %s\n",
+			dev_dbg(con, "Fixing up cyclic dependency with %s\n",
 				 dev_name(sup_dev));
 			device_links_write_lock();
 			fw_devlink_relax_cycle(con, sup_dev);

base-commit: 5fcd0bc17e451e8f140067131fd12be0f5f1204c
-- 
https://chromeos.dev


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] driver core: Make dev_info() messages dev_dbg()
  2021-06-03  6:48 [PATCH] driver core: Make dev_info() messages dev_dbg() Stephen Boyd
@ 2021-06-03 16:18 ` Saravana Kannan
  2021-06-03 20:17   ` Stephen Boyd
  0 siblings, 1 reply; 3+ messages in thread
From: Saravana Kannan @ 2021-06-03 16:18 UTC (permalink / raw)
  To: Stephen Boyd; +Cc: Greg Kroah-Hartman, LKML

On Wed, Jun 2, 2021 at 11:48 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> These seem to mostly print debug information about device link stuff at
> boot. They don't seem very useful outside of debugging so move them to
> dev_dbg().
>
> Cc: Saravana Kannan <saravanak@google.com>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  drivers/base/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index 628e33939aca..066880a843bc 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -865,7 +865,7 @@ static void __device_link_del(struct kref *kref)
>  {
>         struct device_link *link = container_of(kref, struct device_link, kref);
>
> -       dev_info(link->consumer, "Dropping the link to %s\n",
> +       dev_dbg(link->consumer, "Dropping the link to %s\n",
>                  dev_name(link->supplier));

I think this is already fixed in Tot.

>
>         pm_runtime_drop_link(link);
> @@ -1732,7 +1732,7 @@ static int fw_devlink_create_devlink(struct device *con,
>                  */
>                 if (!device_link_add(con, sup_dev, flags) &&
>                     !(flags & DL_FLAG_SYNC_STATE_ONLY)) {
> -                       dev_info(con, "Fixing up cyclic dependency with %s\n",
> +                       dev_dbg(con, "Fixing up cyclic dependency with %s\n",
>                                  dev_name(sup_dev));
>                         device_links_write_lock();
>                         fw_devlink_relax_cycle(con, sup_dev);
>
> base-commit: 5fcd0bc17e451e8f140067131fd12be0f5f1204c

Nak on this one. This doesn't happen for most systems and for the
systems where this does happen, it's handy to figure out any boot
issues that might be caused by this cyclic dependency.

Maybe after a few kernel minor versions if no issues are reported with
fw_devlink for a while, I'd consider making it dbg.

-Saravana

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] driver core: Make dev_info() messages dev_dbg()
  2021-06-03 16:18 ` Saravana Kannan
@ 2021-06-03 20:17   ` Stephen Boyd
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2021-06-03 20:17 UTC (permalink / raw)
  To: Saravana Kannan; +Cc: Greg Kroah-Hartman, LKML

Quoting Saravana Kannan (2021-06-03 09:18:33)
> On Wed, Jun 2, 2021 at 11:48 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > These seem to mostly print debug information about device link stuff at
> > boot. They don't seem very useful outside of debugging so move them to
> > dev_dbg().
> >
> > Cc: Saravana Kannan <saravanak@google.com>
> > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > ---
> >  drivers/base/core.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > index 628e33939aca..066880a843bc 100644
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -865,7 +865,7 @@ static void __device_link_del(struct kref *kref)
> >  {
> >         struct device_link *link = container_of(kref, struct device_link, kref);
> >
> > -       dev_info(link->consumer, "Dropping the link to %s\n",
> > +       dev_dbg(link->consumer, "Dropping the link to %s\n",
> >                  dev_name(link->supplier));
>
> I think this is already fixed in Tot.

Any commit? I looked at linux-next but didn't see it.

>
> >
> >         pm_runtime_drop_link(link);
> > @@ -1732,7 +1732,7 @@ static int fw_devlink_create_devlink(struct device *con,
> >                  */
> >                 if (!device_link_add(con, sup_dev, flags) &&
> >                     !(flags & DL_FLAG_SYNC_STATE_ONLY)) {
> > -                       dev_info(con, "Fixing up cyclic dependency with %s\n",
> > +                       dev_dbg(con, "Fixing up cyclic dependency with %s\n",
> >                                  dev_name(sup_dev));
> >                         device_links_write_lock();
> >                         fw_devlink_relax_cycle(con, sup_dev);
> >
> > base-commit: 5fcd0bc17e451e8f140067131fd12be0f5f1204c
>
> Nak on this one. This doesn't happen for most systems and for the
> systems where this does happen, it's handy to figure out any boot
> issues that might be caused by this cyclic dependency.
>
> Maybe after a few kernel minor versions if no issues are reported with
> fw_devlink for a while, I'd consider making it dbg.
>

Ok, I see this is changed in rc4 so I'll resend.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-03 20:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03  6:48 [PATCH] driver core: Make dev_info() messages dev_dbg() Stephen Boyd
2021-06-03 16:18 ` Saravana Kannan
2021-06-03 20:17   ` Stephen Boyd

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.