From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 008DEC433F5 for ; Wed, 16 Feb 2022 02:22:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238570AbiBPCWn (ORCPT ); Tue, 15 Feb 2022 21:22:43 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:32960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239898AbiBPCWm (ORCPT ); Tue, 15 Feb 2022 21:22:42 -0500 Received: from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com [IPv6:2607:f8b0:4864:20::c33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9DF1EF787 for ; Tue, 15 Feb 2022 18:22:29 -0800 (PST) Received: by mail-oo1-xc33.google.com with SMTP id k13-20020a4a948d000000b003172f2f6bdfso932337ooi.1 for ; Tue, 15 Feb 2022 18:22:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=fK8Mmhno7fLan6TDKNBId+rzPxNl521LefBZ7ENEERM=; b=Tu1Au4lnq1UJyXBeqnsLeFbw8EaG4GbmxIUlt7svJCU5uTPzGtBJlwFoJJrtt7yrtO 9VA4f5mOw1mNlqn4q2kDkG/yRstq7Zfiru3dRcBqygJD6BeE6kioElcckVEu6+F8rtBL 1toixeet31wCEU5P9kJzO5SIS7RtAEADHB+s8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=fK8Mmhno7fLan6TDKNBId+rzPxNl521LefBZ7ENEERM=; b=0ef7LivzAD1q7n5nqRH8q8fPD8sKUfyyAYDT/Sfvrr0Oahg2HuG/XZW6JyYawsaBQq l1D+pzowk+gj4Lu9R38TNovjc20Hb3kynWLbwWKndDwpOqdajPHEU3nlPs5W5rgJB1dc Cmm7BiO5gg+ol2xx/sGkBTkkDZ18fy5X8Qko+TjPk0W8FXYsqkhLW4RxH121Nrm5r+sz /95vI627eU4Nd7qCN6LRJg05YCjqQD14BbnyiwuQKgYDcBfLpm0pTUpWHN9mflVYc435 gjBxVv3wXRFczx0hLXwRSqLVRpRVTHBYqkWEYSKgT17na4nR/HxA9qmDOmGUFgmsE4L1 RRSQ== X-Gm-Message-State: AOAM531R6syMBCsb0h/nLhqm4a2pim/gN614YIlYkqu98GTv2SwWLemA y0ffRIhhDFdaKIRf4jFOjo4n1fRNjSUtPn7jwkg1sw== X-Google-Smtp-Source: ABdhPJyjTYdIHsZuJ13hWO4CixvXg+H94za0iiOclD6oXF5Mh6GJpUPdUk1fk5or2G1mP8ewQeY5KV6BrvCV3C/kh+o= X-Received: by 2002:a05:6870:631a:b0:d1:7d97:806 with SMTP id s26-20020a056870631a00b000d17d970806mr289535oao.8.1644978147558; Tue, 15 Feb 2022 18:22:27 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 15 Feb 2022 18:22:27 -0800 MIME-Version: 1.0 In-Reply-To: <20220201151056.2480055-6-dmitry.baryshkov@linaro.org> References: <20220201151056.2480055-1-dmitry.baryshkov@linaro.org> <20220201151056.2480055-6-dmitry.baryshkov@linaro.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Tue, 15 Feb 2022 18:22:27 -0800 Message-ID: Subject: Re: [PATCH 5/6] drm/msm/dpu: remove struct dpu_encoder_irq To: Abhinav Kumar , Bjorn Andersson , Dmitry Baryshkov , Rob Clark , Sean Paul Cc: David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Dmitry Baryshkov (2022-02-01 07:10:55) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > index ff2218155b44..803fd6f25da1 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > @@ -231,7 +216,7 @@ struct dpu_encoder_phys { > atomic_t pending_ctlstart_cnt; > atomic_t pending_kickoff_cnt; > wait_queue_head_t pending_kickoff_wq; > - struct dpu_encoder_irq irq[INTR_IDX_MAX]; > + int irq[INTR_IDX_MAX]; > }; > > static inline int dpu_encoder_phys_inc_pending(struct dpu_encoder_phys *phys) > @@ -729,20 +727,8 @@ struct dpu_encoder_phys *dpu_encoder_phys_vid_init( > phys_enc->split_role = p->split_role; > phys_enc->intf_mode = INTF_MODE_VIDEO; > phys_enc->enc_spinlock = p->enc_spinlock; > - for (i = 0; i < INTR_IDX_MAX; i++) { > - irq = &phys_enc->irq[i]; > - irq->irq_idx = -EINVAL; > - } > - > - irq = &phys_enc->irq[INTR_IDX_VSYNC]; > - irq->name = "vsync_irq"; > - irq->intr_idx = INTR_IDX_VSYNC; > - irq->func = dpu_encoder_phys_vid_vblank_irq; > - > - irq = &phys_enc->irq[INTR_IDX_UNDERRUN]; > - irq->name = "underrun"; > - irq->intr_idx = INTR_IDX_UNDERRUN; > - irq->func = dpu_encoder_phys_vid_underrun_irq; > + for (i = 0; i < INTR_IDX_MAX; i++) Can this use ARRAY_SIZE(phys_enc->irq)? Safer that way. > + phys_enc->irq[i] = -EINVAL; > > atomic_set(&phys_enc->vblank_refcount, 0); > atomic_set(&phys_enc->pending_kickoff_cnt, 0); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 472CAC433F5 for ; Wed, 16 Feb 2022 02:22:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C8C210E60B; Wed, 16 Feb 2022 02:22:29 +0000 (UTC) Received: from mail-oo1-xc2e.google.com (mail-oo1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 408BB10E60C for ; Wed, 16 Feb 2022 02:22:28 +0000 (UTC) Received: by mail-oo1-xc2e.google.com with SMTP id x6-20020a4a4106000000b003193022319cso917071ooa.4 for ; Tue, 15 Feb 2022 18:22:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=fK8Mmhno7fLan6TDKNBId+rzPxNl521LefBZ7ENEERM=; b=Tu1Au4lnq1UJyXBeqnsLeFbw8EaG4GbmxIUlt7svJCU5uTPzGtBJlwFoJJrtt7yrtO 9VA4f5mOw1mNlqn4q2kDkG/yRstq7Zfiru3dRcBqygJD6BeE6kioElcckVEu6+F8rtBL 1toixeet31wCEU5P9kJzO5SIS7RtAEADHB+s8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=fK8Mmhno7fLan6TDKNBId+rzPxNl521LefBZ7ENEERM=; b=p4JM1T1j4rManrAyUcFQjJSufZxK1JboCxD6RWvc+mOKt4QLwo/5oD6ZfXcEDqWH+n SLtj3EREGmk807sQ/id5CLjs/WoSt8dEZE2q25iOctbshLPk2fiEijSonBVkHVHPFE+7 f3bshU+FcJ8sCstyKEoplFhMFLvjEUd0JO3KSYB9uBhvDk4ilvsShVqiklfJHSlZH+ht STDkU4SLkXycMVu4AOu+bWyD38iSQq1oEN1VQeKF2n4ssMHJEjm5Pu+UfKhC5TrWtyda bOYV6d0z/tKBEx0XosjO19jPctIe/1f1rsY86sgMab5GHp05BZfA2umKV97AKSjlGrCL fkgw== X-Gm-Message-State: AOAM532W3EhfvUaZHAzu++TBhRE5a1srwV8w1r1ETO82zTMTo4HPda7b oO6p5aeRPW+nGYFYyVqSHP9eHd8ZKuKZRi3k6OQHbQ== X-Google-Smtp-Source: ABdhPJyjTYdIHsZuJ13hWO4CixvXg+H94za0iiOclD6oXF5Mh6GJpUPdUk1fk5or2G1mP8ewQeY5KV6BrvCV3C/kh+o= X-Received: by 2002:a05:6870:631a:b0:d1:7d97:806 with SMTP id s26-20020a056870631a00b000d17d970806mr289535oao.8.1644978147558; Tue, 15 Feb 2022 18:22:27 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 15 Feb 2022 18:22:27 -0800 MIME-Version: 1.0 In-Reply-To: <20220201151056.2480055-6-dmitry.baryshkov@linaro.org> References: <20220201151056.2480055-1-dmitry.baryshkov@linaro.org> <20220201151056.2480055-6-dmitry.baryshkov@linaro.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Tue, 15 Feb 2022 18:22:27 -0800 Message-ID: Subject: Re: [PATCH 5/6] drm/msm/dpu: remove struct dpu_encoder_irq To: Abhinav Kumar , Bjorn Andersson , Dmitry Baryshkov , Rob Clark , Sean Paul Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Dmitry Baryshkov (2022-02-01 07:10:55) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > index ff2218155b44..803fd6f25da1 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > @@ -231,7 +216,7 @@ struct dpu_encoder_phys { > atomic_t pending_ctlstart_cnt; > atomic_t pending_kickoff_cnt; > wait_queue_head_t pending_kickoff_wq; > - struct dpu_encoder_irq irq[INTR_IDX_MAX]; > + int irq[INTR_IDX_MAX]; > }; > > static inline int dpu_encoder_phys_inc_pending(struct dpu_encoder_phys *phys) > @@ -729,20 +727,8 @@ struct dpu_encoder_phys *dpu_encoder_phys_vid_init( > phys_enc->split_role = p->split_role; > phys_enc->intf_mode = INTF_MODE_VIDEO; > phys_enc->enc_spinlock = p->enc_spinlock; > - for (i = 0; i < INTR_IDX_MAX; i++) { > - irq = &phys_enc->irq[i]; > - irq->irq_idx = -EINVAL; > - } > - > - irq = &phys_enc->irq[INTR_IDX_VSYNC]; > - irq->name = "vsync_irq"; > - irq->intr_idx = INTR_IDX_VSYNC; > - irq->func = dpu_encoder_phys_vid_vblank_irq; > - > - irq = &phys_enc->irq[INTR_IDX_UNDERRUN]; > - irq->name = "underrun"; > - irq->intr_idx = INTR_IDX_UNDERRUN; > - irq->func = dpu_encoder_phys_vid_underrun_irq; > + for (i = 0; i < INTR_IDX_MAX; i++) Can this use ARRAY_SIZE(phys_enc->irq)? Safer that way. > + phys_enc->irq[i] = -EINVAL; > > atomic_set(&phys_enc->vblank_refcount, 0); > atomic_set(&phys_enc->pending_kickoff_cnt, 0);