From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE8CBC433F5 for ; Thu, 12 May 2022 00:52:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231406AbiELAwb (ORCPT ); Wed, 11 May 2022 20:52:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229998AbiELAw3 (ORCPT ); Wed, 11 May 2022 20:52:29 -0400 Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E82A660ABC for ; Wed, 11 May 2022 17:52:28 -0700 (PDT) Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-ed9ac77cbbso4929358fac.1 for ; Wed, 11 May 2022 17:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=SO048bkaqtJpnNOMEvZB35O9DTWVZ1Wg9kxc4ycyFjg=; b=cOc/ULhNS4VZgkhofRchN39m+cfbPtZsxhK2XKYkfT2dFHetpaa89L2NTSPaoYADiZ DPkgapU/gqwvkkJPzoL3lwgAIpTKGEqV+rQOpuUTp5THjNE1vXdLfxej+k05z8TDHrKI eoPWGslKfu1cmud7L+fcfMsfQuuk2c64zlCnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=SO048bkaqtJpnNOMEvZB35O9DTWVZ1Wg9kxc4ycyFjg=; b=lZMtuqcRug+d0NJpNR8/CH+R4qGIb+PaemAjApLSTlk3BrnOrVQ5ONOI4x3+gzjTss 84EKYgH7wPoM3cFQrOEcCzIPuUvrKgvBxr6aYQHZdUVpWyjOkEmHr44kbKG1izEtAtHO PYHB5nO0D0yL06xFPKd2z1SifwmdbMFaRvuwGKa27a4XrcTSQFGKANsNUBu7v2pZ/hZg 9hDYEZiv2V5N/42RftAmDXmvtNoVhD80UhAt0VkHDIbsutHqdtNqXwlIydms2b2m1cCJ La9PDg3CNVQKYQ51/HQ4OnSjrre08/QX67KN4N/jXEQtB9cZEJf4ytfrp+yyxZaGe2KW RB3g== X-Gm-Message-State: AOAM530Hjjx7yB0U2SJRxN5sDXFKYcjeCogiTAxmGYW5VSJ8/sw/SQgK urQeswQ/ggZN0uXbrRPsxzISUZtCe6ldGDF6paPvjw== X-Google-Smtp-Source: ABdhPJwX4oTvClZRn3k1F+TWgXVFBrjhZFK8ryObp71Dxi76wH3GSTdge9rwubpK0xGCkBygRmrlaUl0Lz8oFCYnoDg= X-Received: by 2002:a05:6870:40c1:b0:ed:9a12:3f95 with SMTP id l1-20020a05687040c100b000ed9a123f95mr4167327oal.193.1652316748287; Wed, 11 May 2022 17:52:28 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 11 May 2022 17:52:27 -0700 MIME-Version: 1.0 In-Reply-To: <20220507114009.1696278-1-dmitry.baryshkov@linaro.org> References: <20220507114009.1696278-1-dmitry.baryshkov@linaro.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Wed, 11 May 2022 17:52:27 -0700 Message-ID: Subject: Re: [PATCH] drm/msm/dpu: remove NULL-ness check in dpu_hw_intr_destroy To: Abhinav Kumar , Dmitry Baryshkov , Rob Clark , Sean Paul Cc: David Airlie , Daniel Vetter , Bjorn Andersson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, kernel test robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Dmitry Baryshkov (2022-05-07 04:40:09) > There is no need to check that kfree() argument is not NULL. Remove > extra check and call kfree() unconditionally. > > Reported-by: kernel test robot > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F03A9C433F5 for ; Thu, 12 May 2022 00:52:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 026D810E74E; Thu, 12 May 2022 00:52:30 +0000 (UTC) Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 175FE10E74E for ; Thu, 12 May 2022 00:52:29 +0000 (UTC) Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-e2fa360f6dso4934330fac.2 for ; Wed, 11 May 2022 17:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=SO048bkaqtJpnNOMEvZB35O9DTWVZ1Wg9kxc4ycyFjg=; b=cOc/ULhNS4VZgkhofRchN39m+cfbPtZsxhK2XKYkfT2dFHetpaa89L2NTSPaoYADiZ DPkgapU/gqwvkkJPzoL3lwgAIpTKGEqV+rQOpuUTp5THjNE1vXdLfxej+k05z8TDHrKI eoPWGslKfu1cmud7L+fcfMsfQuuk2c64zlCnI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=SO048bkaqtJpnNOMEvZB35O9DTWVZ1Wg9kxc4ycyFjg=; b=OlEDwnG9SLqtCCIMUdwqu0PNrwCuZ4L/6nKF4CHrnnmJicYZx9kEfGJeUG4ep7QfiQ mnqr/lYvGPkTHolqxVIWptz2DzG9aH1ssFznHWY9HDih1A5U/gz4H9bHbCHdxjkCZiBy Z/xkNHadxyiqw+QldoGQdIuWd2mg7nP+zHB6LM82KPuSgG17lk33Zu5vUijs6gdBKOVb 327rh5NGWd0KcYXOH9ZNbcW5KYcsUO58UxCyn+VjS0O64jg6RjN/Z8dErs4F1vo6OHvu 2qEE++p7dQAbEFdTM3YcOde0OGPC9Q89YjESx/YJ3l37rF6LLFVTrgd7YTsOf4AQL2jL +QUA== X-Gm-Message-State: AOAM533qAhVEGQVpHWOgYStd9lgix6WVvlyIawziQ4qaaNrmbDQc7/su 64980cJU8WVC6aAZnnB5avuH+C4xW9SBqlVebQ3HBw== X-Google-Smtp-Source: ABdhPJwX4oTvClZRn3k1F+TWgXVFBrjhZFK8ryObp71Dxi76wH3GSTdge9rwubpK0xGCkBygRmrlaUl0Lz8oFCYnoDg= X-Received: by 2002:a05:6870:40c1:b0:ed:9a12:3f95 with SMTP id l1-20020a05687040c100b000ed9a123f95mr4167327oal.193.1652316748287; Wed, 11 May 2022 17:52:28 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 11 May 2022 17:52:27 -0700 MIME-Version: 1.0 In-Reply-To: <20220507114009.1696278-1-dmitry.baryshkov@linaro.org> References: <20220507114009.1696278-1-dmitry.baryshkov@linaro.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Wed, 11 May 2022 17:52:27 -0700 Message-ID: Subject: Re: [PATCH] drm/msm/dpu: remove NULL-ness check in dpu_hw_intr_destroy To: Abhinav Kumar , Dmitry Baryshkov , Rob Clark , Sean Paul Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Dmitry Baryshkov (2022-05-07 04:40:09) > There is no need to check that kfree() argument is not NULL. Remove > extra check and call kfree() unconditionally. > > Reported-by: kernel test robot > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd