From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E9EDC433EF for ; Fri, 24 Jun 2022 23:45:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231781AbiFXXpp (ORCPT ); Fri, 24 Jun 2022 19:45:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231395AbiFXXpo (ORCPT ); Fri, 24 Jun 2022 19:45:44 -0400 Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9FD88AC31 for ; Fri, 24 Jun 2022 16:45:42 -0700 (PDT) Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-101ec2d6087so5816991fac.3 for ; Fri, 24 Jun 2022 16:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc:content-transfer-encoding; bh=j+1eIf5O9WMahlJkl8hYNSnk/bm8biDohg259LJoO/g=; b=WjPp2QhLMxAzMvmNH6Bdyvi7wrjsIG/6SVnjeCIx33ZdnrT0FzloaiGfU0lA3CDeJb D7xY66ytKYA57XIKpfe59/dnVK12xL/fRml9igY3so3l01YCoor2ZFtI37sGeL7idQg1 4VcAOUxad5AkwdS3gKl9l0rQuEiSBnIGTifw4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc:content-transfer-encoding; bh=j+1eIf5O9WMahlJkl8hYNSnk/bm8biDohg259LJoO/g=; b=NP7uxApJSBACmzY6dp12B+Q6Yh7kaYRNmFTv+gqRY+eKjxkGung+VMAd6krZ0Rgph1 juM9Tcfn4dgk+OJs4FzbIyx7WWSnRatKP0xBG6OXm9f4sJw4UoydHUfGMXQISI+lowls JZKMTP5Mbs6TG1YbP2eHYlXg2VIUMfboc3VNRaP3vhcMtDR9uLluMJlx/AtEy56ifw7Y Uq2rbDyfUl8ZB3zB8qx5Ez6IgUcaQlqoU1xO5MV6jkI1Fy59de6mXRguMbs2Vtv3xLZD 9YcmYrr3HtkmYpz3FT38/nMataO/bjVRxrbM03SqDA4zVANpn4JRs42gJdkXEVWasLbC xP0Q== X-Gm-Message-State: AJIora8IHsD92o28hh1nR4b52O25ntdYCnByzo1OCDnSIE4TcKI4NbGy 1oa8lQiKcIbOXUeDPlPdSAfpp1+Uwqon1vChw2xbGQ== X-Google-Smtp-Source: AGRyM1u4e57uuPYmBFxhp7AQ2EnNSWg/r4goHtlbSbtUqSiLnWrjbX1DesaUaEXpyg5Qm32+9mU8qIwp9idPpGqo2As= X-Received: by 2002:a05:6870:b381:b0:fe:2004:b3b5 with SMTP id w1-20020a056870b38100b000fe2004b3b5mr1007924oap.63.1656114342063; Fri, 24 Jun 2022 16:45:42 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 24 Jun 2022 16:45:41 -0700 MIME-Version: 1.0 In-Reply-To: <0ff3d6a3-dc5c-7c77-f8a1-6c4f6c1a3215@quicinc.com> References: <1656090912-18074-1-git-send-email-quic_khsieh@quicinc.com> <1656090912-18074-3-git-send-email-quic_khsieh@quicinc.com> <007ea4c9-9701-f4ab-3278-5d36bf2018c4@quicinc.com> <326912ff-9771-0711-366d-79acd436908b@quicinc.com> <0ff3d6a3-dc5c-7c77-f8a1-6c4f6c1a3215@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Fri, 24 Jun 2022 16:45:41 -0700 Message-ID: Subject: Re: [PATCH v1 2/3] drm/msm/dp: decoupling dp->id out of dp controller_id at scxxxx_dp_cfg table To: Kuogee Hsieh , agross@kernel.org, airlied@linux.ie, bjorn.andersson@linaro.org, daniel@ffwll.ch, dianders@chromium.org, dmitry.baryshkov@linaro.org, dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org Cc: quic_abhinavk@quicinc.com, quic_aravindh@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Kuogee Hsieh (2022-06-24 16:30:59) > > On 6/24/2022 4:12 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-06-24 15:53:45) > >> MSM_DP_CONTROLLER_1 need to match to the index =3D 1 of sc7280_dp_cfg[= ] <=3D=3D This is correct > >> > >> The problem is sc7280_dp_cfg[] have two entries since eDP place at ind= ex > >> of MSM_DP_CONTROLLER_1. > >> > >> but .num_desc =3D 1=C2=A0 <=3D=3D this said only have one entry at sc7= 280_dp_cfg[] > >> table. Therefore eDP will never be found at for loop=C2=A0 at > >> _dpu_kms_initialize_displayport(). > >> > > Yes, but what else does the MSM_DP_CONTROLLER_1 need to match? Because > > the intention of the previous commit was to make it so the order of > > sc7280_dp_cfg couldn't be messed up and not match the > > MSM_DP_CONTROLLER_1 value that lives in sc7280_intf[]. > > > at=C2=A0 _dpu_kms_initialize_displayport() > > > - info.h_tile_instance[0] =3D i; <=3D=3D assign i to become= dp controller id, "i" is index of scxxxx_dp_cfg[] > > This what I mean MSM_DP_CONTROLLER_1 need to match to index =3D 1 of > scxxxx_dp_cfg[]. > > it it is not match, then MSM_DP_CONTROLLER_1 with match to different INTF= . I thought we matched the INTF instance by searching through sc7280_intf[] for a matching MSM_DP_CONTROLLER_1 and then returning that INTF number. See dpu_encoder_get_intf() and the caller. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C43BC43334 for ; Fri, 24 Jun 2022 23:45:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E58810EB2E; Fri, 24 Jun 2022 23:45:44 +0000 (UTC) Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by gabe.freedesktop.org (Postfix) with ESMTPS id C52A710EB2E for ; Fri, 24 Jun 2022 23:45:42 +0000 (UTC) Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-101dc639636so5801352fac.6 for ; Fri, 24 Jun 2022 16:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc:content-transfer-encoding; bh=j+1eIf5O9WMahlJkl8hYNSnk/bm8biDohg259LJoO/g=; b=WjPp2QhLMxAzMvmNH6Bdyvi7wrjsIG/6SVnjeCIx33ZdnrT0FzloaiGfU0lA3CDeJb D7xY66ytKYA57XIKpfe59/dnVK12xL/fRml9igY3so3l01YCoor2ZFtI37sGeL7idQg1 4VcAOUxad5AkwdS3gKl9l0rQuEiSBnIGTifw4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc:content-transfer-encoding; bh=j+1eIf5O9WMahlJkl8hYNSnk/bm8biDohg259LJoO/g=; b=JKcujZRzDFUHyZuA0gd88nm13djESibAxtdzlyvlL79NYeIb204RRhgz0QDBIYmZox 9L5MG0sUB38c3OhDlYC5oL+g/L+zzK1K5paUqEVtd6oqZPEn6SPUEi1hLq/zStCp9dTS KapY1De96LHZLUKu6yWg1fev1RKqivlcccjBO4Imneg0cRU4HrjS0PFf1fTMia4AUvit j+Z0mS8n9YLuB1AV4+GGD7HMNWKutO7tJ1kQxhOdYYb60Z15rn2079EaxScdmYzY9DmZ Di3rlxNhhlsnrElj7Wp1XbepcshqmKOx1dkUhIEHB3fyNI4UgeBaBSGHtG9fnpGwK/1X xP3g== X-Gm-Message-State: AJIora+/MvlE/POpqqJq5fGPzb+yqiO8cQcSHQwB+DN5xPqTRtzHQyEc MNMTg8W5HIMFV3qbP6AUWqafNVp+3y/Qlet9NeLCcQ== X-Google-Smtp-Source: AGRyM1u4e57uuPYmBFxhp7AQ2EnNSWg/r4goHtlbSbtUqSiLnWrjbX1DesaUaEXpyg5Qm32+9mU8qIwp9idPpGqo2As= X-Received: by 2002:a05:6870:b381:b0:fe:2004:b3b5 with SMTP id w1-20020a056870b38100b000fe2004b3b5mr1007924oap.63.1656114342063; Fri, 24 Jun 2022 16:45:42 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 24 Jun 2022 16:45:41 -0700 MIME-Version: 1.0 In-Reply-To: <0ff3d6a3-dc5c-7c77-f8a1-6c4f6c1a3215@quicinc.com> References: <1656090912-18074-1-git-send-email-quic_khsieh@quicinc.com> <1656090912-18074-3-git-send-email-quic_khsieh@quicinc.com> <007ea4c9-9701-f4ab-3278-5d36bf2018c4@quicinc.com> <326912ff-9771-0711-366d-79acd436908b@quicinc.com> <0ff3d6a3-dc5c-7c77-f8a1-6c4f6c1a3215@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Fri, 24 Jun 2022 16:45:41 -0700 Message-ID: Subject: Re: [PATCH v1 2/3] drm/msm/dp: decoupling dp->id out of dp controller_id at scxxxx_dp_cfg table To: Kuogee Hsieh , agross@kernel.org, airlied@linux.ie, bjorn.andersson@linaro.org, daniel@ffwll.ch, dianders@chromium.org, dmitry.baryshkov@linaro.org, dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_sbillaka@quicinc.com, linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com, linux-kernel@vger.kernel.org, quic_aravindh@quicinc.com, freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Kuogee Hsieh (2022-06-24 16:30:59) > > On 6/24/2022 4:12 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-06-24 15:53:45) > >> MSM_DP_CONTROLLER_1 need to match to the index =3D 1 of sc7280_dp_cfg[= ] <=3D=3D This is correct > >> > >> The problem is sc7280_dp_cfg[] have two entries since eDP place at ind= ex > >> of MSM_DP_CONTROLLER_1. > >> > >> but .num_desc =3D 1=C2=A0 <=3D=3D this said only have one entry at sc7= 280_dp_cfg[] > >> table. Therefore eDP will never be found at for loop=C2=A0 at > >> _dpu_kms_initialize_displayport(). > >> > > Yes, but what else does the MSM_DP_CONTROLLER_1 need to match? Because > > the intention of the previous commit was to make it so the order of > > sc7280_dp_cfg couldn't be messed up and not match the > > MSM_DP_CONTROLLER_1 value that lives in sc7280_intf[]. > > > at=C2=A0 _dpu_kms_initialize_displayport() > > > - info.h_tile_instance[0] =3D i; <=3D=3D assign i to become= dp controller id, "i" is index of scxxxx_dp_cfg[] > > This what I mean MSM_DP_CONTROLLER_1 need to match to index =3D 1 of > scxxxx_dp_cfg[]. > > it it is not match, then MSM_DP_CONTROLLER_1 with match to different INTF= . I thought we matched the INTF instance by searching through sc7280_intf[] for a matching MSM_DP_CONTROLLER_1 and then returning that INTF number. See dpu_encoder_get_intf() and the caller.