From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9356FC4708B for ; Tue, 25 May 2021 21:36:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A2C3613AD for ; Tue, 25 May 2021 21:36:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232958AbhEYVhy (ORCPT ); Tue, 25 May 2021 17:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232573AbhEYVhy (ORCPT ); Tue, 25 May 2021 17:37:54 -0400 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FDC4C061574 for ; Tue, 25 May 2021 14:36:24 -0700 (PDT) Received: by mail-oi1-x232.google.com with SMTP id z3so31668453oib.5 for ; Tue, 25 May 2021 14:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=oIw6Lm/oEW4kxw3eJiq093+7BPtybJnf2iAVAUKE+sM=; b=Ij/vaAeJmniEAxFBeZvrK6vWuXnus+DNYdZ6aQCicMy1Jc4wKLWqEETu3fAE5O2vw/ eoIb4O29CH6fH9sFGvo68N2816adL01iY3DWGtZS7QbP4VAjSFHoYVrPM87BBbaQkD2D QYxpGmbFTR8AXLvuWqCNkx6HFH4qdyQ1Pc2v8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=oIw6Lm/oEW4kxw3eJiq093+7BPtybJnf2iAVAUKE+sM=; b=FCNdj5ckx0W8o4/Qjrt6sB9TgcREwcAJA5Du7AS0fIwLysyW1l6WjMk8i03K1xNv10 A4nqUbnjYlYaWeDxnFiSeThai6x8qM+8+UQECg2S2HdA471MWa0tsafpW4yAHsvCEtol HlMRcmcfv/RWHhrZ+ccXm1DhI7S+8sNKBPT6I2UHFW+skj0bLMgsOs0p6P5t6GruQkQ0 Z/T4rsxgL7UDS9fMtH7454MTq/ntsuhG1ZtbKUTNV5oNjmAusgGVU1OZ3rrgLEWSZXYQ w7ieNjZUw41wR6woIJc8O/MilPPoIuKo92BOXV9qPmSyTFX8PUlwV4L1g6BZxID/P1p8 HYBQ== X-Gm-Message-State: AOAM533PZc2iUnDQ7prHM4aE3Wx+rKgaGNl0IncFsmInW54yVIhbQnVU 7fi5nnHFUhSMb2vJ2+TG9OoPjRkbwREKVo01aaIdMg== X-Google-Smtp-Source: ABdhPJwNsDttLPTEzEPUI36VovAcfJ6b4EI4MmCDl4scokm5BDtcdbM8uZchDV6/AnozgWdsmwNeoO2/h+YIlgOhzoU= X-Received: by 2002:a54:4501:: with SMTP id l1mr15689617oil.19.1621978583504; Tue, 25 May 2021 14:36:23 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 25 May 2021 17:36:23 -0400 MIME-Version: 1.0 In-Reply-To: <20210525131051.31250-3-rojay@codeaurora.org> References: <20210525131051.31250-1-rojay@codeaurora.org> <20210525131051.31250-3-rojay@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 25 May 2021 17:36:23 -0400 Message-ID: Subject: Re: [PATCH V11 2/2] i2c: i2c-qcom-geni: Suspend and resume the bus during SYSTEM_SLEEP_PM ops To: Roja Rani Yarubandi , wsa@kernel.org Cc: dianders@chromium.org, saiprakash.ranjan@codeaurora.org, gregkh@linuxfoundation.org, mka@chromium.org, skananth@codeaurora.org, msavaliy@qti.qualcomm.com, skakit@codeaurora.org, rnayak@codeaurora.org, agross@kernel.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, sumit.semwal@linaro.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Roja Rani Yarubandi (2021-05-25 06:10:51) > Mark bus as suspended during system suspend to block the future > transfers. Implement geni_i2c_resume_noirq() to resume the bus. May also be worth noting that this causes some warnings on trogdor boards because suspend ordering is incorrect and the bus is being accessed after it is suspended. Unless that is all resolved? > > Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller") > Signed-off-by: Roja Rani Yarubandi > --- Reviewed-by: Stephen Boyd