From: Stephen Boyd <swboyd@chromium.org>
To: Rakesh Pillai <pillair@codeaurora.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, ohad@wizery.com,
p.zabel@pengutronix.de, robh+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, sibis@codeaurora.org,
mpubbise@codeaurora.org, kuabhs@chromium.org
Subject: Re: [PATCH v3 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support
Date: Thu, 16 Sep 2021 23:25:35 -0700 [thread overview]
Message-ID: <CAE-0n51KBYjZvwGNy06_okmEWjEfRLQO54CYaY6-JnbBk6kOhA@mail.gmail.com> (raw)
In-Reply-To: <1631811353-503-3-git-send-email-pillair@codeaurora.org>
Quoting Rakesh Pillai (2021-09-16 09:55:52)
> @@ -78,6 +84,10 @@ properties:
> Phandle reference to a syscon representing TCSR followed by the
> three offsets within syscon for q6, modem and nc halt registers.
>
> + qcom,qmp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Reference to the AOSS side-channel message RAM.
> +
> qcom,smem-states:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> description: States used by the AP to signal the Hexagon core
> @@ -117,6 +127,33 @@ allOf:
> compatible:
> contains:
> enum:
> + - qcom,sc7280-wpss-pil
> + then:
Honestly I find this if/else to be a huge tangle. Why not split the
binding so that each compatible is a different file? Then it is easier
to read and see what properties to set.
> + properties:
> + interrupts-extended:
> + maxItems: 6
> + items:
> + - description: Watchdog interrupt
> + - description: Fatal interrupt
> + - description: Ready interrupt
next prev parent reply other threads:[~2021-09-17 6:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 16:55 [PATCH v3 0/3] Add support for sc7280 WPSS PIL loading Rakesh Pillai
2021-09-16 16:55 ` [PATCH v3 1/3] dt-bindings: remoteproc: qcom: adsp: Convert binding to YAML Rakesh Pillai
2021-09-17 6:24 ` Stephen Boyd
2021-09-21 23:28 ` Rob Herring
2021-09-22 5:01 ` pillair
2021-09-16 16:55 ` [PATCH v3 2/3] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support Rakesh Pillai
2021-09-17 6:25 ` Stephen Boyd [this message]
2021-09-17 10:26 ` pillair
2021-09-21 23:37 ` Bjorn Andersson
2021-09-22 5:03 ` pillair
2021-09-16 16:55 ` [PATCH v3 3/3] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS Rakesh Pillai
2021-09-17 6:26 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n51KBYjZvwGNy06_okmEWjEfRLQO54CYaY6-JnbBk6kOhA@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kuabhs@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mpubbise@codeaurora.org \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=pillair@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.