From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 270CEC433EF for ; Tue, 8 Mar 2022 20:25:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 34E8F10E561; Tue, 8 Mar 2022 20:25:19 +0000 (UTC) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5947D10E25E for ; Tue, 8 Mar 2022 20:25:18 +0000 (UTC) Received: by mail-oi1-x234.google.com with SMTP id k2so505887oia.2 for ; Tue, 08 Mar 2022 12:25:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=oDPDk3UmBsVk40ec9UZG1guo+bgLJlbyhqOvTa87J18=; b=ZEU3s/iBsPE/dcbZEncVtRdgyz4R+oUlZ8IFZd75aCfzqlFSkSNyCjKiT+LTsfYBHl Cm9iCylS8NjPhmqGyLleWV/AlIuLHWBBjfRO9YzBSGOiL+HUUoYiriTtZCjxZs0k6RSS JHDC2KWjdYFrWraKvKeVS8XH3ypl7yOLBoubU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=oDPDk3UmBsVk40ec9UZG1guo+bgLJlbyhqOvTa87J18=; b=Lx2X9TwNrazZV+IMCmDPoCzmrOG5ERph2gHAEEuIbMWuBcm5fMtQbf4fL0/NDNOWz+ rHn3NX0b8Ad/gQvz4hvtN0HzRL4kOpRGe+/fpI17/aT5NE4EsP8YqYASuFYQNNF3KMVI RFISP2XrJ9XLi86ofdIUNeF73lLsPNXcLM1KYzBYau9HpJXgwR8xnut1Qglwy/jgOkWJ lZaV8/T8RecfmKGV754YL/tWpayD1+v/wI6AD/xd2lVQ/Sfi70hkX80NPDXmvqCee56E dt61AvHiEX13h6KGm5vNAo0CT8KJR5gB3c/iHcKU6pDMrxA3NhZ3FZEapg4hbVB80BHS 3Iog== X-Gm-Message-State: AOAM530sM0cQYFGJ+ZNaHzF6BK6+MKq0iiBCsq4Q3oV/ZAmB5lN+wxqg qC3anH6BhQuMNEXWxwWQfbxVGnJyGUiLzNcHuE7w412gZ44= X-Google-Smtp-Source: ABdhPJyfkvCfjSZ//u1fwsUJLWTGqZE5hW7zbIbFOcJy9M5AYS6WsphZTeYWH38/SUWdTsorovwAZS/YNjiEUrd/bVU= X-Received: by 2002:a05:6808:220d:b0:2d4:99cb:3849 with SMTP id bd13-20020a056808220d00b002d499cb3849mr3846554oib.63.1646771117701; Tue, 08 Mar 2022 12:25:17 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 8 Mar 2022 12:25:16 -0800 MIME-Version: 1.0 In-Reply-To: <20220307133105.GA17534@kili> References: <20220307133105.GA17534@kili> From: Stephen Boyd User-Agent: alot/0.10 Date: Tue, 8 Mar 2022 12:25:16 -0800 Message-ID: Subject: Re: [PATCH] drm/msm/adreno: fix cast in adreno_get_param() To: Akhil P Oommen , Dan Carpenter , Rob Clark Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Jonathan Marek , David Airlie , linux-arm-msm@vger.kernel.org, kernel-janitors@vger.kernel.org, Abhinav Kumar , dri-devel@lists.freedesktop.org, Jordan Crouse , Sean Paul , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Dan Carpenter (2022-03-07 05:31:05) > These casts need to happen before the shift. The only time it would > matter would be if "rev.core" is >= 128. In that case the sign bit > would be extended and we do not want that. > > Fixes: afab9d91d872 ("drm/msm/adreno: Expose speedbin to userspace") > Signed-off-by: Dan Carpenter > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BF6C433FE for ; Tue, 8 Mar 2022 20:25:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349290AbiCHU0P (ORCPT ); Tue, 8 Mar 2022 15:26:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242196AbiCHU0P (ORCPT ); Tue, 8 Mar 2022 15:26:15 -0500 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D31B50E1D for ; Tue, 8 Mar 2022 12:25:18 -0800 (PST) Received: by mail-oi1-x231.google.com with SMTP id i5so508722oih.1 for ; Tue, 08 Mar 2022 12:25:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=oDPDk3UmBsVk40ec9UZG1guo+bgLJlbyhqOvTa87J18=; b=ZEU3s/iBsPE/dcbZEncVtRdgyz4R+oUlZ8IFZd75aCfzqlFSkSNyCjKiT+LTsfYBHl Cm9iCylS8NjPhmqGyLleWV/AlIuLHWBBjfRO9YzBSGOiL+HUUoYiriTtZCjxZs0k6RSS JHDC2KWjdYFrWraKvKeVS8XH3ypl7yOLBoubU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=oDPDk3UmBsVk40ec9UZG1guo+bgLJlbyhqOvTa87J18=; b=LiomUHXfR+2alRfCQYbxT6TMaxas1empfLJjlrIsjiUBesEZ9Cuc3/+3HY42uLP42S JK813bNDSaH1PPM8O7WSKPUjKQHMFMBPvDeuYHBItCu/+TNy3T+gVu9Gn1IjciBvehLD 1FNBrEPPxlsw+prwmbI3SPfY+UTsp0LXE7K5u6WN8Gytarcw5YeWPBmwE3rDdAUWZ5ZT nZcA8VCGhyIPyiCGlW3nN4ZFtEMobZ7z0Y2scDRP4nmVoUCpAWPBy+WXPjG/f79tKfuF lYJUnkyMbU7SmSBZAOVlriJPqwKVlpmyu/T88LXmdjZV9vS5SlOUeiNZ1N8VG5y94qOe qMbw== X-Gm-Message-State: AOAM531dCOVq0bsUlMQX9qldQLJHm0uCnCHte/xMtCuV4lmMea23qhaD 7MrWde9NKwr91vYIpIzlszget4rbqq9CU0v+Tn7ggw== X-Google-Smtp-Source: ABdhPJyfkvCfjSZ//u1fwsUJLWTGqZE5hW7zbIbFOcJy9M5AYS6WsphZTeYWH38/SUWdTsorovwAZS/YNjiEUrd/bVU= X-Received: by 2002:a05:6808:220d:b0:2d4:99cb:3849 with SMTP id bd13-20020a056808220d00b002d499cb3849mr3846554oib.63.1646771117701; Tue, 08 Mar 2022 12:25:17 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 8 Mar 2022 12:25:16 -0800 MIME-Version: 1.0 In-Reply-To: <20220307133105.GA17534@kili> References: <20220307133105.GA17534@kili> From: Stephen Boyd User-Agent: alot/0.10 Date: Tue, 8 Mar 2022 12:25:16 -0800 Message-ID: Subject: Re: [PATCH] drm/msm/adreno: fix cast in adreno_get_param() To: Akhil P Oommen , Dan Carpenter , Rob Clark Cc: Sean Paul , Abhinav Kumar , David Airlie , Daniel Vetter , Jordan Crouse , Jonathan Marek , =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Dan Carpenter (2022-03-07 05:31:05) > These casts need to happen before the shift. The only time it would > matter would be if "rev.core" is >= 128. In that case the sign bit > would be extended and we do not want that. > > Fixes: afab9d91d872 ("drm/msm/adreno: Expose speedbin to userspace") > Signed-off-by: Dan Carpenter > --- Reviewed-by: Stephen Boyd