* [PATCH 0/2] dt-bindings: List supplies needed for sc7280 eDP @ 2022-04-25 21:06 ` Douglas Anderson 0 siblings, 0 replies; 42+ messages in thread From: Douglas Anderson @ 2022-04-25 21:06 UTC (permalink / raw) To: Bjorn Andersson, Vinod Koul, Rob Herring, Dmitry Baryshkov, Rob Clark Cc: Abhinav Kumar, linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Douglas Anderson, Andy Gross, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, linux-kernel While looking through dts changes for sc7280 eDP I found that none of the regulators that were being defined were listed in the bindings. That being said, the current Linux drivers _were_ looking for regulators. This series tries to document the reality to the best of my ability. If someone from Qualcomm has better documentation than I do and wants to correct anything here then I'd be more than happy. For the PHY patch especially I don't have a great way to map what I see in datasheets / schematics to figure out which is the supply for the "phy" and the "pll". Assuming these look OK, I'd expect the PHY patch to land through the PHY tree and the display patch to land through msm-next. I can split the series up if need be--the two patches are just in one series because they have a similar topic--there are no actual dependencies here. Douglas Anderson (2): dt-bindings: msm/dp: List supplies in the bindings dt-bindings: phy: List supplies for qcom,edp-phy .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ 2 files changed, 12 insertions(+) -- 2.36.0.rc2.479.g8af0fa9b8e-goog ^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 0/2] dt-bindings: List supplies needed for sc7280 eDP @ 2022-04-25 21:06 ` Douglas Anderson 0 siblings, 0 replies; 42+ messages in thread From: Douglas Anderson @ 2022-04-25 21:06 UTC (permalink / raw) To: Bjorn Andersson, Vinod Koul, Rob Herring, Dmitry Baryshkov, Rob Clark Cc: Abhinav Kumar, linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Douglas Anderson, Andy Gross, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, linux-kernel While looking through dts changes for sc7280 eDP I found that none of the regulators that were being defined were listed in the bindings. That being said, the current Linux drivers _were_ looking for regulators. This series tries to document the reality to the best of my ability. If someone from Qualcomm has better documentation than I do and wants to correct anything here then I'd be more than happy. For the PHY patch especially I don't have a great way to map what I see in datasheets / schematics to figure out which is the supply for the "phy" and the "pll". Assuming these look OK, I'd expect the PHY patch to land through the PHY tree and the display patch to land through msm-next. I can split the series up if need be--the two patches are just in one series because they have a similar topic--there are no actual dependencies here. Douglas Anderson (2): dt-bindings: msm/dp: List supplies in the bindings dt-bindings: phy: List supplies for qcom,edp-phy .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ 2 files changed, 12 insertions(+) -- 2.36.0.rc2.479.g8af0fa9b8e-goog -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 0/2] dt-bindings: List supplies needed for sc7280 eDP @ 2022-04-25 21:06 ` Douglas Anderson 0 siblings, 0 replies; 42+ messages in thread From: Douglas Anderson @ 2022-04-25 21:06 UTC (permalink / raw) To: Bjorn Andersson, Vinod Koul, Rob Herring, Dmitry Baryshkov, Rob Clark Cc: quic_kalyant, devicetree, Sankeerth Billakanti, Douglas Anderson, David Airlie, linux-arm-msm, Kuogee Hsieh, Abhinav Kumar, dri-devel, Kishon Vijay Abraham I, Sean Paul, Andy Gross, Krzysztof Kozlowski, linux-phy, Stephen Boyd, freedreno, linux-kernel While looking through dts changes for sc7280 eDP I found that none of the regulators that were being defined were listed in the bindings. That being said, the current Linux drivers _were_ looking for regulators. This series tries to document the reality to the best of my ability. If someone from Qualcomm has better documentation than I do and wants to correct anything here then I'd be more than happy. For the PHY patch especially I don't have a great way to map what I see in datasheets / schematics to figure out which is the supply for the "phy" and the "pll". Assuming these look OK, I'd expect the PHY patch to land through the PHY tree and the display patch to land through msm-next. I can split the series up if need be--the two patches are just in one series because they have a similar topic--there are no actual dependencies here. Douglas Anderson (2): dt-bindings: msm/dp: List supplies in the bindings dt-bindings: phy: List supplies for qcom,edp-phy .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ 2 files changed, 12 insertions(+) -- 2.36.0.rc2.479.g8af0fa9b8e-goog ^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings 2022-04-25 21:06 ` Douglas Anderson (?) @ 2022-04-25 21:06 ` Douglas Anderson -1 siblings, 0 replies; 42+ messages in thread From: Douglas Anderson @ 2022-04-25 21:06 UTC (permalink / raw) To: Bjorn Andersson, Vinod Koul, Rob Herring, Dmitry Baryshkov, Rob Clark Cc: Abhinav Kumar, linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Douglas Anderson, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, linux-kernel We're supposed to list the supplies in the dt bindings but there are none in the DP controller bindings. Looking at the Linux driver and existing device trees, we can see that two supplies are expected: - vdda-0p9-supply - vdda-1p2-supply Let's list them both in the bindings. Note that the datasheet for sc7280 doesn't describe these supplies very verbosely. For the 0p9 supply, for instance, it says "Power for eDP 0.9 V circuits". This this is obvious from the property name, we don't bother cluttering the bindings with a description. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index cd05cfd76536..dba31108db51 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -76,6 +76,9 @@ properties: "#sound-dai-cells": const: 0 + vdda-0p9-supply: true + vdda-1p2-supply: true + ports: $ref: /schemas/graph.yaml#/properties/ports properties: @@ -137,6 +140,9 @@ examples: power-domains = <&rpmhpd SC7180_CX>; + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; + vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>; + ports { #address-cells = <1>; #size-cells = <0>; -- 2.36.0.rc2.479.g8af0fa9b8e-goog ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-04-25 21:06 ` Douglas Anderson 0 siblings, 0 replies; 42+ messages in thread From: Douglas Anderson @ 2022-04-25 21:06 UTC (permalink / raw) To: Bjorn Andersson, Vinod Koul, Rob Herring, Dmitry Baryshkov, Rob Clark Cc: Abhinav Kumar, linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Douglas Anderson, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, linux-kernel We're supposed to list the supplies in the dt bindings but there are none in the DP controller bindings. Looking at the Linux driver and existing device trees, we can see that two supplies are expected: - vdda-0p9-supply - vdda-1p2-supply Let's list them both in the bindings. Note that the datasheet for sc7280 doesn't describe these supplies very verbosely. For the 0p9 supply, for instance, it says "Power for eDP 0.9 V circuits". This this is obvious from the property name, we don't bother cluttering the bindings with a description. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index cd05cfd76536..dba31108db51 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -76,6 +76,9 @@ properties: "#sound-dai-cells": const: 0 + vdda-0p9-supply: true + vdda-1p2-supply: true + ports: $ref: /schemas/graph.yaml#/properties/ports properties: @@ -137,6 +140,9 @@ examples: power-domains = <&rpmhpd SC7180_CX>; + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; + vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>; + ports { #address-cells = <1>; #size-cells = <0>; -- 2.36.0.rc2.479.g8af0fa9b8e-goog -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-04-25 21:06 ` Douglas Anderson 0 siblings, 0 replies; 42+ messages in thread From: Douglas Anderson @ 2022-04-25 21:06 UTC (permalink / raw) To: Bjorn Andersson, Vinod Koul, Rob Herring, Dmitry Baryshkov, Rob Clark Cc: quic_kalyant, devicetree, Sankeerth Billakanti, Douglas Anderson, David Airlie, linux-arm-msm, Kuogee Hsieh, Abhinav Kumar, dri-devel, Kishon Vijay Abraham I, Sean Paul, Krzysztof Kozlowski, linux-phy, Stephen Boyd, freedreno, linux-kernel We're supposed to list the supplies in the dt bindings but there are none in the DP controller bindings. Looking at the Linux driver and existing device trees, we can see that two supplies are expected: - vdda-0p9-supply - vdda-1p2-supply Let's list them both in the bindings. Note that the datasheet for sc7280 doesn't describe these supplies very verbosely. For the 0p9 supply, for instance, it says "Power for eDP 0.9 V circuits". This this is obvious from the property name, we don't bother cluttering the bindings with a description. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index cd05cfd76536..dba31108db51 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -76,6 +76,9 @@ properties: "#sound-dai-cells": const: 0 + vdda-0p9-supply: true + vdda-1p2-supply: true + ports: $ref: /schemas/graph.yaml#/properties/ports properties: @@ -137,6 +140,9 @@ examples: power-domains = <&rpmhpd SC7180_CX>; + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; + vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>; + ports { #address-cells = <1>; #size-cells = <0>; -- 2.36.0.rc2.479.g8af0fa9b8e-goog ^ permalink raw reply related [flat|nested] 42+ messages in thread
* Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings 2022-04-25 21:06 ` Douglas Anderson (?) @ 2022-04-25 21:14 ` Stephen Boyd -1 siblings, 0 replies; 42+ messages in thread From: Stephen Boyd @ 2022-04-25 21:14 UTC (permalink / raw) To: Bjorn Andersson, Dmitry Baryshkov, Douglas Anderson, Rob Clark, Rob Herring, Vinod Koul Cc: Abhinav Kumar, linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, linux-kernel Quoting Douglas Anderson (2022-04-25 14:06:42) > We're supposed to list the supplies in the dt bindings but there are > none in the DP controller bindings. Looking at the Linux driver and > existing device trees, we can see that two supplies are expected: > - vdda-0p9-supply > - vdda-1p2-supply > > Let's list them both in the bindings. Note that the datasheet for > sc7280 doesn't describe these supplies very verbosely. For the 0p9 > supply, for instance, it says "Power for eDP 0.9 V circuits". This > this is obvious from the property name, we don't bother cluttering the > bindings with a description. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index cd05cfd76536..dba31108db51 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -76,6 +76,9 @@ properties: > "#sound-dai-cells": > const: 0 > > + vdda-0p9-supply: true > + vdda-1p2-supply: true > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > properties: > @@ -137,6 +140,9 @@ examples: > > power-domains = <&rpmhpd SC7180_CX>; > > + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, so I'd expect this to only matter for the phy that contains the analog circuitry. It would be great to remove the regulator code from drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() call to the phy driver if possible. Hopefully qcom folks can help clarify here. > + vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>; ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-04-25 21:14 ` Stephen Boyd 0 siblings, 0 replies; 42+ messages in thread From: Stephen Boyd @ 2022-04-25 21:14 UTC (permalink / raw) To: Bjorn Andersson, Dmitry Baryshkov, Douglas Anderson, Rob Clark, Rob Herring, Vinod Koul Cc: Abhinav Kumar, linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, linux-kernel Quoting Douglas Anderson (2022-04-25 14:06:42) > We're supposed to list the supplies in the dt bindings but there are > none in the DP controller bindings. Looking at the Linux driver and > existing device trees, we can see that two supplies are expected: > - vdda-0p9-supply > - vdda-1p2-supply > > Let's list them both in the bindings. Note that the datasheet for > sc7280 doesn't describe these supplies very verbosely. For the 0p9 > supply, for instance, it says "Power for eDP 0.9 V circuits". This > this is obvious from the property name, we don't bother cluttering the > bindings with a description. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index cd05cfd76536..dba31108db51 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -76,6 +76,9 @@ properties: > "#sound-dai-cells": > const: 0 > > + vdda-0p9-supply: true > + vdda-1p2-supply: true > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > properties: > @@ -137,6 +140,9 @@ examples: > > power-domains = <&rpmhpd SC7180_CX>; > > + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, so I'd expect this to only matter for the phy that contains the analog circuitry. It would be great to remove the regulator code from drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() call to the phy driver if possible. Hopefully qcom folks can help clarify here. > + vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>; -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-04-25 21:14 ` Stephen Boyd 0 siblings, 0 replies; 42+ messages in thread From: Stephen Boyd @ 2022-04-25 21:14 UTC (permalink / raw) To: Bjorn Andersson, Dmitry Baryshkov, Douglas Anderson, Rob Clark, Rob Herring, Vinod Koul Cc: quic_kalyant, devicetree, Sankeerth Billakanti, David Airlie, linux-arm-msm, Abhinav Kumar, dri-devel, Kishon Vijay Abraham I, Sean Paul, Krzysztof Kozlowski, linux-phy, Kuogee Hsieh, freedreno, linux-kernel Quoting Douglas Anderson (2022-04-25 14:06:42) > We're supposed to list the supplies in the dt bindings but there are > none in the DP controller bindings. Looking at the Linux driver and > existing device trees, we can see that two supplies are expected: > - vdda-0p9-supply > - vdda-1p2-supply > > Let's list them both in the bindings. Note that the datasheet for > sc7280 doesn't describe these supplies very verbosely. For the 0p9 > supply, for instance, it says "Power for eDP 0.9 V circuits". This > this is obvious from the property name, we don't bother cluttering the > bindings with a description. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index cd05cfd76536..dba31108db51 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -76,6 +76,9 @@ properties: > "#sound-dai-cells": > const: 0 > > + vdda-0p9-supply: true > + vdda-1p2-supply: true > + > ports: > $ref: /schemas/graph.yaml#/properties/ports > properties: > @@ -137,6 +140,9 @@ examples: > > power-domains = <&rpmhpd SC7180_CX>; > > + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, so I'd expect this to only matter for the phy that contains the analog circuitry. It would be great to remove the regulator code from drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() call to the phy driver if possible. Hopefully qcom folks can help clarify here. > + vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>; ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings 2022-04-25 21:14 ` Stephen Boyd (?) @ 2022-04-25 21:18 ` Doug Anderson -1 siblings, 0 replies; 42+ messages in thread From: Doug Anderson @ 2022-04-25 21:18 UTC (permalink / raw) To: Stephen Boyd Cc: Bjorn Andersson, Dmitry Baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar, linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML Hi, On Mon, Apr 25, 2022 at 2:14 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Douglas Anderson (2022-04-25 14:06:42) > > We're supposed to list the supplies in the dt bindings but there are > > none in the DP controller bindings. Looking at the Linux driver and > > existing device trees, we can see that two supplies are expected: > > - vdda-0p9-supply > > - vdda-1p2-supply > > > > Let's list them both in the bindings. Note that the datasheet for > > sc7280 doesn't describe these supplies very verbosely. For the 0p9 > > supply, for instance, it says "Power for eDP 0.9 V circuits". This > > this is obvious from the property name, we don't bother cluttering the > > bindings with a description. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > index cd05cfd76536..dba31108db51 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > @@ -76,6 +76,9 @@ properties: > > "#sound-dai-cells": > > const: 0 > > > > + vdda-0p9-supply: true > > + vdda-1p2-supply: true > > + > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > properties: > > @@ -137,6 +140,9 @@ examples: > > > > power-domains = <&rpmhpd SC7180_CX>; > > > > + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; > > Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, so > I'd expect this to only matter for the phy that contains the analog > circuitry. It would be great to remove the regulator code from > drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() call > to the phy driver if possible. Hopefully qcom folks can help clarify > here. Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the schematic in front of me someone labeled these pins on the sc7280 with the "A". ...and the driver looks for a supply with the "a". :-/ It would be good to get clarification from someone with better information. -Doug ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-04-25 21:18 ` Doug Anderson 0 siblings, 0 replies; 42+ messages in thread From: Doug Anderson @ 2022-04-25 21:18 UTC (permalink / raw) To: Stephen Boyd Cc: Bjorn Andersson, Dmitry Baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar, linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML Hi, On Mon, Apr 25, 2022 at 2:14 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Douglas Anderson (2022-04-25 14:06:42) > > We're supposed to list the supplies in the dt bindings but there are > > none in the DP controller bindings. Looking at the Linux driver and > > existing device trees, we can see that two supplies are expected: > > - vdda-0p9-supply > > - vdda-1p2-supply > > > > Let's list them both in the bindings. Note that the datasheet for > > sc7280 doesn't describe these supplies very verbosely. For the 0p9 > > supply, for instance, it says "Power for eDP 0.9 V circuits". This > > this is obvious from the property name, we don't bother cluttering the > > bindings with a description. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > index cd05cfd76536..dba31108db51 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > @@ -76,6 +76,9 @@ properties: > > "#sound-dai-cells": > > const: 0 > > > > + vdda-0p9-supply: true > > + vdda-1p2-supply: true > > + > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > properties: > > @@ -137,6 +140,9 @@ examples: > > > > power-domains = <&rpmhpd SC7180_CX>; > > > > + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; > > Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, so > I'd expect this to only matter for the phy that contains the analog > circuitry. It would be great to remove the regulator code from > drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() call > to the phy driver if possible. Hopefully qcom folks can help clarify > here. Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the schematic in front of me someone labeled these pins on the sc7280 with the "A". ...and the driver looks for a supply with the "a". :-/ It would be good to get clarification from someone with better information. -Doug -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-04-25 21:18 ` Doug Anderson 0 siblings, 0 replies; 42+ messages in thread From: Doug Anderson @ 2022-04-25 21:18 UTC (permalink / raw) To: Stephen Boyd Cc: Rob Clark, quic_kalyant, Sankeerth Billakanti, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, David Airlie, linux-arm-msm, Kuogee Hsieh, Abhinav Kumar, dri-devel, Bjorn Andersson, linux-phy, Vinod Koul, Rob Herring, Krzysztof Kozlowski, Dmitry Baryshkov, Sean Paul, Kishon Vijay Abraham I, freedreno, LKML Hi, On Mon, Apr 25, 2022 at 2:14 PM Stephen Boyd <swboyd@chromium.org> wrote: > > Quoting Douglas Anderson (2022-04-25 14:06:42) > > We're supposed to list the supplies in the dt bindings but there are > > none in the DP controller bindings. Looking at the Linux driver and > > existing device trees, we can see that two supplies are expected: > > - vdda-0p9-supply > > - vdda-1p2-supply > > > > Let's list them both in the bindings. Note that the datasheet for > > sc7280 doesn't describe these supplies very verbosely. For the 0p9 > > supply, for instance, it says "Power for eDP 0.9 V circuits". This > > this is obvious from the property name, we don't bother cluttering the > > bindings with a description. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > index cd05cfd76536..dba31108db51 100644 > > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > > @@ -76,6 +76,9 @@ properties: > > "#sound-dai-cells": > > const: 0 > > > > + vdda-0p9-supply: true > > + vdda-1p2-supply: true > > + > > ports: > > $ref: /schemas/graph.yaml#/properties/ports > > properties: > > @@ -137,6 +140,9 @@ examples: > > > > power-domains = <&rpmhpd SC7180_CX>; > > > > + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; > > Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, so > I'd expect this to only matter for the phy that contains the analog > circuitry. It would be great to remove the regulator code from > drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() call > to the phy driver if possible. Hopefully qcom folks can help clarify > here. Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the schematic in front of me someone labeled these pins on the sc7280 with the "A". ...and the driver looks for a supply with the "a". :-/ It would be good to get clarification from someone with better information. -Doug ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings 2022-04-25 21:18 ` Doug Anderson (?) @ 2022-05-05 18:02 ` Sankeerth Billakanti -1 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti @ 2022-05-05 18:02 UTC (permalink / raw) To: Doug Anderson, Stephen Boyd Cc: bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar (QUIC), linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti (QUIC), Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota (QUIC), Kuogee Hsieh (QUIC), Daniel Vetter, David Airlie, Rob Clark, Sean Paul, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML Hi Doug, >> >> Quoting Douglas Anderson (2022-04-25 14:06:42) >> > We're supposed to list the supplies in the dt bindings but there are >> > none in the DP controller bindings. Looking at the Linux driver and >> > existing device trees, we can see that two supplies are expected: >> > - vdda-0p9-supply >> > - vdda-1p2-supply >> > >> > Let's list them both in the bindings. Note that the datasheet for >> > sc7280 doesn't describe these supplies very verbosely. For the 0p9 >> > supply, for instance, it says "Power for eDP 0.9 V circuits". This >> > this is obvious from the property name, we don't bother cluttering >> > the bindings with a description. >> > >> > Signed-off-by: Douglas Anderson <dianders@chromium.org> >> > --- >> > >> > .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ >> > 1 file changed, 6 insertions(+) >> > >> > diff --git >> > a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> > b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> > index cd05cfd76536..dba31108db51 100644 >> > --- >> > a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.ya >> > +++ ml >> > @@ -76,6 +76,9 @@ properties: >> > "#sound-dai-cells": >> > const: 0 >> > >> > + vdda-0p9-supply: true >> > + vdda-1p2-supply: true >> > + >> > ports: >> > $ref: /schemas/graph.yaml#/properties/ports >> > properties: >> > @@ -137,6 +140,9 @@ examples: >> > >> > power-domains = <&rpmhpd SC7180_CX>; >> > >> > + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; >> >> Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, >> so I'd expect this to only matter for the phy that contains the analog >> circuitry. It would be great to remove the regulator code from >> drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() >> call to the phy driver if possible. Hopefully qcom folks can help >> clarify here. > >Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". >It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the >schematic in front of me someone labeled these pins on the sc7280 with the >"A". ...and the driver looks for a supply with the "a". :-/ > >It would be good to get clarification from someone with better information. > >-Doug Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms. So, as a practice, we put the same name in the DT files. Hence, Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> Thank you, Sankeerth ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-05 18:02 ` Sankeerth Billakanti 0 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti @ 2022-05-05 18:02 UTC (permalink / raw) To: Doug Anderson, Stephen Boyd Cc: bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar (QUIC), linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti (QUIC), Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota (QUIC), Kuogee Hsieh (QUIC), Daniel Vetter, David Airlie, Rob Clark, Sean Paul, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML Hi Doug, >> >> Quoting Douglas Anderson (2022-04-25 14:06:42) >> > We're supposed to list the supplies in the dt bindings but there are >> > none in the DP controller bindings. Looking at the Linux driver and >> > existing device trees, we can see that two supplies are expected: >> > - vdda-0p9-supply >> > - vdda-1p2-supply >> > >> > Let's list them both in the bindings. Note that the datasheet for >> > sc7280 doesn't describe these supplies very verbosely. For the 0p9 >> > supply, for instance, it says "Power for eDP 0.9 V circuits". This >> > this is obvious from the property name, we don't bother cluttering >> > the bindings with a description. >> > >> > Signed-off-by: Douglas Anderson <dianders@chromium.org> >> > --- >> > >> > .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ >> > 1 file changed, 6 insertions(+) >> > >> > diff --git >> > a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> > b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> > index cd05cfd76536..dba31108db51 100644 >> > --- >> > a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.ya >> > +++ ml >> > @@ -76,6 +76,9 @@ properties: >> > "#sound-dai-cells": >> > const: 0 >> > >> > + vdda-0p9-supply: true >> > + vdda-1p2-supply: true >> > + >> > ports: >> > $ref: /schemas/graph.yaml#/properties/ports >> > properties: >> > @@ -137,6 +140,9 @@ examples: >> > >> > power-domains = <&rpmhpd SC7180_CX>; >> > >> > + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; >> >> Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, >> so I'd expect this to only matter for the phy that contains the analog >> circuitry. It would be great to remove the regulator code from >> drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() >> call to the phy driver if possible. Hopefully qcom folks can help >> clarify here. > >Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". >It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the >schematic in front of me someone labeled these pins on the sc7280 with the >"A". ...and the driver looks for a supply with the "a". :-/ > >It would be good to get clarification from someone with better information. > >-Doug Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms. So, as a practice, we put the same name in the DT files. Hence, Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> Thank you, Sankeerth -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-05 18:02 ` Sankeerth Billakanti 0 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti @ 2022-05-05 18:02 UTC (permalink / raw) To: Doug Anderson, Stephen Boyd Cc: Rob Clark, Kalyan Thota (QUIC), Sankeerth Billakanti (QUIC), open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, David Airlie, linux-arm-msm, Kuogee Hsieh (QUIC), Abhinav Kumar (QUIC), dri-devel, bjorn.andersson, linux-phy, Vinod Koul, Rob Herring, Krzysztof Kozlowski, dmitry.baryshkov, Sean Paul, Kishon Vijay Abraham I, freedreno, LKML Hi Doug, >> >> Quoting Douglas Anderson (2022-04-25 14:06:42) >> > We're supposed to list the supplies in the dt bindings but there are >> > none in the DP controller bindings. Looking at the Linux driver and >> > existing device trees, we can see that two supplies are expected: >> > - vdda-0p9-supply >> > - vdda-1p2-supply >> > >> > Let's list them both in the bindings. Note that the datasheet for >> > sc7280 doesn't describe these supplies very verbosely. For the 0p9 >> > supply, for instance, it says "Power for eDP 0.9 V circuits". This >> > this is obvious from the property name, we don't bother cluttering >> > the bindings with a description. >> > >> > Signed-off-by: Douglas Anderson <dianders@chromium.org> >> > --- >> > >> > .../devicetree/bindings/display/msm/dp-controller.yaml | 6 ++++++ >> > 1 file changed, 6 insertions(+) >> > >> > diff --git >> > a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> > b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> > index cd05cfd76536..dba31108db51 100644 >> > --- >> > a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml >> > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.ya >> > +++ ml >> > @@ -76,6 +76,9 @@ properties: >> > "#sound-dai-cells": >> > const: 0 >> > >> > + vdda-0p9-supply: true >> > + vdda-1p2-supply: true >> > + >> > ports: >> > $ref: /schemas/graph.yaml#/properties/ports >> > properties: >> > @@ -137,6 +140,9 @@ examples: >> > >> > power-domains = <&rpmhpd SC7180_CX>; >> > >> > + vdda-0p9-supply = <&vdda_usb_ss_dp_core>; >> >> Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, >> so I'd expect this to only matter for the phy that contains the analog >> circuitry. It would be great to remove the regulator code from >> drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() >> call to the phy driver if possible. Hopefully qcom folks can help >> clarify here. > >Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". >It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the >schematic in front of me someone labeled these pins on the sc7280 with the >"A". ...and the driver looks for a supply with the "a". :-/ > >It would be good to get clarification from someone with better information. > >-Doug Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms. So, as a practice, we put the same name in the DT files. Hence, Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> Thank you, Sankeerth ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings 2022-05-05 18:02 ` Sankeerth Billakanti (?) @ 2022-05-05 18:18 ` Stephen Boyd -1 siblings, 0 replies; 42+ messages in thread From: Stephen Boyd @ 2022-05-05 18:18 UTC (permalink / raw) To: Doug Anderson, Sankeerth Billakanti Cc: Rob Clark, Kalyan Thota, Sankeerth Billakanti, devicetree, David Airlie, linux-arm-msm, Kuogee Hsieh, Abhinav Kumar, dri-devel, bjorn.andersson, linux-phy, Vinod Koul, Rob Herring, Krzysztof Kozlowski, dmitry.baryshkov, Sean Paul, Kishon Vijay Abraham I, freedreno, LKML Quoting Sankeerth Billakanti (2022-05-05 11:02:36) > >> > >> Quoting Douglas Anderson (2022-04-25 14:06:42) > >> > >> Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, > >> so I'd expect this to only matter for the phy that contains the analog > >> circuitry. It would be great to remove the regulator code from > >> drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() > >> call to the phy driver if possible. Hopefully qcom folks can help > >> clarify here. > > > >Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". > >It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the > >schematic in front of me someone labeled these pins on the sc7280 with the > >"A". ...and the driver looks for a supply with the "a". :-/ > > > >It would be good to get clarification from someone with better information. > > > >-Doug > > Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 > for all the platforms. Do your internal power grid documents indicate what these supplies are powering? The question is if these supplies power any of the logic inside the eDP controller or if they only supply power to the analog circuits in the eDP phy. If it's the eDP phy only then the regulator usage in the eDP driver should be removed. I would suspect this is the case because the controller is probably all digital logic and runs at the typical 1.8V that the rest of the SoC uses. Similarly, these are voltage references which sound like a PLL reference voltage. Please clarify this further. > > So, as a practice, we put the same name in the DT files. Hence, > > Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-05 18:18 ` Stephen Boyd 0 siblings, 0 replies; 42+ messages in thread From: Stephen Boyd @ 2022-05-05 18:18 UTC (permalink / raw) To: Doug Anderson, Sankeerth Billakanti Cc: bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar, linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota, Kuogee Hsieh, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, LKML Quoting Sankeerth Billakanti (2022-05-05 11:02:36) > >> > >> Quoting Douglas Anderson (2022-04-25 14:06:42) > >> > >> Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, > >> so I'd expect this to only matter for the phy that contains the analog > >> circuitry. It would be great to remove the regulator code from > >> drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() > >> call to the phy driver if possible. Hopefully qcom folks can help > >> clarify here. > > > >Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". > >It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the > >schematic in front of me someone labeled these pins on the sc7280 with the > >"A". ...and the driver looks for a supply with the "a". :-/ > > > >It would be good to get clarification from someone with better information. > > > >-Doug > > Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 > for all the platforms. Do your internal power grid documents indicate what these supplies are powering? The question is if these supplies power any of the logic inside the eDP controller or if they only supply power to the analog circuits in the eDP phy. If it's the eDP phy only then the regulator usage in the eDP driver should be removed. I would suspect this is the case because the controller is probably all digital logic and runs at the typical 1.8V that the rest of the SoC uses. Similarly, these are voltage references which sound like a PLL reference voltage. Please clarify this further. > > So, as a practice, we put the same name in the DT files. Hence, > > Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-05 18:18 ` Stephen Boyd 0 siblings, 0 replies; 42+ messages in thread From: Stephen Boyd @ 2022-05-05 18:18 UTC (permalink / raw) To: Doug Anderson, Sankeerth Billakanti Cc: bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar, linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota, Kuogee Hsieh, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, LKML Quoting Sankeerth Billakanti (2022-05-05 11:02:36) > >> > >> Quoting Douglas Anderson (2022-04-25 14:06:42) > >> > >> Having 'a' in 'vdda' typically means 'analog' for 'analog' circuits, > >> so I'd expect this to only matter for the phy that contains the analog > >> circuitry. It would be great to remove the regulator code from > >> drivers/gpu/drm/msm/dp/dp_power.c and move the regulator_set_load() > >> call to the phy driver if possible. Hopefully qcom folks can help > >> clarify here. > > > >Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". > >It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the > >schematic in front of me someone labeled these pins on the sc7280 with the > >"A". ...and the driver looks for a supply with the "a". :-/ > > > >It would be good to get clarification from someone with better information. > > > >-Doug > > Our internal power grid documents list the regulators as VDD_A_*_1P2 and VDD_A_*_0P9 > for all the platforms. Do your internal power grid documents indicate what these supplies are powering? The question is if these supplies power any of the logic inside the eDP controller or if they only supply power to the analog circuits in the eDP phy. If it's the eDP phy only then the regulator usage in the eDP driver should be removed. I would suspect this is the case because the controller is probably all digital logic and runs at the typical 1.8V that the rest of the SoC uses. Similarly, these are voltage references which sound like a PLL reference voltage. Please clarify this further. > > So, as a practice, we put the same name in the DT files. Hence, > > Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings 2022-05-05 18:18 ` Stephen Boyd (?) @ 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) -1 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti (QUIC) @ 2022-05-05 18:47 UTC (permalink / raw) To: Stephen Boyd, Doug Anderson Cc: bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar (QUIC), linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti (QUIC), Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota (QUIC), Kuogee Hsieh (QUIC), Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, LKML >Quoting Sankeerth Billakanti (2022-05-05 11:02:36) >> >> >> >> Quoting Douglas Anderson (2022-04-25 14:06:42) >> >> >> >> Having 'a' in 'vdda' typically means 'analog' for 'analog' >> >> circuits, so I'd expect this to only matter for the phy that >> >> contains the analog circuitry. It would be great to remove the >> >> regulator code from drivers/gpu/drm/msm/dp/dp_power.c and move >the >> >> regulator_set_load() call to the phy driver if possible. Hopefully >> >> qcom folks can help clarify here. >> > >> >Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". >> >It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the >> >schematic in front of me someone labeled these pins on the sc7280 >> >with the "A". ...and the driver looks for a supply with the "a". :-/ >> > >> >It would be good to get clarification from someone with better >information. >> > >> >-Doug >> >> Our internal power grid documents list the regulators as VDD_A_*_1P2 >> and VDD_A_*_0P9 for all the platforms. > >Do your internal power grid documents indicate what these supplies are >powering? The question is if these supplies power any of the logic inside the >eDP controller or if they only supply power to the analog circuits in the eDP >phy. If it's the eDP phy only then the regulator usage in the eDP driver should >be removed. I would suspect this is the case because the controller is >probably all digital logic and runs at the typical 1.8V that the rest of the SoC >uses. Similarly, these are voltage references which sound like a PLL reference >voltage. > >Please clarify this further. > For the DP driver using the usb-dp combo phy, there were cases where the usb driver was turning off the phy and pll regulators whenever usb-dp concurrent mode need not be supported. This caused phy and pll to be powered down causing aux transaction failures and display blankouts. From then on, it became a practice for the controller driver to vote for the phy and pll regulators also. >> >> So, as a practice, we put the same name in the DT files. Hence, >> >> Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> >> ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) 0 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti (QUIC) @ 2022-05-05 18:47 UTC (permalink / raw) To: Stephen Boyd, Doug Anderson Cc: bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar (QUIC), linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti (QUIC), Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota (QUIC), Kuogee Hsieh (QUIC), Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, LKML >Quoting Sankeerth Billakanti (2022-05-05 11:02:36) >> >> >> >> Quoting Douglas Anderson (2022-04-25 14:06:42) >> >> >> >> Having 'a' in 'vdda' typically means 'analog' for 'analog' >> >> circuits, so I'd expect this to only matter for the phy that >> >> contains the analog circuitry. It would be great to remove the >> >> regulator code from drivers/gpu/drm/msm/dp/dp_power.c and move >the >> >> regulator_set_load() call to the phy driver if possible. Hopefully >> >> qcom folks can help clarify here. >> > >> >Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". >> >It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the >> >schematic in front of me someone labeled these pins on the sc7280 >> >with the "A". ...and the driver looks for a supply with the "a". :-/ >> > >> >It would be good to get clarification from someone with better >information. >> > >> >-Doug >> >> Our internal power grid documents list the regulators as VDD_A_*_1P2 >> and VDD_A_*_0P9 for all the platforms. > >Do your internal power grid documents indicate what these supplies are >powering? The question is if these supplies power any of the logic inside the >eDP controller or if they only supply power to the analog circuits in the eDP >phy. If it's the eDP phy only then the regulator usage in the eDP driver should >be removed. I would suspect this is the case because the controller is >probably all digital logic and runs at the typical 1.8V that the rest of the SoC >uses. Similarly, these are voltage references which sound like a PLL reference >voltage. > >Please clarify this further. > For the DP driver using the usb-dp combo phy, there were cases where the usb driver was turning off the phy and pll regulators whenever usb-dp concurrent mode need not be supported. This caused phy and pll to be powered down causing aux transaction failures and display blankouts. From then on, it became a practice for the controller driver to vote for the phy and pll regulators also. >> >> So, as a practice, we put the same name in the DT files. Hence, >> >> Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> >> -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) 0 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti (QUIC) @ 2022-05-05 18:47 UTC (permalink / raw) To: Stephen Boyd, Doug Anderson Cc: Rob Clark, Kalyan Thota (QUIC), Sankeerth Billakanti (QUIC), devicetree, David Airlie, linux-arm-msm, Kuogee Hsieh (QUIC), Abhinav Kumar (QUIC), dri-devel, bjorn.andersson, linux-phy, Vinod Koul, Rob Herring, Krzysztof Kozlowski, dmitry.baryshkov, Sean Paul, Kishon Vijay Abraham I, freedreno, LKML >Quoting Sankeerth Billakanti (2022-05-05 11:02:36) >> >> >> >> Quoting Douglas Anderson (2022-04-25 14:06:42) >> >> >> >> Having 'a' in 'vdda' typically means 'analog' for 'analog' >> >> circuits, so I'd expect this to only matter for the phy that >> >> contains the analog circuitry. It would be great to remove the >> >> regulator code from drivers/gpu/drm/msm/dp/dp_power.c and move >the >> >> regulator_set_load() call to the phy driver if possible. Hopefully >> >> qcom folks can help clarify here. >> > >> >Interesting. Oddly enough, the sc7280 datasheet doesn't list the "_A". >> >It calls these "VDD_VREF_0P9" and "VDD_VREF_1P2". However, on the >> >schematic in front of me someone labeled these pins on the sc7280 >> >with the "A". ...and the driver looks for a supply with the "a". :-/ >> > >> >It would be good to get clarification from someone with better >information. >> > >> >-Doug >> >> Our internal power grid documents list the regulators as VDD_A_*_1P2 >> and VDD_A_*_0P9 for all the platforms. > >Do your internal power grid documents indicate what these supplies are >powering? The question is if these supplies power any of the logic inside the >eDP controller or if they only supply power to the analog circuits in the eDP >phy. If it's the eDP phy only then the regulator usage in the eDP driver should >be removed. I would suspect this is the case because the controller is >probably all digital logic and runs at the typical 1.8V that the rest of the SoC >uses. Similarly, these are voltage references which sound like a PLL reference >voltage. > >Please clarify this further. > For the DP driver using the usb-dp combo phy, there were cases where the usb driver was turning off the phy and pll regulators whenever usb-dp concurrent mode need not be supported. This caused phy and pll to be powered down causing aux transaction failures and display blankouts. From then on, it became a practice for the controller driver to vote for the phy and pll regulators also. >> >> So, as a practice, we put the same name in the DT files. Hence, >> >> Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> >> ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) (?) @ 2022-05-05 19:06 ` Stephen Boyd -1 siblings, 0 replies; 42+ messages in thread From: Stephen Boyd @ 2022-05-05 19:06 UTC (permalink / raw) To: Doug Anderson, Sankeerth Billakanti Cc: bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar, linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota, Kuogee Hsieh, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, LKML Quoting Sankeerth Billakanti (QUIC) (2022-05-05 11:47:20) > >Quoting Sankeerth Billakanti (2022-05-05 11:02:36) > >> > >> Our internal power grid documents list the regulators as VDD_A_*_1P2 > >> and VDD_A_*_0P9 for all the platforms. > > > >Do your internal power grid documents indicate what these supplies are > >powering? The question is if these supplies power any of the logic inside the > >eDP controller or if they only supply power to the analog circuits in the eDP > >phy. If it's the eDP phy only then the regulator usage in the eDP driver should > >be removed. I would suspect this is the case because the controller is > >probably all digital logic and runs at the typical 1.8V that the rest of the SoC > >uses. Similarly, these are voltage references which sound like a PLL reference > >voltage. > > > >Please clarify this further. > > > > For the DP driver using the usb-dp combo phy, there were cases where the usb driver > was turning off the phy and pll regulators whenever usb-dp concurrent mode need not be supported. > This caused phy and pll to be powered down causing aux transaction failures and display blankouts. > From then on, it became a practice for the controller driver to vote for the phy and pll regulators also. > That sounds like USB-DP combo phy driver had improper regulator power management where aux transactions from DP didn't keep the power on to the phy. Where does the power physically go? If the power isn't physically going to the DP controller it shouldn't be controlled from the DP controller driver. If the aux bus needs the DP phy enabled, the DP controller driver should enable the phy power (via phy_power_on()?). ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-05 19:06 ` Stephen Boyd 0 siblings, 0 replies; 42+ messages in thread From: Stephen Boyd @ 2022-05-05 19:06 UTC (permalink / raw) To: Doug Anderson, Sankeerth Billakanti Cc: bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar, linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota, Kuogee Hsieh, Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, LKML Quoting Sankeerth Billakanti (QUIC) (2022-05-05 11:47:20) > >Quoting Sankeerth Billakanti (2022-05-05 11:02:36) > >> > >> Our internal power grid documents list the regulators as VDD_A_*_1P2 > >> and VDD_A_*_0P9 for all the platforms. > > > >Do your internal power grid documents indicate what these supplies are > >powering? The question is if these supplies power any of the logic inside the > >eDP controller or if they only supply power to the analog circuits in the eDP > >phy. If it's the eDP phy only then the regulator usage in the eDP driver should > >be removed. I would suspect this is the case because the controller is > >probably all digital logic and runs at the typical 1.8V that the rest of the SoC > >uses. Similarly, these are voltage references which sound like a PLL reference > >voltage. > > > >Please clarify this further. > > > > For the DP driver using the usb-dp combo phy, there were cases where the usb driver > was turning off the phy and pll regulators whenever usb-dp concurrent mode need not be supported. > This caused phy and pll to be powered down causing aux transaction failures and display blankouts. > From then on, it became a practice for the controller driver to vote for the phy and pll regulators also. > That sounds like USB-DP combo phy driver had improper regulator power management where aux transactions from DP didn't keep the power on to the phy. Where does the power physically go? If the power isn't physically going to the DP controller it shouldn't be controlled from the DP controller driver. If the aux bus needs the DP phy enabled, the DP controller driver should enable the phy power (via phy_power_on()?). -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-05 19:06 ` Stephen Boyd 0 siblings, 0 replies; 42+ messages in thread From: Stephen Boyd @ 2022-05-05 19:06 UTC (permalink / raw) To: Doug Anderson, Sankeerth Billakanti Cc: Rob Clark, Kalyan Thota, devicetree, David Airlie, linux-arm-msm, Kuogee Hsieh, Abhinav Kumar, dri-devel, bjorn.andersson, linux-phy, Vinod Koul, Rob Herring, Krzysztof Kozlowski, dmitry.baryshkov, Sean Paul, Kishon Vijay Abraham I, freedreno, LKML Quoting Sankeerth Billakanti (QUIC) (2022-05-05 11:47:20) > >Quoting Sankeerth Billakanti (2022-05-05 11:02:36) > >> > >> Our internal power grid documents list the regulators as VDD_A_*_1P2 > >> and VDD_A_*_0P9 for all the platforms. > > > >Do your internal power grid documents indicate what these supplies are > >powering? The question is if these supplies power any of the logic inside the > >eDP controller or if they only supply power to the analog circuits in the eDP > >phy. If it's the eDP phy only then the regulator usage in the eDP driver should > >be removed. I would suspect this is the case because the controller is > >probably all digital logic and runs at the typical 1.8V that the rest of the SoC > >uses. Similarly, these are voltage references which sound like a PLL reference > >voltage. > > > >Please clarify this further. > > > > For the DP driver using the usb-dp combo phy, there were cases where the usb driver > was turning off the phy and pll regulators whenever usb-dp concurrent mode need not be supported. > This caused phy and pll to be powered down causing aux transaction failures and display blankouts. > From then on, it became a practice for the controller driver to vote for the phy and pll regulators also. > That sounds like USB-DP combo phy driver had improper regulator power management where aux transactions from DP didn't keep the power on to the phy. Where does the power physically go? If the power isn't physically going to the DP controller it shouldn't be controlled from the DP controller driver. If the aux bus needs the DP phy enabled, the DP controller driver should enable the phy power (via phy_power_on()?). ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings 2022-05-05 19:06 ` Stephen Boyd (?) @ 2022-05-06 13:36 ` Sankeerth Billakanti (QUIC) -1 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti (QUIC) @ 2022-05-06 13:36 UTC (permalink / raw) To: Stephen Boyd, Doug Anderson, Sankeerth Billakanti (QUIC) Cc: bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar (QUIC), linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota (QUIC), Kuogee Hsieh (QUIC), Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, LKML >> >> Our internal power grid documents list the regulators as >> >> VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms. >> > >> >Do your internal power grid documents indicate what these supplies >> >are powering? The question is if these supplies power any of the >> >logic inside the eDP controller or if they only supply power to the >> >analog circuits in the eDP phy. If it's the eDP phy only then the >> >regulator usage in the eDP driver should be removed. I would suspect >> >this is the case because the controller is probably all digital logic >> >and runs at the typical 1.8V that the rest of the SoC uses. >> >Similarly, these are voltage references which sound like a PLL reference >voltage. >> > >> >Please clarify this further. >> > >> >> For the DP driver using the usb-dp combo phy, there were cases where >> the usb driver was turning off the phy and pll regulators whenever usb-dp >concurrent mode need not be supported. >> This caused phy and pll to be powered down causing aux transaction failures >and display blankouts. >> From then on, it became a practice for the controller driver to vote for the >phy and pll regulators also. >> > >That sounds like USB-DP combo phy driver had improper regulator power >management where aux transactions from DP didn't keep the power on to >the phy. Where does the power physically go? If the power isn't physically >going to the DP controller it shouldn't be controlled from the DP controller >driver. If the aux bus needs the DP phy enabled, the DP controller driver >should enable the phy power (via phy_power_on()?). Yes, it was limitation earlier when we did not have proper interface to interact with the combo phy. In this case, the power from the regulators go to the combo phy. Now that there is an interface for the controller to interact with the combo phy, the proposal to drop the phy regulator voting from the controller driver seems reasonable to me. The phy_power_on() is used for getting the phy out of low power state or getting it ready for data transfer. The controller driver needs to enable the phy power via the phy_init() before any interaction with the sink like the aux transactions or before sending the data. The controller can disable the regulators via the phy_exit() call. Thank you, Sankeerth ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-06 13:36 ` Sankeerth Billakanti (QUIC) 0 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti (QUIC) @ 2022-05-06 13:36 UTC (permalink / raw) To: Stephen Boyd, Doug Anderson, Sankeerth Billakanti (QUIC) Cc: bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar (QUIC), linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota (QUIC), Kuogee Hsieh (QUIC), Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, LKML >> >> Our internal power grid documents list the regulators as >> >> VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms. >> > >> >Do your internal power grid documents indicate what these supplies >> >are powering? The question is if these supplies power any of the >> >logic inside the eDP controller or if they only supply power to the >> >analog circuits in the eDP phy. If it's the eDP phy only then the >> >regulator usage in the eDP driver should be removed. I would suspect >> >this is the case because the controller is probably all digital logic >> >and runs at the typical 1.8V that the rest of the SoC uses. >> >Similarly, these are voltage references which sound like a PLL reference >voltage. >> > >> >Please clarify this further. >> > >> >> For the DP driver using the usb-dp combo phy, there were cases where >> the usb driver was turning off the phy and pll regulators whenever usb-dp >concurrent mode need not be supported. >> This caused phy and pll to be powered down causing aux transaction failures >and display blankouts. >> From then on, it became a practice for the controller driver to vote for the >phy and pll regulators also. >> > >That sounds like USB-DP combo phy driver had improper regulator power >management where aux transactions from DP didn't keep the power on to >the phy. Where does the power physically go? If the power isn't physically >going to the DP controller it shouldn't be controlled from the DP controller >driver. If the aux bus needs the DP phy enabled, the DP controller driver >should enable the phy power (via phy_power_on()?). Yes, it was limitation earlier when we did not have proper interface to interact with the combo phy. In this case, the power from the regulators go to the combo phy. Now that there is an interface for the controller to interact with the combo phy, the proposal to drop the phy regulator voting from the controller driver seems reasonable to me. The phy_power_on() is used for getting the phy out of low power state or getting it ready for data transfer. The controller driver needs to enable the phy power via the phy_init() before any interaction with the sink like the aux transactions or before sending the data. The controller can disable the regulators via the phy_exit() call. Thank you, Sankeerth -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-06 13:36 ` Sankeerth Billakanti (QUIC) 0 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti (QUIC) @ 2022-05-06 13:36 UTC (permalink / raw) To: Stephen Boyd, Doug Anderson, Sankeerth Billakanti (QUIC) Cc: Rob Clark, Kalyan Thota (QUIC), devicetree, David Airlie, linux-arm-msm, Kuogee Hsieh (QUIC), Abhinav Kumar (QUIC), dri-devel, bjorn.andersson, linux-phy, Vinod Koul, Rob Herring, Krzysztof Kozlowski, dmitry.baryshkov, Sean Paul, Kishon Vijay Abraham I, freedreno, LKML >> >> Our internal power grid documents list the regulators as >> >> VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms. >> > >> >Do your internal power grid documents indicate what these supplies >> >are powering? The question is if these supplies power any of the >> >logic inside the eDP controller or if they only supply power to the >> >analog circuits in the eDP phy. If it's the eDP phy only then the >> >regulator usage in the eDP driver should be removed. I would suspect >> >this is the case because the controller is probably all digital logic >> >and runs at the typical 1.8V that the rest of the SoC uses. >> >Similarly, these are voltage references which sound like a PLL reference >voltage. >> > >> >Please clarify this further. >> > >> >> For the DP driver using the usb-dp combo phy, there were cases where >> the usb driver was turning off the phy and pll regulators whenever usb-dp >concurrent mode need not be supported. >> This caused phy and pll to be powered down causing aux transaction failures >and display blankouts. >> From then on, it became a practice for the controller driver to vote for the >phy and pll regulators also. >> > >That sounds like USB-DP combo phy driver had improper regulator power >management where aux transactions from DP didn't keep the power on to >the phy. Where does the power physically go? If the power isn't physically >going to the DP controller it shouldn't be controlled from the DP controller >driver. If the aux bus needs the DP phy enabled, the DP controller driver >should enable the phy power (via phy_power_on()?). Yes, it was limitation earlier when we did not have proper interface to interact with the combo phy. In this case, the power from the regulators go to the combo phy. Now that there is an interface for the controller to interact with the combo phy, the proposal to drop the phy regulator voting from the controller driver seems reasonable to me. The phy_power_on() is used for getting the phy out of low power state or getting it ready for data transfer. The controller driver needs to enable the phy power via the phy_init() before any interaction with the sink like the aux transactions or before sending the data. The controller can disable the regulators via the phy_exit() call. Thank you, Sankeerth ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings 2022-05-06 13:36 ` Sankeerth Billakanti (QUIC) (?) @ 2022-05-11 18:21 ` Doug Anderson -1 siblings, 0 replies; 42+ messages in thread From: Doug Anderson @ 2022-05-11 18:21 UTC (permalink / raw) To: Sankeerth Billakanti (QUIC) Cc: Stephen Boyd, bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar (QUIC), linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota (QUIC), Kuogee Hsieh (QUIC), Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, LKML Hi, On Fri, May 6, 2022 at 6:36 AM Sankeerth Billakanti (QUIC) <quic_sbillaka@quicinc.com> wrote: > > >> >> Our internal power grid documents list the regulators as > >> >> VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms. > >> > > >> >Do your internal power grid documents indicate what these supplies > >> >are powering? The question is if these supplies power any of the > >> >logic inside the eDP controller or if they only supply power to the > >> >analog circuits in the eDP phy. If it's the eDP phy only then the > >> >regulator usage in the eDP driver should be removed. I would suspect > >> >this is the case because the controller is probably all digital logic > >> >and runs at the typical 1.8V that the rest of the SoC uses. > >> >Similarly, these are voltage references which sound like a PLL reference > >voltage. > >> > > >> >Please clarify this further. > >> > > >> > >> For the DP driver using the usb-dp combo phy, there were cases where > >> the usb driver was turning off the phy and pll regulators whenever usb-dp > >concurrent mode need not be supported. > >> This caused phy and pll to be powered down causing aux transaction failures > >and display blankouts. > >> From then on, it became a practice for the controller driver to vote for the > >phy and pll regulators also. > >> > > > >That sounds like USB-DP combo phy driver had improper regulator power > >management where aux transactions from DP didn't keep the power on to > >the phy. Where does the power physically go? If the power isn't physically > >going to the DP controller it shouldn't be controlled from the DP controller > >driver. If the aux bus needs the DP phy enabled, the DP controller driver > >should enable the phy power (via phy_power_on()?). > > Yes, it was limitation earlier when we did not have proper interface to interact > with the combo phy. > > In this case, the power from the regulators go to the combo phy. > > Now that there is an interface for the controller to interact with the > combo phy, the proposal to drop the phy regulator voting from the controller > driver seems reasonable to me. > > The phy_power_on() is used for getting the phy out of low power state or getting > it ready for data transfer. > > The controller driver needs to enable the phy power via the phy_init() before > any interaction with the sink like the aux transactions or before sending the data. > The controller can disable the regulators via the phy_exit() call. I can confirm that if I stop providing these regulators to the DP controller that the screen still comes up. ...but also there are lots of other things (including the PHY) that power these regulators up... From offline discussion with folks: 1. It sounds like maybe the code for handling the regulators in the DP controller leaked in from downstream where the DP driver itself controls more stuff. 2. We should probably remove these regulators from the DP controller. 3. When we remove this from the DP controller, we'll have to make sure that the PHY driver calls regulator_set_load() as needed. Kuogee has volunteered to own this issue and send out patches fixing the stuff up. So for now, please consider ${SUBJECT} patch abandoned. -Doug ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-11 18:21 ` Doug Anderson 0 siblings, 0 replies; 42+ messages in thread From: Doug Anderson @ 2022-05-11 18:21 UTC (permalink / raw) To: Sankeerth Billakanti (QUIC) Cc: Rob Clark, Kishon Vijay Abraham I, Kalyan Thota (QUIC), devicetree, David Airlie, linux-arm-msm, Kuogee Hsieh (QUIC), Abhinav Kumar (QUIC), dri-devel, bjorn.andersson, linux-phy, Vinod Koul, Rob Herring, Krzysztof Kozlowski, dmitry.baryshkov, Sean Paul, Stephen Boyd, freedreno, LKML Hi, On Fri, May 6, 2022 at 6:36 AM Sankeerth Billakanti (QUIC) <quic_sbillaka@quicinc.com> wrote: > > >> >> Our internal power grid documents list the regulators as > >> >> VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms. > >> > > >> >Do your internal power grid documents indicate what these supplies > >> >are powering? The question is if these supplies power any of the > >> >logic inside the eDP controller or if they only supply power to the > >> >analog circuits in the eDP phy. If it's the eDP phy only then the > >> >regulator usage in the eDP driver should be removed. I would suspect > >> >this is the case because the controller is probably all digital logic > >> >and runs at the typical 1.8V that the rest of the SoC uses. > >> >Similarly, these are voltage references which sound like a PLL reference > >voltage. > >> > > >> >Please clarify this further. > >> > > >> > >> For the DP driver using the usb-dp combo phy, there were cases where > >> the usb driver was turning off the phy and pll regulators whenever usb-dp > >concurrent mode need not be supported. > >> This caused phy and pll to be powered down causing aux transaction failures > >and display blankouts. > >> From then on, it became a practice for the controller driver to vote for the > >phy and pll regulators also. > >> > > > >That sounds like USB-DP combo phy driver had improper regulator power > >management where aux transactions from DP didn't keep the power on to > >the phy. Where does the power physically go? If the power isn't physically > >going to the DP controller it shouldn't be controlled from the DP controller > >driver. If the aux bus needs the DP phy enabled, the DP controller driver > >should enable the phy power (via phy_power_on()?). > > Yes, it was limitation earlier when we did not have proper interface to interact > with the combo phy. > > In this case, the power from the regulators go to the combo phy. > > Now that there is an interface for the controller to interact with the > combo phy, the proposal to drop the phy regulator voting from the controller > driver seems reasonable to me. > > The phy_power_on() is used for getting the phy out of low power state or getting > it ready for data transfer. > > The controller driver needs to enable the phy power via the phy_init() before > any interaction with the sink like the aux transactions or before sending the data. > The controller can disable the regulators via the phy_exit() call. I can confirm that if I stop providing these regulators to the DP controller that the screen still comes up. ...but also there are lots of other things (including the PHY) that power these regulators up... From offline discussion with folks: 1. It sounds like maybe the code for handling the regulators in the DP controller leaked in from downstream where the DP driver itself controls more stuff. 2. We should probably remove these regulators from the DP controller. 3. When we remove this from the DP controller, we'll have to make sure that the PHY driver calls regulator_set_load() as needed. Kuogee has volunteered to own this issue and send out patches fixing the stuff up. So for now, please consider ${SUBJECT} patch abandoned. -Doug ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings @ 2022-05-11 18:21 ` Doug Anderson 0 siblings, 0 replies; 42+ messages in thread From: Doug Anderson @ 2022-05-11 18:21 UTC (permalink / raw) To: Sankeerth Billakanti (QUIC) Cc: Stephen Boyd, bjorn.andersson, dmitry.baryshkov, Rob Clark, Rob Herring, Vinod Koul, Abhinav Kumar (QUIC), linux-phy, dri-devel, freedreno, Kishon Vijay Abraham I, Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota (QUIC), Kuogee Hsieh (QUIC), Daniel Vetter, David Airlie, Rob Clark, Sean Paul, devicetree, LKML Hi, On Fri, May 6, 2022 at 6:36 AM Sankeerth Billakanti (QUIC) <quic_sbillaka@quicinc.com> wrote: > > >> >> Our internal power grid documents list the regulators as > >> >> VDD_A_*_1P2 and VDD_A_*_0P9 for all the platforms. > >> > > >> >Do your internal power grid documents indicate what these supplies > >> >are powering? The question is if these supplies power any of the > >> >logic inside the eDP controller or if they only supply power to the > >> >analog circuits in the eDP phy. If it's the eDP phy only then the > >> >regulator usage in the eDP driver should be removed. I would suspect > >> >this is the case because the controller is probably all digital logic > >> >and runs at the typical 1.8V that the rest of the SoC uses. > >> >Similarly, these are voltage references which sound like a PLL reference > >voltage. > >> > > >> >Please clarify this further. > >> > > >> > >> For the DP driver using the usb-dp combo phy, there were cases where > >> the usb driver was turning off the phy and pll regulators whenever usb-dp > >concurrent mode need not be supported. > >> This caused phy and pll to be powered down causing aux transaction failures > >and display blankouts. > >> From then on, it became a practice for the controller driver to vote for the > >phy and pll regulators also. > >> > > > >That sounds like USB-DP combo phy driver had improper regulator power > >management where aux transactions from DP didn't keep the power on to > >the phy. Where does the power physically go? If the power isn't physically > >going to the DP controller it shouldn't be controlled from the DP controller > >driver. If the aux bus needs the DP phy enabled, the DP controller driver > >should enable the phy power (via phy_power_on()?). > > Yes, it was limitation earlier when we did not have proper interface to interact > with the combo phy. > > In this case, the power from the regulators go to the combo phy. > > Now that there is an interface for the controller to interact with the > combo phy, the proposal to drop the phy regulator voting from the controller > driver seems reasonable to me. > > The phy_power_on() is used for getting the phy out of low power state or getting > it ready for data transfer. > > The controller driver needs to enable the phy power via the phy_init() before > any interaction with the sink like the aux transactions or before sending the data. > The controller can disable the regulators via the phy_exit() call. I can confirm that if I stop providing these regulators to the DP controller that the screen still comes up. ...but also there are lots of other things (including the PHY) that power these regulators up... From offline discussion with folks: 1. It sounds like maybe the code for handling the regulators in the DP controller leaked in from downstream where the DP driver itself controls more stuff. 2. We should probably remove these regulators from the DP controller. 3. When we remove this from the DP controller, we'll have to make sure that the PHY driver calls regulator_set_load() as needed. Kuogee has volunteered to own this issue and send out patches fixing the stuff up. So for now, please consider ${SUBJECT} patch abandoned. -Doug -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy 2022-04-25 21:06 ` Douglas Anderson (?) @ 2022-04-25 21:06 ` Douglas Anderson -1 siblings, 0 replies; 42+ messages in thread From: Douglas Anderson @ 2022-04-25 21:06 UTC (permalink / raw) To: Bjorn Andersson, Vinod Koul, Rob Herring, Dmitry Baryshkov, Rob Clark Cc: Abhinav Kumar, linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Douglas Anderson, Andy Gross, devicetree, linux-kernel We're supposed to list the supplies in the dt bindings but there are none in the eDP PHY bindings. Looking at the driver in Linux, I can see that there seem to be two relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings. NOTE: from looking at the Qualcomm datasheet for sc7280, it's not immediately clear how to figure out how to fill in these supplies. The only two eDP related supplies are simply described as "power for eDP 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and from comparing how a similar PHY is hooked up on other similar Qualcomm boards, I'll make the educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use that in the example here. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml index a5850ff529f8..cf9e9b8011cb 100644 --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml @@ -41,6 +41,9 @@ properties: "#phy-cells": const: 0 + vdda-phy-supply: true + vdda-pll-supply: true + required: - compatible - reg @@ -65,5 +68,8 @@ examples: #clock-cells = <1>; #phy-cells = <0>; + + vdda-phy-supply = <&vdd_a_edp_0_1p2>; + vdda-pll-supply = <&vdd_a_edp_0_0p9>; }; ... -- 2.36.0.rc2.479.g8af0fa9b8e-goog ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy @ 2022-04-25 21:06 ` Douglas Anderson 0 siblings, 0 replies; 42+ messages in thread From: Douglas Anderson @ 2022-04-25 21:06 UTC (permalink / raw) To: Bjorn Andersson, Vinod Koul, Rob Herring, Dmitry Baryshkov, Rob Clark Cc: Abhinav Kumar, linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Douglas Anderson, Andy Gross, devicetree, linux-kernel We're supposed to list the supplies in the dt bindings but there are none in the eDP PHY bindings. Looking at the driver in Linux, I can see that there seem to be two relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings. NOTE: from looking at the Qualcomm datasheet for sc7280, it's not immediately clear how to figure out how to fill in these supplies. The only two eDP related supplies are simply described as "power for eDP 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and from comparing how a similar PHY is hooked up on other similar Qualcomm boards, I'll make the educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use that in the example here. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml index a5850ff529f8..cf9e9b8011cb 100644 --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml @@ -41,6 +41,9 @@ properties: "#phy-cells": const: 0 + vdda-phy-supply: true + vdda-pll-supply: true + required: - compatible - reg @@ -65,5 +68,8 @@ examples: #clock-cells = <1>; #phy-cells = <0>; + + vdda-phy-supply = <&vdd_a_edp_0_1p2>; + vdda-pll-supply = <&vdd_a_edp_0_0p9>; }; ... -- 2.36.0.rc2.479.g8af0fa9b8e-goog -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply related [flat|nested] 42+ messages in thread
* [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy @ 2022-04-25 21:06 ` Douglas Anderson 0 siblings, 0 replies; 42+ messages in thread From: Douglas Anderson @ 2022-04-25 21:06 UTC (permalink / raw) To: Bjorn Andersson, Vinod Koul, Rob Herring, Dmitry Baryshkov, Rob Clark Cc: quic_kalyant, devicetree, Sankeerth Billakanti, Douglas Anderson, linux-arm-msm, Kuogee Hsieh, Abhinav Kumar, dri-devel, Kishon Vijay Abraham I, Andy Gross, Krzysztof Kozlowski, linux-phy, Stephen Boyd, freedreno, linux-kernel We're supposed to list the supplies in the dt bindings but there are none in the eDP PHY bindings. Looking at the driver in Linux, I can see that there seem to be two relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings. NOTE: from looking at the Qualcomm datasheet for sc7280, it's not immediately clear how to figure out how to fill in these supplies. The only two eDP related supplies are simply described as "power for eDP 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and from comparing how a similar PHY is hooked up on other similar Qualcomm boards, I'll make the educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use that in the example here. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml index a5850ff529f8..cf9e9b8011cb 100644 --- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml @@ -41,6 +41,9 @@ properties: "#phy-cells": const: 0 + vdda-phy-supply: true + vdda-pll-supply: true + required: - compatible - reg @@ -65,5 +68,8 @@ examples: #clock-cells = <1>; #phy-cells = <0>; + + vdda-phy-supply = <&vdd_a_edp_0_1p2>; + vdda-pll-supply = <&vdd_a_edp_0_0p9>; }; ... -- 2.36.0.rc2.479.g8af0fa9b8e-goog ^ permalink raw reply related [flat|nested] 42+ messages in thread
* RE: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy 2022-04-25 21:06 ` Douglas Anderson (?) @ 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) -1 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti (QUIC) @ 2022-05-05 18:47 UTC (permalink / raw) To: Douglas Anderson, bjorn.andersson, Vinod Koul, Rob Herring, dmitry.baryshkov, Rob Clark Cc: Abhinav Kumar (QUIC), linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti (QUIC), Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota (QUIC), Kuogee Hsieh (QUIC), Andy Gross, devicetree, linux-kernel >We're supposed to list the supplies in the dt bindings but there are none in >the eDP PHY bindings. > >Looking at the driver in Linux, I can see that there seem to be two relevant >supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings. > >NOTE: from looking at the Qualcomm datasheet for sc7280, it's not >immediately clear how to figure out how to fill in these supplies. The only two >eDP related supplies are simply described as "power for eDP 0.9V circuits" and >"power for eDP 1.2V circuits". From guessing and from comparing how a >similar PHY is hooked up on other similar Qualcomm boards, I'll make the >educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply >goes to "vdda-pll" and I'll use that in the example here. > >Signed-off-by: Douglas Anderson <dianders@chromium.org> >--- > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >index a5850ff529f8..cf9e9b8011cb 100644 >--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >@@ -41,6 +41,9 @@ properties: > "#phy-cells": > const: 0 > >+ vdda-phy-supply: true >+ vdda-pll-supply: true >+ > required: > - compatible > - reg >@@ -65,5 +68,8 @@ examples: > > #clock-cells = <1>; > #phy-cells = <0>; >+ >+ vdda-phy-supply = <&vdd_a_edp_0_1p2>; >+ vdda-pll-supply = <&vdd_a_edp_0_0p9>; > }; > ... >-- >2.36.0.rc2.479.g8af0fa9b8e-goog Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy @ 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) 0 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti (QUIC) @ 2022-05-05 18:47 UTC (permalink / raw) To: Douglas Anderson, bjorn.andersson, Vinod Koul, Rob Herring, dmitry.baryshkov, Rob Clark Cc: Abhinav Kumar (QUIC), linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti (QUIC), Krzysztof Kozlowski, linux-arm-msm, Kalyan Thota (QUIC), Kuogee Hsieh (QUIC), Andy Gross, devicetree, linux-kernel >We're supposed to list the supplies in the dt bindings but there are none in >the eDP PHY bindings. > >Looking at the driver in Linux, I can see that there seem to be two relevant >supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings. > >NOTE: from looking at the Qualcomm datasheet for sc7280, it's not >immediately clear how to figure out how to fill in these supplies. The only two >eDP related supplies are simply described as "power for eDP 0.9V circuits" and >"power for eDP 1.2V circuits". From guessing and from comparing how a >similar PHY is hooked up on other similar Qualcomm boards, I'll make the >educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply >goes to "vdda-pll" and I'll use that in the example here. > >Signed-off-by: Douglas Anderson <dianders@chromium.org> >--- > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >index a5850ff529f8..cf9e9b8011cb 100644 >--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >@@ -41,6 +41,9 @@ properties: > "#phy-cells": > const: 0 > >+ vdda-phy-supply: true >+ vdda-pll-supply: true >+ > required: > - compatible > - reg >@@ -65,5 +68,8 @@ examples: > > #clock-cells = <1>; > #phy-cells = <0>; >+ >+ vdda-phy-supply = <&vdd_a_edp_0_1p2>; >+ vdda-pll-supply = <&vdd_a_edp_0_0p9>; > }; > ... >-- >2.36.0.rc2.479.g8af0fa9b8e-goog Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* RE: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy @ 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) 0 siblings, 0 replies; 42+ messages in thread From: Sankeerth Billakanti (QUIC) @ 2022-05-05 18:47 UTC (permalink / raw) To: Douglas Anderson, bjorn.andersson, Vinod Koul, Rob Herring, dmitry.baryshkov, Rob Clark Cc: Kalyan Thota (QUIC), devicetree, Sankeerth Billakanti (QUIC), linux-arm-msm, Kuogee Hsieh (QUIC), Abhinav Kumar (QUIC), dri-devel, Kishon Vijay Abraham I, Andy Gross, Krzysztof Kozlowski, linux-phy, Stephen Boyd, freedreno, linux-kernel >We're supposed to list the supplies in the dt bindings but there are none in >the eDP PHY bindings. > >Looking at the driver in Linux, I can see that there seem to be two relevant >supplies: "vdda-phy" and "vdda-pll". Let's add those to the bindings. > >NOTE: from looking at the Qualcomm datasheet for sc7280, it's not >immediately clear how to figure out how to fill in these supplies. The only two >eDP related supplies are simply described as "power for eDP 0.9V circuits" and >"power for eDP 1.2V circuits". From guessing and from comparing how a >similar PHY is hooked up on other similar Qualcomm boards, I'll make the >educated guess that the 1.2V supply goes to "vdda-phy" and the 0.9V supply >goes to "vdda-pll" and I'll use that in the example here. > >Signed-off-by: Douglas Anderson <dianders@chromium.org> >--- > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > >diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >index a5850ff529f8..cf9e9b8011cb 100644 >--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml >@@ -41,6 +41,9 @@ properties: > "#phy-cells": > const: 0 > >+ vdda-phy-supply: true >+ vdda-pll-supply: true >+ > required: > - compatible > - reg >@@ -65,5 +68,8 @@ examples: > > #clock-cells = <1>; > #phy-cells = <0>; >+ >+ vdda-phy-supply = <&vdd_a_edp_0_1p2>; >+ vdda-pll-supply = <&vdd_a_edp_0_0p9>; > }; > ... >-- >2.36.0.rc2.479.g8af0fa9b8e-goog Reviewed-by: Sankeerth Billakanti <quic_sbillaka@quicinc.com> ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy 2022-04-25 21:06 ` Douglas Anderson (?) @ 2022-06-16 15:35 ` Doug Anderson -1 siblings, 0 replies; 42+ messages in thread From: Doug Anderson @ 2022-06-16 15:35 UTC (permalink / raw) To: Vinod Koul Cc: Abhinav Kumar, linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Andy Gross, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML, Rob Herring, Dmitry Baryshkov, Rob Clark, Bjorn Andersson Hi, On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson <dianders@chromium.org> wrote: > > We're supposed to list the supplies in the dt bindings but there are > none in the eDP PHY bindings. > > Looking at the driver in Linux, I can see that there seem to be two > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > bindings. > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > immediately clear how to figure out how to fill in these supplies. The > only two eDP related supplies are simply described as "power for eDP > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > from comparing how a similar PHY is hooked up on other similar > Qualcomm boards, I'll make the educated guess that the 1.2V supply > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > that in the example here. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) Even though patch #1 in this series should be dropped, this patch (patch #2) is still valid. Vinod: I assume this would land in your tree along with the first two patches in Kuogee's series [1], which are related. Please let me know if you need me to re-send or anything. Thanks! [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ -Doug ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy @ 2022-06-16 15:35 ` Doug Anderson 0 siblings, 0 replies; 42+ messages in thread From: Doug Anderson @ 2022-06-16 15:35 UTC (permalink / raw) To: Vinod Koul Cc: Abhinav Kumar, linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Andy Gross, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML, Rob Herring, Dmitry Baryshkov, Rob Clark, Bjorn Andersson Hi, On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson <dianders@chromium.org> wrote: > > We're supposed to list the supplies in the dt bindings but there are > none in the eDP PHY bindings. > > Looking at the driver in Linux, I can see that there seem to be two > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > bindings. > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > immediately clear how to figure out how to fill in these supplies. The > only two eDP related supplies are simply described as "power for eDP > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > from comparing how a similar PHY is hooked up on other similar > Qualcomm boards, I'll make the educated guess that the 1.2V supply > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > that in the example here. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) Even though patch #1 in this series should be dropped, this patch (patch #2) is still valid. Vinod: I assume this would land in your tree along with the first two patches in Kuogee's series [1], which are related. Please let me know if you need me to re-send or anything. Thanks! [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ -Doug -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy @ 2022-06-16 15:35 ` Doug Anderson 0 siblings, 0 replies; 42+ messages in thread From: Doug Anderson @ 2022-06-16 15:35 UTC (permalink / raw) To: Vinod Koul Cc: quic_kalyant, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Sankeerth Billakanti, Rob Clark, linux-arm-msm, Kuogee Hsieh, Abhinav Kumar, dri-devel, Kishon Vijay Abraham I, Rob Herring, Andy Gross, Bjorn Andersson, Dmitry Baryshkov, Krzysztof Kozlowski, linux-phy, Stephen Boyd, freedreno, LKML Hi, On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson <dianders@chromium.org> wrote: > > We're supposed to list the supplies in the dt bindings but there are > none in the eDP PHY bindings. > > Looking at the driver in Linux, I can see that there seem to be two > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > bindings. > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > immediately clear how to figure out how to fill in these supplies. The > only two eDP related supplies are simply described as "power for eDP > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > from comparing how a similar PHY is hooked up on other similar > Qualcomm boards, I'll make the educated guess that the 1.2V supply > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > that in the example here. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) Even though patch #1 in this series should be dropped, this patch (patch #2) is still valid. Vinod: I assume this would land in your tree along with the first two patches in Kuogee's series [1], which are related. Please let me know if you need me to re-send or anything. Thanks! [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ -Doug ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy 2022-06-16 15:35 ` Doug Anderson (?) @ 2022-06-17 0:10 ` Vinod Koul -1 siblings, 0 replies; 42+ messages in thread From: Vinod Koul @ 2022-06-17 0:10 UTC (permalink / raw) To: Doug Anderson Cc: Abhinav Kumar, linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Andy Gross, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML, Rob Herring, Dmitry Baryshkov, Rob Clark, Bjorn Andersson On 16-06-22, 08:35, Doug Anderson wrote: > Hi, > > On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson <dianders@chromium.org> wrote: > > > > We're supposed to list the supplies in the dt bindings but there are > > none in the eDP PHY bindings. > > > > Looking at the driver in Linux, I can see that there seem to be two > > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > > bindings. > > > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > > immediately clear how to figure out how to fill in these supplies. The > > only two eDP related supplies are simply described as "power for eDP > > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > > from comparing how a similar PHY is hooked up on other similar > > Qualcomm boards, I'll make the educated guess that the 1.2V supply > > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > > that in the example here. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Even though patch #1 in this series should be dropped, this patch > (patch #2) is still valid. Vinod: I assume this would land in your > tree along with the first two patches in Kuogee's series [1], which > are related. Please let me know if you need me to re-send or anything. I have applied this patch, thanks > [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ This needs rebase on phy split which I have picked -- ~Vinod ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy @ 2022-06-17 0:10 ` Vinod Koul 0 siblings, 0 replies; 42+ messages in thread From: Vinod Koul @ 2022-06-17 0:10 UTC (permalink / raw) To: Doug Anderson Cc: Abhinav Kumar, linux-phy, Stephen Boyd, dri-devel, freedreno, Kishon Vijay Abraham I, Sankeerth Billakanti, Krzysztof Kozlowski, linux-arm-msm, quic_kalyant, Kuogee Hsieh, Andy Gross, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML, Rob Herring, Dmitry Baryshkov, Rob Clark, Bjorn Andersson On 16-06-22, 08:35, Doug Anderson wrote: > Hi, > > On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson <dianders@chromium.org> wrote: > > > > We're supposed to list the supplies in the dt bindings but there are > > none in the eDP PHY bindings. > > > > Looking at the driver in Linux, I can see that there seem to be two > > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > > bindings. > > > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > > immediately clear how to figure out how to fill in these supplies. The > > only two eDP related supplies are simply described as "power for eDP > > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > > from comparing how a similar PHY is hooked up on other similar > > Qualcomm boards, I'll make the educated guess that the 1.2V supply > > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > > that in the example here. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Even though patch #1 in this series should be dropped, this patch > (patch #2) is still valid. Vinod: I assume this would land in your > tree along with the first two patches in Kuogee's series [1], which > are related. Please let me know if you need me to re-send or anything. I have applied this patch, thanks > [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ This needs rebase on phy split which I have picked -- ~Vinod -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy ^ permalink raw reply [flat|nested] 42+ messages in thread
* Re: [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy @ 2022-06-17 0:10 ` Vinod Koul 0 siblings, 0 replies; 42+ messages in thread From: Vinod Koul @ 2022-06-17 0:10 UTC (permalink / raw) To: Doug Anderson Cc: quic_kalyant, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, Sankeerth Billakanti, Rob Clark, linux-arm-msm, Kuogee Hsieh, Abhinav Kumar, dri-devel, Kishon Vijay Abraham I, Rob Herring, Andy Gross, Bjorn Andersson, Dmitry Baryshkov, Krzysztof Kozlowski, linux-phy, Stephen Boyd, freedreno, LKML On 16-06-22, 08:35, Doug Anderson wrote: > Hi, > > On Mon, Apr 25, 2022 at 2:07 PM Douglas Anderson <dianders@chromium.org> wrote: > > > > We're supposed to list the supplies in the dt bindings but there are > > none in the eDP PHY bindings. > > > > Looking at the driver in Linux, I can see that there seem to be two > > relevant supplies: "vdda-phy" and "vdda-pll". Let's add those to the > > bindings. > > > > NOTE: from looking at the Qualcomm datasheet for sc7280, it's not > > immediately clear how to figure out how to fill in these supplies. The > > only two eDP related supplies are simply described as "power for eDP > > 0.9V circuits" and "power for eDP 1.2V circuits". From guessing and > > from comparing how a similar PHY is hooked up on other similar > > Qualcomm boards, I'll make the educated guess that the 1.2V supply > > goes to "vdda-phy" and the 0.9V supply goes to "vdda-pll" and I'll use > > that in the example here. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > Even though patch #1 in this series should be dropped, this patch > (patch #2) is still valid. Vinod: I assume this would land in your > tree along with the first two patches in Kuogee's series [1], which > are related. Please let me know if you need me to re-send or anything. I have applied this patch, thanks > [1] https://lore.kernel.org/r/1653507433-22585-1-git-send-email-quic_khsieh@quicinc.com/ This needs rebase on phy split which I have picked -- ~Vinod ^ permalink raw reply [flat|nested] 42+ messages in thread
end of thread, other threads:[~2022-06-17 0:10 UTC | newest] Thread overview: 42+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-04-25 21:06 [PATCH 0/2] dt-bindings: List supplies needed for sc7280 eDP Douglas Anderson 2022-04-25 21:06 ` Douglas Anderson 2022-04-25 21:06 ` Douglas Anderson 2022-04-25 21:06 ` [PATCH 1/2] dt-bindings: msm/dp: List supplies in the bindings Douglas Anderson 2022-04-25 21:06 ` Douglas Anderson 2022-04-25 21:06 ` Douglas Anderson 2022-04-25 21:14 ` Stephen Boyd 2022-04-25 21:14 ` Stephen Boyd 2022-04-25 21:14 ` Stephen Boyd 2022-04-25 21:18 ` Doug Anderson 2022-04-25 21:18 ` Doug Anderson 2022-04-25 21:18 ` Doug Anderson 2022-05-05 18:02 ` Sankeerth Billakanti 2022-05-05 18:02 ` Sankeerth Billakanti 2022-05-05 18:02 ` Sankeerth Billakanti 2022-05-05 18:18 ` Stephen Boyd 2022-05-05 18:18 ` Stephen Boyd 2022-05-05 18:18 ` Stephen Boyd 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) 2022-05-05 19:06 ` Stephen Boyd 2022-05-05 19:06 ` Stephen Boyd 2022-05-05 19:06 ` Stephen Boyd 2022-05-06 13:36 ` Sankeerth Billakanti (QUIC) 2022-05-06 13:36 ` Sankeerth Billakanti (QUIC) 2022-05-06 13:36 ` Sankeerth Billakanti (QUIC) 2022-05-11 18:21 ` Doug Anderson 2022-05-11 18:21 ` Doug Anderson 2022-05-11 18:21 ` Doug Anderson 2022-04-25 21:06 ` [PATCH 2/2] dt-bindings: phy: List supplies for qcom,edp-phy Douglas Anderson 2022-04-25 21:06 ` Douglas Anderson 2022-04-25 21:06 ` Douglas Anderson 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) 2022-05-05 18:47 ` Sankeerth Billakanti (QUIC) 2022-06-16 15:35 ` Doug Anderson 2022-06-16 15:35 ` Doug Anderson 2022-06-16 15:35 ` Doug Anderson 2022-06-17 0:10 ` Vinod Koul 2022-06-17 0:10 ` Vinod Koul 2022-06-17 0:10 ` Vinod Koul
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.