All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Douglas Anderson <dianders@chromium.org>,
	Rob Herring <robh@kernel.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
	Alexandru M Stan <amstan@chromium.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Rajendra Nayak <quic_rjendra@quicinc.com>,
	"Joseph S . Barrera III" <joebar@chromium.org>,
	Julius Werner <jwerner@chromium.org>,
	Andy Gross <agross@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings
Date: Thu, 12 May 2022 11:42:10 -0700	[thread overview]
Message-ID: <CAE-0n51fD6H2+JmFLMWyWuamcXDWzLQaXuWpnanvwO8rDQcuKQ@mail.gmail.com> (raw)
In-Reply-To: <20220512090429.1.I9804fcd5d6c8552ab25f598dd7a3ea71b15b55f0@changeid>

Quoting Douglas Anderson (2022-05-12 09:04:45)
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 5c06d1bfc046..399be67eb5d2 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -214,11 +214,191 @@ properties:
>                - qcom,ipq8074-hk10-c2
>            - const: qcom,ipq8074
>

Side note: The top of this file describes a scheme that is basically not
used by any compatibles in this file. I came up with that scheme many
years ago so that we could upstream DTS files but still be able to
generate the magic numbers that the bootloader picked DTBs by. I hope
nobody assumes that description applies to "google," prefixed
compatibles.

Can the description can be amended to indicate the "google," scheme with
rev and sku details? Or a bindings/arm/chrome.yaml file could be made
and all google prefix chromeos board compatibles could be put in there
regardless of SoC used.

> +      # Qualcomm Technologies, Inc. SC7180 IDP
>        - items:
>            - enum:
>                - qcom,sc7180-idp
>            - const: qcom,sc7180
>
> +      # Google CoachZ (rev1 - 2)

Can we follow the design of rockchip.yaml and also include the marketing
name (if published)? That helps folks match things up quicker.

  parent reply	other threads:[~2022-05-12 18:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12 16:04 [PATCH 1/3] dt-bindings: arm: qcom: Add sc7180 Chromebook board bindings Douglas Anderson
2022-05-12 16:04 ` [PATCH 2/3] dt-bindings: arm: qcom: Add / fix sc7280 " Douglas Anderson
2022-05-13 12:33   ` Rob Herring
2022-05-13 13:43     ` Doug Anderson
2022-05-12 16:04 ` [PATCH 3/3] dt-bindings: arm: qcom: Add more sc7180 Chromebook " Douglas Anderson
2022-05-12 18:42 ` Stephen Boyd [this message]
2022-05-13  7:57 ` [PATCH 1/3] dt-bindings: arm: qcom: Add " Krzysztof Kozlowski
2022-05-13  9:00   ` Krzysztof Kozlowski
2022-05-13 17:00     ` Doug Anderson
2022-05-16  6:40       ` Krzysztof Kozlowski
2022-05-16 15:11         ` Doug Anderson
2022-05-16 15:14           ` Krzysztof Kozlowski
2022-05-16 15:20             ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAE-0n51fD6H2+JmFLMWyWuamcXDWzLQaXuWpnanvwO8rDQcuKQ@mail.gmail.com \
    --to=swboyd@chromium.org \
    --cc=agross@kernel.org \
    --cc=amstan@chromium.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=joebar@chromium.org \
    --cc=jwerner@chromium.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.