From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF0EC433EF for ; Tue, 28 Sep 2021 20:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DB9660FC0 for ; Tue, 28 Sep 2021 20:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242835AbhI1VAA (ORCPT ); Tue, 28 Sep 2021 17:00:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242830AbhI1VAA (ORCPT ); Tue, 28 Sep 2021 17:00:00 -0400 Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A27DC061745 for ; Tue, 28 Sep 2021 13:58:20 -0700 (PDT) Received: by mail-ot1-x32b.google.com with SMTP id l16-20020a9d6a90000000b0053b71f7dc83so131072otq.7 for ; Tue, 28 Sep 2021 13:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=JxCbOz9qgttDGSSzA1A+6uSJW6TvZefvlJJb7t5kz1o=; b=duC8iY3GkRQ5Nob6TY8qS1K8UBtaDRxsgpLtkJ0Yvh/yjxWmMoaKqrdC9Ny+iT0jeD +9BBeke8Ciy45JL2dmx6DioP1WSAZ/CsoO1fPDb7g/OMWcPbzk77sB/Ud0uR5tnDufJG PyCu+7w2tKMdXDXsvmm5/t8oQ+os+tLRfI1Gg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=JxCbOz9qgttDGSSzA1A+6uSJW6TvZefvlJJb7t5kz1o=; b=t6wPbzjVTCvLZdmUKzsuY8WDuln74k05KZwwVIgFsz6cq98KCfvAIhDq9iiFm5hkSi DvwkmkCeIPHc+rK7vlT/j+McMg2JCuNdnaH3/NTMMMuQWHhtNEUCyFucsTxdT0SjYviW Qceg9IK6lenHEnQbZTPPbsBSg4e9zrO8UTe2HQuZa0hXk+2nbQAlf8235GnrZFZL1Zwb KAsaSchmbl6rvo04l1HA1qXKTrz/2MD6Ffcao4aDCu8Mfd63f1PrCCfHc9s8Cn2DZk/8 h33RpfNpmJxeYoycvgeaDJLbM7g7tJiUqkMjerqDGp6jFwbws8exqd8WCl40BKhetSFP ulAg== X-Gm-Message-State: AOAM532nGbduRmFrOrHWI1zD2kmVVnYaed4mIUGjzHsKn47EHpaQhDY+ XkwvZn1I9yg35PtpTazq/A6TahaGsecQy5+gONuC8Q== X-Google-Smtp-Source: ABdhPJyx8L7PGpIsF51ydfQYJSyJeg2xs9b0R4HUjdFcklP5svjYgwTs03pQUYw6ANvsHBi68B0ohEcyCtS45Xeg568= X-Received: by 2002:a05:6830:358:: with SMTP id h24mr6688222ote.159.1632862699941; Tue, 28 Sep 2021 13:58:19 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 28 Sep 2021 13:58:19 -0700 MIME-Version: 1.0 In-Reply-To: <20210927184858.2.I651eec59ce3cd1c4bdd64de31f9c3531f501b3a8@changeid> References: <20210927184858.1.Ib7e63ae17e827ce0636a09d5dec9796043e4f80a@changeid> <20210927184858.2.I651eec59ce3cd1c4bdd64de31f9c3531f501b3a8@changeid> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 28 Sep 2021 13:58:19 -0700 Message-ID: Subject: Re: [PATCH 2/2] arm64: dts: sc7180: Support Parade ps8640 edp bridge To: LKML , Philip Chen Cc: dianders@chromium.org, Andy Gross , Bjorn Andersson , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Philip Chen (2021-09-27 18:49:40) > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-parade-ps8640.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-parade-ps8640.dtsi > new file mode 100644 > index 000000000000..647afb3a7c6a > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-parade-ps8640.dtsi > @@ -0,0 +1,105 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Trogdor dts fragment for the boards with Parade ps8640 edp bridge > + * > + * Copyright 2021 Google LLC. > + */ > + > +/ { > + pp3300_brij_ps8640: pp3300-brij-ps8640 { > + compatible = "regulator-fixed"; > + status = "okay"; > + regulator-name = "pp3300_brij_ps8640"; > + > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&en_pp3300_edp_brij_ps8640>; > + > + vin-supply = <&pp3300_a>; > + }; > +}; > + > +&dsi0_out { > + remote-endpoint = <&ps8640_in>; > +}; > + > +&i2c2 { > + ps8640_bridge: edp-bridge@8 { > + compatible = "parade,ps8640"; > + reg = <0x8>; > + > + powerdown-gpios = <&tlmm 104 GPIO_ACTIVE_LOW>; > + reset-gpios = <&tlmm 11 GPIO_ACTIVE_LOW>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&edp_brij_en>, <&edp_brij_ps8640_rst>; Ah here it is. Ignore my concern on patch #1. > + > + vdd12-supply = <&pp1200_brij>; > + vdd33-supply = <&pp3300_brij_ps8640>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + ps8640_in: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + ps8640_out: endpoint { > + remote-endpoint = <&panel_in_edp>; > + }; > + }; > + }; > + > + aux_bus: aux-bus { The parade,ps8640 binding needs an update for aux-bus. Is that somewhere in linux-next or on the list? > + panel: panel { > + /* Compatible will be filled in per-board */ > + power-supply = <&pp3300_dx_edp>; > + backlight = <&backlight>; > + > + port { > + panel_in_edp: endpoint { > + remote-endpoint = <&ps8640_out>; > + }; > + }; > + }; > + }; > + }; > +};