From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA675C4743D for ; Fri, 4 Jun 2021 21:56:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AEDB361404 for ; Fri, 4 Jun 2021 21:56:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229929AbhFDV55 (ORCPT ); Fri, 4 Jun 2021 17:57:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229755AbhFDV54 (ORCPT ); Fri, 4 Jun 2021 17:57:56 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 049F9C061766 for ; Fri, 4 Jun 2021 14:56:10 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id w23-20020a9d5a970000b02903d0ef989477so6086805oth.9 for ; Fri, 04 Jun 2021 14:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=evDQonRj1S3K8SX7rZUDCIBczFx/sTo8Wvx2aYwIKls=; b=OWVBOB4L27Ux5W7z3KOprvIdOjq6V6gJYuHTJkkC+0KGtG05Uyygnys63nU6Hg4h7j iB+z2RmmKspf7lVJInQgiatOtsE65JJNqbtYqHRLPcsOVBsrm6FGazfGDlE4y5uGFGXG +4+fz2igEEl0ganIoL7z4jkhrrpZTxNkyRA6g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=evDQonRj1S3K8SX7rZUDCIBczFx/sTo8Wvx2aYwIKls=; b=Af5De6rveXbf+wx4yPqg7DpbBwOBWz2VBswsIX+HRs4ObIZHHjQ/1b3DcInX266fSS 7MfcndSbmpLs9wzrw2NZ5IYrERoeD8AtnudfBtKHOv+n++dAj2aOvZTI9sJXpeaGg65V d3Ywv4eWQCiuijrP8jU8WRjazRzE9sLkVGtgXfeaded5KEaNa8f50FjUw7YmNqkYBlmf fUsTCnpOly6t5OKUmyzs77PU5WlFZr85g+q9v09ePh/z8Z4LFGEs8kKiOSjjZ/6BtFUG Vzmy8dB6m8Ij0c88WmMEiKs5yAF+3VTwlIN4ijifYMtThd718rvUnTUQD2jMPJZsidSu DGfA== X-Gm-Message-State: AOAM532sEpfYN1KP8tdKQB9jYQTMQOUL/kJS/bbjVSdau87KCC0UBk8A bFklehYeoIxvcnInAzurv1DtGXtT0IF2f2+pye/Wow== X-Google-Smtp-Source: ABdhPJz30wwX+MWCxP0OwF1fi1pxyg1nUhQ2q7Vjonlctql1t61M7fV2t4d5RvkXGcWbtIcYD5GCLLqwA8BnqteyMT4= X-Received: by 2002:a05:6830:3154:: with SMTP id c20mr5443978ots.233.1622843769406; Fri, 04 Jun 2021 14:56:09 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 4 Jun 2021 21:56:09 +0000 MIME-Version: 1.0 In-Reply-To: References: <20210511042043.592802-1-bjorn.andersson@linaro.org> <20210511042043.592802-5-bjorn.andersson@linaro.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Fri, 4 Jun 2021 21:56:09 +0000 Message-ID: Subject: Re: [Freedreno] [PATCH 4/4] drm/msm/dp: Add support for SC8180x eDP To: Bjorn Andersson , abhinavk@codeaurora.org Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , sbillaka@codeaurora.org, Tanmay Shah , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dmitry Baryshkov , freedreno@lists.freedesktop.org, Chandan Uddaraju Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting abhinavk@codeaurora.org (2021-05-28 16:40:32) > On 2021-05-10 21:20, Bjorn Andersson wrote: > > The eDP controller found in SC8180x is at large compatible with the > > current implementation, but has its register blocks at slightly > > different offsets. > > > > Add the compatible and the new register layout. > > > I am not able to completely recall the history of why in the DP bindings > we added DP register base as a big hunk and let catalog handle the > submodule > offsets. I complained that there were many I/O regions for the DP block that didn't seem to be changing between SoCs. Nobody objected to removing it back then, but if the plan was to move things around later on then it makes sense to split it out like it was done initially. > > I guess earlier that made sense because DP sub-block offsets were fixed. > But if we plan to re-use the DP driver for eDP as well like this series, > then maybe it might be > better if this comes from device tree like the earlier version was > planning to > > https://patchwork.kernel.org/project/dri-devel/patch/0101016ec6ddf446-e87ab1ce-5cbf-40a0-a0bb-cd0151cd577a-000000@us-west-2.amazonses.com/ > Agreed. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25485C4743C for ; Fri, 4 Jun 2021 21:56:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E265861404 for ; Fri, 4 Jun 2021 21:56:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E265861404 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 505D66E40F; Fri, 4 Jun 2021 21:56:11 +0000 (UTC) Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2EBE06F55D for ; Fri, 4 Jun 2021 21:56:10 +0000 (UTC) Received: by mail-ot1-x329.google.com with SMTP id h24-20020a9d64180000b029036edcf8f9a6so10520923otl.3 for ; Fri, 04 Jun 2021 14:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=evDQonRj1S3K8SX7rZUDCIBczFx/sTo8Wvx2aYwIKls=; b=OWVBOB4L27Ux5W7z3KOprvIdOjq6V6gJYuHTJkkC+0KGtG05Uyygnys63nU6Hg4h7j iB+z2RmmKspf7lVJInQgiatOtsE65JJNqbtYqHRLPcsOVBsrm6FGazfGDlE4y5uGFGXG +4+fz2igEEl0ganIoL7z4jkhrrpZTxNkyRA6g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=evDQonRj1S3K8SX7rZUDCIBczFx/sTo8Wvx2aYwIKls=; b=Of9wvb2rlzLr8li16T/diyb6XhnGHeip7G9+KcvWf278jY37hnHoj9dQ/bhz2CcCpX SYwhK0HaZmqUYsmzS6/PkfEmM/BQIhzaNrwD52d3dP70rN49AfVx5GPLEHhJN+XpEMz6 Zl8aoXEoHTMJIFndx++DLeTEHo3NNthp9LInFPohHlzpWwD5D78teOg8kAqCfEl0DfHn iVKEpBfvvk2wZQWW1q55SPhABXMgTrgtm8OzJPYcaPgcqMiBV1ubKU7kzx7l6dk66zKL HF///9NW6rjsJzDA9335pPu/PNLC1WXym9D5/YOh+VgCUasYucq5zvob7ikiH56g9wCI LaJA== X-Gm-Message-State: AOAM532AhAGiV5qLRn7Y8/GIvc6a1YaEW55AbNDJMLDRUqQvnZjxjauL VOkS3JOJEhXrlNY3o7kjVg5ca7+4++1glo7D6EuhEQ== X-Google-Smtp-Source: ABdhPJz30wwX+MWCxP0OwF1fi1pxyg1nUhQ2q7Vjonlctql1t61M7fV2t4d5RvkXGcWbtIcYD5GCLLqwA8BnqteyMT4= X-Received: by 2002:a05:6830:3154:: with SMTP id c20mr5443978ots.233.1622843769406; Fri, 04 Jun 2021 14:56:09 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 4 Jun 2021 21:56:09 +0000 MIME-Version: 1.0 In-Reply-To: References: <20210511042043.592802-1-bjorn.andersson@linaro.org> <20210511042043.592802-5-bjorn.andersson@linaro.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Fri, 4 Jun 2021 21:56:09 +0000 Message-ID: Subject: Re: [Freedreno] [PATCH 4/4] drm/msm/dp: Add support for SC8180x eDP To: Bjorn Andersson , abhinavk@codeaurora.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Tanmay Shah , dri-devel@lists.freedesktop.org, Dmitry Baryshkov , sbillaka@codeaurora.org, Sean Paul , Chandan Uddaraju Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting abhinavk@codeaurora.org (2021-05-28 16:40:32) > On 2021-05-10 21:20, Bjorn Andersson wrote: > > The eDP controller found in SC8180x is at large compatible with the > > current implementation, but has its register blocks at slightly > > different offsets. > > > > Add the compatible and the new register layout. > > > I am not able to completely recall the history of why in the DP bindings > we added DP register base as a big hunk and let catalog handle the > submodule > offsets. I complained that there were many I/O regions for the DP block that didn't seem to be changing between SoCs. Nobody objected to removing it back then, but if the plan was to move things around later on then it makes sense to split it out like it was done initially. > > I guess earlier that made sense because DP sub-block offsets were fixed. > But if we plan to re-use the DP driver for eDP as well like this series, > then maybe it might be > better if this comes from device tree like the earlier version was > planning to > > https://patchwork.kernel.org/project/dri-devel/patch/0101016ec6ddf446-e87ab1ce-5cbf-40a0-a0bb-cd0151cd577a-000000@us-west-2.amazonses.com/ > Agreed.