From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C55C4743F for ; Tue, 25 Jan 2022 22:58:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234503AbiAYW6s (ORCPT ); Tue, 25 Jan 2022 17:58:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234496AbiAYW6r (ORCPT ); Tue, 25 Jan 2022 17:58:47 -0500 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28058C06161C for ; Tue, 25 Jan 2022 14:58:47 -0800 (PST) Received: by mail-oi1-x232.google.com with SMTP id q186so34121732oih.8 for ; Tue, 25 Jan 2022 14:58:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=4GrEGiXjXL9jM2PagphyLmPQgXS8BKdDMmMa/v1WcS8=; b=KnrApliL2b9WWrU59yhGRfdoFGaa55rg/vI7LRBW36Wfx60ses5GccZ+b4Z4vF18uG ehlsp1efYiE7XxXHgy63iyBfkfblH4TMkMDMpfERGniIW98kOdQv9ZRLA8SdFFX/appE g2hIeQTf4Z7Tu7id3qc0/jrNfUstimOw5TfME= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=4GrEGiXjXL9jM2PagphyLmPQgXS8BKdDMmMa/v1WcS8=; b=jcUuaxrcWbPmslox0aIfZlXar8uBDnRAyxr+PZ6J9ewyN4YgpInzoieIVozCdn6b5l deJFCA5iIABrC2oj8U1M3fykd2c3f//jS3+g352UuGvwif1aeUjp8KTcOFG8FwLYkHAu KwyqB6KfUJPLIhV92OW+4ikop8vuZb41Ib5pGC02Yn0VadTS0CBpdp+4GXsETuHnBXYD 1YzUctjtBcuX4c6noG4R8Ud8ytPHjA+95S3n28gEK7X7FdzNyjsGeszn146XNbtAp8EN YZ71j6coNRV4ZeFg2eLxdthCCERZm6QzU560XcQMicriZI8RAlMZYBx30v2SlIGkCOtH rWZg== X-Gm-Message-State: AOAM530z4YjpeKy1J/wKCcsiUDyH82JCgMPpP5rm5z4C5MWqGXsNAwHW 4owCWFnjUHoeTE8EbzfbsBzG87TBz8onz/LTOra75g== X-Google-Smtp-Source: ABdhPJz/O3MC6yV8Na0Cedpp8W0CwTEtF8gOk/oxJ4e1SCN0kqjYYdRYhajhxsZdC8Xxbi2ioFnxITFxMTR/93UaP9Q= X-Received: by 2002:a05:6808:1302:: with SMTP id y2mr2158640oiv.238.1643151526577; Tue, 25 Jan 2022 14:58:46 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 25 Jan 2022 14:58:46 -0800 MIME-Version: 1.0 In-Reply-To: <20220125144316.v2.5.I5604b7af908e8bbe709ac037a6a8a6ba8a2bfa94@changeid> References: <20220125224422.544381-1-dianders@chromium.org> <20220125144316.v2.5.I5604b7af908e8bbe709ac037a6a8a6ba8a2bfa94@changeid> From: Stephen Boyd User-Agent: alot/0.10 Date: Tue, 25 Jan 2022 14:58:46 -0800 Message-ID: Subject: Re: [PATCH v2 5/5] arm64: dts: qcom: sc7280: Add herobrine-r1 To: Bjorn Andersson , Douglas Anderson Cc: konrad.dybcio@somainline.org, kgodara@codeaurora.org, mka@chromium.org, sibis@codeaurora.org, pmaliset@codeaurora.org, quic_rjendra@quicinc.com, Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Douglas Anderson (2022-01-25 14:44:22) > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts > new file mode 100644 > index 000000000000..f95273052da0 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts > @@ -0,0 +1,313 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Herobrine board device tree source > + * > + * Copyright 2022 Google LLC. > + */ > + > +/dts-v1/; > + > +#include "sc7280-herobrine.dtsi" > + > +/ { > + model = "Google Herobrine (rev1+)"; > + compatible = "google,herobrine", "qcom,sc7280"; Can we stop adding "qcom,sc7280" to the board compatible string? It looks out of place. It's the compatible for the SoC and should really be the compatible for the /soc node. > +}; > + > +/* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */ > + > +&ap_spi_fp { > + status = "okay"; > +}; [...] > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > new file mode 100644 > index 000000000000..24c34ddebd18 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -0,0 +1,778 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Google Herobrine baseboard device tree source > + * [...] > + > + vin-supply = <&ppvar_sys>; > + }; > + > + pp3300_codec: pp3300-codec-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "pp3300_codec"; > + > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 105 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + pinctrl-names = "default"; > + pinctrl-0 = <&en_pp3300_codec>; > + > + vin-supply = <&pp3300_z1>; > + }; > + > + pp3300_left_in_mlb: pp3300-left-in-mlb { Sometimes '-regulator' is left out. Is that intentional? I suppose it would be better if every node had regulator postfix, but it may be too long of a node name? > + compatible = "regulator-fixed"; > + regulator-name = "pp3300_left_in_mlb"; > + > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + > + gpio = <&tlmm 80 GPIO_ACTIVE_HIGH>;