From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07B96C4338F for ; Thu, 22 Jul 2021 19:00:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F37C60EBE for ; Thu, 22 Jul 2021 19:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbhGVSUy (ORCPT ); Thu, 22 Jul 2021 14:20:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbhGVSUy (ORCPT ); Thu, 22 Jul 2021 14:20:54 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FD66C061757 for ; Thu, 22 Jul 2021 12:01:29 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id u15so7721076oiw.3 for ; Thu, 22 Jul 2021 12:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=7Ps4RwIG6XxXEH9dDOqdo2BIvmsObr7mTJxhT6gePXI=; b=gNpk0Cpx9lWZ2uCwsB/kcTfPh+1K9iB+EDMv+ITNQxIi0uF+cfnykM1D7qwr+sXIu1 C4UsfhxUoxPtHzoauLJAMCXX5ORhEV6TfPvly9wQSKI6Ndm+5GGQcZeJqoNU1YhHBqzd 3HUMA5UwuNAAXpkwhE+tCQ2ifijzqZJukQM8Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=7Ps4RwIG6XxXEH9dDOqdo2BIvmsObr7mTJxhT6gePXI=; b=UaDyKW4xFsc/iPExcP0sNDYvL0P2D4yufi3KBTjqodL9+eyYm2jfP5v8XxNtLCVUNf Gq2+vDTDIsyuKtY1vmx2qaJmPDEkFB2LbeQjzK8N8FyJT+MHUokbesDjO5pIo0tD1AEB EAH7nxVR+wUR97nNYFwYdPgpoVlG5wuujCHUmKuUEvDoom29Qf49sd//1cpWLxCD9D0Q SbqcpT47BWpOwPWXphkaYRYxGDoobKJv+tUBekXRNLo31Qjw/RQCXWXUdIqmJ6Vj0snu CeHytq05svVF2zxXZ8bzDta54heKVAmRE+F0PTBX5cWHrqe/O7uhDQWqB++my5Cvsc3h TePQ== X-Gm-Message-State: AOAM531eTf1AFV5lDJUwKH/0KSAyrmERD7/xPjVYLRZwtjxDutCrB1lj FMmjlaj6o0H4GzsiyX03uqN0zH+2+x/ztVZsl9BV4w== X-Google-Smtp-Source: ABdhPJxQNi5FQCMbhTIZY1DogS2Ny4lCD+0Ic7kNij6RwwSTL/wAv3FKZBJNJ150MFs4NFiNsZf52qF6aTUeZdpMpkM= X-Received: by 2002:a05:6808:a83:: with SMTP id q3mr6706715oij.125.1626980488491; Thu, 22 Jul 2021 12:01:28 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 22 Jul 2021 19:01:27 +0000 MIME-Version: 1.0 In-Reply-To: <1626191647-13901-2-git-send-email-khsieh@codeaurora.org> References: <1626191647-13901-1-git-send-email-khsieh@codeaurora.org> <1626191647-13901-2-git-send-email-khsieh@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 22 Jul 2021 19:01:27 +0000 Message-ID: Subject: Re: [PATCH v2 1/7] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run To: Kuogee Hsieh , dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run Cc: abhinavk@codeaurora.org, aravindh@codeaurora.org, airlied@linux.ie, daniel@ffwll.ch, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Kuogee Hsieh (2021-07-13 08:54:01) > DP cable should always connect to DPU during the entire PHY compliance > testing run. Since DP PHY compliance test is executed at irq_hpd event > context, dp_ctrl_off_link_stream() should be used instead of dp_ctrl_off(). > dp_ctrl_off() is used for unplug event which is triggered when DP cable is > dis connected. > > Changes in V2: > -- add fixes statement > > Fixes: f21c8a276c2d ("drm/msm/dp: handle irq_hpd with sink_count = 0 correctly") > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E9D9C4338F for ; Thu, 22 Jul 2021 19:00:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71A8960EBD for ; Thu, 22 Jul 2021 19:01:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 71A8960EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D90DE6E9C8; Thu, 22 Jul 2021 19:01:29 +0000 (UTC) Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 535526E9C8 for ; Thu, 22 Jul 2021 19:01:29 +0000 (UTC) Received: by mail-oi1-x22c.google.com with SMTP id t143so7685849oie.8 for ; Thu, 22 Jul 2021 12:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=7Ps4RwIG6XxXEH9dDOqdo2BIvmsObr7mTJxhT6gePXI=; b=gNpk0Cpx9lWZ2uCwsB/kcTfPh+1K9iB+EDMv+ITNQxIi0uF+cfnykM1D7qwr+sXIu1 C4UsfhxUoxPtHzoauLJAMCXX5ORhEV6TfPvly9wQSKI6Ndm+5GGQcZeJqoNU1YhHBqzd 3HUMA5UwuNAAXpkwhE+tCQ2ifijzqZJukQM8Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=7Ps4RwIG6XxXEH9dDOqdo2BIvmsObr7mTJxhT6gePXI=; b=Is/YyPIOwci7l38VMi3Yh9qZMDUc2AVPzZh4YXcATP9CWFm2tNZWYEJBuVUbct3Eor kT9kiO66cbu5gM5jLZWWLoFNquxAild/o0pMvV6P1Xth9AFT3DtJgvUidijhdWWIIJyK HOdRWDMYZAiLuXo7BZi9xFcUjkwN4Rd0lqcNtJIjbOlWPMJjLqh6vUj0d3/kPhSISki8 1gMxib7j42GjInQDLpmtVJorExOBHtMB3OXtL2TGfmeOpcrk/66DBgYjeBlmBARoD9Td CqR3Fhko0gOKR7rYircmWpv/HFHw1Er3SLW/leKRxBlXPkb9gOX9hO0X2otpa6eKWrcD kAAg== X-Gm-Message-State: AOAM530BUQcRAPYO+KrHV9pDcifM2j6VPicbWABi5Rk41K3l1eqx1BTK 9vlPV79Kwyf+S7Gjn60GlWiAHntKIRUspnZnOBcKJg== X-Google-Smtp-Source: ABdhPJxQNi5FQCMbhTIZY1DogS2Ny4lCD+0Ic7kNij6RwwSTL/wAv3FKZBJNJ150MFs4NFiNsZf52qF6aTUeZdpMpkM= X-Received: by 2002:a05:6808:a83:: with SMTP id q3mr6706715oij.125.1626980488491; Thu, 22 Jul 2021 12:01:28 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 22 Jul 2021 19:01:27 +0000 MIME-Version: 1.0 In-Reply-To: <1626191647-13901-2-git-send-email-khsieh@codeaurora.org> References: <1626191647-13901-1-git-send-email-khsieh@codeaurora.org> <1626191647-13901-2-git-send-email-khsieh@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 22 Jul 2021 19:01:27 +0000 Message-ID: Subject: Re: [PATCH v2 1/7] drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run To: Kuogee Hsieh , dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, abhinavk@codeaurora.org, bjorn.andersson@linaro.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Kuogee Hsieh (2021-07-13 08:54:01) > DP cable should always connect to DPU during the entire PHY compliance > testing run. Since DP PHY compliance test is executed at irq_hpd event > context, dp_ctrl_off_link_stream() should be used instead of dp_ctrl_off(). > dp_ctrl_off() is used for unplug event which is triggered when DP cable is > dis connected. > > Changes in V2: > -- add fixes statement > > Fixes: f21c8a276c2d ("drm/msm/dp: handle irq_hpd with sink_count = 0 correctly") > > Signed-off-by: Kuogee Hsieh > --- Reviewed-by: Stephen Boyd