From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A946C433F5 for ; Fri, 3 Sep 2021 18:12:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F5A760FDC for ; Fri, 3 Sep 2021 18:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350445AbhICSNc (ORCPT ); Fri, 3 Sep 2021 14:13:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350427AbhICSNc (ORCPT ); Fri, 3 Sep 2021 14:13:32 -0400 Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3ADCC061764 for ; Fri, 3 Sep 2021 11:12:31 -0700 (PDT) Received: by mail-oi1-x232.google.com with SMTP id s20so230981oiw.3 for ; Fri, 03 Sep 2021 11:12:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=EmxGvSFHzwGSo5pc2/hQyVW83mXoB+h7zPtCUkGNIwE=; b=K9bKKR5p2Hj2dhQigCQ/Rvb66nsPCiDyB65R1H+Uc84IFdA9pH+Fj4/myNe5PdhG2x WtYjgGbOGYPlmE3ASrCrurIbw5w9QLknsSyS3BcSfN4BvuLQm0LWnjbq0cQS/hf38Tqe ZK/KbCE1Mq0CMe4+goX2oFt1VZ5xN4pIg580A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=EmxGvSFHzwGSo5pc2/hQyVW83mXoB+h7zPtCUkGNIwE=; b=LIf6JLNF4hXfaFpNpCzqIwhB3BoDpBydGSyV26+fLwazZYcsjOmcnTBq22KEwc0LWf 9z1iZs6RBUNCkoNYMUp1Zw6eOHK1znJ4T3HJ3g7OCAnBisskMgawalze3kzWYj6kemsP LlzVcrCULbIYFykdr+rz1L6g/bWvqb4JJ3e9Kyfb5MoJJn2z9IsHOWXZ7mtH/CBWxD8b GUcgtLtPBaaX2GeUgBUocXFDPn2E8pEPdjOI7TSQSBZoXkhLbmf11L3tTQBYeO189mAk ZTTiYryyM7mY3nyS8CskyGlEZ0zJi3em0+KOdWuTtqrD6uGixiafXL57XNCKrIAJAZXJ Ux7w== X-Gm-Message-State: AOAM530jkaXo77UJEjR4/mRREmLKNu6++hcdUrpZGb7YtZiM3ErjG0Gv bzBIH8bm0c37jDMAvsBzNK4Ue8qNnnnzLAYHm84bWQ== X-Google-Smtp-Source: ABdhPJwF6W9Z4C+HCFQkMAT6oKcjVmRCjzrzU0QSEWMUFiOx8lt5Tj7tw21m1kfNNgGcgcNqMTNn1WdwOzXEDm98oh8= X-Received: by 2002:a54:4419:: with SMTP id k25mr125286oiw.32.1630692751276; Fri, 03 Sep 2021 11:12:31 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 3 Sep 2021 14:12:30 -0400 MIME-Version: 1.0 In-Reply-To: <1630574106-3394-3-git-send-email-skakit@codeaurora.org> References: <1630574106-3394-1-git-send-email-skakit@codeaurora.org> <1630574106-3394-3-git-send-email-skakit@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Fri, 3 Sep 2021 14:12:30 -0400 Message-ID: Subject: Re: [PATCH V2 2/2] arm64: dts: sc7280: Add volume up support for sc7280-idp To: Andy Gross , Bjorn Andersson , Linus Walleij , Rob Herring , satya priya Cc: David Collins , kgunda@codeaurora.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting satya priya (2021-09-02 02:15:06) > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 371a2a9..52bcbbc 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -199,6 +199,37 @@ > modem-init; > }; > > +&soc { 's' comes after 'p' so this is in the wrong place. > + gpio_keys { > + compatible = "gpio-keys"; > + label = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&key_vol_up_default>; > + > + vol_up { > + label = "volume_up"; > + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>; > + linux,input-type = <1>; > + linux,code = ; > + gpio-key,wakeup; > + debounce-interval = <15>; > + linux,can-disable; > + }; > + }; > +}; > + > +&pm7325_gpios { > + key_vol_up_default: key_vol_up_default { Please move this to the "PINCTRL - additions to nodes defined in sc7280.dtsi" section and then sort alphabetically on node naem. > + pins = "gpio6"; > + function = "normal"; > + input-enable; > + bias-pull-up; > + power-source = <0>; > + qcom,drive-strength = <3>; > + }; > +}; > + > &pmk8350_vadc { > pmk8350_die_temp { > reg = ;