All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	David Collins <collinsd@codeaurora.org>,
	satya priya <skakit@codeaurora.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: pm8941-pwrkey - fix comma vs semicolon issue
Date: Fri, 23 Jul 2021 20:12:58 +0000	[thread overview]
Message-ID: <CAE-0n52ZFNWLhwis4UT9vWuCyzy=u4QkeeuZdygFFwvLJiq1Eg@mail.gmail.com> (raw)
In-Reply-To: <YPsd74LoRtB9tTKK@google.com>

Quoting Dmitry Torokhov (2021-07-23 12:52:15)
> On Fri, Jul 23, 2021 at 07:43:52PM +0000, Stephen Boyd wrote:
> > Quoting Dmitry Torokhov (2021-07-23 12:39:02)
> > > There is absolutely no reason to use comma operator in this code, 2
> > > separate statements make much more sense.
> > >
> > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > ---
> >
> > Fixes: 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350
> > PON_HLOS PMIC peripheral")
>
> It actually predates this patch and also not really a fix as the
> original code ends up working properly, but looks weird.

Alright.

      reply	other threads:[~2021-07-23 20:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 19:39 [PATCH] Input: pm8941-pwrkey - fix comma vs semicolon issue Dmitry Torokhov
2021-07-23 19:43 ` Stephen Boyd
2021-07-23 19:52   ` Dmitry Torokhov
2021-07-23 20:12     ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAE-0n52ZFNWLhwis4UT9vWuCyzy=u4QkeeuZdygFFwvLJiq1Eg@mail.gmail.com' \
    --to=swboyd@chromium.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=collinsd@codeaurora.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skakit@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.