From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9924C433F5 for ; Sat, 15 Jan 2022 07:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232638AbiAOHuf (ORCPT ); Sat, 15 Jan 2022 02:50:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232629AbiAOHue (ORCPT ); Sat, 15 Jan 2022 02:50:34 -0500 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7BF2C061574 for ; Fri, 14 Jan 2022 23:50:32 -0800 (PST) Received: by mail-oi1-x233.google.com with SMTP id r138so15598218oie.3 for ; Fri, 14 Jan 2022 23:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=h3PgS0CNglNFEriFcIB5fPEGJsKvjMbV56HeR6dLGrE=; b=EmUyNC5+fyl6EfcWg7V5NP/+/kTDIH/EdOvuowOUADAQekSeyTVMo2Pw+R7MGnNyr3 5F8QHuI+3uuwmjE0hhIplcSf2WL7/QNRQcOV1244KFMSs7KyWUA1l2Wf6ku/ze8CULMO JrK0FD1KD6O13Y02WDkLJ8qPwwJwBY8Rk79Pk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=h3PgS0CNglNFEriFcIB5fPEGJsKvjMbV56HeR6dLGrE=; b=2Uit2x11H7JdcWahYaFQfLX7ZTEI9zl37Bhold6f3iQae3UtumC2oOw/C3x1bk15Hb NFNI2tcCAHxU2bkdcSCe7rCWBoHg3qd039oBucoGqYT59+UCmGOONwpNrD0qREZ0Cg4M 4G2rCCVcOPesx+/dayefx5HubSPwb03AXlDtE0nZYQB5T6kya3c9HHFUBTcORTW6Gg/9 /syGNEJjkghEUi3Zn+6reVdhZNk2qKc8xhLgR8lhNC/8MFGtK/UlOUOsnv7EfZcaENzK wiCGb3oowDDXBvaZr8wdA6ZzAce5h8VK7TADqeMS+5gk3kzvKzRbAWanBXPxqEHm95j5 FhDw== X-Gm-Message-State: AOAM532B7fSxuOvMK8CwlGMB5uQsgO5VXfqC6Bd0NJNPLLYmX2RyTipe n1eud0NSxmU05E4T6mLuLwxMc8VQJOR4mrnx17opRQ== X-Google-Smtp-Source: ABdhPJx02kIfoT6/5m/ATyYIlU8INhZ26iHsr9xTblSQKWo5tlo36oAirP0TSNUr8dUl4s8qhL52VFzPwIS7Yj/lE4c= X-Received: by 2002:aca:a953:: with SMTP id s80mr15972957oie.164.1642233032027; Fri, 14 Jan 2022 23:50:32 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 15 Jan 2022 01:50:31 -0600 MIME-Version: 1.0 In-Reply-To: References: <20220106214556.2461363-1-swboyd@chromium.org> <20220106214556.2461363-26-swboyd@chromium.org> <1a3b368eb891ca55c33265397cffab0b9f128737.camel@mediatek.com> <69a10908622512c60790f97942731a8ab989b727.camel@mediatek.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Sat, 15 Jan 2022 01:50:31 -0600 Message-ID: Subject: Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver To: Yong Wu Cc: Krzysztof Kozlowski , Greg Kroah-Hartman , Douglas Anderson , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Joerg Roedel , Will Deacon , Daniel Vetter , "Rafael J. Wysocki" , Rob Clark , Russell King , Saravana Kannan , linux-mediatek@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Yong Wu (2022-01-14 23:39:52) > On Fri, 2022-01-14 at 15:30 -0600, Stephen Boyd wrote: > > > > This sounds more correct to me. I'm not an expert on runtime PM > > though > > as I always have to read the code to remember how it works. if the > > device isn't ready for runtime PM until the component bind function > > is > > called then runtime PM shouldn't be enabled on the component device. > > Anyway, We should update the SMI driver for this case. I prepare a > patch into this patchset or I send it independently? which way is > better? I can roll it into this patch. It needs to be combined otherwise it breaks the bisectability of the series. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07F04C433FE for ; Sat, 15 Jan 2022 07:50:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 99CED82B24; Sat, 15 Jan 2022 07:50:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eu1rc12u5SMl; Sat, 15 Jan 2022 07:50:35 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 70D3182B1E; Sat, 15 Jan 2022 07:50:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 43F28C0077; Sat, 15 Jan 2022 07:50:35 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id A2B04C002F for ; Sat, 15 Jan 2022 07:50:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 89FC660AA9 for ; Sat, 15 Jan 2022 07:50:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=chromium.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uHzfAMrzvID6 for ; Sat, 15 Jan 2022 07:50:33 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by smtp3.osuosl.org (Postfix) with ESMTPS id F17F360879 for ; Sat, 15 Jan 2022 07:50:32 +0000 (UTC) Received: by mail-oi1-x229.google.com with SMTP id q186so15582752oih.8 for ; Fri, 14 Jan 2022 23:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=h3PgS0CNglNFEriFcIB5fPEGJsKvjMbV56HeR6dLGrE=; b=EmUyNC5+fyl6EfcWg7V5NP/+/kTDIH/EdOvuowOUADAQekSeyTVMo2Pw+R7MGnNyr3 5F8QHuI+3uuwmjE0hhIplcSf2WL7/QNRQcOV1244KFMSs7KyWUA1l2Wf6ku/ze8CULMO JrK0FD1KD6O13Y02WDkLJ8qPwwJwBY8Rk79Pk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=h3PgS0CNglNFEriFcIB5fPEGJsKvjMbV56HeR6dLGrE=; b=64W1f02+T6h5zwSgwCn5XrWPtlQZT/OU1DR8qxTP5+Qs9BP5BsYUp0VvdmzTK/LQch AfcRCfu+qPXduq+S+uhVpw0saBc3Bv+kI2SJPtPZJb/zN0aJbp0EZef4NowoWs3afVlC jFABWPrfQLWwHpM3bxWaL8SkPP+CDU/LL4QQo4N/r30zkLEZrLUbiqkY1+YA/18v+c/G n6x3+dXl0t/bsgehhQubOEOHiQ9BB6TIsj4uNtJGRBS7+I1u1j/vLMcFXuq/n9QmBXEz iYdS9ax61ewyhL8W+8VcLG7gyUzA51B+UDG0crYST7Qqrbv1uf9J/GRKXd2zZ6Pis/qm VcQg== X-Gm-Message-State: AOAM533ald6qQfLKkGQGdpUlyMaO5bqBx1mYPsfHNEUsLe+D7FruUahP fCYfVKeYX82UoIsmcfJPnuuEQ+ppM/UIz5BBbi2EMA== X-Google-Smtp-Source: ABdhPJx02kIfoT6/5m/ATyYIlU8INhZ26iHsr9xTblSQKWo5tlo36oAirP0TSNUr8dUl4s8qhL52VFzPwIS7Yj/lE4c= X-Received: by 2002:aca:a953:: with SMTP id s80mr15972957oie.164.1642233032027; Fri, 14 Jan 2022 23:50:32 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 15 Jan 2022 01:50:31 -0600 MIME-Version: 1.0 In-Reply-To: References: <20220106214556.2461363-1-swboyd@chromium.org> <20220106214556.2461363-26-swboyd@chromium.org> <1a3b368eb891ca55c33265397cffab0b9f128737.camel@mediatek.com> <69a10908622512c60790f97942731a8ab989b727.camel@mediatek.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Sat, 15 Jan 2022 01:50:31 -0600 Message-ID: Subject: Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver To: Yong Wu Cc: youlin.pei@mediatek.com, Saravana Kannan , Will Deacon , Krzysztof Kozlowski , Greg Kroah-Hartman , "Rafael J. Wysocki" , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Russell King , freedreno@lists.freedesktop.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" Quoting Yong Wu (2022-01-14 23:39:52) > On Fri, 2022-01-14 at 15:30 -0600, Stephen Boyd wrote: > > > > This sounds more correct to me. I'm not an expert on runtime PM > > though > > as I always have to read the code to remember how it works. if the > > device isn't ready for runtime PM until the component bind function > > is > > called then runtime PM shouldn't be enabled on the component device. > > Anyway, We should update the SMI driver for this case. I prepare a > patch into this patchset or I send it independently? which way is > better? I can roll it into this patch. It needs to be combined otherwise it breaks the bisectability of the series. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC612C433F5 for ; Sat, 15 Jan 2022 07:50:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FXcsMT94ppDfa2fTHIzzKbUbZglj6K1or9wlMnW5LJY=; b=OKvZKvtCOlEzEA QZLgXHb65nLv19bjJOn0cJogNkosm49hi2/x9COtohQ0Mv5fzK+Z6qV2igE0KKz+Zon165PLMVbzX 8A6BSlrK7oMc2EWuxk/97qxEBi5A3d+MOfUHQS/y6KmdszapunCg+juEnOuK6LOT7HUkmzB9gypOO 2i7oI6freaAk3Ep8Ef2FcWQvrCjRZ7EQ+z2eElRESr5XOtzxR8o6NVMwU6GTjKxFNGUQ0oMeVxCWQ k7WESrzfLofQogVdwhK8UYOHb0OTMUUwdzQ3gH0wIHWCRgjNe7KfzNCKHgLzcaTeoLyzKpkz5pkP1 qSgRXfkO1AjQGFWm1LRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8dpc-00AmgI-Vm; Sat, 15 Jan 2022 07:50:36 +0000 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8dpa-00AmfG-1R for linux-mediatek@lists.infradead.org; Sat, 15 Jan 2022 07:50:35 +0000 Received: by mail-oi1-x22d.google.com with SMTP id s127so15615401oig.2 for ; Fri, 14 Jan 2022 23:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=h3PgS0CNglNFEriFcIB5fPEGJsKvjMbV56HeR6dLGrE=; b=EmUyNC5+fyl6EfcWg7V5NP/+/kTDIH/EdOvuowOUADAQekSeyTVMo2Pw+R7MGnNyr3 5F8QHuI+3uuwmjE0hhIplcSf2WL7/QNRQcOV1244KFMSs7KyWUA1l2Wf6ku/ze8CULMO JrK0FD1KD6O13Y02WDkLJ8qPwwJwBY8Rk79Pk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=h3PgS0CNglNFEriFcIB5fPEGJsKvjMbV56HeR6dLGrE=; b=LIJ4WvufuBQAxR7tulMHAOblQcu/+kP34CKLaWDIVp5H5/Wel1UV0HE14QnPI7IN6k 3wwdfeKDsoceWXxgDSN5a5jwCFETlc9dztBAYMf+QHQxmZHri2nHUXeLsOVVTzQhH7Jc enWvxildcZSUoU2ya2xSxEXZKI2aRU7e+BGmD+yN6jlfJIRKRmRIZmfXYfL0JLHs/3gp G7ZUq/XnqQR2CIOUadNlUMurkr15oUN2sDtnfn5JxKP19dfeOnpOoJI2WNbpyIqv3v9P rnI/ojB0HUIBY5U3Ib9WCVf0PKBZekCqBJtFXHv4rJlFySOrVdr5Mh5SBzOaydHD79Qf DrPQ== X-Gm-Message-State: AOAM533jU3M21bDw88aAjxN66VSY/GIUQkbCV6YQnEeJ6Zl7KNrHKvu0 8dyvNJ/ZNIueIMuYRxevS3H0csH5bz3BYKEq9BVoBw== X-Google-Smtp-Source: ABdhPJx02kIfoT6/5m/ATyYIlU8INhZ26iHsr9xTblSQKWo5tlo36oAirP0TSNUr8dUl4s8qhL52VFzPwIS7Yj/lE4c= X-Received: by 2002:aca:a953:: with SMTP id s80mr15972957oie.164.1642233032027; Fri, 14 Jan 2022 23:50:32 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 15 Jan 2022 01:50:31 -0600 MIME-Version: 1.0 In-Reply-To: References: <20220106214556.2461363-1-swboyd@chromium.org> <20220106214556.2461363-26-swboyd@chromium.org> <1a3b368eb891ca55c33265397cffab0b9f128737.camel@mediatek.com> <69a10908622512c60790f97942731a8ab989b727.camel@mediatek.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Sat, 15 Jan 2022 01:50:31 -0600 Message-ID: Subject: Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver To: Yong Wu Cc: Krzysztof Kozlowski , Greg Kroah-Hartman , Douglas Anderson , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Joerg Roedel , Will Deacon , Daniel Vetter , "Rafael J. Wysocki" , Rob Clark , Russell King , Saravana Kannan , linux-mediatek@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220114_235034_128016_1B79F082 X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Quoting Yong Wu (2022-01-14 23:39:52) > On Fri, 2022-01-14 at 15:30 -0600, Stephen Boyd wrote: > > > > This sounds more correct to me. I'm not an expert on runtime PM > > though > > as I always have to read the code to remember how it works. if the > > device isn't ready for runtime PM until the component bind function > > is > > called then runtime PM shouldn't be enabled on the component device. > > Anyway, We should update the SMI driver for this case. I prepare a > patch into this patchset or I send it independently? which way is > better? I can roll it into this patch. It needs to be combined otherwise it breaks the bisectability of the series. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D971DC433EF for ; Sat, 15 Jan 2022 07:50:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A650E10EAFA; Sat, 15 Jan 2022 07:50:33 +0000 (UTC) Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC8AF10EAFA for ; Sat, 15 Jan 2022 07:50:32 +0000 (UTC) Received: by mail-oi1-x22a.google.com with SMTP id w188so15522506oiw.13 for ; Fri, 14 Jan 2022 23:50:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=h3PgS0CNglNFEriFcIB5fPEGJsKvjMbV56HeR6dLGrE=; b=EmUyNC5+fyl6EfcWg7V5NP/+/kTDIH/EdOvuowOUADAQekSeyTVMo2Pw+R7MGnNyr3 5F8QHuI+3uuwmjE0hhIplcSf2WL7/QNRQcOV1244KFMSs7KyWUA1l2Wf6ku/ze8CULMO JrK0FD1KD6O13Y02WDkLJ8qPwwJwBY8Rk79Pk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=h3PgS0CNglNFEriFcIB5fPEGJsKvjMbV56HeR6dLGrE=; b=xfxeo/bL6A6V7KNOG1rUqA9a3P6JKCVpxEPTjcxRBnV2kq3CWY045T6+ICA+93d7ky zeTe20A5b9awgveWnhnmFs3Pi7Y5QJ92THMbraKcLjTu22AHiV3/4yVBX9eN/c9Z4fab cSd1vCzM8WSlxmME/B73cTefWLkLuhALG0u+A+QAZ2Kz/hVfWooj1M2fHp0gRz13fXzI 8BQxhiBHfe8gjeTRTq2Ja0iy70XMw+pX4cPqvqOBKoxNmSnzeEKBnVhTRa99Vfr20DIk lU4LQNbslJw1/SyiEy4YZf9lfABcKweYtnGWLkqYxBCjLxtbQRDI3OmBC2M6VCIe+Bod UrDQ== X-Gm-Message-State: AOAM530+FYW1Igs0ESCZn1cu6vS14k8Q2jwnquu5smF5ydK7No6x4Sdd anlajJEPBS85H/0WYccrxHEW8XMrIlYeFsC/Esxjug== X-Google-Smtp-Source: ABdhPJx02kIfoT6/5m/ATyYIlU8INhZ26iHsr9xTblSQKWo5tlo36oAirP0TSNUr8dUl4s8qhL52VFzPwIS7Yj/lE4c= X-Received: by 2002:aca:a953:: with SMTP id s80mr15972957oie.164.1642233032027; Fri, 14 Jan 2022 23:50:32 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 15 Jan 2022 01:50:31 -0600 MIME-Version: 1.0 In-Reply-To: References: <20220106214556.2461363-1-swboyd@chromium.org> <20220106214556.2461363-26-swboyd@chromium.org> <1a3b368eb891ca55c33265397cffab0b9f128737.camel@mediatek.com> <69a10908622512c60790f97942731a8ab989b727.camel@mediatek.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Sat, 15 Jan 2022 01:50:31 -0600 Message-ID: Subject: Re: [PATCH v5 25/32] iommu/mtk: Migrate to aggregate driver To: Yong Wu Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, Saravana Kannan , Will Deacon , Krzysztof Kozlowski , Greg Kroah-Hartman , Joerg Roedel , "Rafael J. Wysocki" , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Vetter , iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Russell King , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Yong Wu (2022-01-14 23:39:52) > On Fri, 2022-01-14 at 15:30 -0600, Stephen Boyd wrote: > > > > This sounds more correct to me. I'm not an expert on runtime PM > > though > > as I always have to read the code to remember how it works. if the > > device isn't ready for runtime PM until the component bind function > > is > > called then runtime PM shouldn't be enabled on the component device. > > Anyway, We should update the SMI driver for this case. I prepare a > patch into this patchset or I send it independently? which way is > better? I can roll it into this patch. It needs to be combined otherwise it breaks the bisectability of the series.