From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8017EC433EF for ; Thu, 19 May 2022 22:49:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244469AbiESWs7 (ORCPT ); Thu, 19 May 2022 18:48:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244074AbiESWs5 (ORCPT ); Thu, 19 May 2022 18:48:57 -0400 Received: from mail-oa1-x2e.google.com (mail-oa1-x2e.google.com [IPv6:2001:4860:4864:20::2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAA3D92D08 for ; Thu, 19 May 2022 15:48:56 -0700 (PDT) Received: by mail-oa1-x2e.google.com with SMTP id 586e51a60fabf-edf3b6b0f2so8467576fac.9 for ; Thu, 19 May 2022 15:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=gPmJM59HilOSZAiNocBUyn1VGxu9PFrDrw8E4Yeqrfk=; b=Ivbz2PDWtVwyLf0aE9K3mPrsVLOK80ClXfeDGxNsqdlxmI6lf/HqV7VfS+K1pFR238 KfAvg7i6sxEPBmB782C8Q6xIoiiz4VrGwKI6qxj4FpHIfeHM7VsU0oaEHwdpWxktouqK 31WAtWkdHxSG3SjDgz+OusBnk+tjWjtiPafIw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=gPmJM59HilOSZAiNocBUyn1VGxu9PFrDrw8E4Yeqrfk=; b=OW8FdEyNF1HN2uhcIG5w3oeG07ioa1g7OBxdTBzx6vmU+ayqNRPMG02QySauuGS7L9 ULH0bwQG+lCQ4nLI3tPIWzXSzem0+EnG7Pjh4N+ve06IUkP6XHbGwlYD09cIZd24otZw zsJl2mxyshn3haM3JzRL7dAo9jsU5/p7laVKDDIVYT9PYzCdF6f5UGVb42aRHzTDzOkx SCJxobszsSL2z8xibYSUkRi/07k8+dQraYpTA2uzdsqJyZOcffAko64VKxhUIVecWiQM jx/X3Us1mBfFW7npvUve+PQ3vRaKZKVpNqvLdJSbKZybvMhboPTmSDxWu+NZEr9v+a6q tquQ== X-Gm-Message-State: AOAM533kyrSFAdc1/Nijnm8ZagaGntEYbqRxPch9T4+XSK7XPcCjuBw+ PlPZgOSja9IpoZ+XK4Uw8zt3CpVNSPQea0AqkmeK1A== X-Google-Smtp-Source: ABdhPJw5ddHxY0cfryu3hgg4S9UcGUCH59iSaeUGGcNe4rzoKsPmMGWR455MyyYyru3KXBJ68SY9LKIemGUmA3oUAE4= X-Received: by 2002:a05:6870:240d:b0:f1:b878:e97c with SMTP id n13-20020a056870240d00b000f1b878e97cmr3801393oap.193.1653000536016; Thu, 19 May 2022 15:48:56 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 19 May 2022 15:48:55 -0700 MIME-Version: 1.0 In-Reply-To: <1652982339-18190-3-git-send-email-quic_khsieh@quicinc.com> References: <1652982339-18190-1-git-send-email-quic_khsieh@quicinc.com> <1652982339-18190-3-git-send-email-quic_khsieh@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Thu, 19 May 2022 15:48:55 -0700 Message-ID: Subject: Re: [PATCH v5 2/3] phy: qcom-qmp: add regulator_set_load to dp phy To: Kuogee Hsieh , agross@kernel.org, airlied@linux.ie, bjorn.andersson@linaro.org, daniel@ffwll.ch, dianders@chromium.org, dmitry.baryshkov@linaro.org, dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org Cc: quic_abhinavk@quicinc.com, quic_aravindh@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Kuogee Hsieh (2022-05-19 10:45:38) > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > index b144ae1..24f39ee 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -5008,6 +5019,11 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy) > return 0; > } > > + if (cfg->vreg_enable_load) { > + for (i = 0; i <= cfg->num_vregs; i++) Just less than (<) cfg->num_vregs, not less than or equal to (<=) > + regulator_set_load(qmp->vregs[i].consumer, cfg->vreg_enable_load[i]); > + } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EF65C433F5 for ; Thu, 19 May 2022 22:48:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E281710F289; Thu, 19 May 2022 22:48:57 +0000 (UTC) Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by gabe.freedesktop.org (Postfix) with ESMTPS id D357B11A4FA for ; Thu, 19 May 2022 22:48:56 +0000 (UTC) Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-e5e433d66dso8493331fac.5 for ; Thu, 19 May 2022 15:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=gPmJM59HilOSZAiNocBUyn1VGxu9PFrDrw8E4Yeqrfk=; b=Ivbz2PDWtVwyLf0aE9K3mPrsVLOK80ClXfeDGxNsqdlxmI6lf/HqV7VfS+K1pFR238 KfAvg7i6sxEPBmB782C8Q6xIoiiz4VrGwKI6qxj4FpHIfeHM7VsU0oaEHwdpWxktouqK 31WAtWkdHxSG3SjDgz+OusBnk+tjWjtiPafIw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=gPmJM59HilOSZAiNocBUyn1VGxu9PFrDrw8E4Yeqrfk=; b=lFVkUJB1qTeYUvuMooCXm3FFEubCYgHn4xeYIm+2Y2i37l3G/iYT+X+3H+nOMDGdeX 0yaCP8O1vysRo5XzBT2nQuv1se4Qqf1g87eloPdr4mvKZOILN64a/Is5/7Spba53Oe2l fXAZe16f8Al8qh/tPlZXnq25GtTjgJdJLKm73G6domq1jx+PUs6JG4NMvisMwH6VFV9O T4/NMk+CxxKmutWjTX0Jnj/kgCNIKzk2Wi6XmVZtGE7hzNsog+aPcdv7z0JthMR9tLm9 4Okut16yZ9ST2Tkv5G1e03nbO3z+fAtVz/VRSqgbsvBJLI7pQMCpwvGUnuiOk3rdJ4js EVLQ== X-Gm-Message-State: AOAM530X4IlrSlNMSnnooEl5nyvJnfX4HiHqzB4g4IRU+CWu42qMuYwd w4bxUx4wuUFpEGYxClnz2zw9XkI27Pe2aZZvsdl7LQ== X-Google-Smtp-Source: ABdhPJw5ddHxY0cfryu3hgg4S9UcGUCH59iSaeUGGcNe4rzoKsPmMGWR455MyyYyru3KXBJ68SY9LKIemGUmA3oUAE4= X-Received: by 2002:a05:6870:240d:b0:f1:b878:e97c with SMTP id n13-20020a056870240d00b000f1b878e97cmr3801393oap.193.1653000536016; Thu, 19 May 2022 15:48:56 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 19 May 2022 15:48:55 -0700 MIME-Version: 1.0 In-Reply-To: <1652982339-18190-3-git-send-email-quic_khsieh@quicinc.com> References: <1652982339-18190-1-git-send-email-quic_khsieh@quicinc.com> <1652982339-18190-3-git-send-email-quic_khsieh@quicinc.com> From: Stephen Boyd User-Agent: alot/0.10 Date: Thu, 19 May 2022 15:48:55 -0700 Message-ID: Subject: Re: [PATCH v5 2/3] phy: qcom-qmp: add regulator_set_load to dp phy To: Kuogee Hsieh , agross@kernel.org, airlied@linux.ie, bjorn.andersson@linaro.org, daniel@ffwll.ch, dianders@chromium.org, dmitry.baryshkov@linaro.org, dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_sbillaka@quicinc.com, linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com, linux-kernel@vger.kernel.org, quic_aravindh@quicinc.com, freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Kuogee Hsieh (2022-05-19 10:45:38) > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > index b144ae1..24f39ee 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -5008,6 +5019,11 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy) > return 0; > } > > + if (cfg->vreg_enable_load) { > + for (i = 0; i <= cfg->num_vregs; i++) Just less than (<) cfg->num_vregs, not less than or equal to (<=) > + regulator_set_load(qmp->vregs[i].consumer, cfg->vreg_enable_load[i]); > + } >