From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD4EDC432BE for ; Thu, 22 Jul 2021 20:07:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A437C60EB8 for ; Thu, 22 Jul 2021 20:07:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230358AbhGVT00 (ORCPT ); Thu, 22 Jul 2021 15:26:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229649AbhGVT0Z (ORCPT ); Thu, 22 Jul 2021 15:26:25 -0400 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C4D0C061575 for ; Thu, 22 Jul 2021 13:07:00 -0700 (PDT) Received: by mail-ot1-x329.google.com with SMTP id j1-20020a0568302701b02904d1f8b9db81so6408367otu.12 for ; Thu, 22 Jul 2021 13:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=O8dDgSeZjlhPao9QRuOYxkfISrHgO2l6PhjYbW5g3pw=; b=X2bvxtNR79OkmCWe08P/hN6fnPvQe9zDyBpX7Jxdc1kokI00XqWy/PrsXfH00R/5Ao zIw0o3tfvhRxvR6mGy/yo6dPMohc9RnVqfU8OowzBL4AynRk9iY261MysIDm+juXfIBS AkPkXyg7xi6gdmy/bIpZpo5OcSzAyalfJlubI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=O8dDgSeZjlhPao9QRuOYxkfISrHgO2l6PhjYbW5g3pw=; b=V6QlJAfhiIPeL8PedK2k4JiSdyUm7p2UTOY6ueaJt+A3w+PV3L6PW9h0l58DH4iyJ8 Fd3nsTjWsyim4Mrd13m3/TlnQgFf+pE/G2is/dAtVtaf2SXKH04MnfGYN0AblDPNdr/I DAwccGCqkSO8rhau+xNIJY4zh6RxR1BDNOZeweDhqfux6msvvvlPXDQlVeCWgSUtKS8X 8HJF1WXN6ywTK84s9bnFKM0DshLn29kk4k2JGAHtnzSZygnq3BnRNqDl/vp7rXyPjI6V yjtV7CwkxYz4JSxpjH7MrzxR4/aEdDuqQvvRnF9M2UeAYH39ZMLQPIwEjMQuwnG7Gq6T DLQg== X-Gm-Message-State: AOAM5303eu60CdFgMsCVu1ph2227xkn21gxp2mJai8SDxtOBbRUcA6zm xr4Op0bIO1IdHobdwvilVficXOesKEdR6Jt1bSsZGg== X-Google-Smtp-Source: ABdhPJwldBK47Or1p1ivwfzx0ETv9cQ7IC2/MrivbSo7ScqHLOOcpcP56sV3AD4XttYcPbUS++a1HNWU0OWyQn9YNNI= X-Received: by 2002:a9d:8c7:: with SMTP id 65mr978424otf.25.1626984419283; Thu, 22 Jul 2021 13:06:59 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 22 Jul 2021 20:06:58 +0000 MIME-Version: 1.0 In-Reply-To: <20210722024227.3313096-3-bjorn.andersson@linaro.org> References: <20210722024227.3313096-1-bjorn.andersson@linaro.org> <20210722024227.3313096-3-bjorn.andersson@linaro.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 22 Jul 2021 20:06:58 +0000 Message-ID: Subject: Re: [PATCH 2/5] drm/msm/dp: Use devres for ioremap() To: Abhinav Kumar , Bjorn Andersson , Daniel Vetter , David Airlie , Rob Clark , Rob Herring , Sean Paul Cc: Kuogee Hsieh , Tanmay Shah , Chandan Uddaraju , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Bjorn Andersson (2021-07-21 19:42:24) > The non-devres version of ioremap is used, which requires manual > cleanup. But the code paths leading here is mixed with other devres > users, so rely on this for ioremap as well to simplify the code. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd > drivers/gpu/drm/msm/dp/dp_parser.c | 29 ++++------------------------- > 1 file changed, 4 insertions(+), 25 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c b/drivers/gpu/drm/msm/dp/dp_parser.c > index 0519dd3ac3c3..c064ced78278 100644 > --- a/drivers/gpu/drm/msm/dp/dp_parser.c > +++ b/drivers/gpu/drm/msm/dp/dp_parser.c > @@ -32,7 +32,7 @@ static int msm_dss_ioremap(struct platform_device *pdev, > } > > io_data->len = (u32)resource_size(res); > - io_data->base = ioremap(res->start, io_data->len); > + io_data->base = devm_ioremap(&pdev->dev, res->start, io_data->len); > if (!io_data->base) { > DRM_ERROR("%pS->%s: ioremap failed\n", > __builtin_return_address(0), __func__); I don't think we need this print either, but that can come later in addition to using devm_platform_get_and_ioremap_resource(). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC312C43214 for ; Thu, 22 Jul 2021 20:07:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77EA360EB2 for ; Thu, 22 Jul 2021 20:07:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 77EA360EB2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8DC46EE32; Thu, 22 Jul 2021 20:07:01 +0000 (UTC) Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6057C6EE4F for ; Thu, 22 Jul 2021 20:07:00 +0000 (UTC) Received: by mail-ot1-x329.google.com with SMTP id b24-20020a9d60d80000b02904d14e47202cso6464250otk.4 for ; Thu, 22 Jul 2021 13:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=O8dDgSeZjlhPao9QRuOYxkfISrHgO2l6PhjYbW5g3pw=; b=X2bvxtNR79OkmCWe08P/hN6fnPvQe9zDyBpX7Jxdc1kokI00XqWy/PrsXfH00R/5Ao zIw0o3tfvhRxvR6mGy/yo6dPMohc9RnVqfU8OowzBL4AynRk9iY261MysIDm+juXfIBS AkPkXyg7xi6gdmy/bIpZpo5OcSzAyalfJlubI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=O8dDgSeZjlhPao9QRuOYxkfISrHgO2l6PhjYbW5g3pw=; b=tXRU2+8wN1LgCSeccz/JXXD6NRCKIMtIcjt8bQZoQc/k5EuIUHFL0yQaftsLjtY4Xs EfAlDJKDzwVjj0qrVsOwFHIrZSlQL8atu2c79o6ibrvcaFkbx7nEVtYCpptAriEk8m9k Zt/5t83l8x4o3HKa9oCVX/fNEMoYoLG9+LeIaH96MpFbQqqYkd7iUlTEhnMBXqKLlU/v BWyLuRtS6tAuw26RpxZO0P0GYXtfEA4PcTa7t/R30yBWhMbcJr8ZLFPfR7az4QsZyMr5 7PVYLtZYuqoCg2WF3DPFLtRgRn4nhjocuLM2xGCaU3lA4uedxXCaDNhMpwlYjtaNlhsz bv0A== X-Gm-Message-State: AOAM531kBILnS1zJ28xFIqzP9EHsdYeTgmljD/JcFbOlwMy5IcshTNPr jL+MhiybZOzYJphJwMsP27ET2hlNjqDdjy2hSplUyA== X-Google-Smtp-Source: ABdhPJwldBK47Or1p1ivwfzx0ETv9cQ7IC2/MrivbSo7ScqHLOOcpcP56sV3AD4XttYcPbUS++a1HNWU0OWyQn9YNNI= X-Received: by 2002:a9d:8c7:: with SMTP id 65mr978424otf.25.1626984419283; Thu, 22 Jul 2021 13:06:59 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 22 Jul 2021 20:06:58 +0000 MIME-Version: 1.0 In-Reply-To: <20210722024227.3313096-3-bjorn.andersson@linaro.org> References: <20210722024227.3313096-1-bjorn.andersson@linaro.org> <20210722024227.3313096-3-bjorn.andersson@linaro.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 22 Jul 2021 20:06:58 +0000 Message-ID: Subject: Re: [PATCH 2/5] drm/msm/dp: Use devres for ioremap() To: Abhinav Kumar , Bjorn Andersson , Daniel Vetter , David Airlie , Rob Clark , Rob Herring , Sean Paul Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kuogee Hsieh , Tanmay Shah , freedreno@lists.freedesktop.org, Chandan Uddaraju Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Bjorn Andersson (2021-07-21 19:42:24) > The non-devres version of ioremap is used, which requires manual > cleanup. But the code paths leading here is mixed with other devres > users, so rely on this for ioremap as well to simplify the code. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd > drivers/gpu/drm/msm/dp/dp_parser.c | 29 ++++------------------------- > 1 file changed, 4 insertions(+), 25 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c b/drivers/gpu/drm/msm/dp/dp_parser.c > index 0519dd3ac3c3..c064ced78278 100644 > --- a/drivers/gpu/drm/msm/dp/dp_parser.c > +++ b/drivers/gpu/drm/msm/dp/dp_parser.c > @@ -32,7 +32,7 @@ static int msm_dss_ioremap(struct platform_device *pdev, > } > > io_data->len = (u32)resource_size(res); > - io_data->base = ioremap(res->start, io_data->len); > + io_data->base = devm_ioremap(&pdev->dev, res->start, io_data->len); > if (!io_data->base) { > DRM_ERROR("%pS->%s: ioremap failed\n", > __builtin_return_address(0), __func__); I don't think we need this print either, but that can come later in addition to using devm_platform_get_and_ioremap_resource().