From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v3 01/10] drivers: qcom: rpmh-rsc: add RPMH controller for QCOM SoCs Date: Fri, 9 Mar 2018 13:37:12 -0800 Message-ID: References: <20180302164317.10554-1-ilina@codeaurora.org> <20180302164317.10554-2-ilina@codeaurora.org> <152036550693.218381.11708415467260101936@swboyd.mtv.corp.google.com> <20180309213327.GA2806@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180309213327.GA2806@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Lina Iyer Cc: Andy Gross , David Brown , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, rnayak@codeaurora.org, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Fri, Mar 9, 2018 at 1:33 PM, Lina Iyer wrote: > Hi Stephen, > > I will address all the comments in the next spin of the patch. Here are > some responses to the questions. > > On Tue, Mar 06 2018 at 12:45 -0700, Stephen Boyd wrote: >> >> Quoting Lina Iyer (2018-03-02 08:43:08) > > [...] >> >> +#include >> >> If the driver doesn't become tristate, this should become export.h >> instead of module.h >> > MODULE_DEVICE_TABLE seems to need this. > If you don't have tristate then MODULE_DEVICE_TABLE isn't needed.