From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6867BC433F5 for ; Wed, 6 Apr 2022 04:01:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A87210ECE3; Wed, 6 Apr 2022 04:01:10 +0000 (UTC) Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC13010ECE3 for ; Wed, 6 Apr 2022 04:01:09 +0000 (UTC) Received: by mail-oi1-x229.google.com with SMTP id e189so1212670oia.8 for ; Tue, 05 Apr 2022 21:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=WGUazAz+54LKBDcmDz/G18fzJNOk0DJxlOhHCUXankQ=; b=hfUYXYOTYj6R1wH7vLfFU1M78Xe+pSbNhFcloVsqgMLI7XFRyw+zsprecqCimVMnGH +svkrY3vzWiM7LGZC8KNfRKElz2Ta1vlGMevx8Z31we8M0Ju8aO06Rjv0M6R/k5JSc96 GcWyG+SrXJ9ikL+KNKJZ5ZUKpgammAd+qqRZk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=WGUazAz+54LKBDcmDz/G18fzJNOk0DJxlOhHCUXankQ=; b=DE35UTpzEaWrDq387jr91VbbOdsHty7LqkHZDC7cw5R6snzgWSUoPlPORUgmKl87ZH ph+IF8w/VAc3sO7zzlpAc1WmkiiIhWlrdD271fZeg88IBii9Qj/Clt1nilhU4O4Wo1Ze pxMF979P2RnvPU/Q+OKAIjmvuXvzFsPBznQMKIUsJSvhywH0jLx4Rq0Xgu3rsRVnEGzo kFnDfGNqXGWMxCnSWqhkoC53DkXImdZGchjr/olelxdpDddiGhBkKYkS9xv485XORoxR YKzP6XpoLhtANh0SFlPQlW0cohtFr/05dg27Lo5Rtp9TFoOzxxkBGGRxzHL6DCehQn1T JI7Q== X-Gm-Message-State: AOAM533Se27liI7PT4UHwJUREe4HyTt7dIvupeCXkcURAgFkz8uS9EUD 6JjBl2bKESOh/NRMFoUO/Cz27KFkmYMCfbrU/4hGBQ== X-Google-Smtp-Source: ABdhPJxWPA9p5d7NmUiUlh/dFDZl8efg+pQvD/HgLU5K/+3BeTFisXtsgjxxnhu+VH+3biB4raAHw2pEX8Qj/I6wP9A= X-Received: by 2002:aca:a9c8:0:b0:2da:45b6:b796 with SMTP id s191-20020acaa9c8000000b002da45b6b796mr2652702oie.193.1649217669012; Tue, 05 Apr 2022 21:01:09 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Apr 2022 21:01:08 -0700 MIME-Version: 1.0 In-Reply-To: <20220405235059.359738-2-dmitry.baryshkov@linaro.org> References: <20220405235059.359738-1-dmitry.baryshkov@linaro.org> <20220405235059.359738-2-dmitry.baryshkov@linaro.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Tue, 5 Apr 2022 21:01:08 -0700 Message-ID: Subject: Re: [PATCH 1/3] drm/msm/dpu: remove manual destruction of DRM objects To: Abhinav Kumar , Bjorn Andersson , Dmitry Baryshkov , Rob Clark , Sean Paul Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Dmitry Baryshkov (2022-04-05 16:50:57) > Remove manual removal of DRM modesetting objects, it is done anyway by > the drm_mode_config_cleanup() called from msm_drm_uninit(). Other > MSM display drivers (MDP4, MDP5) do not manually destroy objects and > trust generic code to do it's work. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63CD4C433FE for ; Wed, 6 Apr 2022 10:18:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243735AbiDFKU0 (ORCPT ); Wed, 6 Apr 2022 06:20:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378004AbiDFKSy (ORCPT ); Wed, 6 Apr 2022 06:18:54 -0400 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AC10223BF9 for ; Tue, 5 Apr 2022 21:01:09 -0700 (PDT) Received: by mail-oi1-x22a.google.com with SMTP id q189so1207001oia.9 for ; Tue, 05 Apr 2022 21:01:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=WGUazAz+54LKBDcmDz/G18fzJNOk0DJxlOhHCUXankQ=; b=hfUYXYOTYj6R1wH7vLfFU1M78Xe+pSbNhFcloVsqgMLI7XFRyw+zsprecqCimVMnGH +svkrY3vzWiM7LGZC8KNfRKElz2Ta1vlGMevx8Z31we8M0Ju8aO06Rjv0M6R/k5JSc96 GcWyG+SrXJ9ikL+KNKJZ5ZUKpgammAd+qqRZk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=WGUazAz+54LKBDcmDz/G18fzJNOk0DJxlOhHCUXankQ=; b=R+oKcytJSpfNsEKtLeOJtOz3nhBK82/JW43FXhvAzUErcoMeFq+pQHDpLbevQMHAss yX3PkGcPy+hLMg9okN7mSYGyYQ3TWzEyufFtZBHv/SStCQ2ODWGF1RLgmlsLe5iAi0f+ cA309FXPumRzIVyy2My4vU5tZHJYsH78UzXglHDBy+AEkzT5Kg/RKKXpNx/Datwbze/m E6IvUe/1M4gBN4W937w+9P6VX+N4zqyM87dvvlbop169Pmx/nIx/uFi1P0WzK61NOuwA K9tOfo47N5x4iOPJbfH2xmmgatCr8jMQanuKa3g6Hqeh7jl07RrcmPuqKJf6nAkgsMd2 kEeA== X-Gm-Message-State: AOAM533FX1LTfphigwnBXHXTvEroG4yxydbiNP9MCNpgxnkpwceDyv0g dz8TxsMt0VDba2/hkjVZkSp7doFlLPj0LnRm2GCQSw== X-Google-Smtp-Source: ABdhPJxWPA9p5d7NmUiUlh/dFDZl8efg+pQvD/HgLU5K/+3BeTFisXtsgjxxnhu+VH+3biB4raAHw2pEX8Qj/I6wP9A= X-Received: by 2002:aca:a9c8:0:b0:2da:45b6:b796 with SMTP id s191-20020acaa9c8000000b002da45b6b796mr2652702oie.193.1649217669012; Tue, 05 Apr 2022 21:01:09 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 5 Apr 2022 21:01:08 -0700 MIME-Version: 1.0 In-Reply-To: <20220405235059.359738-2-dmitry.baryshkov@linaro.org> References: <20220405235059.359738-1-dmitry.baryshkov@linaro.org> <20220405235059.359738-2-dmitry.baryshkov@linaro.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Tue, 5 Apr 2022 21:01:08 -0700 Message-ID: Subject: Re: [PATCH 1/3] drm/msm/dpu: remove manual destruction of DRM objects To: Abhinav Kumar , Bjorn Andersson , Dmitry Baryshkov , Rob Clark , Sean Paul Cc: David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Dmitry Baryshkov (2022-04-05 16:50:57) > Remove manual removal of DRM modesetting objects, it is done anyway by > the drm_mode_config_cleanup() called from msm_drm_uninit(). Other > MSM display drivers (MDP4, MDP5) do not manually destroy objects and > trust generic code to do it's work. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd