From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C30C47088 for ; Wed, 26 May 2021 20:26:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7363E61003 for ; Wed, 26 May 2021 20:26:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233459AbhEZU2U (ORCPT ); Wed, 26 May 2021 16:28:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229500AbhEZU2T (ORCPT ); Wed, 26 May 2021 16:28:19 -0400 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3286C061574 for ; Wed, 26 May 2021 13:26:47 -0700 (PDT) Received: by mail-oi1-x22f.google.com with SMTP id s19so2797926oic.7 for ; Wed, 26 May 2021 13:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=l48jC3erVA2+3dsNyPrwjVQi4loUlksxzkUCOK7XbBY=; b=KkO4x62ipqLrd1vB/3ZYMOoeF6E0oF8Toceds26PSo6RX0C4IJxsuSHLQtScA5IUve xxSogbqN2ttnf503Xc5rqVGuGPwYC3l3mdyAYFaFHzhnNIugTpleG4bgQP9FVupa+gG3 4nQahMZ4ccd9OEegpeReNeb3M2nCo32/bYG4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=l48jC3erVA2+3dsNyPrwjVQi4loUlksxzkUCOK7XbBY=; b=uHSE2uUiwhH5hRVmugOIrdTcA96AoeQJqGrGDTGgej2ulNsSY6xaye0D2CvfoTO+nL 95CWOA6wPg02Byag49g4WCOapyfYVpW7024WUa7rjFBh27xlACj5r9cB+zxtTTNLWZha T99D3zpHijf6Rkf+xmsLWAck4ZFOyNPKy4jyhgEeFCc9SUwopJafOVLsrAie1xR7P35N 0xOqky3D09lrIhzF0/s94N0kA1XWvbGk10GsY6LpW/1MR4yM5J2IVVTEQjHyBw4Hu3va oXN4NRETYSdedF5vZUbkKi0ybTLOmfVKNYqXPeRxAlSV4TKWQH2fWFjPHcmML9WBzWwU 48vQ== X-Gm-Message-State: AOAM531XfByktIArnswV6yZm8FThjz0OdLs0kPIjMyNzTJ+gtB6JCVVw QANvmUtG7n9ocdeo6Un2H+BGrPdXwqA4Qjj3yDIzlQ== X-Google-Smtp-Source: ABdhPJxqrw0FFEVLVjFne4yQD7bjJsI0jl4IHyHVIGIutGLKyBUZOBMKCKTW55HPplbIm8j1D9R31kxOtPaT3/KMfS4= X-Received: by 2002:a05:6808:144e:: with SMTP id x14mr3308962oiv.166.1622060807146; Wed, 26 May 2021 13:26:47 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 26 May 2021 16:26:46 -0400 MIME-Version: 1.0 In-Reply-To: <20210526034500.954219-1-gwendal@chromium.org> References: <20210526034500.954219-1-gwendal@chromium.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Wed, 26 May 2021 16:26:46 -0400 Message-ID: Subject: Re: [PATCH] mfd: cros_ec_dev: Load lightbar module only present To: Gwendal Grignou , bleung@chromium.org, enric.balletbo@collabora.com, groeck@chromium.org, lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Gwendal Grignou (2021-05-25 20:45:00) > The pixel lightbar is only present on chromebook pixel (link), pixel 2 > and pixel C. For the latter two, the EC reports its presence. > Instead of always loading the lightbar driver on all chromebook, only > load it when reported by the EC or Link device. > > Signed-off-by: Gwendal Grignou > --- Tested-by: Stephen Boyd Reviewed-by: Stephen Boyd