From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6C93C433EF for ; Thu, 3 Mar 2022 22:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235029AbiCCW0X (ORCPT ); Thu, 3 Mar 2022 17:26:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236867AbiCCW0X (ORCPT ); Thu, 3 Mar 2022 17:26:23 -0500 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FE2D10DA6F for ; Thu, 3 Mar 2022 14:25:37 -0800 (PST) Received: by mail-ot1-x329.google.com with SMTP id l25-20020a9d7a99000000b005af173a2875so5869110otn.2 for ; Thu, 03 Mar 2022 14:25:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=W6b+sDlQ6fUC15y02viB9CBBs238nvSYgTbrXnSADxI=; b=i2VfhCwlYGuVKKwL2On8iEbyuLJyjQn2RZoPEiUYjw6HvvOnr1qNcHvsCi6NwL3w+Y oau/hrdWaWQwCpLO3mcfsYYwxfC4AXGtI8JB3sTnm8lZsoE7z3uI2oXik9/GeHNZW4GQ KBU77p6PVW4i8EQ+/ue+Mj1ZHXAesYbfQbVW8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=W6b+sDlQ6fUC15y02viB9CBBs238nvSYgTbrXnSADxI=; b=mpRr3WnnPNhoyryAXmYIrXmZgu83KHpETfey5N3R+K1OMZSxECaS2DRWcjjk52bgrd tVEvM1Am6fQBr3Zy7xmiRoQ1gths4ijFdlc8PqK2odpmp9WTIlhmKUpnWqprZXldkRca yUf4wy+euDceON6fCbeXrpXrFWhnTVTEZlsWjTBqq160HgNIITBB2NnWFfoNlgcVg9tZ exWVasU0JqH02Rnmoflvn8LUybecko9fAEjnLZtLOssSlRfyzsGaGJHA6J+YCpLkd3Km EewQkzuMWV7eLRP3h7fd2R+ejbdGzf492A164YX3gt3YhV+N1H4301MQGSyfyhMALrxO IhAA== X-Gm-Message-State: AOAM532Agy08w2SERB+LUnalFpynL/ycRtJQ3Q3n6kQehSuuISSq/J7J wgVfGpdHr7oirfxT+n0I6Y7VfX4UzpEos0CEiPoz8A== X-Google-Smtp-Source: ABdhPJySDSyjRk7hKcrQxOwP82H8qzkkTjbRnV9lItUMyzxYwnq8G8pll8AB/Htj0HsykplhTrDx4gVGSByQP9iDe0k= X-Received: by 2002:a9d:22e9:0:b0:5ac:1754:342c with SMTP id y96-20020a9d22e9000000b005ac1754342cmr20039488ota.159.1646346336645; Thu, 03 Mar 2022 14:25:36 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 3 Mar 2022 14:25:36 -0800 MIME-Version: 1.0 In-Reply-To: <20220217055529.499829-3-dmitry.baryshkov@linaro.org> References: <20220217055529.499829-1-dmitry.baryshkov@linaro.org> <20220217055529.499829-3-dmitry.baryshkov@linaro.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Thu, 3 Mar 2022 14:25:36 -0800 Message-ID: Subject: Re: [PATCH v5 2/5] drm/msm/dp: "inline" dp_ctrl_set_clock_rate("ctrl_link") To: Abhinav Kumar , Bjorn Andersson , Dmitry Baryshkov , Rob Clark , Sean Paul Cc: David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Dmitry Baryshkov (2022-02-16 21:55:26) > "ctrl_link" is the clock from DP_CTRL_PM module. The result of setting > the rate for it would be a call to dev_pm_opp_set_rate(). Instead of > saving the rate inside struct dss_module_power, call the > devm_pm_opp_set_rate() directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8E32C433F5 for ; Thu, 3 Mar 2022 22:25:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DA99010E35D; Thu, 3 Mar 2022 22:25:38 +0000 (UTC) Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id 568D510E35D for ; Thu, 3 Mar 2022 22:25:37 +0000 (UTC) Received: by mail-ot1-x334.google.com with SMTP id p12-20020a05683019cc00b005af1442c9e9so5836312otp.13 for ; Thu, 03 Mar 2022 14:25:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=W6b+sDlQ6fUC15y02viB9CBBs238nvSYgTbrXnSADxI=; b=i2VfhCwlYGuVKKwL2On8iEbyuLJyjQn2RZoPEiUYjw6HvvOnr1qNcHvsCi6NwL3w+Y oau/hrdWaWQwCpLO3mcfsYYwxfC4AXGtI8JB3sTnm8lZsoE7z3uI2oXik9/GeHNZW4GQ KBU77p6PVW4i8EQ+/ue+Mj1ZHXAesYbfQbVW8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=W6b+sDlQ6fUC15y02viB9CBBs238nvSYgTbrXnSADxI=; b=rYiNzcjB5j2h4cr6Q9oX9CgJnDZYjIdbVUBzMlbujQhyP1CHUiYjRUOu7gn82xT20c HIPlk/hMSc+diu5TDExIl38HyTGHmURbP+1Z+5GCCd4eNffNeG4DuomQt80nFqKmL72G kIBAYdCpkxX1LUjiJKR0vsavbNSOIMtLFXMRXSEImQfNzEqPQ2pCGNAFSKnZ/r9G6c7g Sr2JNOQ0H5Ly3Xijf3mG8eEOtqW4+XpGnOvePs6EcOnEcVM9Wf2POrACZm8Zq4KkVZTe q6W1VaEVVm3o7d/b22erd7hSPoh+42iZ25RjEF3sGHrmJtEbEbOuu9dBiWuHMKS9Tqhc 9WyQ== X-Gm-Message-State: AOAM531lvnVv3KTa21gBjiDu7qO9KK1t3GuwMQmvHhaOVFe0JZt4kNwZ cPEdKmpOi/X9UskVuTrs+cCUNOq0KjQUjsyct64P7A== X-Google-Smtp-Source: ABdhPJySDSyjRk7hKcrQxOwP82H8qzkkTjbRnV9lItUMyzxYwnq8G8pll8AB/Htj0HsykplhTrDx4gVGSByQP9iDe0k= X-Received: by 2002:a9d:22e9:0:b0:5ac:1754:342c with SMTP id y96-20020a9d22e9000000b005ac1754342cmr20039488ota.159.1646346336645; Thu, 03 Mar 2022 14:25:36 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 3 Mar 2022 14:25:36 -0800 MIME-Version: 1.0 In-Reply-To: <20220217055529.499829-3-dmitry.baryshkov@linaro.org> References: <20220217055529.499829-1-dmitry.baryshkov@linaro.org> <20220217055529.499829-3-dmitry.baryshkov@linaro.org> From: Stephen Boyd User-Agent: alot/0.10 Date: Thu, 3 Mar 2022 14:25:36 -0800 Message-ID: Subject: Re: [PATCH v5 2/5] drm/msm/dp: "inline" dp_ctrl_set_clock_rate("ctrl_link") To: Abhinav Kumar , Bjorn Andersson , Dmitry Baryshkov , Rob Clark , Sean Paul Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Dmitry Baryshkov (2022-02-16 21:55:26) > "ctrl_link" is the clock from DP_CTRL_PM module. The result of setting > the rate for it would be a call to dev_pm_opp_set_rate(). Instead of > saving the rate inside struct dss_module_power, call the > devm_pm_opp_set_rate() directly. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd