From: Stephen Boyd <swboyd@chromium.org> To: Andy Gross <agross@kernel.org>, Judy Hsiao <judyhsiao@chromium.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Herring <robh+dt@kernel.org>, Srini Kandagatla <srinivas.kandagatla@linaro.org>, dianders@chromium.org, mka@chromium.org, cychiang@google.com, judyhsiao@google.com, tzungbi@chromium.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1 Date: Fri, 20 May 2022 13:38:00 -0700 [thread overview] Message-ID: <CAE-0n53e0bq_MbfgZYdxatP8CpGVMKkBKOnSDOV+MvbBFB6wOA@mail.gmail.com> (raw) In-Reply-To: <20220520161004.1141554-2-judyhsiao@chromium.org> Quoting Judy Hsiao (2022-05-20 09:10:02) > 1. Add drive strength property for mi2s1 on sc7280 based platforms. > 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk. s/Disbale/Disable/ The commit text is a list of things done but no reason why they're done. I'd appreciate more freeform text with a blurb why a drive strength is chosen and why pulls are disabled. > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index 9cb1bc8ed6b5..6d8744e130b0 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -612,6 +612,20 @@ &dp_hot_plug_det { > bias-disable; > }; > > +&mi2s1_data0 { > + drive-strength = <6>; > + bias-disable; Is there an external pull on this line? > +}; > + > +&mi2s1_sclk { > + drive-strength = <6>; > + bias-disable; Is there an external pull on this line? If so please add that details as a comment like we do for other external pulls. > +};
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org> To: Andy Gross <agross@kernel.org>, Judy Hsiao <judyhsiao@chromium.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Herring <robh+dt@kernel.org>, Srini Kandagatla <srinivas.kandagatla@linaro.org>, dianders@chromium.org, mka@chromium.org, cychiang@google.com, judyhsiao@google.com, tzungbi@chromium.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1 Date: Fri, 20 May 2022 13:38:00 -0700 [thread overview] Message-ID: <CAE-0n53e0bq_MbfgZYdxatP8CpGVMKkBKOnSDOV+MvbBFB6wOA@mail.gmail.com> (raw) In-Reply-To: <20220520161004.1141554-2-judyhsiao@chromium.org> Quoting Judy Hsiao (2022-05-20 09:10:02) > 1. Add drive strength property for mi2s1 on sc7280 based platforms. > 2. Disbale the pull-up mi2s1_data0, mi2s1_sclk. s/Disbale/Disable/ The commit text is a list of things done but no reason why they're done. I'd appreciate more freeform text with a blurb why a drive strength is chosen and why pulls are disabled. > Signed-off-by: Judy Hsiao <judyhsiao@chromium.org> > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index 9cb1bc8ed6b5..6d8744e130b0 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -612,6 +612,20 @@ &dp_hot_plug_det { > bias-disable; > }; > > +&mi2s1_data0 { > + drive-strength = <6>; > + bias-disable; Is there an external pull on this line? > +}; > + > +&mi2s1_sclk { > + drive-strength = <6>; > + bias-disable; Is there an external pull on this line? If so please add that details as a comment like we do for other external pulls. > +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-20 20:38 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-20 16:10 [v2 0/3] Add dtsi for sc7280 herobrine boards that using rt5682 codec Judy Hsiao 2022-05-20 16:10 ` Judy Hsiao 2022-05-20 16:10 ` [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1 Judy Hsiao 2022-05-20 16:10 ` Judy Hsiao 2022-05-20 17:27 ` Matthias Kaehlcke 2022-05-20 17:27 ` Matthias Kaehlcke 2022-05-20 20:38 ` Stephen Boyd [this message] 2022-05-20 20:38 ` Stephen Boyd 2022-05-20 20:39 ` Doug Anderson 2022-05-20 20:39 ` Doug Anderson 2022-05-20 21:01 ` Stephen Boyd 2022-05-20 21:01 ` Stephen Boyd 2022-05-20 21:05 ` Doug Anderson 2022-05-20 21:05 ` Doug Anderson 2022-05-20 20:43 ` Doug Anderson 2022-05-20 20:43 ` Doug Anderson 2022-05-20 16:10 ` [v2 2/3] arm64: dts: qcom: sc7280: Add sc7280-herobrine-audio-rt5682.dtsi Judy Hsiao 2022-05-20 16:10 ` Judy Hsiao 2022-05-20 17:36 ` Matthias Kaehlcke 2022-05-20 17:36 ` Matthias Kaehlcke 2022-05-20 20:49 ` Doug Anderson 2022-05-20 20:49 ` Doug Anderson 2022-05-20 16:10 ` [v2 3/3] arm64: dts: qcom: sc7280: include sc7280-herobrine-audio-rt5682.dtsi in villager and herobrine-r1 Judy Hsiao 2022-05-20 16:10 ` Judy Hsiao 2022-05-20 17:59 ` Matthias Kaehlcke 2022-05-20 17:59 ` Matthias Kaehlcke 2022-05-20 20:50 ` Doug Anderson 2022-05-20 20:50 ` Doug Anderson -- strict thread matches above, loose matches on Subject: below -- 2022-05-20 16:07 [v2 0/3] Add dtsi for sc7280 herobrine boards that using rt5682 codec Judy Hsiao 2022-05-20 16:07 ` [v2 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1 Judy Hsiao 2022-05-20 16:07 ` Judy Hsiao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAE-0n53e0bq_MbfgZYdxatP8CpGVMKkBKOnSDOV+MvbBFB6wOA@mail.gmail.com \ --to=swboyd@chromium.org \ --cc=agross@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=cychiang@google.com \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=judyhsiao@chromium.org \ --cc=judyhsiao@google.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mka@chromium.org \ --cc=robh+dt@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=tzungbi@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.