From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3238C433F5 for ; Thu, 13 Jan 2022 23:13:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235421AbiAMXNJ (ORCPT ); Thu, 13 Jan 2022 18:13:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232394AbiAMXNJ (ORCPT ); Thu, 13 Jan 2022 18:13:09 -0500 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C287BC06161C for ; Thu, 13 Jan 2022 15:13:08 -0800 (PST) Received: by mail-oi1-x22b.google.com with SMTP id s9so9935869oib.11 for ; Thu, 13 Jan 2022 15:13:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=sMMqNSDsbwa7yFsyX3bGhmbn1MJoJMBHF2qgWzw9Mzs=; b=e9TkMcxTOSS/64wt9ZC2xTerMvvL1hENNYRBuClFXx/siDYX5i1oCQiJADqjzsbrgy wVjkMUSfXf3YjWKS9PkxJuOKDKB2J9fObDPBExgWBjIHo442CJ3EVE6gtGn5FtgvA6iU bkn2frXC6bFNDtrmo8PI5yibl+vD/9QwcQ1zc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=sMMqNSDsbwa7yFsyX3bGhmbn1MJoJMBHF2qgWzw9Mzs=; b=5FlCuRwUcWNE8ZFnu84xN0k3Xg1owTLN9KhXJpHujXRmgqe+lHTAOi2k9sC2KOTbJf 2MO9xdVSlp1q/q9/KB98tIwDzfQYQSj/0XYk2ZGr/fR2rRrUbCwZrkzmp0FpKVMRf/n4 E6pPSp1QvqX+84nXAL3zUQbrZmd22LuuL8PSPvHq93EYndV9kNd127nAcopgZzEnNPrj NiW/kcbwn5zydtcfKvz0qvnlmTQxwJx/wa1rxn1z20C3rF8mZuxN/i3o1Z/ATp2JN7wd QGYiWbkximJqsmXpSpflOaeNl7Gscu0ezcUiaaDK7EmqgkSEMpDkf2GMYSTBF2lT3VMZ KHzw== X-Gm-Message-State: AOAM53257I+RFZH2FEtEHAZdbnpsEsRCSX5gqFgiKfR60ONR0RlSCHpV KoeP4p6mRqUCclBYx6/NzGBWtOYoELzUvvGNrzWo4Q== X-Google-Smtp-Source: ABdhPJysPzSfwlVyVdWBKUalOT0iR/oa380Ka2xGSIUkYRdu/+jueIFwVtoKPaDzivQWTPr7woGPCTGrXqUbOmHoLlw= X-Received: by 2002:aca:a953:: with SMTP id s80mr10804519oie.164.1642115588114; Thu, 13 Jan 2022 15:13:08 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Jan 2022 15:13:07 -0800 MIME-Version: 1.0 In-Reply-To: References: <1641926606-1012-1-git-send-email-quic_khsieh@quicinc.com> <1641926606-1012-2-git-send-email-quic_khsieh@quicinc.com> <84ee17f9-2597-86b6-1517-2358d443f65b@quicinc.com> <338ae657-e8ed-e620-0aa7-4ad05df18ad1@quicinc.com> <64ad7053-beac-0c28-7d09-ea32a4f7fbad@quicinc.com> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 13 Jan 2022 15:13:07 -0800 Message-ID: Subject: Re: [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received To: Kuogee Hsieh , agross@kernel.org, airlied@linux.ie, bjorn.andersson@linaro.org, daniel@ffwll.ch, dmitry.baryshkov@linaro.org, dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org Cc: quic_abhinavk@quicinc.com, aravindh@codeaurora.org, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Kuogee Hsieh (2022-01-13 14:14:27) > > On 1/13/2022 1:52 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-01-13 12:44:16) > >> On 1/13/2022 11:47 AM, Stephen Boyd wrote: > >>> Quoting Kuogee Hsieh (2022-01-13 09:51:42) > >>>> On 1/12/2022 8:13 PM, Stephen Boyd wrote: > >>>>>>>> - if (dp->usbpd->orientation == ORIENTATION_CC2) > >>>>>>>> - flip = true; > >>>>>>>> + dp_power_init(dp->power, false); > >>>>>>>> + dp_ctrl_reset_irq_ctrl(dp->ctrl, true); > >>>>>>>> + > >>>>>>>> + /* > >>>>>>>> + * eDP is the embedded primary display and has its own phy > >>>>>>>> + * initialize phy immediately > >>>>>>> Question still stands why we can't wait for hpd high from the eDP panel. > >>>>>>> Also, I think "has its own phy" means that it's not part of a combo > >>>>>>> USB+DP phy? Can you please clarify? > >> Correct, eDP has its dedicated phy which is not part of combo phy. > > Why does that mean we can't wait for hpd high from the eDP panel? > > Sorry, missed this one. > > Yes, it can wait for hpd high. > > Since it always presented, I just think it is better to show display > sooner not later until hdp high. > > you like it to wait until hpd high? Yes. The less special cases the easier it is to read and modify later. I also worry that someone will decide to connect a DP connector to the eDP pins and then not always drive HPD high. In that case this code would need to change so it seems better to follow one flow instead of two. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8377BC4332F for ; Thu, 13 Jan 2022 23:13:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DCD210E793; Thu, 13 Jan 2022 23:13:10 +0000 (UTC) Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by gabe.freedesktop.org (Postfix) with ESMTPS id D82F510E791 for ; Thu, 13 Jan 2022 23:13:08 +0000 (UTC) Received: by mail-oi1-x233.google.com with SMTP id i9so10000438oih.4 for ; Thu, 13 Jan 2022 15:13:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=sMMqNSDsbwa7yFsyX3bGhmbn1MJoJMBHF2qgWzw9Mzs=; b=e9TkMcxTOSS/64wt9ZC2xTerMvvL1hENNYRBuClFXx/siDYX5i1oCQiJADqjzsbrgy wVjkMUSfXf3YjWKS9PkxJuOKDKB2J9fObDPBExgWBjIHo442CJ3EVE6gtGn5FtgvA6iU bkn2frXC6bFNDtrmo8PI5yibl+vD/9QwcQ1zc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=sMMqNSDsbwa7yFsyX3bGhmbn1MJoJMBHF2qgWzw9Mzs=; b=r1voOpdQyXTEqo62Zi5qpL1ejECrFjXNewULDkeQWiZT5rC6EnstuXepj/B8FBNbV1 0Xp11Ahs3VY4TjRM4moP7sT1wx1GW+V7+w8npUb7Jba93JErZRPlBKhlXd6PFYTm6jU8 TaL4ISGr779W25rEDRtmObxlMDVfor2ObFv/Xb9HqW9/N9wIBuUeRnvwQpTbYpGTUWUr pPKvwHamDnl/2kWnsQLqztBonAO6SGIbFTr1lNQQO+6fj2HgFkdMhfEj3rVLnG3mdwjb NDLVfHdz8f866ehF5jD4Y10jd5l1otAJv4mwYb3xmR5q+T/+RVkAywS0/07wWKulXpmh se4w== X-Gm-Message-State: AOAM531N/cGUx6MjGybOm4iYnV1U0UrxyYIIv0iyLbpLgx2gGz34VTUX 4EXF8PrpDjjo0a36KTSAK/59EnUb8OY2HmK7tjvYAQ== X-Google-Smtp-Source: ABdhPJysPzSfwlVyVdWBKUalOT0iR/oa380Ka2xGSIUkYRdu/+jueIFwVtoKPaDzivQWTPr7woGPCTGrXqUbOmHoLlw= X-Received: by 2002:aca:a953:: with SMTP id s80mr10804519oie.164.1642115588114; Thu, 13 Jan 2022 15:13:08 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 13 Jan 2022 15:13:07 -0800 MIME-Version: 1.0 In-Reply-To: References: <1641926606-1012-1-git-send-email-quic_khsieh@quicinc.com> <1641926606-1012-2-git-send-email-quic_khsieh@quicinc.com> <84ee17f9-2597-86b6-1517-2358d443f65b@quicinc.com> <338ae657-e8ed-e620-0aa7-4ad05df18ad1@quicinc.com> <64ad7053-beac-0c28-7d09-ea32a4f7fbad@quicinc.com> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 13 Jan 2022 15:13:07 -0800 Message-ID: Subject: Re: [PATCH v11 1/4] drm/msm/dp: do not initialize phy until plugin interrupt received To: Kuogee Hsieh , agross@kernel.org, airlied@linux.ie, bjorn.andersson@linaro.org, daniel@ffwll.ch, dmitry.baryshkov@linaro.org, dri-devel@lists.freedesktop.org, robdclark@gmail.com, sean@poorly.run, vkoul@kernel.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: quic_sbillaka@quicinc.com, linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com, linux-kernel@vger.kernel.org, aravindh@codeaurora.org, freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Kuogee Hsieh (2022-01-13 14:14:27) > > On 1/13/2022 1:52 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-01-13 12:44:16) > >> On 1/13/2022 11:47 AM, Stephen Boyd wrote: > >>> Quoting Kuogee Hsieh (2022-01-13 09:51:42) > >>>> On 1/12/2022 8:13 PM, Stephen Boyd wrote: > >>>>>>>> - if (dp->usbpd->orientation == ORIENTATION_CC2) > >>>>>>>> - flip = true; > >>>>>>>> + dp_power_init(dp->power, false); > >>>>>>>> + dp_ctrl_reset_irq_ctrl(dp->ctrl, true); > >>>>>>>> + > >>>>>>>> + /* > >>>>>>>> + * eDP is the embedded primary display and has its own phy > >>>>>>>> + * initialize phy immediately > >>>>>>> Question still stands why we can't wait for hpd high from the eDP panel. > >>>>>>> Also, I think "has its own phy" means that it's not part of a combo > >>>>>>> USB+DP phy? Can you please clarify? > >> Correct, eDP has its dedicated phy which is not part of combo phy. > > Why does that mean we can't wait for hpd high from the eDP panel? > > Sorry, missed this one. > > Yes, it can wait for hpd high. > > Since it always presented, I just think it is better to show display > sooner not later until hdp high. > > you like it to wait until hpd high? Yes. The less special cases the easier it is to read and modify later. I also worry that someone will decide to connect a DP connector to the eDP pins and then not always drive HPD high. In that case this code would need to change so it seems better to follow one flow instead of two.