From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59D7EC433EF for ; Fri, 17 Sep 2021 03:52:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B0FC60F46 for ; Fri, 17 Sep 2021 03:52:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244120AbhIQDxV (ORCPT ); Thu, 16 Sep 2021 23:53:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234543AbhIQDxP (ORCPT ); Thu, 16 Sep 2021 23:53:15 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15A8EC061574 for ; Thu, 16 Sep 2021 20:51:54 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id c42-20020a05683034aa00b0051f4b99c40cso11203768otu.0 for ; Thu, 16 Sep 2021 20:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=eC8WWm0GB9m9+OiTXjvJDwwJ4bOx9YsGIUwSquTEdkE=; b=leXlvUp4wCgJ+WDoSlsI5mfKEeObgFzMYEyDUeRToizAqmkwRLhzsTBxrdEHJ1LdYD F1jlqshs/rFCIBHW6i5CscigoTLiIEwaxQ1O/7w84B5WqXaa6JB05tIBgBGUouTzY+BZ 5ngRCTCyGAVKY1/dVw68vCIPuKawOTvBfu5lM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=eC8WWm0GB9m9+OiTXjvJDwwJ4bOx9YsGIUwSquTEdkE=; b=BUDLz8r8G/+rhBjt0PmL67wnr3GbMLk+6wPTletvnyazRqQSicwPs78At+F+tMoCuK xve5al2YVKJPCwuzqMyLhH/77EgJF+Oct0WwP0VjzBFV83IV26nOjZeqjGjZSV4tAQAA E6u7hIudOc5IMWrZOqhPyvJhPIC74/uAyLh5vjnsHCTCBtG7FVvL8ryUjjWoAmzXgCV2 aXZFRL0WqoBIRjEWTBfsBKISYxBgMsVq0eXcD66+NA/jYTgowg8mffjMzFqaI85q7ksE FIQHriht43VBMWp83BP9uHzfkPOiNkzv9CxRx9NmW7RBS9X3DUD0RTh9vbjcRWwc97/s 5JyA== X-Gm-Message-State: AOAM531T8TT268xTJY8Bcx3ysq2YNb8WGQlHeh/E1PzkZTfJHm+RoaMi u0cnZtYOq2tIxk3dQKSO1ffxgUB8bpCWzDqDruNd7Q== X-Google-Smtp-Source: ABdhPJwb+CAeP1LbhPRSrTra9NOvhp96+APdALmb4BWvnUD6hxz1CMABXqTRzuUhf7PFT5ityKS48rAG+XuHAMo+ZcQ= X-Received: by 2002:a05:6830:719:: with SMTP id y25mr7534615ots.77.1631850713468; Thu, 16 Sep 2021 20:51:53 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 16 Sep 2021 20:51:52 -0700 MIME-Version: 1.0 In-Reply-To: <20210915203834.1439-12-sean@poorly.run> References: <20210915203834.1439-1-sean@poorly.run> <20210915203834.1439-12-sean@poorly.run> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 16 Sep 2021 20:51:52 -0700 Message-ID: Subject: Re: [PATCH v2 11/13] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules To: Sean Paul , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Sean Paul , Rob Clark , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Sean Paul (2021-09-15 13:38:30) > From: Sean Paul > > Audio is initialized last, it should be de-initialized first to match > the order in dp_init_sub_modules(). I don't really understand why the driver is written with all this "get" stuff but sure. > > Signed-off-by: Sean Paul > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-12-sean@poorly.run #v1 > > Changes in v2: > -None > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4227C433F5 for ; Fri, 17 Sep 2021 03:51:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D31860F21 for ; Fri, 17 Sep 2021 03:51:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7D31860F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B75E86EB42; Fri, 17 Sep 2021 03:51:54 +0000 (UTC) Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2439D6EB42 for ; Fri, 17 Sep 2021 03:51:54 +0000 (UTC) Received: by mail-ot1-x335.google.com with SMTP id x10-20020a056830408a00b004f26cead745so11139901ott.10 for ; Thu, 16 Sep 2021 20:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=eC8WWm0GB9m9+OiTXjvJDwwJ4bOx9YsGIUwSquTEdkE=; b=leXlvUp4wCgJ+WDoSlsI5mfKEeObgFzMYEyDUeRToizAqmkwRLhzsTBxrdEHJ1LdYD F1jlqshs/rFCIBHW6i5CscigoTLiIEwaxQ1O/7w84B5WqXaa6JB05tIBgBGUouTzY+BZ 5ngRCTCyGAVKY1/dVw68vCIPuKawOTvBfu5lM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=eC8WWm0GB9m9+OiTXjvJDwwJ4bOx9YsGIUwSquTEdkE=; b=fvtiu1d+gIB6GVe5/ZS9Va8ttPJ3pf9f2Sf4NCG8aZ3BDc4ja6+mGmAVl7v+0CR7n3 XBE8oQy7zyByEFgiHPpR0LXCp4WDNy/X17YaO2m+ENRfa3+n7Nr7GwZRyutuSXE0LTXd wKgEtCbKD8gZxqnrlD2MTJI8N8mTtRJhUyE897LZ1CLy9zr54Ur9YiUo4Ymy2R71LlzM 5P8WqF7Yqd5G+SLpHSIYgJbp3oGOL5agXY4ZC/CbtmA0HDzvuNHlsKyJ3ExzaDOnyDdC vNQaACHpG6IPWqwtkRYbRYuR/ZDQjikn1YITXrHNPwUF6S7mFVm7ciLR96sYdSQRGLnq V6mQ== X-Gm-Message-State: AOAM532UXv7NPtmRghNefgJpB4eyZL4b47rCO+F1IXOqHjXEDdXBmlvO rdgsqdv0joJ/ecJIjWnxtsO5g1dr5osQZIKtB9TQpA== X-Google-Smtp-Source: ABdhPJwb+CAeP1LbhPRSrTra9NOvhp96+APdALmb4BWvnUD6hxz1CMABXqTRzuUhf7PFT5ityKS48rAG+XuHAMo+ZcQ= X-Received: by 2002:a05:6830:719:: with SMTP id y25mr7534615ots.77.1631850713468; Thu, 16 Sep 2021 20:51:53 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 16 Sep 2021 20:51:52 -0700 MIME-Version: 1.0 In-Reply-To: <20210915203834.1439-12-sean@poorly.run> References: <20210915203834.1439-1-sean@poorly.run> <20210915203834.1439-12-sean@poorly.run> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 16 Sep 2021 20:51:52 -0700 Message-ID: Subject: Re: [PATCH v2 11/13] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules To: Sean Paul , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Sean Paul , Rob Clark , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Sean Paul (2021-09-15 13:38:30) > From: Sean Paul > > Audio is initialized last, it should be de-initialized first to match > the order in dp_init_sub_modules(). I don't really understand why the driver is written with all this "get" stuff but sure. > > Signed-off-by: Sean Paul > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-12-sean@poorly.run #v1 > > Changes in v2: > -None > --- Reviewed-by: Stephen Boyd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69E96C433F5 for ; Fri, 17 Sep 2021 03:51:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F2D660F21 for ; Fri, 17 Sep 2021 03:51:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0F2D660F21 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B07076EB4C; Fri, 17 Sep 2021 03:51:55 +0000 (UTC) Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3418F6EB49 for ; Fri, 17 Sep 2021 03:51:54 +0000 (UTC) Received: by mail-ot1-x32e.google.com with SMTP id k12-20020a056830150c00b0051abe7f680bso11172335otp.1 for ; Thu, 16 Sep 2021 20:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=eC8WWm0GB9m9+OiTXjvJDwwJ4bOx9YsGIUwSquTEdkE=; b=leXlvUp4wCgJ+WDoSlsI5mfKEeObgFzMYEyDUeRToizAqmkwRLhzsTBxrdEHJ1LdYD F1jlqshs/rFCIBHW6i5CscigoTLiIEwaxQ1O/7w84B5WqXaa6JB05tIBgBGUouTzY+BZ 5ngRCTCyGAVKY1/dVw68vCIPuKawOTvBfu5lM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=eC8WWm0GB9m9+OiTXjvJDwwJ4bOx9YsGIUwSquTEdkE=; b=5BTxT8ylTnXNLYdVp9HcuZ4qfbTfV7M9fAKKN/OdjQM0JFqXoHlDMoxZ2bm823k7xS +l674UpzVEQcM5PbwRGwgr4U2XECgjnFolwSrgs+O+dMEe1xbwch80qYE1b5tlfhPj3r S54Iucjy1v4o14mYCKAoI2oU+eftZ/NP8a9UT67kkggAkYSSMpZumrBqgOuaqGpvRpb7 PcrvSvbCArqw011Z1Q6SvMh1r9FTmzgdM+YxhTcrYbYaBDWCwfv3F094WpKpaAv/FFbV yp5h9cPgMTBPyncDzHJEAV0JhN1OCcV1rDE5zEnONsKFiMle4Bv1RJED4T5KnyFxg7q1 t0nw== X-Gm-Message-State: AOAM532X6xeevBABDmYm6yN8mAofqbBtbd0Y9G8eMYsWt82L6XRdu0Ek 2ZZoQCoV2AVUhvm8QvsvTKp5FJSu0FNs2oLcM9pMpdE6U4M= X-Google-Smtp-Source: ABdhPJwb+CAeP1LbhPRSrTra9NOvhp96+APdALmb4BWvnUD6hxz1CMABXqTRzuUhf7PFT5ityKS48rAG+XuHAMo+ZcQ= X-Received: by 2002:a05:6830:719:: with SMTP id y25mr7534615ots.77.1631850713468; Thu, 16 Sep 2021 20:51:53 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 16 Sep 2021 20:51:52 -0700 MIME-Version: 1.0 In-Reply-To: <20210915203834.1439-12-sean@poorly.run> References: <20210915203834.1439-1-sean@poorly.run> <20210915203834.1439-12-sean@poorly.run> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 16 Sep 2021 20:51:52 -0700 Message-ID: To: Sean Paul , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Sean Paul , Rob Clark , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [Intel-gfx] [PATCH v2 11/13] drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Quoting Sean Paul (2021-09-15 13:38:30) > From: Sean Paul > > Audio is initialized last, it should be de-initialized first to match > the order in dp_init_sub_modules(). I don't really understand why the driver is written with all this "get" stuff but sure. > > Signed-off-by: Sean Paul > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-12-sean@poorly.run #v1 > > Changes in v2: > -None > --- Reviewed-by: Stephen Boyd