From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FDC2C433FE for ; Thu, 7 Oct 2021 18:34:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AF24610EA for ; Thu, 7 Oct 2021 18:34:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243632AbhJGSgj (ORCPT ); Thu, 7 Oct 2021 14:36:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233859AbhJGSgi (ORCPT ); Thu, 7 Oct 2021 14:36:38 -0400 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB3E4C061760 for ; Thu, 7 Oct 2021 11:34:44 -0700 (PDT) Received: by mail-ot1-x336.google.com with SMTP id c6-20020a9d2786000000b005471981d559so8610428otb.5 for ; Thu, 07 Oct 2021 11:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=pMbvU4NuLdDg7x2gXhImMJJO8NYwPnWe5Vdp9WJAd/o=; b=lYFzTwpxajvpajNgQ3XKznusSHTanFX+EeDXtgylVlLxQ6102Fn+EndYOXTM9n5nZ9 5ATqjdI+ZjKtzsFBGtAlPzRwEPrsAwhdobvc/jMce7fENw1Uq4w5HLoQELHmK32Nepaw bBNcE8vmGxGcTGShbB8McfBqSlmzqmydwk56w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=pMbvU4NuLdDg7x2gXhImMJJO8NYwPnWe5Vdp9WJAd/o=; b=XwiuBtXSwWOnAbWk09UEHZ/N6+WQQKbl7k5OjrppQQu9BjxinaU6WW7tUnW2SqqsIz cptx7rAqHmmB3dfxq0P5gNsVe01MjuBboPNuYbmgruMiJ9lNL7tvxD6KQ/nqEm3UE/q4 yc+DDiqVeBvuyIeLYhCMKWFAdxE/US4RyRAYsUM1puEWFaSJy2rG3TFD/S1HejU8NvU6 MvngtzG30+o4XAUBu6vE2jYMWXL1c4sN2guBEaVnnrRXjqM0ESDD2y2PMEtfiMhWdF/O AsXb2dtcZtWPJuaxxtV4qBl0piHrKzANbn6Erg9lKW7fMIhg+fny2YWUP0TbdLpvGd5D eR6Q== X-Gm-Message-State: AOAM530+V1HNebASiLgdkKk3PWNgxaDjOetI+ypkvh2nuaW4dw8v6u86 AdUWy3YakL3i7DQbZrZBbmVlVqbYE9sKfUoPhTjN/Q== X-Google-Smtp-Source: ABdhPJyDJU9ANF00rxAGsnwYPAeFgl12LTvc5zWIlHFElQD2qEn72bHEeASpKui2Xeg3tM2e25hEinotUfg/QCJJLSI= X-Received: by 2002:a05:6830:1c2e:: with SMTP id f14mr4797816ote.159.1633631684290; Thu, 07 Oct 2021 11:34:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 7 Oct 2021 14:34:43 -0400 MIME-Version: 1.0 In-Reply-To: <1633330133-29617-1-git-send-email-pillair@codeaurora.org> References: <1633330133-29617-1-git-send-email-pillair@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Thu, 7 Oct 2021 14:34:43 -0400 Message-ID: Subject: Re: [PATCH v6 0/3] Add support for sc7280 WPSS PIL loading To: Rakesh Pillai , agross@kernel.org, bjorn.andersson@linaro.org, mathieu.poirier@linaro.org, ohad@wizery.com, p.zabel@pengutronix.de, robh+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sibis@codeaurora.org, mpubbise@codeaurora.org, kuabhs@chromium.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Rakesh Pillai (2021-10-03 23:48:50) > Add support for PIL loading of WPSS co-processor for SC7280 SOCs. > > Changes from v4/v5: > - Add yaml conversion for adsp/cdsp dt-bindings > - Change clock names in wpss dt-bindings > - Correct mistake in signed-off enail ID Can you keep a running tally here of the full progression of the series? That helps to look back and make sure we don't make a comment that has already been made before. One more request. Can you add support for 'firmware-name' like there is in Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt so that we can install firmware into some namespaced/versioned place instead of having to put wpss files into /lib/firmware? It would also be nice to load a single firmware file instead of having to split the file into many pieces. > > Rakesh Pillai (3): > dt-bindings: remoteproc: qcom: adsp: Convert binding to YAML > dt-bindings: remoteproc: qcom: Add SC7280 WPSS support > remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS >