From: Stephen Boyd <swboyd@chromium.org>
To: skakit@codeaurora.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
David Collins <collinsd@codeaurora.org>,
kgunda@codeaurora.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V5 2/2] arm64: dts: sc7280: Add volume up support for sc7280-idp
Date: Thu, 16 Sep 2021 23:07:05 -0700 [thread overview]
Message-ID: <CAE-0n53x6oB+Rj1_1QDNMVJowyCUeXgGBMmZ1SW1rTMmcEwD4A@mail.gmail.com> (raw)
In-Reply-To: <baa5c4b4dd19e0a24d28b8bff559b868@codeaurora.org>
Quoting skakit@codeaurora.org (2021-09-16 21:08:11)
> On 2021-09-17 00:32, Stephen Boyd wrote:
> > Quoting Satya Priya (2021-09-16 06:21:38)
> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> >> b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> >> index 371a2a9..cbbb0ee 100644
> >> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> >> @@ -12,6 +12,26 @@
> >> #include "pm8350c.dtsi"
> >> #include "pmk8350.dtsi"
> >>
> >> +/ {
> >> + gpio-keys {
> >> + compatible = "gpio-keys";
> >> + label = "gpio-keys";
> >> +
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&key_vol_up_default>;
> >> +
> >> + volume-up {
> >> + label = "volume_up";
> >> + gpios = <&pm7325_gpios 6 GPIO_ACTIVE_LOW>;
> >> + linux,input-type = <1>;
> >> + linux,code = <KEY_VOLUMEUP>;
> >
> > Is there an include for this define? Looks like
> > <dt-bindings/input/input.h> should be added as well? Did you try
> > compiling?
> >
>
> Yeah, it needs <dt-bindings/input/linux-event-codes.h> to be included.
> This header was included in pmk8350.dtsi which is added in this file.
Alright, got it. If you can include this header in this dts file it
would be better so we don't rely on implicit includes from other files
to get macros. With that change you can add my
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
prev parent reply other threads:[~2021-09-17 6:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 13:21 [PATCH V5 0/2] Add Vol+ support for sc7280-idp Satya Priya
2021-09-16 13:21 ` [PATCH V5 1/2] pinctrl: qcom: spmi-gpio: correct parent irqspec translation Satya Priya
2021-09-16 23:08 ` Linus Walleij
2021-09-16 13:21 ` [PATCH V5 2/2] arm64: dts: sc7280: Add volume up support for sc7280-idp Satya Priya
2021-09-16 19:02 ` Stephen Boyd
2021-09-17 4:08 ` skakit
2021-09-17 6:07 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n53x6oB+Rj1_1QDNMVJowyCUeXgGBMmZ1SW1rTMmcEwD4A@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.