From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC439C4338F for ; Thu, 29 Jul 2021 16:51:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 119A460560 for ; Thu, 29 Jul 2021 16:51:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 119A460560 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:50174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m99Ft-0005HF-S8 for qemu-devel@archiver.kernel.org; Thu, 29 Jul 2021 12:51:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m99Eu-0004XI-MT for qemu-devel@nongnu.org; Thu, 29 Jul 2021 12:50:32 -0400 Received: from mail-vs1-xe2c.google.com ([2607:f8b0:4864:20::e2c]:44916) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m99Es-0005WI-Q1 for qemu-devel@nongnu.org; Thu, 29 Jul 2021 12:50:32 -0400 Received: by mail-vs1-xe2c.google.com with SMTP id t2so3854797vsa.11 for ; Thu, 29 Jul 2021 09:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=3vHRslPZvTxMxTMsrG/qrWh19WUFTjXZwWg9ggs5SZ0=; b=lvmhCorjT84BBreaP1RTPkcXaqeZlEVxyNJ5vMj4xDyeuERw8c5KSc8z5fZuKbc7Wv 0VWp5N5ngxR2kEThyOokCb1YbJTbtjCkdjGmNpJSpf3EIVCyIa4B/8U9RDV+JnkriXNm z59vkSaMXsQuSMi4TervKJm8czFltDyWzBOHB2GkjQxlNsMTRK4TuXAxTqWcMT0pj7E7 KhsxzHJ5y+Tl0gdRyLrys8EIYQmuw2jqzRBzr2thyobwONtylFt2tZ+Q+vkeR5Dc/ynr f7aQSVI3lQbeG4Sn4s1uKwS6UOSSq4gWmN88UL0u3pkwg3imZh5FwybSumyayzNxbL81 1wQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=3vHRslPZvTxMxTMsrG/qrWh19WUFTjXZwWg9ggs5SZ0=; b=esVMT38YhgkOYnnyd/F3CV5nOKeOq6V/Cg0dRpnOkdp7ZyOgzPhSfyx5H2lRUKdXgY Zvhrrd30TwTr2LDzn9zsfWex/xOsAmeUgSi6A0tdvv4utIHppVjkC91U/jBMUlCYXOj1 Gb4+U47lnsay4qweg9ms/IZTEX1E1SvMmgUJuFso2upYycqocnElyvCTWAiJVvE1sIb9 Bi0WkCQVyhw3uFDZ8vtjOlfFiqUn4nwaqJrr3BMv2MwymuZ4SE6s2ukVsyWpWMkjgq+v D/7rK6bSN2/2ZCilWjfZUdWHM06XwfPMCNhr8CC9qlYjeNWUS0wkkXgr8wFFShztDmY/ fJnQ== X-Gm-Message-State: AOAM530hRfP2krxHLMPdE3n/h0B/Yrvjp1B2mZ/o0kKtwBN17sthOJLc EXxi0Wz+jxBnO6hmnZZ+CsSgpXCSrRhzbnPPzMk= X-Google-Smtp-Source: ABdhPJyxVbNh8Kgs43J3CehAZ+a8+72KMoNFvIWPDexPQFdAsR9yu4SZN3vPwm4wjakm3mygYc2C/3JHFRtiHtM2bdg= X-Received: by 2002:a67:cb0a:: with SMTP id b10mr5227630vsl.9.1627577429494; Thu, 29 Jul 2021 09:50:29 -0700 (PDT) MIME-Version: 1.0 References: <20210729124713.208422-1-pbonzini@redhat.com> <20210729124713.208422-7-pbonzini@redhat.com> In-Reply-To: From: =?UTF-8?B?572X5YuH5YiaKFlvbmdnYW5nIEx1byk=?= Date: Fri, 30 Jul 2021 00:50:18 +0800 Message-ID: Subject: Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject To: Peter Maydell Content-Type: multipart/alternative; boundary="000000000000878fea05c845e640" Received-SPF: pass client-ip=2607:f8b0:4864:20::e2c; envelope-from=luoyonggang@gmail.com; helo=mail-vs1-xe2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: luoyonggang@gmail.com Cc: Paolo Bonzini , Thomas Huth , QEMU Developers , =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --000000000000878fea05c845e640 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Relative symlink should work on Windows. Only symlink that points to non-exist file would file. On Thu, Jul 29, 2021 at 11:09 PM Peter Maydell wrote: > > On Thu, 29 Jul 2021 at 15:05, Thomas Huth wrote: > > > > On 29/07/2021 14.58, Peter Maydell wrote: > > > On Thu, 29 Jul 2021 at 13:56, Paolo Bonzini wrote: > > >> > > >> From: Marc-Andr=C3=A9 Lureau > > >> > > >> Meson now checks that subprojects do not access files from parent > > >> project. While we all agree this is best practice, libvhost-user als= o > > >> want to share a few headers with QEMU, and libvhost-user isn't really a > > >> standalone project at this point (although this is making the dependency > > >> a bit more explicit). > > >> > > >> Signed-off-by: Marc-Andr=C3=A9 Lureau > > >> Message-Id: <20210505151313.203258-1-marcandre.lureau@redhat.com> > > >> Signed-off-by: Paolo Bonzini > > >> --- > > >> subprojects/libvhost-user/include/atomic.h | 1 + > > >> subprojects/libvhost-user/libvhost-user.c | 2 +- > > >> subprojects/libvhost-user/meson.build | 6 +----- > > >> subprojects/libvhost-user/standard-headers/linux | 1 + > > > > > >> diff --git a/subprojects/libvhost-user/include/atomic.h b/subprojects/libvhost-user/include/atomic.h > > >> new file mode 120000 > > >> index 0000000000..8c2be64f7b > > >> --- /dev/null > > >> +++ b/subprojects/libvhost-user/include/atomic.h > > >> @@ -0,0 +1 @@ > > >> +../../../include/qemu/atomic.h > > >> \ No newline at end of file > > > > > >> diff --git a/subprojects/libvhost-user/standard-headers/linux b/subprojects/libvhost-user/standard-headers/linux > > >> new file mode 120000 > > >> index 0000000000..15a2378139 > > >> --- /dev/null > > >> +++ b/subprojects/libvhost-user/standard-headers/linux > > >> @@ -0,0 +1 @@ > > >> +../../../include/standard-headers/linux > > >> \ No newline at end of file > > > > > > > > > Should these really be missing the trailing newline ? > > > > It's a symlink, so yes, there does not need to be a newline in here. > > Interesting. How does it work on Windows hosts ? > > -- PMM > -- =E6=AD=A4=E8=87=B4 =E7=A4=BC =E7=BD=97=E5=8B=87=E5=88=9A Yours sincerely, Yonggang Luo --000000000000878fea05c845e640 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Relative symlink should work on Windows.
Only symlink t= hat points to non-exist file would file.

On Thu, Jul 29, 2021 at 11:= 09 PM Peter Maydell <peter.m= aydell@linaro.org> wrote:
>
> On Thu, 29 Jul 2021 at 15:= 05, Thomas Huth <thuth@redhat.com> wrote:
> >
> > On 29/07/2021 14.58, Peter Maydell w= rote:
> > > On Thu, 29 Jul 2021 at 13:56, Paolo Bonzini <pbonzini@redhat.com> wrote:
&= gt; > >>
> > >> From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> > >>
> > >> Meson now checks that sub= projects do not access files from parent
> > >> project. Whi= le we all agree this is best practice, libvhost-user also
> > >= > want to share a few headers with QEMU, and libvhost-user isn't rea= lly a
> > >> standalone project at this point (although this= is making the dependency
> > >> a bit more explicit).
&g= t; > >>
> > >> Signed-off-by: Marc-Andr=C3=A9 Lurea= u <marcandre.lureau@redha= t.com>
> > >> Message-Id: <20210505151313.203258-1-mar= candre.lureau@redhat.com>
> > >> Signed-off-by: Paolo= Bonzini <pbonzini@redhat.com= >
> > >> ---
> > >> =C2=A0 subprojects/lib= vhost-user/include/atomic.h =C2=A0 =C2=A0 =C2=A0 | 1 +
> > >>= ; =C2=A0 subprojects/libvhost-user/libvhost-user.c =C2=A0 =C2=A0 =C2=A0 =C2= =A0| 2 +-
> > >> =C2=A0 subprojects/libvhost-user/meson.buil= d =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 6 +-----
> > >>= =C2=A0 subprojects/libvhost-user/standard-headers/linux | 1 +
> >= >
> > >> diff --git a/subprojects/libvhost-user/include/= atomic.h b/subprojects/libvhost-user/include/atomic.h
> > >>= new file mode 120000
> > >> index 0000000000..8c2be64f7b> > >> --- /dev/null
> > >> +++ b/subprojects/l= ibvhost-user/include/atomic.h
> > >> @@ -0,0 +1 @@
> &= gt; >> +../../../include/qemu/atomic.h
> > >> \ No new= line at end of file
> > >
> > >> diff --git a/su= bprojects/libvhost-user/standard-headers/linux b/subprojects/libvhost-user/= standard-headers/linux
> > >> new file mode 120000
> &= gt; >> index 0000000000..15a2378139
> > >> --- /dev/nu= ll
> > >> +++ b/subprojects/libvhost-user/standard-headers/l= inux
> > >> @@ -0,0 +1 @@
> > >> +../../../in= clude/standard-headers/linux
> > >> \ No newline at end of f= ile
> > >
> > >
> > > Should these real= ly be missing the trailing newline ?
> >
> > It's a s= ymlink, so yes, there does not need to be a newline in here.
>
>= ; Interesting. How does it work on Windows hosts ?
>
> -- PMM>


--
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=E6=AD=A4=E8=87= =B4
=E7=A4=BC
=E7=BD=97=E5=8B=87=E5=88=9A
Yours
=C2=A0 =C2=A0 s= incerely,
Yonggang Luo
--000000000000878fea05c845e640--