From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH, INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A6F0C433DB for ; Fri, 8 Jan 2021 15:24:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8532D239EB for ; Fri, 8 Jan 2021 15:24:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8532D239EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kxtcR-0007a8-Bp for qemu-devel@archiver.kernel.org; Fri, 08 Jan 2021 10:24:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kxtbb-0007BL-Dr for qemu-devel@nongnu.org; Fri, 08 Jan 2021 10:23:11 -0500 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:39424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kxtbY-0006HN-RG for qemu-devel@nongnu.org; Fri, 08 Jan 2021 10:23:11 -0500 Received: by mail-lf1-x134.google.com with SMTP id a12so23768212lfl.6 for ; Fri, 08 Jan 2021 07:23:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=x4QM7QFfbI5uj39hWRobs6kfQ6+NnlpMPSV/kYHQawM=; b=GhhOoQD0zy9R7qreUih+DO6Rtj7zKX1MucaKiIqOwpQB9hfaFOVPprYdpdcjIBpgpa 6LhtSXEX35wSw97CExr9Vg34CahEPpmrPuERlDvycd3qeUX0pNFBH8+oYMBZBaAzBN6c 6TGDx0JdANcvZPiTF7+EyoxRPq4JzVgWAA+5kqomkNPPLDOSeELqL2X5memBP7EyRMtu t+ZhDSgvGRfGWC2OWozQo35min6vCYCOPY3GK8kPkO6nxVyyh0pHQU+c2OIEqq8BVSob X6IC+sv0bYk5NVa6R61SxjryfzIwECdZqkJaB/6d32BbWt2gnUEwSfVHI4fPcZ3Zwgxf 52cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=x4QM7QFfbI5uj39hWRobs6kfQ6+NnlpMPSV/kYHQawM=; b=f20NSRMnA2I541om1eefZ5UQ/qqglWGry9DN6cqvwJibfn+lCUlAE3Z9fY7u9UI18K skhTIol3yfUXj9f+zyj41DspnKHaeqEZbF4tcD5SCViNdL4OCC5rwsvFfrx9IF4XSkgV aAUYQo0sbrPqqJEwMOdrvFC8iwx1EfylBZEcLM1khqGuLQvATvZY9Dachdhyr4Yjm1Qh sz//JkWgHLDi29x5oayZmCnVfvdopuCLEvgUR31kWvwpjj32gOp10IVldRSml+EjWtIz qGQOQOI7npM9RIpPgoQ3wfq70clj8m4DRCRyKwZ64ftVgTeDvxDcxc+qgb48Tb1v6PyH rdKA== X-Gm-Message-State: AOAM530sgyxN+8zCnuO1Sl2WH5BqY7oNkKY0feg82ZHaRIToftsQeOro WnlI5DMtZoAm7MQRjZp1BFNQLh1qTZeQUNdY1aA= X-Google-Smtp-Source: ABdhPJzejj9IC0k0DLIv8UKM1EVZTpgedGpntEPFzuZUA1UupI2l5/vwwr4K1W78Bdz8UeCpydt7vTJeBWlhl8TFJJk= X-Received: by 2002:a19:ad4b:: with SMTP id s11mr1739430lfd.427.1610119386560; Fri, 08 Jan 2021 07:23:06 -0800 (PST) MIME-Version: 1.0 References: <20210107222253.20382-1-f4bug@amsat.org> In-Reply-To: From: =?UTF-8?B?572X5YuH5YiaKFlvbmdnYW5nIEx1byk=?= Date: Fri, 8 Jan 2021 07:22:55 -0800 Message-ID: Subject: Re: [PULL 00/66] MIPS patches for 2021-01-07 To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="00000000000014ffb405b8652267" Received-SPF: pass client-ip=2a00:1450:4864:20::134; envelope-from=luoyonggang@gmail.com; helo=mail-lf1-x134.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: luoyonggang@gmail.com Cc: Peter Maydell , Aleksandar Rikalo , kvm-devel , Paul Burton , Libvirt , Huacai Chen , Richard Henderson , "qemu-devel@nongnu.org Developers" , Laurent Vivier , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000014ffb405b8652267 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Jan 8, 2021 at 3:31 AM Philippe Mathieu-Daud=C3=A9 wrote: > > Hi Peter, > > Le ven. 8 janv. 2021 11:35, Peter Maydell a =C3=A9crit : >> >> On Thu, 7 Jan 2021 at 22:25, Philippe Mathieu-Daud=C3=A9 wrote: >> > >> > The following changes since commit 470dd6bd360782f5137f7e3376af6a44658eb1d3: >> > >> > Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-060121-4' into staging (2021-01-06 22:18:36 +0000) >> > >> > are available in the Git repository at: >> > >> > https://gitlab.com/philmd/qemu.git tags/mips-20210107 >> > >> > for you to fetch changes up to f97d339d612b86d8d336a11f01719a10893d6707: >> > >> > docs/system: Remove deprecated 'fulong2e' machine alias (2021-01-07 22:57:49 +0100) >> > >> > ---------------------------------------------------------------- >> > MIPS patches queue >> > >> > - Simplify CPU/ISA definitions >> > - Various maintenance code movements in translate.c >> > - Convert part of the MSA ASE instructions to decodetree >> > - Convert some instructions removed from Release 6 to decodetree >> > - Remove deprecated 'fulong2e' machine alias >> >> Hi; this failed to build on some of my hosts: >> >> [1/4674] Generating 'libqemu-mipsel-softmmu.fa.p/decode-mips64r6.c.inc'. >> FAILED: libqemu-mipsel-softmmu.fa.p/decode-mips64r6.c.inc >> /usr/bin/python3 /home/petmay01/qemu-for-merges/scripts/decodetree.py >> ../../target/mips/mips64r6.decode --static-deco >> de=3Ddecode_mips64r6 -o libqemu-mipsel-softmmu.fa.p/decode-mips64r6.c.in= c >> Traceback (most recent call last): >> File "/home/petmay01/qemu-for-merges/scripts/decodetree.py", line >> 1397, in >> main() >> File "/home/petmay01/qemu-for-merges/scripts/decodetree.py", line >> 1308, in main >> parse_file(f, toppat) >> File "/home/petmay01/qemu-for-merges/scripts/decodetree.py", line >> 994, in parse_file >> for line in f: >> File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode >> return codecs.ascii_decode(input, self.errors)[0] >> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position >> 80: ordinal not in range(128) Can we always reading file in decodetree with utf8 encoding And convert all decodetree to utf8 encoding, and the problem should resolved. ``` scripts/decodetree.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/decodetree.py b/scripts/decodetree.py index 47aa9caf6d..8c9eb365ac 100644 --- a/scripts/decodetree.py +++ b/scripts/decodetree.py @@ -1304,7 +1304,7 @@ def main(): for filename in args: input_file =3D filename - f =3D open(filename, 'r') + f =3D open(filename, 'r', encoding=3D"utf8") parse_file(f, toppat) f.close() ``` > > > My lastname in the copyright line =3D) > >> [2/4674] Generating 'libqemu-mipsel-softmmu.fa.p/decode-msa64.c.inc'. >> FAILED: libqemu-mipsel-softmmu.fa.p/decode-msa64.c.inc >> /usr/bin/python3 /home/petmay01/qemu-for-merges/scripts/decodetree.py >> ../../target/mips/msa64.decode --static-decode=3D >> decode_msa64 -o libqemu-mipsel-softmmu.fa.p/decode-msa64.c.inc >> Traceback (most recent call last): >> File "/home/petmay01/qemu-for-merges/scripts/decodetree.py", line >> 1397, in >> main() >> File "/home/petmay01/qemu-for-merges/scripts/decodetree.py", line >> 1308, in main >> parse_file(f, toppat) >> File "/home/petmay01/qemu-for-merges/scripts/decodetree.py", line >> 994, in parse_file >> for line in f: >> File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode >> return codecs.ascii_decode(input, self.errors)[0] >> UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position >> 93: ordinal not in range(128) >> >> etc. >> >> Looks like decodetree fails to cope with non-ASCII characters in >> its input file -- probably this depends on the host locale settings: >> I think these hosts run in the 'C' locale. > > > Can you provide more information on your host so we can cover it in Gitlab-CI? > > Thanks, > > Phil. -- =E6=AD=A4=E8=87=B4 =E7=A4=BC =E7=BD=97=E5=8B=87=E5=88=9A Yours sincerely, Yonggang Luo --00000000000014ffb405b8652267 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Jan 8, 2021 at 3:31 AM Philippe Mathieu-Da= ud=C3=A9 <f4bug@amsat.org> wro= te:
>
> Hi Peter,
>
> Le ven. 8 janv. 2021 11:35, P= eter Maydell <peter.maydell@= linaro.org> a =C3=A9crit :
>>
>> On Thu, 7 Jan 202= 1 at 22:25, Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org> wrote:
>> >
>> > The fo= llowing changes since commit 470dd6bd360782f5137f7e3376af6a44658eb1d3:
&= gt;> >
>> > =C2=A0 Merge remote-tracking branch 'remo= tes/stsquad/tags/pull-testing-060121-4' into staging (2021-01-06 22:18:= 36 +0000)
>> >
>> > are available in the Git reposi= tory at:
>> >
>> > =C2=A0 https://gitlab.com/philmd/qemu.git tags/mips-2021= 0107
>> >
>> > for you to fetch changes up to f97d3= 39d612b86d8d336a11f01719a10893d6707:
>> >
>> > =C2= =A0 docs/system: Remove deprecated 'fulong2e' machine alias (2021-0= 1-07 22:57:49 +0100)
>> >
>> > --------------------= --------------------------------------------
>> > MIPS patches = queue
>> >
>> > - Simplify CPU/ISA definitions
&= gt;> > - Various maintenance code movements in translate.c
>>= ; > - Convert part of the MSA ASE instructions to decodetree
>>= > - Convert some instructions removed from Release 6 to decodetree
&= gt;> > - Remove deprecated 'fulong2e' machine alias
>&g= t;
>> Hi; this failed to build on some of my hosts:
>>>> [1/4674] Generating 'libqemu-mipsel-softmmu.fa.p/decode-mips6= 4r6.c.inc'.
>> FAILED: libqemu-mipsel-softmmu.fa.p/decode-mips= 64r6.c.inc
>> /usr/bin/python3 /home/petmay01/qemu-for-merges/scri= pts/decodetree.py
>> ../../target/mips/mips64r6.decode --static-de= co
>> de=3Ddecode_mips64r6 -o libqemu-mipsel-softmmu.fa.p/decode-m= ips64r6.c.inc
>> Traceback (most recent call last):
>> = =C2=A0 File "/home/petmay01/qemu-for-merges/scripts/decodetree.py"= ;, line
>> 1397, in <module>
>> =C2=A0 =C2=A0 main(= )
>> =C2=A0 File "/home/petmay01/qemu-for-merges/scripts/deco= detree.py", line
>> 1308, in main
>> =C2=A0 =C2=A0 p= arse_file(f, toppat)
>> =C2=A0 File "/home/petmay01/qemu-for-= merges/scripts/decodetree.py", line
>> 994, in parse_file
= >> =C2=A0 =C2=A0 for line in f:
>> =C2=A0 File "/usr/li= b/python3.6/encodings/ascii.py", line 26, in decode
>> =C2=A0= =C2=A0 return codecs.ascii_decode(input, self.errors)[0]
>> Unico= deDecodeError: 'ascii' codec can't decode byte 0xc3 in position=
>> 80: ordinal not in range(128)
Can we always reading file in= decodetree with utf8 encoding
And convert all decodetree to utf8 encod= ing, and the problem should resolved.
```
=C2=A0scripts/decodetree.py= | 2 +-
=C2=A01 file changed, 1 insertion(+), 1 deletion(-)

diff = --git a/scripts/decodetree.py b/scripts/decodetree.py
index 47aa9caf6d..= 8c9eb365ac 100644
--- a/scripts/decodetree.py
+++ b/scripts/decodetre= e.py
@@ -1304,7 +1304,7 @@ def main():
=C2=A0
=C2=A0 =C2=A0 =C2=A0= for filename in args:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0input_file =3D f= ilename
- =C2=A0 =C2=A0 =C2=A0 =C2=A0f =3D open(filename, 'r')+ =C2=A0 =C2=A0 =C2=A0 =C2=A0f =3D open(filename, 'r', encoding= =3D"utf8")
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0parse_file(f, top= pat)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0f.close()
=C2=A0
```
&g= t;
>
> My lastname in the copyright line =3D)
>
>&g= t; [2/4674] Generating 'libqemu-mipsel-softmmu.fa.p/decode-msa64.c.inc&= #39;.
>> FAILED: libqemu-mipsel-softmmu.fa.p/decode-msa64.c.inc>> /usr/bin/python3 /home/petmay01/qemu-for-merges/scripts/decodetre= e.py
>> ../../target/mips/msa64.decode --static-decode=3D
>&= gt; decode_msa64 -o libqemu-mipsel-softmmu.fa.p/decode-msa64.c.inc
>&= gt; Traceback (most recent call last):
>> =C2=A0 File "/home/= petmay01/qemu-for-merges/scripts/decodetree.py", line
>> 1397= , in <module>
>> =C2=A0 =C2=A0 main()
>> =C2=A0 Fil= e "/home/petmay01/qemu-for-merges/scripts/decodetree.py", line>> 1308, in main
>> =C2=A0 =C2=A0 parse_file(f, toppat)
= >> =C2=A0 File "/home/petmay01/qemu-for-merges/scripts/decodetre= e.py", line
>> 994, in parse_file
>> =C2=A0 =C2=A0 f= or line in f:
>> =C2=A0 File "/usr/lib/python3.6/encodings/as= cii.py", line 26, in decode
>> =C2=A0 =C2=A0 return codecs.as= cii_decode(input, self.errors)[0]
>> UnicodeDecodeError: 'asci= i' codec can't decode byte 0xc3 in position
>> 93: ordinal= not in range(128)
>>
>> etc.
>>
>> Loo= ks like decodetree fails to cope with non-ASCII characters in
>> i= ts input file -- probably this depends on the host locale settings:
>= > I think these hosts run in the 'C' locale.
>
>
= > Can you provide more information on your host so we can cover it in Gi= tlab-CI?
>
> Thanks,
>
> Phil.



--=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=E6=AD=A4=E8=87=B4
=E7=A4=BC
=E7= =BD=97=E5=8B=87=E5=88=9A
Yours
=C2=A0 =C2=A0 sincerely,
Yonggang L= uo
--00000000000014ffb405b8652267--