From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1518038709; cv=none; d=google.com; s=arc-20160816; b=ofO+Lu7Sbciq9LxU8kDJ5pmhzExjeXW4lGWrhK2S3GiQVogbnCtYDEr0POizdXRs4U +nfXNVasLyHF73zIJWZswHza9inQhJ4xMHeMEThjBuwvE+axE+lztLHLXS0zcymNXY5k nmgL5ceK9UFYuTW6oJcFCPyTpebbj4rdEpM39BgXHWS0cGg+6Qr95bn6+s6dR+dCYPEB 3oELgSMFjMhV2wBqYrBO+CDylECLNqPl9+vnSm3TQ3H/4RCrX1vwsxPgOYr1/4XccMkO 88bA/MOAGdHksgCITQQ+fhgbDX5LG9m2ZlBgozqxX9kJsD9+9XnrL5rzXg1sttcghRi8 7eRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:dkim-signature:arc-authentication-results; bh=wAhdHN+nDM6CTrXZRlcz3dyI0UM1bbFDxm1M1KbdGdg=; b=yiuMR6HLbfj0WQfukT9z2jAeQpIkJywYLxmDjNg3oLrrsZ3kCGfOrQqe2Z0wW4g9zG lVS15hnuwQ1Xy6oK1N7ItIfpgM5PJVLEBL3UNjFMCSrSaw+elj3zUiH3dyA4dr1SCDCJ ll7OmzhHGyj3tVSu2lLJ6SOFdFOL+cetYPSsGLxEhidYI1R+3RKRmhzrP7ox4h0Aneui GY+RYrb2e+b0qqOHtlxuhT1OebZuimj1O70MCxeqqqMrlnGRc3CdSR09F3xr/3D9l6z5 sXW4Ev4hkF98zZTPG1r6z/AcoUcWBelEBumjvLigdaALUqil7kwafNSx1VPhClA/Lpor 4ZRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=IujEi/yq; spf=pass (google.com: domain of jinqian@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jinqian@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=IujEi/yq; spf=pass (google.com: domain of jinqian@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jinqian@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com X-Google-Smtp-Source: AH8x224QLqLHH2IFUnq+hinoIqsPX0rHA8jQr3nnrx6L43Bzxg9BFGylr+HKuqYawVJAiE2Tg1x9/bikvtL7FQ6568U= MIME-Version: 1.0 References: <20180206235354.79591-1-jinqian@android.com> <20180207200604.GB15309@kroah.com> In-Reply-To: <20180207200604.GB15309@kroah.com> From: Jin Qian Date: Wed, 07 Feb 2018 21:24:57 +0000 Message-ID: Subject: Re: [PATCHv2 1/1] ext4/f2fs: don't put symlink in pagecache into highmem To: Greg KH Cc: Jin Qian , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , Changman Lee , Chao Yu , Alexander Viro , Jeff Layton , "J. Bruce Fields" , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-stable Content-Type: multipart/alternative; boundary="001a113ad4aaf701ac0564a5edff" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcSW1wb3J0YW50Ig==?= X-GMAIL-THRID: =?utf-8?q?1591778957140204202?= X-GMAIL-MSGID: =?utf-8?q?1591778957140204202?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: --001a113ad4aaf701ac0564a5edff Content-Type: text/plain; charset="UTF-8" It must be some weird gerrit stuff when I cherry-pick from linux to aosp to linux. Will keep a note for future uploads. Thanks, jin On Wed, Feb 7, 2018 at 1:18 PM Greg KH wrote: > Some minor nits for when you send your next patch for stable: > > On Tue, Feb 06, 2018 at 03:53:53PM -0800, Jin Qian wrote: > > From: Jin Qian > > The original patch was written by Al Viro, please do not take the > original authorship off, that's not good. > > > partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstream > > to v4.4 to prevent virt_to_page on highmem. > > > > ext4_encrypted_follow_link uses kmap() for cpage > > caddr = kmap(cpage); > > > > _ext4_fname_disk_to_usr calls virt_to_page on the kmapped address. > > _ext4_fname_disk_to_usr() > > ext4_fname_decrypt() > > sg_init_one() > > sg_init_one(&src_sg, iname->name, iname->len); > > sg_set_page(sg, virt_to_page(buf), buflen, > offset_in_page(buf)); > > > > Cc: linux-stable # 4.4.y > > Signed-off-by: Al Viro > > Signed-off-by: Jin Qian > > Signed-off-by: Jin Qian > > Why did you sign off on this twice? > > thanks, > > greg k-h > --001a113ad4aaf701ac0564a5edff Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
It must be some weird gerrit stuff when I cherry-pick from= linux to aosp to linux. Will keep a note for future uploads.

Thanks,
jin

On Wed, Feb 7, 2018 at 1:18 PM Greg KH <gregkh@linuxfoundation.org>= wrote:
Some minor nits for when yo= u send your next patch for stable:

On Tue, Feb 06, 2018 at 03:53:53PM -0800, Jin Qian wrote:
> From: Jin Qian <jinqian@google.com>

The original patch was written by Al Viro, please do not take the
original authorship off, that's not good.

> partial backport from 21fc61c73c3903c4c312d0802da01ec2b323d174 upstrea= m
> to v4.4 to prevent virt_to_page on highmem.
>
> ext4_encrypted_follow_link uses kmap() for cpage
>=C2=A0 =C2=A0caddr =3D kmap(cpage);
>
> _ext4_fname_disk_to_usr calls virt_to_page on the kmapped address.
>=C2=A0 =C2=A0_ext4_fname_disk_to_usr()
>=C2=A0 =C2=A0 =C2=A0ext4_fname_decrypt()
>=C2=A0 =C2=A0 =C2=A0 =C2=A0sg_init_one()
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0sg_init_one(&src_sg, iname->na= me, iname->len);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0sg_set_page(sg, virt_to_page(b= uf), buflen, offset_in_page(buf));
>
> Cc: linux-stable <stable@vger.kernel.org> # 4.4.y
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Jin Qian <jinqian@google.com>
> Signed-off-by: Jin Qian <jinqian@android.com>

Why did you sign off on this twice?

thanks,

greg k-h
--001a113ad4aaf701ac0564a5edff--